GNU bug report logs - #49729
[PATCH core-updates] build-system/gnu: Make gzip files writable before resetting timestamps.

Previous Next

Package: guix-patches;

Reported by: Sarah Morgensen <iskarian <at> mgsn.dev>

Date: Sun, 25 Jul 2021 06:13:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates] build-system/gnu: Make gzip files writable
 before resetting timestamps.
Date: Sat, 24 Jul 2021 23:12:04 -0700
guix/build/gnu-build-system.scm (reset-gzip-timestamps): Ensure gzip
files are writable before resetting their timestamps.
---
Hello Guix,

There have been a number of instances of packages having to add their own phase
before 'reset-gzip-timestamps to make the gzip files writable--perhaps the gnu
build system can take care of this itself? WDYT?

--
Sarah
 guix/build/gnu-build-system.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm
index d0f7413268..d84411c090 100644
--- a/guix/build/gnu-build-system.scm
+++ b/guix/build/gnu-build-system.scm
@@ -598,6 +598,8 @@ and 'man/'.  This phase moves directories to the right place if needed."
                                         (string-suffix? ".tgz" file))
                                     (gzip-file? file)))
                              #:stat lstat)))
+      ;; Ensure the files are writable.
+      (for-each make-file-writable files)
       (for-each reset-gzip-timestamp files)))
 
   (match outputs

base-commit: 7bef3be1d318beebaf48ac6daa3140205ba18e98
-- 
2.31.1





This bug report was last modified 1 year and 183 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.