From unknown Fri Aug 15 02:02:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49722 <49722@debbugs.gnu.org> To: bug#49722 <49722@debbugs.gnu.org> Subject: Status: 27.2; Emacs won't build with old versions of fontconfig Reply-To: bug#49722 <49722@debbugs.gnu.org> Date: Fri, 15 Aug 2025 09:02:40 +0000 retitle 49722 27.2; Emacs won't build with old versions of fontconfig reassign 49722 emacs submitter 49722 Andrei Kuznetsov severity 49722 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 12:31:28 2021 Received: (at submit) by debbugs.gnu.org; 24 Jul 2021 16:31:28 +0000 Received: from localhost ([127.0.0.1]:46807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7KYh-0006Ay-UY for submit@debbugs.gnu.org; Sat, 24 Jul 2021 12:31:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:33942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Ehw-0006j5-AM for submit@debbugs.gnu.org; Sat, 24 Jul 2021 06:16:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Ehu-00009w-Vm for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 06:16:35 -0400 Received: from m12-12.163.com ([220.181.12.12]:50772) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Ehp-00054e-7X for bug-gnu-emacs@gnu.org; Sat, 24 Jul 2021 06:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=ZgVWN NPjWXjBYu2Opdvs/T0k0bju1dOq4Kka6/IFVt8=; b=JlUrUXh8CiXx1UFZX0hAJ sKYzPq538U5B8kEvAJTeIAmUZQFGV0hI6n8TpoaLopdJQ3pRlp2CoeSGBXSoIl3f cHG63yEz2isFxmwcldNd/MAUxfoJmSJ6L920sVr6d928e7H6deOJozhjUSqS5adA aZnD5y1fN8q4YUTvhcr0ug= Received: from po-lus-librem-15 (unknown [61.172.31.87]) by smtp8 (Coremail) with SMTP id DMCowACHNRLg5PtgGuH7QQ--.10577S2; Sat, 24 Jul 2021 18:01:05 +0800 (CST) From: Andrei Kuznetsov To: bug-gnu-emacs@gnu.org Subject: 27.2; Emacs won't build with old versions of fontconfig Date: Sat, 24 Jul 2021 18:01:03 +0800 Message-ID: <87k0lg115s.fsf@163.com> MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: DMCowACHNRLg5PtgGuH7QQ--.10577S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxXry3GF4DJF1rWF4xtrWfAFb_yoWrXryrpa y2krW5tF4Fq34j9a1Iy3Wq9rWrZa93Aan8G34jgw45uay5t3WI9r13tr15ArZrCr1rX3yU ZrnxWF98XF1UZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jcAwxUUUUU= X-Originating-IP: [61.172.31.87] X-CM-SenderInfo: rurskkarusmjiyx6il2tof0z/1tbi6wHZpFXlw6cALQAAsu Received-SPF: pass client-ip=220.181.12.12; envelope-from=r12451428287@163.com; helo=m12-12.163.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FROM_LOCAL_DIGITS=0.001, FROM_LOCAL_HEX=0.006, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 24 Jul 2021 12:31:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) I was unable to build Emacs 27.2 on a system with some old version (2.5.0) of fontconfig without applying the following patch: diff -u a/emacs-27.2/src/xftfont.c b/emacs-27.2/src/xftfont.c --- a/emacs-27.2/src/xftfont.c +++ b/emacs-27.2/src/xftfont.c @@ -588,8 +588,10 @@ r1 = FcPatternGetInteger (pat, FC_HINT_STYLE, 0, &i1); r2 = FcPatternGetInteger (oldpat, FC_HINT_STYLE, 0, &i2); if (r1 != r2 || i1 != i2) goto out; +#ifdef FC_LCD_FILTER r1 = FcPatternGetInteger (pat, FC_LCD_FILTER, 0, &i1); r2 = FcPatternGetInteger (oldpat, FC_LCD_FILTER, 0, &i2); +#endif if (r1 != r2 || i1 != i2) goto out; r1 = FcPatternGetInteger (pat, FC_RGBA, 0, &i1); r2 = FcPatternGetInteger (oldpat, FC_RGBA, 0, &i2); Diff finished. Sat Jul 24 14:26:32 2021 The system on which the bug was discovered runs Fedora Core 9, but it should be reproducible by building Emacs with Xft on a system with fontconfig older than 2.6.0 (and possibly newer -- I am not sure on that). In GNU Emacs 27.2 (build 1, powerpc-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2021-07-24 built on distributor-machine Windowing system distributor 'The X.Org Foundation', version 11.0.12101001 System Description: Fedora release 9 (Sulphur) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --prefix=/usr/local --with-gnutls=no' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GLIB ACL LIBSELINUX LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS PDUMPER Important settings: value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 44357 8801) (symbols 24 5958 1) (strings 16 16066 1889) (string-bytes 1 512783) (vectors 8 9285) (vector-slots 4 137016 13736) (floats 8 21 50) (intervals 28 202 7) (buffers 576 11) (heap 1024 3934 455)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 12:38:03 2021 Received: (at 49722) by debbugs.gnu.org; 24 Jul 2021 16:38:03 +0000 Received: from localhost ([127.0.0.1]:46824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Kf5-0006LY-9i for submit@debbugs.gnu.org; Sat, 24 Jul 2021 12:38:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Kf2-0006Kv-AD for 49722@debbugs.gnu.org; Sat, 24 Jul 2021 12:38:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44936) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Kex-0004uy-34; Sat, 24 Jul 2021 12:37:55 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1037 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Kew-00032e-NJ; Sat, 24 Jul 2021 12:37:55 -0400 Date: Sat, 24 Jul 2021 19:37:42 +0300 Message-Id: <83zguby8fd.fsf@gnu.org> From: Eli Zaretskii To: Andrei Kuznetsov In-Reply-To: <87k0lg115s.fsf@163.com> (message from Andrei Kuznetsov on Sat, 24 Jul 2021 18:01:03 +0800) Subject: Re: bug#49722: 27.2; Emacs won't build with old versions of fontconfig References: <87k0lg115s.fsf@163.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49722 Cc: 49722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrei Kuznetsov > Date: Sat, 24 Jul 2021 18:01:03 +0800 > > I was unable to build Emacs 27.2 on a system with some old version > (2.5.0) of fontconfig without applying the following patch: Thanks, but please show the error messages you saw before applying that patch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 21:05:52 2021 Received: (at 49722) by debbugs.gnu.org; 25 Jul 2021 01:05:52 +0000 Received: from localhost ([127.0.0.1]:47243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7SaV-000413-OG for submit@debbugs.gnu.org; Sat, 24 Jul 2021 21:05:52 -0400 Received: from m12-16.163.com ([220.181.12.16]:33260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7SP6-0003jV-6x for 49722@debbugs.gnu.org; Sat, 24 Jul 2021 20:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=YVL+z j1gHmLGePo9CrK9hWpMJhfBVcYkYafaP5MfBbk=; b=ItWpMcUkqPVj/HU6HdQNH tz9bWR9GZOzYxMzm5VeNzMU4cyquA70gfPpO5Ha88TtQCHr2Z0Be2bc2B5xEwFQX GtohBVW3z8Bh3vD0/oQL/fCFLqPe1sZFAixf2/Kc4DnAfSq5n7s7KBf1vBE/kyIS reGtUD1UNhhnDC48TinAFg= Received: from po-lus-librem-15 (unknown [61.172.31.87]) by smtp12 (Coremail) with SMTP id EMCowAC3tDUntvxgg8Wp4A--.32637S2; Sun, 25 Jul 2021 08:53:59 +0800 (CST) From: Andrei Kuznetsov To: Eli Zaretskii Subject: Re: bug#49722: 27.2; Emacs won't build with old versions of fontconfig References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> Date: Sun, 25 Jul 2021 08:53:59 +0800 In-Reply-To: <83zguby8fd.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jul 2021 19:37:42 +0300") Message-ID: <87o8arz00o.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: EMCowAC3tDUntvxgg8Wp4A--.32637S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUF-B_DUUUU X-Originating-IP: [61.172.31.87] X-CM-SenderInfo: rurskkarusmjiyx6il2tof0z/xtbBQgfapF++MqQsLAAAsM X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 49722 X-Mailman-Approved-At: Sat, 24 Jul 2021 21:05:50 -0400 Cc: 49722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Eli Zaretskii writes: > Thanks, but please show the error messages you saw before applying > that patch. xftfont.c: In function =E2=80=98xftfont_cached_font_ok=E2=80=99: xftfont.c:591: error: =E2=80=98FC_LCD_FILTER=E2=80=99 undeclared (first use= in this function) xftfont.c:591: error: (Each undeclared identifier is reported only once xftfont.c:591: error: for each function it appears in.) It appears that FC_LCD_FILTER is not present on these older versions of fontconfig. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 02:43:20 2021 Received: (at 49722) by debbugs.gnu.org; 25 Jul 2021 06:43:20 +0000 Received: from localhost ([127.0.0.1]:47423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Xr6-0008KK-IE for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:43:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Xr5-0008K6-2u for 49722@debbugs.gnu.org; Sun, 25 Jul 2021 02:43:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60474) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Xqz-000581-NJ; Sun, 25 Jul 2021 02:43:13 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4905 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7Xqz-0006zb-BU; Sun, 25 Jul 2021 02:43:13 -0400 Date: Sun, 25 Jul 2021 09:43:01 +0300 Message-Id: <838s1uyjuy.fsf@gnu.org> From: Eli Zaretskii To: Andrei Kuznetsov In-Reply-To: <87o8arz00o.fsf@163.com> (message from Andrei Kuznetsov on Sun, 25 Jul 2021 08:53:59 +0800) Subject: Re: bug#49722: 27.2; Emacs won't build with old versions of fontconfig References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> <87o8arz00o.fsf@163.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49722 Cc: 49722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrei Kuznetsov > Cc: 49722@debbugs.gnu.org > Date: Sun, 25 Jul 2021 08:53:59 +0800 > > Eli Zaretskii writes: > > > Thanks, but please show the error messages you saw before applying > > that patch. > > xftfont.c: In function ‘xftfont_cached_font_ok’: > xftfont.c:591: error: ‘FC_LCD_FILTER’ undeclared (first use in this function) > xftfont.c:591: error: (Each undeclared identifier is reported only once > xftfont.c:591: error: for each function it appears in.) > > It appears that FC_LCD_FILTER is not present on these older versions of > fontconfig. Thanks. We once had the following in xftfont.c: #ifndef FC_LCD_FILTER /* Older fontconfig versions don't have FC_LCD_FILTER. */ #define FC_LCD_FILTER "lcdfilter" #endif But it got moved to ftfont.c when a function which used it was moved there. However, since xftfont.c still uses this, I think we should have this #define in xftfont.c as well, so please try adding that at the beginning of xftfont.c, and see if that helps. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 11:35:26 2021 Received: (at 49722) by debbugs.gnu.org; 25 Jul 2021 15:35:27 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7gA2-0007fS-GT for submit@debbugs.gnu.org; Sun, 25 Jul 2021 11:35:26 -0400 Received: from m12-14.163.com ([220.181.12.14]:41961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7cJK-0007AU-0k for 49722@debbugs.gnu.org; Sun, 25 Jul 2021 07:28:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=96fVr r8a9Zz1FnyEWPsv3SwGZQecCDXDV9ih3lcwgik=; b=a03trfFDRVUt2a6k0sN38 MyyaAXS+xJJlvB21lj5t7HqOoJRdH/N3Eh8Ws8xxgPd1tB4v7+j6/KoGNcgJCiBJ gahNCgIr73MQAXZysRQsVGBQWujiBsNzd1yWOSum1sdSrLjfBqCwX+da4YoMo3W0 SxJLypF8OUJ9MLjENFumr4= Received: from po-lus-librem-15 (unknown [61.172.31.87]) by smtp10 (Coremail) with SMTP id DsCowACnr5viSv1g_gsCCw--.9938S2; Sun, 25 Jul 2021 19:28:34 +0800 (CST) From: Andrei Kuznetsov To: Eli Zaretskii Subject: Re: bug#49722: 27.2; Emacs won't build with old versions of fontconfig References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> <87o8arz00o.fsf@163.com> <838s1uyjuy.fsf@gnu.org> Date: Sun, 25 Jul 2021 19:28:34 +0800 In-Reply-To: <838s1uyjuy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Jul 2021 09:43:01 +0300") Message-ID: <87im0yzl7h.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: DsCowACnr5viSv1g_gsCCw--.9938S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUY6pPUUUUU X-Originating-IP: [61.172.31.87] X-CM-SenderInfo: rurskkarusmjiyx6il2tof0z/1tbiWw3apFSIq7u-7QABs3 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 49722 X-Mailman-Approved-At: Sun, 25 Jul 2021 11:35:25 -0400 Cc: 49722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Eli Zaretskii writes: > However, since xftfont.c still uses this, I think we should > have this #define in xftfont.c as well, so please try adding that at > the beginning of xftfont.c, and see if that helps. Indeed it does. With the aformentioned change, Emacs now builds and seems to operate normally. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 05 10:14:22 2021 Received: (at 49722) by debbugs.gnu.org; 5 Nov 2021 14:14:22 +0000 Received: from localhost ([127.0.0.1]:46728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizz3-0007dF-Rl for submit@debbugs.gnu.org; Fri, 05 Nov 2021 10:14:22 -0400 Received: from mail-pg1-f170.google.com ([209.85.215.170]:39527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizz1-0007cn-V2 for 49722@debbugs.gnu.org; Fri, 05 Nov 2021 10:14:20 -0400 Received: by mail-pg1-f170.google.com with SMTP id g184so8494071pgc.6 for <49722@debbugs.gnu.org>; Fri, 05 Nov 2021 07:14:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=SVGRLVyJc35thK1MKIYjHNajJJjYHRe5RooWJ12VYNM=; b=xfieKselGy8pe4NtxGveLxiv4Ujs/NSvDce38VZ6VckmQhf/mXWY0/Ggf7tZ7MtEtS mvqejNCWrY2BdrQgodAp7MXPxlOqWJNxbtkl9Oela81uX+q2+O3bbfvuZ1j6b5AZ9Jbj OTqgF/uJTvA9skjyfA0WhIsN5dI3SHHW9i/X5qMUmY5whxK4ySr8AyWYvu+GHlGggx3p d5XmiPF4GhSV3CeHb9ZmpBZ8TCrD0WWCWo2r9SQqPJxl9l4ShahzAxZUz4TOU6hVpdXo htLosDHlSa7UIojtBr7Es7TeCHScK3eQzffyXV3tnwbsJBFN90xfHoruBgT1VlNQX35z O3Dw== X-Gm-Message-State: AOAM531zfP0OXL3nI1jnAcZOuys9EE634DxwSi5nUmddpJqsEZHdD44G KNl/PTILA/ktv/q5nccOUsUuDgXq1P8cSB32k+0= X-Google-Smtp-Source: ABdhPJw5c4ycEbr0NxoLWHVo9khsPEf6PMWVIiYH0eSHfGphBj8cgsvSwDkM34SlnwTBjy3RJlTuO7dZUuiofc8mBnI= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr59104283pfj.0.1636121650873; Fri, 05 Nov 2021 07:14:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Nov 2021 07:14:10 -0700 From: Stefan Kangas In-Reply-To: <87im0yzl7h.fsf@163.com> (Andrei Kuznetsov's message of "Sun, 25 Jul 2021 19:28:34 +0800") References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> <87o8arz00o.fsf@163.com> <838s1uyjuy.fsf@gnu.org> <87im0yzl7h.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 5 Nov 2021 07:14:10 -0700 Message-ID: Subject: Re: bug#49722: 27.2; Emacs won't build with old versions of fontconfig To: Andrei Kuznetsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 49722 Cc: Eli Zaretskii , 49722@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 49722 28.1 thanks Eli Zaretskii writes: >> xftfont.c: In function =E2=80=98xftfont_cached_font_ok=E2=80=99: >> xftfont.c:591: error: =E2=80=98FC_LCD_FILTER=E2=80=99 undeclared (first = use in this function) >> xftfont.c:591: error: (Each undeclared identifier is reported only once >> xftfont.c:591: error: for each function it appears in.) >> >> It appears that FC_LCD_FILTER is not present on these older versions of >> fontconfig. > > Thanks. We once had the following in xftfont.c: > > #ifndef FC_LCD_FILTER > /* Older fontconfig versions don't have FC_LCD_FILTER. */ > #define FC_LCD_FILTER "lcdfilter" > #endif > > But it got moved to ftfont.c when a function which used it was moved > there. However, since xftfont.c still uses this, I think we should > have this #define in xftfont.c as well, so please try adding that at > the beginning of xftfont.c, and see if that helps. Andrei Kuznetsov writes: > Indeed it does. With the aformentioned change, Emacs now builds and > seems to operate normally. The fix was installed, so I'm closing this bug report. commit 41a55a330f518254da795719ac6e3085254d4110 Author: Eli Zaretskii Date: Sun Jul 25 15:50:46 2021 +0300 Fix compilation of xftfont.c with old fontconfig * src/xftfont.c (FC_LCD_FILTER): Define if undefined, for older versions of fontconfig. This was mistakenly deleted 2 years ago. (Bug#49722) From unknown Fri Aug 15 02:02:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Dec 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator