Subject: [PATCH] gnu: Add gmic-qt-gimp.

From: Vinicius Monego <[email-masked]>
Date: Fri, 22 Oct 2021 14:14:15 +0000

Hi,

> * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.

I built and tested this patch and can confirm it works. A few nitpicks
that I have:

> +    (inputs
> +      ;; GIMP and its dependencies.
> +      `(("gimp" ,gimp)
> +        ("gdk-pixbuf" ,gdk-pixbuf)
> +        ("cairo" ,cairo)
> +        ("gegl" ,gegl)
> +        ,@(package-inputs gmic-qt)))

Should be one space below inputs. Also the labeled inputs should be
sorted alphabetically. See the gmic-qt package for instance.

> +    (arguments
> +      (substitute-keyword-arguments (package-arguments gmic-qt)
> +        ((#:configure-flags flags)
> +         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> +                (string-append "-DGMIC_LIB_PATH="
> +                               (assoc-ref %build-inputs "gmic")
> "/lib")))))

Should be one space below arguments (see gmic-qt-krita for instance).

If you're using Emacs, the indentation should be fixed automatically
with M-x indent-sexp or indent-region.

Vinicius