Subject: bug#49715: closed (Re: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 22 Oct 2021 20:33:02 +0000

Your bug report

#49715: [PATCH] gnu: Add gmic-qt-gimp.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
49715: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49715
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp.
From: Leo Famulari <[email-masked]>
To: Vinicius Monego <[email-masked]>
Cc: [email-masked], Ivan Gankevich <[email-masked]>
Date: Fri, 22 Oct 2021 16:32:13 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote:
> Hi,
> 
> > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
> 
> I built and tested this patch and can confirm it works. A few nitpicks
> that I have:
> 
> > +    (inputs
> > +      ;; GIMP and its dependencies.
> > +      `(("gimp" ,gimp)
> > +        ("gdk-pixbuf" ,gdk-pixbuf)
> > +        ("cairo" ,cairo)
> > +        ("gegl" ,gegl)
> > +        ,@(package-inputs gmic-qt)))
> 
> Should be one space below inputs. Also the labeled inputs should be
> sorted alphabetically. See the gmic-qt package for instance.
> 
> > +    (arguments
> > +      (substitute-keyword-arguments (package-arguments gmic-qt)
> > +        ((#:configure-flags flags)
> > +         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> > +                (string-append "-DGMIC_LIB_PATH="
> > +                               (assoc-ref %build-inputs "gmic")
> > "/lib")))))
> 
> Should be one space below arguments (see gmic-qt-krita for instance).
> 
> If you're using Emacs, the indentation should be fixed automatically
> with M-x indent-sexp or indent-region.

Thanks for the patch and the review, everybody!

I made the requested changes and pushed as
41492639e0223dc8fc1a357e1f9537577c055db7

Subject: [PATCH] gnu: Add gmic-qt-gimp.
From: Ivan Gankevich <[email-masked]>
To: [email-masked]
Cc: Ivan Gankevich <[email-masked]>
Date: Sat, 24 Jul 2021 11:51:56 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
---
 gnu/packages/image-processing.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index df77bef192..399ee55c87 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2021 Andy Tai <[email-masked]>
 ;;; Copyright © 2021 Ekaitz Zarraga <[email-masked]>
 ;;; Copyright © 2021 Paul Garlick <[email-masked]>
+;;; Copyright © 2021 Ivan Gankevich <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,6 +57,7 @@
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages geo)
   #:use-module (gnu packages ghostscript)
+  #:use-module (gnu packages gimp)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
@@ -801,6 +803,25 @@ including 2D color images.")
                               (assoc-ref %build-inputs "gmic") "/lib")))))
     (synopsis "Krita plugin for the G'MIC image processing framework")))
 
+(define-public gmic-qt-gimp
+  (package
+    (inherit gmic-qt)
+    (name "gmic-qt-gimp")
+    (inputs
+      ;; GIMP and its dependencies.
+      `(("gimp" ,gimp)
+        ("gdk-pixbuf" ,gdk-pixbuf)
+        ("cairo" ,cairo)
+        ("gegl" ,gegl)
+        ,@(package-inputs gmic-qt)))
+    (arguments
+      (substitute-keyword-arguments (package-arguments gmic-qt)
+        ((#:configure-flags flags)
+         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
+                (string-append "-DGMIC_LIB_PATH="
+                               (assoc-ref %build-inputs "gmic") "/lib")))))
+    (synopsis "GIMP plugin for the G'MIC image processing framework")))
+
 (define-public nip2
   (package
     (name "nip2")
-- 
2.32.0