From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 04:54:26 2021 Received: (at submit) by debbugs.gnu.org; 24 Jul 2021 08:54:27 +0000 Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7DQQ-0004eI-LK for submit@debbugs.gnu.org; Sat, 24 Jul 2021 04:54:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:51906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7DQL-0004e4-IM for submit@debbugs.gnu.org; Sat, 24 Jul 2021 04:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7DQL-0002zI-8V for guix-patches@gnu.org; Sat, 24 Jul 2021 04:54:21 -0400 Received: from mail.spbu.ru ([195.70.197.23]:36028 helo=cgp2.pu.ru) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1m7DQH-0002Hd-Sq for guix-patches@gnu.org; Sat, 24 Jul 2021 04:54:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=HKyOJxgvjw+ZZNEuQXCjL2sPae9Z4nQ82s2eN6aHc2o=; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject :Cc:To:From; b=aKvpVvYLurmjtx55PvqmR65pkQPYKXOfzD09k3JryTbhBnc9knS2FrYs12kIKN xYJlPf3+bWzBAJwifZLGnzbmr5UvDD9+7t/j6ImdNBcMIXi58zvxosPqZJ6giPDQF8rum4nqrY2B8 s6EcoyAjLObr+b1Wu9qDUJ8vmLNza7ms0JH92B0XXYpRKFATWzPwQdCBXvVCqOTAOy1tYRU+4iewK wXz6kdwy0VVI6SivBN+XppsnkMaM3CoLyryf1FIZJaykxbR+PzI0e9WAwORO/xtMLOc3i/QHlixhg 5M7l6MhV6cjFV0PEV1U/GI6Jljz9uHTXnH0wdHQfurSjlnSTg== Received: from [172.27.221.159] (account st018947@spbu.ru HELO localhost.localdomain) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 173879971; Sat, 24 Jul 2021 11:54:12 +0300 From: Ivan Gankevich To: guix-patches@gnu.org Subject: [PATCH] gnu: Add gmic-qt-gimp. Date: Sat, 24 Jul 2021 11:51:56 +0300 Message-Id: <20210724085155.21417-1-i.gankevich@spbu.ru> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.70.197.23; envelope-from=i.gankevich@spbu.ru; helo=cgp2.pu.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Ivan Gankevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable. --- gnu/packages/image-processing.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index df77bef192..399ee55c87 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -17,6 +17,7 @@ ;;; Copyright © 2021 Andy Tai ;;; Copyright © 2021 Ekaitz Zarraga ;;; Copyright © 2021 Paul Garlick +;;; Copyright © 2021 Ivan Gankevich ;;; ;;; This file is part of GNU Guix. ;;; @@ -56,6 +57,7 @@ #:use-module (gnu packages fontutils) #:use-module (gnu packages geo) #:use-module (gnu packages ghostscript) + #:use-module (gnu packages gimp) #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) @@ -801,6 +803,25 @@ including 2D color images.") (assoc-ref %build-inputs "gmic") "/lib"))))) (synopsis "Krita plugin for the G'MIC image processing framework"))) +(define-public gmic-qt-gimp + (package + (inherit gmic-qt) + (name "gmic-qt-gimp") + (inputs + ;; GIMP and its dependencies. + `(("gimp" ,gimp) + ("gdk-pixbuf" ,gdk-pixbuf) + ("cairo" ,cairo) + ("gegl" ,gegl) + ,@(package-inputs gmic-qt))) + (arguments + (substitute-keyword-arguments (package-arguments gmic-qt) + ((#:configure-flags flags) + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON" + (string-append "-DGMIC_LIB_PATH=" + (assoc-ref %build-inputs "gmic") "/lib"))))) + (synopsis "GIMP plugin for the G'MIC image processing framework"))) + (define-public nip2 (package (name "nip2") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 10:26:24 2021 Received: (at 49715) by debbugs.gnu.org; 22 Oct 2021 14:26:24 +0000 Received: from localhost ([127.0.0.1]:33422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdvV2-0006Zn-IF for submit@debbugs.gnu.org; Fri, 22 Oct 2021 10:26:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdvUz-0006ZQ-Ru for 49715@debbugs.gnu.org; Fri, 22 Oct 2021 10:26:22 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 1B714240101 for <49715@debbugs.gnu.org>; Fri, 22 Oct 2021 16:26:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1634912775; bh=w21d5qQSkRxlY46m8KYqA+gq5aDK6YX+0PpRdkN/USA=; h=Subject:From:To:Cc:Date:From; b=hGm3YTfIud0kYanYNkqPT3Kp9J04y3zcy0JBfujijm9cEygVv4IWlmWtGENkqVWes lqwQF6dtyb+y3OITn9QYkuI2u5Wn0SrAHPLtlC3vgpk5hxMyZajkcE/F0KntdeGGrY 7FXStJKv6SpPkm5EJ64PGUNDxsndNhpE/7ePiawobR9LBLqPdJv77ZwX7CrJszAmc7 0W5vsk7gvfMyugRsjf4YVq13deExFKjspytCskdLiXxC+yc2fHYj97YU7UtMF0+Vnl F9eXXaFNllAWLnI0KMJtgeFW0nL14KIFUtF5eBTM+TTsxnFuLYIL+ePF4IM92zIiyu DptNfxxccCBEQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HbRVF1rhwz9rxL; Fri, 22 Oct 2021 16:26:12 +0200 (CEST) Message-ID: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> Subject: [PATCH] gnu: Add gmic-qt-gimp. From: Vinicius Monego To: 49715@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Fri, 22 Oct 2021 14:14:15 +0000 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49715 Cc: Ivan Gankevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable. I built and tested this patch and can confirm it works. A few nitpicks that I have: > + (inputs > + ;; GIMP and its dependencies. > + `(("gimp" ,gimp) > + ("gdk-pixbuf" ,gdk-pixbuf) > + ("cairo" ,cairo) > + ("gegl" ,gegl) > + ,@(package-inputs gmic-qt))) Should be one space below inputs. Also the labeled inputs should be sorted alphabetically. See the gmic-qt package for instance. > + (arguments > + (substitute-keyword-arguments (package-arguments gmic-qt) > + ((#:configure-flags flags) > + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON" > + (string-append "-DGMIC_LIB_PATH=" > + (assoc-ref %build-inputs "gmic") > "/lib"))))) Should be one space below arguments (see gmic-qt-krita for instance). If you're using Emacs, the indentation should be fixed automatically with M-x indent-sexp or indent-region. Vinicius From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 16:32:26 2021 Received: (at 49715-done) by debbugs.gnu.org; 22 Oct 2021 20:32:26 +0000 Received: from localhost ([127.0.0.1]:33845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1DG-0006Wo-0k for submit@debbugs.gnu.org; Fri, 22 Oct 2021 16:32:26 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me1DB-0006WX-2U for 49715-done@debbugs.gnu.org; Fri, 22 Oct 2021 16:32:25 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A0F5C5C00D1; Fri, 22 Oct 2021 16:32:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Oct 2021 16:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=EnwbtRBWLEROTSccR3fK7b+f Rrojy+tjE47qRcg37LE=; b=gETFaT7Op2lR2ereSTEdrqHYLtVxQB614sJMrVWj Nw65F5EEYz6mVISVkMxUH5kNyB3Uhs5luyI/hgNmOaapDhMjjVJYqF9OFVVyXV34 eEyU2lcst8SXEel1us3CMfqw4EqOyR0R1dlCWzWyw6VmM7RuMCoF8vCF5OmT+HLS 3CI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=EnwbtR BWLEROTSccR3fK7b+fRrojy+tjE47qRcg37LE=; b=aIBbwLtqoTOV/+ftSUQ+nf YyOaN5DDtNDkOlRb918ehzg6+gC1q6ViQh64xKdqonP/KixI6Vtd9gHdSPF3Pe7+ b6a4KV8ODmWx+oJD/brd8vTnSyL39hfYOXukjMUlTwLLsB6rf4KB+ki0zDSxpR7d MESXMc6wXI8VJxYnCJxkW5sa2HSaGfC4UF8kpW4X5n+Dolx8JYD2POmYO847uepq N35QHZzckFVk5S1HOylVGHTMBdVTTUIB53/DPDZmuXc/7X9eM+JKmywhym4SO2NG OiOL/L34b1XIHr0/JdguyvtiVqCJkKBodGsRRVRubUg/s6SOWSEU43C3BZ1b4Y2w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvkedgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtrodttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepgffhjeelveetueevhfehhefhvefggeevtdetteejhfeffedvhfdvtdejjeek udefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Oct 2021 16:32:15 -0400 (EDT) Date: Fri, 22 Oct 2021 16:32:13 -0400 From: Leo Famulari To: Vinicius Monego Subject: Re: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp. Message-ID: References: <20210724085155.21417-1-i.gankevich@spbu.ru> <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50ae7ea8f8252e1b9b57c7bf31ab4cd78718f1af.camel@posteo.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49715-done Cc: 49715-done@debbugs.gnu.org, Ivan Gankevich X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote: > Hi, > > > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable. > > I built and tested this patch and can confirm it works. A few nitpicks > that I have: > > > + (inputs > > + ;; GIMP and its dependencies. > > + `(("gimp" ,gimp) > > + ("gdk-pixbuf" ,gdk-pixbuf) > > + ("cairo" ,cairo) > > + ("gegl" ,gegl) > > + ,@(package-inputs gmic-qt))) > > Should be one space below inputs. Also the labeled inputs should be > sorted alphabetically. See the gmic-qt package for instance. > > > + (arguments > > + (substitute-keyword-arguments (package-arguments gmic-qt) > > + ((#:configure-flags flags) > > + '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON" > > + (string-append "-DGMIC_LIB_PATH=" > > + (assoc-ref %build-inputs "gmic") > > "/lib"))))) > > Should be one space below arguments (see gmic-qt-krita for instance). > > If you're using Emacs, the indentation should be fixed automatically > with M-x indent-sexp or indent-region. Thanks for the patch and the review, everybody! I made the requested changes and pushed as 41492639e0223dc8fc1a357e1f9537577c055db7 From unknown Thu Aug 14 18:40:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Nov 2021 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator