From unknown Mon Aug 11 21:15:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49704 <49704@debbugs.gnu.org> To: bug#49704 <49704@debbugs.gnu.org> Subject: Status: 28.0.50; erc-response object retained in text-props via erc-button Reply-To: bug#49704 <49704@debbugs.gnu.org> Date: Tue, 12 Aug 2025 04:15:00 +0000 retitle 49704 28.0.50; erc-response object retained in text-props via erc-b= utton reassign 49704 emacs submitter 49704 "J.P." severity 49704 minor tag 49704 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 03:50:29 2021 Received: (at submit) by debbugs.gnu.org; 23 Jul 2021 07:50:30 +0000 Received: from localhost ([127.0.0.1]:42210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6pwz-0004hr-C4 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 03:50:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:36812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6pwx-0004hj-D4 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 03:50:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6pwx-0007H6-3P for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 03:50:27 -0400 Received: from mail-109-mta190.mxroute.com ([136.175.109.190]:34173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6pws-0001L3-Ne for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2021 03:50:26 -0400 Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta190.mxroute.com (ZoneMTA) with ESMTPSA id 17ad25354c4000ae11.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 23 Jul 2021 07:45:14 +0000 X-Zone-Loop: 83bfdc947628c146378ff51735bc5cefffb63a92950b X-Originating-IP: [149.28.56.236] From: "J.P." To: bug-gnu-emacs@gnu.org Subject: 28.0.50; erc-response object retained in text-props via erc-button Date: Fri, 23 Jul 2021 00:45:12 -0700 Message-ID: <874kclh3sn.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-AuthUser: masked@neverwas.me X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, NEURAL_SPAM=0, FROM_HAS_DN=0, HAS_ATTACHMENT=0, FROM_EQ_ENVFROM=0, MIME_TRACE=0, MIME_GOOD=-0.1, RCPT_COUNT_ONE=0, MID_RHS_MATCH_FROM=0, RCVD_COUNT_ZERO=0, TO_DN_NONE=0] Received-SPF: pass client-ip=136.175.109.190; envelope-from=jp@neverwas.me; helo=mail-109-mta190.mxroute.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Severity: minor Tags: patch Hi, I encountered this while messing with: bug#49690: 28.0.50; ERC makes a button of `let' but not `let*' Whenever text from a received message is inserted into an ERC buffer, the function `erc-display-line-1' runs four hooks. Two of these, `erc-insert-modify-hook' and `erc-insert-post-hook' (basically identical), run with the buffer narrowed to the region surrounding the newly inserted message. This message features a text property called `erc-parsed', whose value is the original `erc-response' object used to represent that message as structured data during processing. Afterwards, `erc-display-line-1' removes `erc-parsed'. Question: shouldn't the hook functions being run here take care not to retain references to these objects unless actually needed? Specifically, `erc-button-add-buttons-1', which runs on `erc-insert-modify-hook' (via `erc-button-add-buttons'), saves portions of the text matching non-nick patterns in a text property called `erc-data'. These are arguments to be applied to a function stored in another text property, `erc-callback', which runs on mouse click or RET. It's obviously too late to change the interface for these hooks (for example, by adding a new "response object" param). But that doesn't mean we can't insist that hook functions at least make their intentions toward these response objects known rather than just stash them away in case some downstream facility (e.g., third-party code) might need them (which may have been the motivation here if this stashing was indeed intentional). For now, unless I'm way off the mark (wouldn't be the first time), I propose dropping all properties of all strings stored in `erc-data'. Of the functions called with `erc-data': - erc-browse-emacswiki - erc-browse-emacswiki-lisp - erc-button-search-url - erc-button-rfc-url - erc-button-describe-symbol - Info-goto-node - browse-url - browse-url-button-open-url none, AFAICT, actually uses 'erc-parsed' (or any property, for that matter). Obviously, this issue is small potatoes relative to ERC's other problems, so it can probably be put off indefinitely. Thanks. P.S. See also: `erc-hide-current-message-p' In GNU Emacs 28.0.50 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-07-20 built on localhost Repository revision: 1b251ed4e8550c889d17fe7d88f58aa2fbc95fe0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Fedora 34 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no --with-xwidgets --with-modules --with-harfbuzz --with-cairo --with-json build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu CC=gcc 'CFLAGS=-O0 -g3' LDFLAGS=-Wl,-z,relro PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 51359 6165) (symbols 48 6620 1) (strings 32 18257 1521) (string-bytes 1 615936) (vectors 16 13438) (vector-slots 8 179083 10089) (floats 8 21 47) (intervals 56 260 0) (buffers 992 10)) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Remove-text-props-from-callback-args-in-erc-button.patch >From 27f3157275e1462cc45c43a407a25a942df505b5 Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Thu, 22 Jul 2021 23:47:48 -0700 Subject: [PATCH] Remove text props from callback args in erc-button * lisp/erc/erc-button.el (erc-button-add-buttons-1): Remove text properties from strings stored in `erc-data' and passed to `erc-callback' (both text properties themselves). --- lisp/erc/erc-button.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/erc/erc-button.el b/lisp/erc/erc-button.el index cb9af92ba1..8f792752d1 100644 --- a/lisp/erc/erc-button.el +++ b/lisp/erc/erc-button.el @@ -299,7 +299,7 @@ erc-button-add-buttons-1 (end (match-end (nth 1 entry))) (form (nth 2 entry)) (fun (nth 3 entry)) - (data (mapcar #'match-string (nthcdr 4 entry)))) + (data (mapcar #'match-string-no-properties (nthcdr 4 entry)))) (when (or (eq t form) (eval form t)) (erc-button-add-button start end fun nil data regexp))))) -- 2.31.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 07:47:10 2021 Received: (at 49704) by debbugs.gnu.org; 23 Jul 2021 11:47:11 +0000 Received: from localhost ([127.0.0.1]:42451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6te2-00089f-Kv for submit@debbugs.gnu.org; Fri, 23 Jul 2021 07:47:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6te0-00083n-AX for 49704@debbugs.gnu.org; Fri, 23 Jul 2021 07:47:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ofJCi22aEtDtHcTAm3qdJq4rKHFvRTAd3x1r7z4kIEQ=; b=ulb7PC2WcNI0WCMyvcZhd7BW9n nayDpkEr8Uk5Lg7EwI9mHVHcjQnJLMFy6AoaB+b/xBwtfTI5BZ9vIipJpCpDAK/rHFyWHUNMgif1B mHb3r753NI41j1Sa667BwJE810Zvq22GUx2mbBph6sMO0bfB5/TPz7NVB06h2YeJHqn4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6tdr-0007Et-56; Fri, 23 Jul 2021 13:47:01 +0200 From: Lars Ingebrigtsen To: "J.P." Subject: Re: bug#49704: 28.0.50; erc-response object retained in text-props via erc-button References: <874kclh3sn.fsf@neverwas.me> X-Now-Playing: Bill Rieflin & Chris Connelly's _Largo_: "Pray'r" Date: Fri, 23 Jul 2021 13:46:58 +0200 In-Reply-To: <874kclh3sn.fsf@neverwas.me> (J. P.'s message of "Fri, 23 Jul 2021 00:45:12 -0700") Message-ID: <87mtqddzgt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "J.P." writes: > Question: shouldn't the hook functions being run here take care not to > retain references to these objects unless actually needed? I'm not quite sure I understand what problem the current text properties lead to? Is it saving memory-hungry closures in the text properties or something? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49704 Cc: 49704@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "J.P." writes: > Question: shouldn't the hook functions being run here take care not to > retain references to these objects unless actually needed? I'm not quite sure I understand what problem the current text properties lead to? Is it saving memory-hungry closures in the text properties or something? I had a look at the data in some buttons in an erc buffer, and nothing there really seems excessive? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 09:14:42 2021 Received: (at 49704) by debbugs.gnu.org; 23 Jul 2021 13:14:42 +0000 Received: from localhost ([127.0.0.1]:42579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v0g-0004bu-PX for submit@debbugs.gnu.org; Fri, 23 Jul 2021 09:14:42 -0400 Received: from mail-109-mta243.mxroute.com ([136.175.109.243]:33529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v0b-0004ba-Tb for 49704@debbugs.gnu.org; Fri, 23 Jul 2021 09:14:37 -0400 Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta243.mxroute.com (ZoneMTA) with ESMTPSA id 17ad380ab67000ae11.001 for <49704@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 23 Jul 2021 13:14:22 +0000 X-Zone-Loop: 3d4b87198d6b8d8fb032a1a982daa388b3ae514b1cd8 X-Originating-IP: [149.28.56.236] From: "J.P." To: Lars Ingebrigtsen Subject: Re: bug#49704: 28.0.50; erc-response object retained in text-props via erc-button References: <874kclh3sn.fsf@neverwas.me> <87mtqddzgt.fsf@gnus.org> Date: Fri, 23 Jul 2021 06:14:20 -0700 In-Reply-To: <87mtqddzgt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 23 Jul 2021 13:46:58 +0200") Message-ID: <87zgud895f.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: masked@neverwas.me X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, URIBL_BLOCKED=0, FROM_HAS_DN=0, RCPT_COUNT_THREE=0, TO_DN_SOME=0, MIME_GOOD=-0.1, NEURAL_SPAM=0, RCVD_COUNT_ZERO=0, FROM_EQ_ENVFROM=0, MIME_TRACE=0, MID_RHS_MATCH_FROM=0] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49704 Cc: 49704@debbugs.gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I'm not quite sure I understand what problem the current text properties > lead to? Is it saving memory-hungry closures in the text properties or > something? No, no closures, just strings containing the raw message and the various message parts. So on average, not a huge deal, I guess, even for channels with lots of links (for example, from a GitHub bot yapping about every commit)? > I had a look at the data in some buttons in an erc buffer, and nothing > there really seems excessive? Here's a recent example from #emacs. Original message: alice: check out the example in this page: https://www.gnu.org/software/groff/manual/html_node/Line-Layout.html#Line-Layout `erc-data' prop (edited): (#("https://www.gnu.org/software/groff/manual/html_node/Line-Layout.html#Line-Layout" 0 80 (tags ((batch . "767fece2e664ff56f97eb768f7ddb5c7") (time . "2021-07-21T09:04:51.884Z")) rear-sticky t erc-parsed #s(erc-response "@batch=767fece2e664ff56f97eb768f7ddb5c7;time=2021-07-21T09:04:51.884Z " ":Redacted!viking@124.197.53.238 PRIVMSG #emacs :alice: check out the " "example in this page: https://www.gnu.org/software/groff/manual/html_" "node/Line-Layout.html#Line-Layout" "Redacted!viking@124.197.53.238" "PRIVMSG" ("#emacs" "alice: check out the example in this page: https://www.gnu.org" "/software/groff/manual/html_node/Line-Layout.html#Line-Layout") "alice: check out the example in this page: https://www.gnu.org/software" "/groff/manual/html_node/Line-Layout.html#Line-Layout" ((batch . "767fece2e664ff56f97eb768f7ddb5c7") (time . "2021-07-21T09:04:51.884Z"))) font-lock-face erc-default-face))) So just the message text in a different form. If these aren't worth the bean counting, that's good news. ERC will need to store increasingly more data for *all* messages as it adapts to the evolving standard. It already relies on text properties in part to do that, so it's good to know that'll continue to be an option. I suppose I got all worked up over nothing then. As usual, many thanks and many more apologies. I leave you in peace (for now). From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 09:16:57 2021 Received: (at 49704) by debbugs.gnu.org; 23 Jul 2021 13:16:57 +0000 Received: from localhost ([127.0.0.1]:42588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v2u-0004ga-P9 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 09:16:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v2s-0004gJ-52 for 49704@debbugs.gnu.org; Fri, 23 Jul 2021 09:16:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kQlIghKLoVfS2tIA4kyralGYG2xH4ywOKWF+dfMbkj4=; b=VKDzfvQaJ9rOgozUHt/P60qJOm nFOvLKmbxpIpwGs91l3vQVV76C4Me2TAKnjJrotaMAFkWNfUtZdK17f14GDHRtZ7dvaihHBmRUog7 NdnfWxCRiyqKop8IMS5o1TIWawVt/TGh3mEsHOuS+NXcZBP4vTaM9eeJsxmjyOO1sYzo=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6v2j-0000D2-Un; Fri, 23 Jul 2021 15:16:48 +0200 From: Lars Ingebrigtsen To: "J.P." Subject: Re: bug#49704: 28.0.50; erc-response object retained in text-props via erc-button References: <874kclh3sn.fsf@neverwas.me> <87mtqddzgt.fsf@gnus.org> <87zgud895f.fsf@neverwas.me> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUFAwQRCgo+P0P3 9uzn385oWVSPcV+noZncx6hhSTkTDhIuICCljHFMLS7///8ts5kaAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UHFw0DOP5E66kAAAFuSURBVDjLdZO9S8NAFMDfFaI2VXiBohjHVnRxSgYHN2tnpQriFEcr TjqIq1AUlyzu59BBaeGGUpBOGXQT6n/kXe4KJu/lQd6F+937unsPoCjYio9EoAXKoBd3WQC38YAH j/EzC/zD+IUFtaiTOSCEBB8XwIviFIW10KoRIogcLkf7Sp+1royZyRQCFM3oQAYIFqAB5nz4ZuvT 5qXgCK2vG+G85G5crhImyUhhYdPJxryZkNqMWpdtxYIp7pFbCkMJcAZUTLl+3xVaDu7NoT5njGAb g+EFs+9fI3gDSV15v/oan45d5f/kVX+TriSg0deq/QAEeCah09TcdhG8G3Wexy6CsVE7QEHDHN5i AMyk+ykDMbOLIH1VtzdIG85Ta4oFq+koYcFKNjzJX4a4+tGdwjb1B9p9AjYl8mBq8uXAuKIOWFKO lEEtsc9Eh/Mqt8inoii7CnjpZRXg7rIC3FtXNPi3XchELeaAWnza/eAPjyU+SQrAhKgAAAAldEVY dGRhdGU6Y3JlYXRlADIwMjEtMDctMjNUMTM6MDM6NTYrMDA6MDBMvKCpAAAAJXRFWHRkYXRlOm1v ZGlmeQAyMDIxLTA3LTIzVDEzOjAzOjU2KzAwOjAwPeEYFQAAAABJRU5ErkJggg== X-Now-Playing: The Human League's _Octopus (2)_: "Words (Demo)" Date: Fri, 23 Jul 2021 15:16:45 +0200 In-Reply-To: <87zgud895f.fsf@neverwas.me> (J. P.'s message of "Fri, 23 Jul 2021 06:14:20 -0700") Message-ID: <87bl6tcgqq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "J.P." writes: > No, no closures, just strings containing the raw message and the various > message parts. Oh, OK, I thought I was misunderstanding something. I think your patch is the right thing here, though -- I don't think any usages of the the stashed data uses the text properties, and it'll make Emac [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49704 Cc: 49704@debbugs.gnu.org, emacs-erc@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "J.P." writes: > No, no closures, just strings containing the raw message and the various > message parts. Oh, OK, I thought I was misunderstanding something. I think your patch is the right thing here, though -- I don't think any usages of the the stashed data uses the text properties, and it'll make Emacs use less memory, so I've now applied it to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 23 09:18:26 2021 Received: (at control) by debbugs.gnu.org; 23 Jul 2021 13:18:26 +0000 Received: from localhost ([127.0.0.1]:42592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v4M-0004jK-60 for submit@debbugs.gnu.org; Fri, 23 Jul 2021 09:18:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6v4J-0004j5-OQ for control@debbugs.gnu.org; Fri, 23 Jul 2021 09:18:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1ye4WP4t39LQlRXbFk7EiJaqh/LAlNBk3LGgKp4bhOM=; b=R1IqYBxUplK3spSJNVftIuPUyM hCPotq/NpKeesPAOqdantw+2qsTvC6nih7T+ZBFLkeiOeWnSYitm7Q65TNzbNLDs8zKFRtC3xw/G5 YTTaNWaaJmEl4hmsuEU8grj2v15s7AkM4ZtlamJ/JBujbamVXJsSmgxgPnxbu41siMC4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6v4C-0000EQ-6j for control@debbugs.gnu.org; Fri, 23 Jul 2021 15:18:18 +0200 Date: Fri, 23 Jul 2021 15:18:15 +0200 Message-Id: <87a6mdcgo8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49704 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49704 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49704 28.1 quit From unknown Mon Aug 11 21:15:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Aug 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator