Subject: bug#49674: 28.0.50; Should unload-feature remove advices?

From: Michael Heerdegen <[email-masked]>
Date: Wed, 21 Jul 2021 04:38:33 +0200

Hello,

While talking about the text about FEATURE-unload-hook in
(info "(elisp) Coding Conventions") (Bug#21440) the question was raised
whether `unload-feature' should try to automatically remove advices
(nadvice style) that belong to functions defined by the unloaded
feature.  Currently these are ignored.  I guess it would be a good
thing.  AFAICT old-style advices were (and are) handled.

And the docstring of `unload-feature' covers a lot of cases to care
about manually, but it doesn't mention advices.  Should it?

TIA,

Michael.