GNU bug report logs - #49674
28.0.50; Should unload-feature remove advices?

Previous Next

To reply to this bug, email your comments to 49674 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Should unload-feature remove advices?
Date: Wed, 21 Jul 2021 04:38:33 +0200

Hello,

While talking about the text about FEATURE-unload-hook in
(info "(elisp) Coding Conventions") (Bug#21440) the question was raised
whether `unload-feature' should try to automatically remove advices
(nadvice style) that belong to functions defined by the unloaded
feature.  Currently these are ignored.  I guess it would be a good
thing.  AFAICT old-style advices were (and are) handled.

And the docstring of `unload-feature' covers a lot of cases to care
about manually, but it doesn't mention advices.  Should it?


TIA,

Michael.

Message #8 received at 49674 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 49674 <at> debbugs.gnu.org
Subject: Re: bug#49674: 28.0.50; Should unload-feature remove advices?
Date: Wed, 21 Jul 2021 16:57:56 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> While talking about the text about FEATURE-unload-hook in
> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
> whether `unload-feature' should try to automatically remove advices
> (nadvice style) that belong to functions defined by the unloaded
> feature.  Currently these are ignored.  I guess it would be a good
> thing.  AFAICT old-style advices were (and are) handled.

I think that sounds like a good idea, but perhaps Stefan has a comment
here (added to the CCs).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 49674 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 49674 <at> debbugs.gnu.org
Subject: Re: bug#49674: 28.0.50; Should unload-feature remove advices?
Date: Wed, 21 Jul 2021 11:14:54 -0400

Lars Ingebrigtsen [2021-07-21 16:57:56] wrote:
> Michael Heerdegen <michael_heerdegen <at> web.de> writes:
>> While talking about the text about FEATURE-unload-hook in
>> (info "(elisp) Coding Conventions") (Bug#21440) the question was raised
>> whether `unload-feature' should try to automatically remove advices
>> (nadvice style) that belong to functions defined by the unloaded
>> feature.  Currently these are ignored.  I guess it would be a good
>> thing.  AFAICT old-style advices were (and are) handled.
> I think that sounds like a good idea, but perhaps Stefan has a comment
> here (added to the CCs).

Sounds good to me, yes.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.