GNU bug report logs - #49672
[PATCH 0/9] Target check fixes and cleanups

Previous Next

Full log

Message #47 received at 49672 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: 49672 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>,
 Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH v2 2/6] gnu: libgc: Use default argument in ‘target-hurd?’ call
Date: Sun, 27 Mar 2022 18:40:22 -0300

‘%current-system’ is always defined, so the expression
“(or (%current-system) (%current-target-system))” is equivalent to
“(%current-system)”, which is unlikely to be the intent of the code.

The default argument for ‘target-hurd?’ has the ‘or’ expression in the
correct order, so just use that.

* gnu/packages/bdw-gc.scm (libgc)[arguments]<#:configure-flags>: Omit
argument in call to ‘target-hurd?’.
---
 gnu/packages/bdw-gc.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index 2698d56da00b..13a6691db4b2 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -56,8 +56,7 @@ (define-public libgc
        ;; to configure script. See bug report and discussion:
        ;; <https://lists.opendylan.org/pipermail/bdwgc/2017-April/006275.html>
        ;; <https://lists.gnu.org/archive/html/bug-hurd/2017-01/msg00008.html>
-       ,@(if (target-hurd? (or (%current-system)
-                               (%current-target-system)))
+       ,@(if (target-hurd?)
              '("--disable-gcj-support")
              '()))))
    (native-inputs (list pkg-config))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.