GNU bug report logs - #49670
[PATCH] gnu: gnome-maps: Unregister from DBus when asked to.

Previous Next

Full log

Message #11 received at 49670 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 49670 <at> debbugs.gnu.org
Subject: Re: bug#49670: [PATCH] gnu: gnome-maps: Unregister from DBus when
 asked to.
Date: Wed, 21 Jul 2021 16:28:01 +0200

Hi!

Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:

> * gnu/packages/patches/gnome-maps-really-do-unregister.patch: New file.
> * gnu/packages/geo.scm (gnome-maps)[patches]: Add it here...
> * gnu/local.mk (dist_patch_DATA): ... and here.
> ---
> I've opened a separate merge request upsteam [1], but since their CI is
> currently failing, it will take some time for this patch to make it into a
> release.
>
> [1] https://gitlab.gnome.org/GNOME/gnome-maps/-/merge_requests/187

> +              (patches
> +               (search-patches
> +                "gnome-maps-really-do-unregister.patch"))))

This can all go on a single line.

> +++ b/gnu/packages/patches/gnome-maps-really-do-unregister.patch
> @@ -0,0 +1,13 @@
> +Index: gnome-maps-3.36.7/src/application.js

Could you add a line at the top of this patch saying what it does along
with a link to the merge request above?

Apart from that the two patches LGTM, especially if it allows me to use
gnome-maps again.  :-)

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.