GNU bug report logs - #49659
[PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxime Devos <maximedevos <at> telenet.be>
Subject: bug#49659: closed (Re: bug#49659: [PATCH core-updates] gnu:
 guile: Fix failing tests on i686-linux.)
Date: Wed, 21 Jul 2021 13:50:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#49659: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 49659 <at> debbugs.gnu.org.

-- 
49659: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49659
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49659-done <at> debbugs.gnu.org
Subject: Re: bug#49659: [PATCH core-updates] gnu: guile: Fix failing tests
 on i686-linux.
Date: Wed, 21 Jul 2021 15:49:15 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> i586-gnu might have the same issue.
>
> * gnu/packages/guile.scm (guile-3.0)[arguments]<#:configure-flags>:
>   Add "-fexcess-precision=standard" to CFLAGS when
>   (target-x86-32?) is true.
>
> Fixes: <https://issues.guix.gnu.org/49368>.

I tweaked the commit log and pushed as
fccc0275091af10a46471c68df525d19f446af9e.

Looks like we should be able to move forward with this branch now,
thank you!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>
Subject: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.
Date: Tue, 20 Jul 2021 13:27:12 +0200

i586-gnu might have the same issue.

* gnu/packages/guile.scm
  (guile-3.0)[arguments]<#:configure-flags>: Add
  "-fexcess-precision=standard" to CFLAGS.
---
 gnu/packages/guile.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index d78c57e88c..e1f6495837 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2018 Eric Bavier <bavier <at> member.fsf.org>
 ;;; Copyright © 2019 Taylan Kammer <taylan.kammer <at> gmail.com>
 ;;; Copyright © 2020, 2021 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2021 Maxime Devos <maximedevos <at> telenet.be>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -316,7 +317,10 @@ without requiring the source code to be rewritten.")
     (arguments
      (substitute-keyword-arguments (package-arguments guile-2.2)
        ((#:configure-flags flags ''())
-        (let ((flags `(cons "--enable-mini-gmp" ,flags)))
+        ;; -fexcess-precision=standard is required when compiling for
+        ;; i686-linux, otherwise "numbers.test" will fail.
+        (let ((flags `(cons* "CFLAGS=-g -O2 -fexcess-precision=standard"
+                              "--enable-mini-gmp" ,flags)))
           ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd.
           (if (hurd-target?)
               `(cons "--disable-jit" ,flags)
-- 
2.32.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.