Subject: bug#49659: closed (Re: bug#49659: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 21 Jul 2021 13:50:02 +0000

Your bug report

#49659: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
49659: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49659
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#49659: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.
From: Ludovic Courtès <[email-masked]>
To: Maxime Devos <[email-masked]>
Cc: [email-masked]
Date: Wed, 21 Jul 2021 15:49:15 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Maxime Devos <[email-masked]> skribis:

> i586-gnu might have the same issue.
>
> * gnu/packages/guile.scm (guile-3.0)[arguments]<#:configure-flags>:
>   Add "-fexcess-precision=standard" to CFLAGS when
>   (target-x86-32?) is true.
>
> Fixes: <https://issues.guix.gnu.org/49368>.

I tweaked the commit log and pushed as
fccc0275091af10a46471c68df525d19f446af9e.

Looks like we should be able to move forward with this branch now,
thank you!

Ludo’.

Subject: [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.
From: Maxime Devos <[email-masked]>
To: [email-masked]
Cc: Maxime Devos <[email-masked]>
Date: Tue, 20 Jul 2021 13:27:12 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

i586-gnu might have the same issue.

* gnu/packages/guile.scm
  (guile-3.0)[arguments]<#:configure-flags>: Add
  "-fexcess-precision=standard" to CFLAGS.
---
 gnu/packages/guile.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index d78c57e88c..e1f6495837 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -16,6 +16,7 @@
 ;;; Copyright © 2018 Eric Bavier <[email-masked]>
 ;;; Copyright © 2019 Taylan Kammer <[email-masked]>
 ;;; Copyright © 2020, 2021 Efraim Flashner <[email-masked]>
+;;; Copyright © 2021 Maxime Devos <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -316,7 +317,10 @@ without requiring the source code to be rewritten.")
     (arguments
      (substitute-keyword-arguments (package-arguments guile-2.2)
        ((#:configure-flags flags ''())
-        (let ((flags `(cons "--enable-mini-gmp" ,flags)))
+        ;; -fexcess-precision=standard is required when compiling for
+        ;; i686-linux, otherwise "numbers.test" will fail.
+        (let ((flags `(cons* "CFLAGS=-g -O2 -fexcess-precision=standard"
+                              "--enable-mini-gmp" ,flags)))
           ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd.
           (if (hurd-target?)
               `(cons "--disable-jit" ,flags)
-- 
2.32.0