GNU bug report logs - #49632
[PATCH] Ensure that M-x gdb populates gud-repeat-map

Previous Next

Full log

Message #32 received at 49632 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Juri Linkov <juri <at> linkov.net>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49632 <at> debbugs.gnu.org
Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
Date: Sat, 24 Jul 2021 05:33:50 +0200 (CEST)

[Message part 1 (text/plain, inline)]

OK, I've updated the patch following Juri's suggestions.

> ----------------------------------------
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Sent: Mon Jul 19 17:52:43 CEST 2021
> To: Juri Linkov <juri <at> linkov.net>
> Cc: Brian Leung <leungbk <at> mailfence.com>, <49632 <at> debbugs.gnu.org>
> Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
> 
> 
> Juri Linkov <juri <at> linkov.net> writes:
> 
> > Exactly.  But this means that you need to populate a new separate map
> > 'gdb-repeat-map' specific to 'gdb' commands.  Also I noticed that the
> > current name of 'gud-repeat-map' is wrong.  It should be renamed to
> > 'gud-gdb-repeat-map'.  So other debuggers could populate own repeat-maps
> > named e.g. 'sdb-repeat-map', 'jdb-repeat-map', 'perldb-repeat-map', etc.
> 
> I see.  Then Brian's patch is functionally correct, but it shouldn't be
> copy-and-pasted -- instead separating it out into a helper function and
> using it both places seems like the correct thing to do.
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no


-- 
Sent with https://mailfence.com
Secure and private email

-- 
Mailfence.com
Private and secure email

[0001-Ensure-that-gud-commands-for-M-x-gdb-are-handled-by-.patch (text/x-diff, attachment)]

[0002-Ensure-that-gud-commands-for-non-GDB-debuggers-are-h.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.