GNU bug report logs - #49632
[PATCH] Ensure that M-x gdb populates gud-repeat-map

Previous Next

Full log

Message #23 received at 49632 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 49632 <at> debbugs.gnu.org, Brian Leung <leungbk <at> mailfence.com>
Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
Date: Mon, 19 Jul 2021 17:52:43 +0200

Juri Linkov <juri <at> linkov.net> writes:

> Exactly.  But this means that you need to populate a new separate map
> 'gdb-repeat-map' specific to 'gdb' commands.  Also I noticed that the
> current name of 'gud-repeat-map' is wrong.  It should be renamed to
> 'gud-gdb-repeat-map'.  So other debuggers could populate own repeat-maps
> named e.g. 'sdb-repeat-map', 'jdb-repeat-map', 'perldb-repeat-map', etc.

I see.  Then Brian's patch is functionally correct, but it shouldn't be
copy-and-pasted -- instead separating it out into a helper function and
using it both places seems like the correct thing to do.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.