GNU bug report logs - #49632
[PATCH] Ensure that M-x gdb populates gud-repeat-map

Previous Next

Package: emacs;

Reported by: Brian Leung <leungbk <at> mailfence.com>

Date: Mon, 19 Jul 2021 03:38:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 49632 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> mailfence.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49632 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
Date: Mon, 19 Jul 2021 16:57:11 +0200 (CEST)
> I admit I don't understand the rationale for the patch at all.
> "M-x gdb" already repeats these commands when you type just RET
> into the interaction buffer, so what exactly does this change
> do, and how can I see its effect?

RET can repeat only the last command (afaik). If instead I want to run, in order:

1. continue
2. next
3. next
4. stepi

then without this patch, I would need to press

1. C-x C-a C-r
2. C-x C-a C-n
3. C-x C-a C-n
4. C-x C-a C-i

if using M-x gdb.

With the patch, I can press:

1. C-x C-a C-r
2. n
3. n
4. i

since the new repeat-mode defines the appropriate repeat map.

> ----------------------------------------
> From: Eli Zaretskii <eliz <at> gnu.org>
> Sent: Mon Jul 19 15:13:52 CEST 2021
> To: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: <leungbk <at> mailfence.com>, <49632 <at> debbugs.gnu.org>, <juri <at> linkov.net>
> Subject: Re: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map
> 
> 
> > From: Lars Ingebrigtsen <larsi <at> gnus.org>
> > Date: Mon, 19 Jul 2021 15:06:31 +0200
> > Cc: 49632 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
> > 
> > Brian Leung <leungbk <at> mailfence.com> writes:
> > 
> > > * lisp/progmodes/gdb-mi.el (gdb): Populate gud-repeat-map. This is
> > > copied from the gud-gdb command.
> > 
> > Instead of copying the code, perhaps it should be separated out into its
> > own function and then called from both places?
> > 
> > But I don't quite understand why gud-repeat-map is populated in the
> > normal way -- i.e., in `gud-repeat-map' so that users can
> > redefine/override entries as usual.
> 
> I admit I don't understand the rationale for the patch at all.
> "M-x gdb" already repeats these commands when you type just RET
> into the interaction buffer, so what exactly does this change
> do, and how can I see its effect?


-- 
Sent with https://mailfence.com
Secure and private email

-- 
Mailfence.com
Private and secure email




This bug report was last modified 3 years and 295 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.