From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 18 19:15:56 2021 Received: (at submit) by debbugs.gnu.org; 18 Jul 2021 23:15:56 +0000 Received: from localhost ([127.0.0.1]:57612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5G0p-0003dr-Uh for submit@debbugs.gnu.org; Sun, 18 Jul 2021 19:15:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:39844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5CyV-0003BL-KG for submit@debbugs.gnu.org; Sun, 18 Jul 2021 16:01:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5CyV-0007tj-55 for guix-patches@gnu.org; Sun, 18 Jul 2021 16:01:19 -0400 Received: from mail-out2.in.tum.de ([131.159.0.36]:36795 helo=mail-out2.informatik.tu-muenchen.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5CyT-0004jp-1z for guix-patches@gnu.org; Sun, 18 Jul 2021 16:01:18 -0400 Received: from mailrelay1.rbg.tum.de (mailrelay1.in.tum.de [131.159.254.14]) by mail-out2.informatik.tu-muenchen.de (Postfix) with ESMTP id 81A022400BB for ; Sun, 18 Jul 2021 22:01:05 +0200 (CEST) Received: by mailrelay1.rbg.tum.de (Postfix, from userid 112) id 7F790105; Sun, 18 Jul 2021 22:01:05 +0200 (CEST) Received: from mailrelay1.rbg.tum.de (localhost [127.0.0.1]) by mailrelay1.rbg.tum.de (Postfix) with ESMTP id 94073104 for ; Sun, 18 Jul 2021 22:01:01 +0200 (CEST) Received: from mail.net.in.tum.de (mail.net.in.tum.de [IPv6:2001:4ca0:2001:14:216:3eff:fe52:ed14]) by mailrelay1.rbg.tum.de (Postfix) with ESMTP id 91908102 for ; Sun, 18 Jul 2021 22:01:01 +0200 (CEST) Received: from amnesix.net.in.tum.de (amnesix.net.in.tum.de [IPv6:2001:4ca0:2001:11:e2d5:5eff:fea9:55ca]) by mail.net.in.tum.de (Postfix) with ESMTP id 6618D28D080E; Sun, 18 Jul 2021 22:01:01 +0200 (CEST) From: itd To: guix-patches@gnu.org Subject: [PATCH] import/print: package->code: Fix license object. Date: Sun, 18 Jul 2021 22:01:00 +0200 Message-ID: <87h7gr5r43.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=131.159.0.36; envelope-from=itd@net.in.tum.de; helo=mail-out2.informatik.tu-muenchen.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 18 Jul 2021 19:15:54 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/import/print.scm (package->code)code>: Update generated licence object to match record constructor. --- Hi, given the following example (please note the fake license): ```bash ( printf '%s\n'\ "(define-module (out) #:use-module (guix packages) #:use-module (guix download))"\ "(define license (@@ (guix licenses) license))" # see commit 1597613488 guix import json /dev/stdin < out.scm guix build -L . hello ``` This example fails to build for me with error: ```bash guix build: warning: failed to load '(out)': Wrong type to apply: "hello" ``` I suspect this to be caused by the generated license definition: ```guile (license (license (name "FSDG-compatible") (uri "a-license") (comment ""))))) ``` After patching, the package builds successfully with the following license definition: ```guile (license (license "FSDG-compatible" "a-license" "")))) ``` Regards itd guix/import/print.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/guix/import/print.scm b/guix/import/print.scm index dcc38abc70..0310739b3a 100644 --- a/guix/import/print.scm +++ b/guix/import/print.scm @@ -60,9 +60,9 @@ when evaluated." (if var (symbol-append 'license: var) `(license - (name ,(license-name lic)) - (uri ,(license-uri lic)) - (comment ,(license-comment lic)))))) + ,(license-name lic) + ,(license-uri lic) + ,(license-comment lic))))) (define (search-path-specification->code spec) `(search-path-specification -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 10:58:17 2021 Received: (at 49627-done) by debbugs.gnu.org; 19 Jul 2021 14:58:17 +0000 Received: from localhost ([127.0.0.1]:59764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5UiZ-00065h-Es for submit@debbugs.gnu.org; Mon, 19 Jul 2021 10:58:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5UiX-000654-F2 for 49627-done@debbugs.gnu.org; Mon, 19 Jul 2021 10:58:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5UiQ-0003ym-EA; Mon, 19 Jul 2021 10:57:54 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=42880 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5UiQ-0004cx-1W; Mon, 19 Jul 2021 10:57:54 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: itd Subject: Re: bug#49627: [PATCH] import/print: package->code: Fix license object. References: <87h7gr5r43.fsf@localhost> Date: Mon, 19 Jul 2021 16:57:52 +0200 In-Reply-To: <87h7gr5r43.fsf@localhost> (itd@net.in.tum.de's message of "Sun, 18 Jul 2021 22:01:00 +0200") Message-ID: <87fswamjv3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49627-done Cc: 49627-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, itd skribis: > * guix/import/print.scm (package->code)code>: Update generated > licence object to match record constructor. Applied, thanks! Ludo=E2=80=99. From unknown Fri Sep 05 08:21:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Aug 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator