From unknown Tue Aug 19 23:15:43 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49620] [PATCH 2/2] Add pirate-get Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Jul 2021 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49620@debbugs.gnu.org X-Debbugs-Original-To: "guix-patches@gnu.org" Reply-To: phodina Received: via spool by submit@debbugs.gnu.org id=B.162660825630736 (code B ref -1); Sun, 18 Jul 2021 11:38:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jul 2021 11:37:36 +0000 Received: from localhost ([127.0.0.1]:55292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5572-0007zg-99 for submit@debbugs.gnu.org; Sun, 18 Jul 2021 07:37:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:53878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5570-0007zY-6e for submit@debbugs.gnu.org; Sun, 18 Jul 2021 07:37:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m556z-0003OO-WE for guix-patches@gnu.org; Sun, 18 Jul 2021 07:37:34 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:62172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m556y-0004hl-93 for guix-patches@gnu.org; Sun, 18 Jul 2021 07:37:33 -0400 Date: Sun, 18 Jul 2021 11:37:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1626608245; bh=hvsl1iJLJUt8YI+rE2cbJCk3ZdUsY4rsTDZy1ghxCRw=; h=Date:To:From:Reply-To:Subject:From; b=UKR62ynBh93AQsXLcjmSWjSTyAI/Yncxy/afqKzpH4Z7I1fAM4hqfxLFtxWnJxLUR 6g8emzSyyiKWPXBVcH7RgJcjlgPQ/6tr3ulDLTJL8vCNHoeIPZJpK7wCcSDFXLYwJ0 zmk8Pd9zL9dQPvPMbG2tfyAe5R6s/3cvvydIpQ2g= From: phodina Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.136; envelope-from=phodina@protonmail.com; helo=mail-40136.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) And the pirate-get definition itself --- index 40b93c4b30..eaf521090c 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -1778,6 +1778,33 @@ helpers.") appealing ASCII table format") (license license:bsd3))) +(define-public python-pirate-get + (package + (name "python-pirate-get") + (version "0.4.0") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pirate-get" version)) + (sha256 + (base32 + "07s5ss9dxccx1mip7pyga1fagywkqchxmzz55ng47ac9053ffxkq")))) + (build-system python-build-system) + (propagated-inputs + `(("python-colorama" ,python-colorama) + ("python-pyperclip" ,python-pyperclip) + ("python-veryprettytable" + ,python-veryprettytable))) + (home-page + "https://github.com/vikstrous/pirate-get") + (synopsis + "A command line interface for The Pirate Bay") + (description + "pirate-get is a convenient command line tool (inspired by APT) +to speed up your trip to the Pirate Bay and get your completely legal +torrents more quickly.") + (license license:gpl3))) + (define-public python2-humanfriendly (let ((base (package-with-python2 (strip-python2-variant python-humanfriendly)))) -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 20 22:53:46 2021 Received: (at control) by debbugs.gnu.org; 21 Jul 2021 02:53:46 +0000 Received: from localhost ([127.0.0.1]:35866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Mk-00050W-1g for submit@debbugs.gnu.org; Tue, 20 Jul 2021 22:53:46 -0400 Received: from out0.migadu.com ([94.23.1.103]:33887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m62Mg-00050E-Eg; Tue, 20 Jul 2021 22:53:43 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626836020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P6p1rMNlUc3Bpbdbr2Hp+cJdLEMYUyKiYB1flDMDsQ0=; b=d835on4oexQqeUkYnXmVy3D9tGq4VjF+uMA2aEBFmO3EblG1upjtwQZIbYqFytyY4cW+5q pkB+he4Tuixx/oFRPgw25uDh5scaDAdmmDThbvxS5ZXWD6L9oGXR5nezUk6bd8ZeLddkqT vKtb+ttnZ2M4dV6A7T6oBVVj0CU+O7s= From: Sarah Morgensen To: phodina Subject: Re: bug#49619: [PATCH 1/2] Add pirate-get References: Date: Tue, 20 Jul 2021 19:53:37 -0700 In-Reply-To: (phodina@protonmail.com's message of "Sun, 18 Jul 2021 11:36:02 +0000") Message-ID: <86bl6wtm1a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 49619@debbugs.gnu.org, control@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) merge 49619 49620 thanks Hello, Thanks for the patch. Please note that when submitting patchsets, only the first patch should be sent to guix-patches@gnu.org; the rest should be sent to the generated bug number, in this case 49619@debbugs.gnu.org, in reply to the first email. You can find information about contributing at: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html I also have a few suggestions so your patch can be accepted. phodina writes: > Add pkg veryprettytable as a dependency for pkg pirate-get > > --- Commit messages should follow the ChangeLog format; see the commit history for examples. For example, this commit message would look like: --8<---------------cut here---------------start------------->8--- gnu: Add python-veryprettytable. * gnu/packages/python-xyz.scm (python-veryprettytable): New variable. --8<---------------cut here---------------end--------------->8--- > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index d8c3fbec07..40b93c4b30 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -1754,6 +1754,30 @@ helpers.") > (properties `((python2-variant . ,(delay python2-humanfriendly)))) > (license license:expat))) > > +(define-public python-veryprettytable > + (package > + (name "python-veryprettytable") > + (version "0.8.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "veryprettytable" version)) > + (sha256 > + (base32 > + "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-colorama" ,python-colorama) > + ("python-termcolor" ,python-termcolor))) > + (home-page > + "https://github.com/smeggingsmegger/VeryPrettyTable") > + (synopsis > + "A visually appealing ASCII table output format") Avoid starting synopses and descriptions with articles. "Visually appealing..." would be fine. > + (description > + "A simple Python library for easily displaying tabular data in a visually > +appealing ASCII table format") Descriptions typically start: "VeryPrettyTable is a simple..." The description for pirate-get should probably start "Pirate-get is a..." or "@code{pirate-get} is a..." > + (license license:bsd3))) This should be license:bsd-3. > + > (define-public python2-humanfriendly > (let ((base (package-with-python2 > (strip-python2-variant python-humanfriendly)))) > -- > 2.31.1 You should also add your copyright at the top of the file, below all the others. Please use `--reroll-count=` when generating revised patchsets and `--to=49169@debbugs.gnu.org --in-reply-to=` when sending. -- Sarah