GNU bug report logs - #49619
[PATCH 1/2] Add pirate-get

Previous Next

Full log

Message #28 received at 49619 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: phodina <phodina <at> protonmail.com>
Cc: 49619 <at> debbugs.gnu.org
Subject: Re: [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table.
Date: Tue, 21 Sep 2021 20:21:53 -0700

[Message part 1 (text/plain, inline)]

Hi,

phodina <phodina <at> protonmail.com> writes:

> Hi Sarah!
>
> Are these fixes now compliant to upstream the patch?

It's pretty good.  I went ahead and made a few changes (attached below):
I tweaked the descriptions, I changed very-pretty-table to
veryprettytable so the python importer can find it in the future, I
changed pirate-get's propagated-inputs to inputs since it's an end-user
package, and I changed the license of pirate-get to AGPL-3.

* Package review checklist (WIP)
Lack of a check is not proof of noncompliance.

1. [X] Package builds (guix build package)
     [X] x86_64  [ ] aarch64  [ ] armhf     [ ] powerpc64le
     [ ] i686    [ ] i586     [ ] mips64le
2. [X] Build is reproducible (guix build --rounds=n package)
3. [X] Tests enabled (if available) or disabled with in-source comment
4. [X] No extraneous dependencies (guix size package)
5. [X] No unnecessary pre-built binaries/blobs
6. [X] Dependencies unvendored when available in Guix
7. [X] Cross-compile friendly (cc-for-target, patches with inputs)
8. [X] License matches source
9. [X] No problematic lints (guix lint package)
10. [X] Formatting follows guidelines
    - [X] Lines wrap at 80 characters
    - [X] Indentation passes etc/indent-code.el
    - [X] Two spaces used between sentences

For new packages:
1. [X] Source url is robust
   * mirror:// used with url-fetch when possible
   * No auto-generated archives from source repo (prefer cloning)
2. [X] Synopsis is short, descriptive, and meaningful to a wide audience
3. [X] Description is objective, takes 5-10 lines, uses full sentences,
   and provides the information users need to decide whether the
   software fits their needs.

I also gave it a spin, and it works fine as long as the SSL_CERT_DIR
environment variable is defined (I think that's beyond the scope of this
package). LGTM.

Thanks for your work!

--
Sarah

[v4-0001-gnu-Add-python-veryprettytable.patch (text/x-patch, inline)]

From e468a5f5722a31ce9999ddba43a8de120521a938 Mon Sep 17 00:00:00 2001
Message-Id: <e468a5f5722a31ce9999ddba43a8de120521a938.1632277047.git.iskarian <at> mgsn.dev>
From: phodina <phodina <at> protonmail.com>
Date: Sat, 18 Sep 2021 12:44:21 +0000
Subject: [PATCH v4 1/2] gnu: Add python-veryprettytable.

* gnu/packages/python-xyz.scm (python-veryprettytable): New variable.
---
 gnu/packages/python-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4e2e719afc..b1f162d079 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1793,6 +1793,33 @@ helpers.")
     (properties `((python2-variant . ,(delay python2-humanfriendly))))
     (license license:expat)))
 
+(define-public python-veryprettytable
+  (package
+    (name "python-veryprettytable")
+    (version "0.8.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "veryprettytable" version))
+       (sha256
+        (base32
+         "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-colorama" ,python-colorama)
+       ("python-termcolor" ,python-termcolor)))
+    (home-page
+     "https://github.com/smeggingsmegger/VeryPrettyTable")
+    (synopsis
+     "Visually appealing ASCII table output format for Python")
+    (description
+     "VeryPrettyTable is a Python library for displaying tabular data in a
+visually appealing ASCII or HTML table.  Output is highly configurable,
+including text alignment, padding, borders, sort order, and more.  Data can be
+inserted directly, read from a CSV file, or imported using a Python DB-API
+database cursor such as @code{sqlite3}.")
+    (license license:bsd-3)))
+
 (define-public python2-humanfriendly
   (let ((base (package-with-python2
                 (strip-python2-variant python-humanfriendly))))

base-commit: a916d50566e77ae730e34f1753ceb78cc6bf0a5a
-- 
2.33.0

[v4-0002-gnu-Add-python-pirate-get.patch (text/x-patch, inline)]

From 5e99c1f791c990dd76cd63a9ab2a5196656c5c6f Mon Sep 17 00:00:00 2001
Message-Id: <5e99c1f791c990dd76cd63a9ab2a5196656c5c6f.1632277047.git.iskarian <at> mgsn.dev>
In-Reply-To: <e468a5f5722a31ce9999ddba43a8de120521a938.1632277047.git.iskarian <at> mgsn.dev>
References: <e468a5f5722a31ce9999ddba43a8de120521a938.1632277047.git.iskarian <at> mgsn.dev>
From: phodina <phodina <at> protonmail.com>
Date: Sat, 18 Sep 2021 12:45:04 +0000
Subject: [PATCH v4 2/2] gnu: Add python-pirate-get.

* gnu/packages/python-xyz.scm (python-pirate-get): New variable.
---
 gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index b1f162d079..86962e35b8 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1820,6 +1820,34 @@ inserted directly, read from a CSV file, or imported using a Python DB-API
 database cursor such as @code{sqlite3}.")
     (license license:bsd-3)))
 
+(define-public python-pirate-get
+  (package
+    (name "python-pirate-get")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pirate-get" version))
+       (sha256
+        (base32
+         "07s5ss9dxccx1mip7pyga1fagywkqchxmzz55ng47ac9053ffxkq"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-colorama" ,python-colorama)
+       ("python-pyperclip" ,python-pyperclip)
+       ("python-veryprettytable" ,python-veryprettytable)))
+    (home-page
+     "https://github.com/vikstrous/pirate-get")
+    (synopsis
+     "Command line interface for The Pirate Bay")
+    (description
+     "@code{pirate-get} is an unofficial command line interface for searching
+The Pirate Bay, inspired by @command{apt}.  Results can be saved as JSON,
+@code{.torrent} files, or magnet links, or they can be opened directly in
+@command{transmission-remote}.  @code{pirate-get} also supports searching
+mirrors or a local copy of The Pirate Bay's database.")
+    (license license:agpl3)))
+
 (define-public python2-humanfriendly
   (let ((base (package-with-python2
                 (strip-python2-variant python-humanfriendly))))
-- 
2.33.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.