Package: guix-patches;
Reported by: Alexandre Hannud Abdo <abdo <at> member.fsf.org>
Date: Sun, 18 Jul 2021 00:47:03 UTC
Severity: normal
Tags: patch
Done: Efraim Flashner <efraim <at> flashner.co.il>
Bug is archived. No further changes may be made.
View this message in rfc822 format
From: help-debbugs <at> gnu.org (GNU bug Tracking System) To: Efraim Flashner <efraim <at> flashner.co.il> Cc: tracker <at> debbugs.gnu.org Subject: bug#49614: closed ([PATCH] gnu: Add sequeler.) Date: Tue, 20 Jul 2021 09:04:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 20 Jul 2021 12:02:01 +0300 with message-id <YPaRCV0sBhH7rv58 <at> 3900XT> and subject line Re: [bug#49614] [PATCH] gnu: Add sequeler. has caused the debbugs.gnu.org bug report #49614, regarding [PATCH] gnu: Add sequeler. to be marked as done. (If you believe you have received this mail in error, please contact help-debbugs <at> gnu.org.) -- 49614: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49614 GNU Bug Tracking System Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Alexandre Hannud Abdo <abdo <at> member.fsf.org> To: guix-patches <guix-patches <at> gnu.org> Subject: [PATCH] gnu: Add sequeler. Date: Sun, 18 Jul 2021 02:46:50 +0200[Message part 3 (text/plain, inline)]* gnu/packages/databases.scm (sequeler): New variable. --- gnu/packages/databases.scm | 49 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 28832041ed..19c720a94a 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -52,6 +52,7 @@ ;;; Copyright © 2021 Pjotr Prins <pjotr.guix <at> thebird.nl> ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com> ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org> +;;; Copyright © 2021 Alexandre Hannud Abdo <abdo <at> member.fsf.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -78,6 +79,7 @@ #:use-module (gnu packages bash) #:use-module (gnu packages bison) #:use-module (gnu packages boost) + #:use-module (gnu packages build-tools) #:use-module (gnu packages check) #:use-module (gnu packages cmake) #:use-module (gnu packages compression) @@ -88,11 +90,14 @@ #:use-module (gnu packages dbm) #:use-module (gnu packages emacs) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) #:use-module (gnu packages glib) + #:use-module (gnu packages gnome) #:use-module (gnu packages gnupg) #:use-module (gnu packages golang) + #:use-module (gnu packages gtk) #:use-module (gnu packages guile) #:use-module (gnu packages icu4c) #:use-module (gnu packages jemalloc) @@ -109,6 +114,7 @@ #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) #:use-module (gnu packages onc-rpc) + #:use-module (gnu packages pantheon) #:use-module (gnu packages parallel) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -130,6 +136,7 @@ #:use-module (gnu packages ruby) #:use-module (gnu packages serialization) #:use-module (gnu packages sphinx) + #:use-module (gnu packages ssh) #:use-module (gnu packages sqlite) #:use-module (gnu packages tcl) #:use-module (gnu packages terminals) @@ -148,6 +155,7 @@ #:use-module (guix build-system emacs) #:use-module (guix build-system gnu) #:use-module (guix build-system go) + #:use-module (guix build-system meson) #:use-module (guix build-system perl) #:use-module (guix build-system python) #:use-module (guix build-system ruby) @@ -3983,3 +3991,44 @@ PostreSQL, SQLite, ODBC and MySQL.") "FreeTDS is an implementation of the Tabular DataStream protocol, used for connecting to MS SQL and Sybase servers over TCP/IP.") (license license:lgpl2.0+))) + +(define-public sequeler + (package + (name "sequeler") + (version "0.8.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Alecaddd/sequeler") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1q1vzc3likpiwfh6blkyiz0wr0aarj9xrm8gbi7m3p1wslkpah7c")))) + (build-system meson-build-system) + (native-inputs + `(("pkg-config" ,pkg-config) + ("meson" ,meson) + ("vala" ,vala) + ("desktop-file-utils" ,desktop-file-utils) + ;; ("appstream-glib" ,appstream-glib) ; validation fails for lack of network + ("glib:bin" ,glib "bin") ; for glib-compile-resources + ("gtk+" ,gtk+ "bin"))) + (inputs + `(("gtk+" ,gtk+) + ("granite" ,granite) + ("libgee" ,libgee) + ("glib" ,glib) + ("libxml2" ,libxml2) + ("libgda" ,libgda) + ("gtksourceview-3" ,gtksourceview-3) + ("libsecret" ,libsecret) + ("libssh2" ,libssh2) + ("gettext-minimal" ,gettext-minimal))) + (synopsis "Friendly SQL Client") + (description "Sequeler is a native Linux SQL client built in Vala and +Gtk. It allows you to connect to your local and remote databases, write SQL in +a handy text editor with language recognition, and visualize SELECT results in +a Gtk.Grid Widget.") + (home-page "https://github.com/Alecaddd/sequeler") + (license license:lgpl3+))) -- 2.32.0[OpenPGP_0x10508FA593B7BE6D.asc (application/pgp-keys, attachment)][OpenPGP_signature (application/pgp-signature, attachment)]
[Message part 6 (message/rfc822, inline)]
From: Efraim Flashner <efraim <at> flashner.co.il> To: Alexandre Hannud Abdo <abdo <at> member.fsf.org> Cc: 49614-done <at> debbugs.gnu.org Subject: Re: [bug#49614] [PATCH] gnu: Add sequeler. Date: Tue, 20 Jul 2021 12:02:01 +0300[Message part 7 (text/plain, inline)]Not using a GTK based desktop I was able to make some changes to make sure it ran smoothly. On Mon, Jul 19, 2021 at 02:47:03PM +0200, Alexandre Hannud Abdo wrote: > * gnu/packages/databases.scm (sequeler): New variable. > --- > gnu/packages/databases.scm | 49 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index 28832041ed..19c720a94a 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -52,6 +52,7 @@ > ;;; Copyright © 2021 Pjotr Prins <pjotr.guix <at> thebird.nl> > ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com> > ;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org> > +;;; Copyright © 2021 Alexandre Hannud Abdo <abdo <at> member.fsf.org> > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -78,6 +79,7 @@ > #:use-module (gnu packages bash) > #:use-module (gnu packages bison) > #:use-module (gnu packages boost) > + #:use-module (gnu packages build-tools) > #:use-module (gnu packages check) > #:use-module (gnu packages cmake) > #:use-module (gnu packages compression) > @@ -88,11 +90,14 @@ > #:use-module (gnu packages dbm) > #:use-module (gnu packages emacs) > #:use-module (gnu packages flex) > + #:use-module (gnu packages freedesktop) > #:use-module (gnu packages gcc) > #:use-module (gnu packages gettext) > #:use-module (gnu packages glib) > + #:use-module (gnu packages gnome) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages golang) > + #:use-module (gnu packages gtk) > #:use-module (gnu packages guile) > #:use-module (gnu packages icu4c) > #:use-module (gnu packages jemalloc) > @@ -109,6 +114,7 @@ > #:use-module (gnu packages multiprecision) > #:use-module (gnu packages ncurses) > #:use-module (gnu packages onc-rpc) > + #:use-module (gnu packages pantheon) > #:use-module (gnu packages parallel) > #:use-module (gnu packages pcre) > #:use-module (gnu packages perl) > @@ -130,6 +136,7 @@ > #:use-module (gnu packages ruby) > #:use-module (gnu packages serialization) > #:use-module (gnu packages sphinx) > + #:use-module (gnu packages ssh) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages tcl) > #:use-module (gnu packages terminals) > @@ -148,6 +155,7 @@ > #:use-module (guix build-system emacs) > #:use-module (guix build-system gnu) > #:use-module (guix build-system go) > + #:use-module (guix build-system meson) > #:use-module (guix build-system perl) > #:use-module (guix build-system python) > #:use-module (guix build-system ruby) > @@ -3983,3 +3991,44 @@ PostreSQL, SQLite, ODBC and MySQL.") > "FreeTDS is an implementation of the Tabular DataStream protocol, used for > connecting to MS SQL and Sybase servers over TCP/IP.") > (license license:lgpl2.0+))) > + > +(define-public sequeler > + (package > + (name "sequeler") > + (version "0.8.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Alecaddd/sequeler") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1q1vzc3likpiwfh6blkyiz0wr0aarj9xrm8gbi7m3p1wslkpah7c")))) > + (build-system meson-build-system) I added some boilerplate here to wrap the gtk variables and to not build the icon-cache since it's built at profile-creation time. > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("meson" ,meson) > + ("vala" ,vala) > + ("desktop-file-utils" ,desktop-file-utils) > + ;; ("appstream-glib" ,appstream-glib) ; validation fails for lack of network > + ("glib:bin" ,glib "bin") ; for glib-compile-resources > + ("gtk+" ,gtk+ "bin"))) meson isn't needed because it's included by default with the meson-build-system. I took out the desktop-file-utils since we weren't updating the desktop database. > + (inputs > + `(("gtk+" ,gtk+) > + ("granite" ,granite) > + ("libgee" ,libgee) > + ("glib" ,glib) > + ("libxml2" ,libxml2) > + ("libgda" ,libgda) > + ("gtksourceview-3" ,gtksourceview-3) > + ("libsecret" ,libsecret) > + ("libssh2" ,libssh2) > + ("gettext-minimal" ,gettext-minimal))) gettext-minimal I moved to native-inputs. I also added gsettings-desktop-schemas to inputs since it complained (at me) when I tried to run sequeler without including it. > + (synopsis "Friendly SQL Client") > + (description "Sequeler is a native Linux SQL client built in Vala and > +Gtk. It allows you to connect to your local and remote databases, write SQL in > +a handy text editor with language recognition, and visualize SELECT results in > +a Gtk.Grid Widget.") > + (home-page "https://github.com/Alecaddd/sequeler") > + (license license:lgpl3+))) Looking at the source code headers it looks like it's gpl2+, so I changed the license. > -- > 2.32.0 > Thanks for the patch! Pushed. -- Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted[signature.asc (application/pgp-signature, inline)]
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.