From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 20:34:14 2021 Received: (at submit) by debbugs.gnu.org; 17 Jul 2021 00:34:15 +0000 Received: from localhost ([127.0.0.1]:52581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4YHW-00030W-KY for submit@debbugs.gnu.org; Fri, 16 Jul 2021 20:34:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:50218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4YHS-00030N-P0 for submit@debbugs.gnu.org; Fri, 16 Jul 2021 20:34:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4YHQ-0006AS-L7 for guix-patches@gnu.org; Fri, 16 Jul 2021 20:34:09 -0400 Received: from mail-dm6nam12olkn20830.outbound.protection.outlook.com ([2a01:111:f400:fe59::830]:9889 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4YHO-0006l2-Q7 for guix-patches@gnu.org; Fri, 16 Jul 2021 20:34:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nbMkkwQivbLlXLxAZwupxjrrU8Y+YbjIM0v1uexXU7Pdi0TTEzRt8FyTL9dXp8aRiD6EhPLaUb1MhLQXfFoexSu4iQMduFOupoGrUVFB+EyNpqdI3/V9gw6A+5m730xqtiLB+3T9patxiWlKJhsL3AgEOPqqfasf5YL4MllUS5m4XRr9JoCf9wA/c9+Lvk6E3XQ8MsSfpqu6pjtZdUOdYlyYERO16IXvOQIjZTyoGX9D1qlHDuEufC2kW3DBVCpoDbNxw3qkeE7W5y1XDZck6shb1g9Xrx6RPVvQNEcfPn28/7PaymxuDLrLjrOLEEr+XLW0K5jzorRJV1ge0jwEpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Kv4Hcqug9VTWdKV8o15wDcNm6WaDm56/cf6FfoW4pY=; b=VbDLXtVME4+6mVc43N4qPP5GeyZBnXIfMoyLgRl1HpMOmQQvlxBfdD/8zW+JJT7mDxSXaa1Ncx+hDd8IH1TTfEYtpE+uQdE8XDGjIPk/xZQT8Bd2FtuZxSUSEqQmEbZRViGawzrh9Vt/5wY8P+0z0qfG1zOMD+2VXvjvHUGppYh8HYqWGoNKBBgoPzlZ4SR1D7FAGHeDtD7HYU+ta2a8vgSSoHWG6okFRXOGb19hmlKxiazCOJwvZLVorZM/4t3jwC/lXdNVD6/obiT3niY2F9YDqGvwR36d/Ey42FcAD20/JmlgQiWtdIbtc0wuw5qIDQL4NAeprSMTA/k0hJzJOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Kv4Hcqug9VTWdKV8o15wDcNm6WaDm56/cf6FfoW4pY=; b=op/w9pCMppvj6WpzSWx9LtXRdJ4izlj1iBGD+45y3CHpYf4BwQ36T4f7WVDmp8XjUZrLUY1CeteyHb0LNcvQMd82excn5yqKW8uuKXbAA27kzQCtkzitAOe2rsCsaf6Rt4GtOc3HiDH7Y094lLqaSGcnt/WU2A8OJBFWCdTEfqimXrvCGWgGAlsOZfxJKutkhx8frym4/E/u+17yjrGraC8g88BqgMNljq0FFJUgPLd+LZaUpTiUgfPVFMsDsn3IijrC/YG/HAOKRVSm2Xf7ZYZ2yvjNewPGVNF/YXHcHd85g/TFNm6pEg17t9W1qlEZ+msMKGzuGj4l+DAkOp6P5A== Received: from BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) by BYAPR05MB4439.namprd05.prod.outlook.com (2603:10b6:a02:f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.14; Sat, 17 Jul 2021 00:29:04 +0000 Received: from BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::a8fb:37d1:b1a7:6841]) by BYAPR05MB4023.namprd05.prod.outlook.com ([fe80::a8fb:37d1:b1a7:6841%5]) with mapi id 15.20.4352.013; Sat, 17 Jul 2021 00:29:04 +0000 From: Morgan.J.Smith@outlook.com To: guix-patches@gnu.org Subject: [PATCH] services: transmission: Create downloads directory. Date: Fri, 16 Jul 2021 20:28:31 -0400 Message-ID: X-Mailer: git-send-email 2.32.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-TMN: [a8dk/nhD/r+vi0eD688lWABo8TlOJH8r] X-ClientProxiedBy: YQXPR01CA0115.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:41::44) To BYAPR05MB4023.namprd05.prod.outlook.com (2603:10b6:a02:87::30) X-Microsoft-Original-Message-ID: <20210717002830.24790-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from workpad.hitronhub.home (170.52.80.188) by YQXPR01CA0115.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:41::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Sat, 17 Jul 2021 00:29:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eac60ff1-c696-4ed8-ef65-08d948b9e0cf X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UISu0KpCjC6bp3SOlRwUczU4BGBgghyrJ2VUeVTqfhGMu5zyzCrJwJQPL6zV6M4UOipguWNSqU8jt7b/NErHLOOaIKyGwGhRhqYduIC6rECIGC3ao5mCiXSvfSJoPnbBeX6ocTut5hLLSrPBxPlcZX7SGePyZSDSHp9hhS3nKZzEfhzf1JbeKXAZTD/XAaHOVYhhIi7XKmvEdHfsg1hz9wWGdS+kDJgUHbi7HCA2cbpw4RbCLCWMhK0nwXx592Kwa1g/yLnu0u3abyYHruyAU6rtq/9WMK2sopa2oxPGX9OEcRCauFQ35u5MYgGfS65yZmKqcJrIwR1IvO7gkslBahh2uriVDVQNnyTIgDzdxx4wE2fWL41p+ohBirvYCLMI5P3fzqgw9vAJYF+LHqtURIrZAgV8wDp0VsL40GToz4cEHZIBdPl5eXPrLRRdZW+9EBzLYc0HRq5isV16r18p1NijhCWfyUxlWavMfmyovBorgb5MMxVteA0uX/9RrXl6JFlvtZ/FhB6VdZWK95le++qCfAJgqVPB02I+DvAGJu1URdGnUwmTiEp+yFWUzkkKVwlKNH/GByrcF6RoIJVj917TBH6CufTu9qi5xEPYehDy7TnRHUg0nGyj/XYBpgJhsPMRzGZipCcVbaLaxxyOMb9DIcxtL/mMJAkI1djdI4E+HeI9kQMdnOEOB8urxNEfk28PU/AOyqhEQ== X-MS-TrafficTypeDiagnostic: BYAPR05MB4439: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d/0QA2jyNo4DMjiMayO8tMt34cuyzaQ9nc0ifQSOO0VVxAwuS68A7OjFDiR+l7xDgWKWiGaLsJ3downhnBItVRqJn5qpjXYLHrFU9ALXqFfoUcQjDrYRpFbpxOkHF7R1YPiJQOBw2W/L2ui5JFZhXBqaBCh+LhbbDaEaJ/xYM5AgiiRdTvr/+gB5Ztw8nswu3PwHHVmkT8ViQXLjCiUE3Ss8edmCfGK9uLzjHsETzjhAJdCr7Bi4KuCMWyJ/L3lCec4tmrQDv5LZDV2Gpw+DR0In5QOTpo9nReOS8zmq2NFOjfWduFaoMNnUkMRITf3QrOph0CXlc8HiQYhRRjk0jA5VdSS1zkqbSnHJbsq9Gc+8noEL2D+KQ7vEhlkn+m9SkFXAc46rElaoah/hU1FyMAich2LybPb0FFdVqbq9L1+tZFbxd91nhEg5wow3mOOy X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DLkCKCWVD9BWBMEBiQSXueX6Zulm7BfyjsQaPHlkb8Wzg8z6OCrUb7L3XU2DtmsG/oeACjmbFT/7K2QV87eEZ4AIDG4bh8W46a1hkekzkel1t5TsQeaXSZ3pMr3QZwFvzkHQgpRoBbqnQOoHBv85fw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eac60ff1-c696-4ed8-ef65-08d948b9e0cf X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB4023.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2021 00:29:03.3785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4439 Received-SPF: pass client-ip=2a01:111:f400:fe59::830; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: submit Cc: Morgan Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * gnu/services/file-sharing.scm (transmission-daemon-activation): Create downloads directory. This fixes a bug where transmission doesn't have permission to create it's download directory. This bug occurs when download-dir is configured to a location where the transmission user doesn't have permission to create a directory. --- gnu/services/file-sharing.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/services/file-sharing.scm b/gnu/services/file-sharing.scm index 72cd6478d6..143fd3ed75 100644 --- a/gnu/services/file-sharing.scm +++ b/gnu/services/file-sharing.scm @@ -746,6 +746,7 @@ produces a Transmission settings file (@file{settings.json}) matching CONFIG." (define (transmission-daemon-activation config) "Return the Transmission Daemon activation GEXP for CONFIG." (let ((config-dir %transmission-daemon-configuration-directory) + (download-dir (transmission-daemon-configuration-download-dir config)) (incomplete-dir-enabled (transmission-daemon-configuration-incomplete-dir-enabled? config)) (incomplete-dir @@ -769,7 +770,8 @@ produces a Transmission settings file (@file{settings.json}) matching CONFIG." (for-each (lambda (directory-specification) (apply mkdir-p/perms directory-specification)) '(#$@(append - `((,config-dir #o750)) + `((,config-dir #o750) + (,download-dir #o755)) (if incomplete-dir-enabled `((,incomplete-dir #o750)) '()) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 17 07:53:09 2021 Received: (at 49601) by debbugs.gnu.org; 17 Jul 2021 11:53:09 +0000 Received: from localhost ([127.0.0.1]:52908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4isX-0004U9-HY for submit@debbugs.gnu.org; Sat, 17 Jul 2021 07:53:09 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:36478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4isV-0004Tb-3I for 49601@debbugs.gnu.org; Sat, 17 Jul 2021 07:53:08 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id C8CDDA05B8; Sat, 17 Jul 2021 11:53:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EQdWE-mB-vZB; Sat, 17 Jul 2021 11:53:00 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 116CBA0193; Sat, 17 Jul 2021 11:52:58 +0000 (UTC) From: Simon South To: Morgan.J.Smith@outlook.com Subject: Re: [bug#49601] [PATCH] services: transmission: Create downloads directory. References: Date: Sat, 17 Jul 2021 07:52:21 -0400 In-Reply-To: (Morgan J. Smith's message of "Fri, 16 Jul 2021 20:28:31 -0400") Message-ID: <87y2a5gnt6.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49601 Cc: 49601@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Morgan.J.Smith@outlook.com writes: > This fixes a bug where transmission doesn't have permission to create > it's download directory. This bug occurs when download-dir is > configured to a location where the transmission user doesn't have > permission to create a directory. Morgan, I recall originally having the service activation create the downloads directory, as your change makes it do, but then removing this as there was some common case where it made service activation fail. Unfortunately, I've forgotten what that was. Let me see if I can duplicate that and if so, perhaps we can find a solution that will handle both cases. At any rate: > + (,download-dir #o755)) The folder permissions should be #o750, not #o755. The reasoning here is that it ought to be possible to place limits on who can see and access files being shared by other users. -- Simon South simon@simonsouth.net From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 17 13:47:47 2021 Received: (at 49601) by debbugs.gnu.org; 17 Jul 2021 17:47:47 +0000 Received: from localhost ([127.0.0.1]:54611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4oPj-0001Bl-EV for submit@debbugs.gnu.org; Sat, 17 Jul 2021 13:47:47 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:43236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4oPh-0001BW-Bv for 49601@debbugs.gnu.org; Sat, 17 Jul 2021 13:47:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 35D92A41DF; Sat, 17 Jul 2021 17:47:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo05-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo05-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dPL-wB33ER91; Sat, 17 Jul 2021 17:47:38 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id B88E89FF68; Sat, 17 Jul 2021 17:47:36 +0000 (UTC) From: Simon South To: Morgan.J.Smith@outlook.com Subject: Re: [bug#49601] [PATCH] services: transmission: Create downloads directory. References: <87y2a5gnt6.fsf@simonsouth.net> Date: Sat, 17 Jul 2021 13:47:07 -0400 In-Reply-To: <87y2a5gnt6.fsf@simonsouth.net> (Simon South's message of "Sat, 17 Jul 2021 07:52:21 -0400") Message-ID: <87v958g7dw.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49601 Cc: 49601@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon South writes: > Let me see if I can duplicate that... I haven't been able to duplicate whatever issue it was I saw originally. Likely it had to do with the download directory being placed on a separate volume and thus matching a mount point already declared in the operating-system declaration. Probably the system test should be expanded to check this kind of configuration works but a quick test on my end shows that at least for existing setups, it is not a problem. Morgan, just a few pieces of feedback then: > This fixes a bug where transmission doesn't have permission to create > it's download directory. This bug occurs when download-dir is "it's" should be "its" (no apostrophe) here, the possessive form. > + (,download-dir #o755)) Again, the permissions here should be "#o750". Finally, I recommend updating the system test (in gnu/tests/file-sharing.scm) to verify the download directory is created correctly, now that this functionality has been added. I've included a patch below that does this for you. To verify this works, apply the patch and run the test suite with make check-system TESTS="transmission-daemon" The Guix manual has more information[0]. Otherwise, looks good to me. Thanks for submitting this patch. [0] https://guix.gnu.org/en/manual/en/html_node/Running-the-Test-Suite.html -- Simon South simon@simonsouth.net diff --git a/gnu/tests/file-sharing.scm b/gnu/tests/file-sharing.scm index 9a8ee6a593..d27a206c4f 100644 --- a/gnu/tests/file-sharing.scm +++ b/gnu/tests/file-sharing.scm @@ -34,6 +34,8 @@ (define %transmission-daemon-group "transmission") (define %transmission-daemon-config-dir "/var/lib/transmission-daemon") +(define %transmission-daemon-download-dir + (string-append %transmission-daemon-config-dir "/downloads")) (define %transmission-daemon-watch-dir (string-append %transmission-daemon-config-dir "/watch")) (define %transmission-daemon-incomplete-dir @@ -110,8 +112,9 @@ #t) marionette)) - ;; Make sure Transmission Daemon's configuration directory has been - ;; created with the correct ownership and permissions. + ;; Make sure Transmission Daemon's configuration and download + ;; directories have been created with the correct ownership and + ;; permissions. (test-assert "configuration directory exists" (marionette-eval '(eq? (stat:type (stat #$%transmission-daemon-config-dir)) @@ -132,6 +135,26 @@ #o750) marionette)) + (test-assert "download directory exists" + (marionette-eval + '(eq? (stat:type (stat #$%transmission-daemon-download-dir)) + 'directory) + marionette)) + (test-assert "download directory has correct ownership" + (marionette-eval + '(let ((download-dir (stat #$%transmission-daemon-download-dir)) + (transmission-user (getpwnam #$%transmission-daemon-user))) + (and (eqv? (stat:uid download-dir) + (passwd:uid transmission-user)) + (eqv? (stat:gid download-dir) + (passwd:gid transmission-user)))) + marionette)) + (test-assert "download directory has expected permissions" + (marionette-eval + '(eqv? (stat:perms (stat #$%transmission-daemon-download-dir)) + #o750) + marionette)) + ;; Make sure the incomplete-downloads and watch directories have been ;; created with the correct ownership and permissions. (test-assert "incomplete-downloads directory exists" From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 08:14:25 2021 Received: (at 49601) by debbugs.gnu.org; 19 Jul 2021 12:14:25 +0000 Received: from localhost ([127.0.0.1]:58238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5SAD-0001Qz-Fp for submit@debbugs.gnu.org; Mon, 19 Jul 2021 08:14:25 -0400 Received: from flashner.co.il ([178.62.234.194]:38314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5SA9-0001Qh-1G for 49601@debbugs.gnu.org; Mon, 19 Jul 2021 08:14:24 -0400 Received: from localhost (unknown [31.210.177.125]) by flashner.co.il (Postfix) with ESMTPSA id 4356B40041; Mon, 19 Jul 2021 12:14:15 +0000 (UTC) Date: Mon, 19 Jul 2021 15:13:04 +0300 From: Efraim Flashner To: Simon South Subject: Re: [bug#49601] [PATCH] services: transmission: Create downloads directory. Message-ID: Mail-Followup-To: Efraim Flashner , Simon South , Morgan.J.Smith@outlook.com, 49601@debbugs.gnu.org References: <87y2a5gnt6.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e4reVeQoChYaVqsn" Content-Disposition: inline In-Reply-To: <87y2a5gnt6.fsf@simonsouth.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49601 Cc: Morgan.J.Smith@outlook.com, 49601@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --e4reVeQoChYaVqsn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 17, 2021 at 07:52:21AM -0400, Simon South wrote: > Morgan.J.Smith@outlook.com writes: > > This fixes a bug where transmission doesn't have permission to create > > it's download directory. This bug occurs when download-dir is > > configured to a location where the transmission user doesn't have > > permission to create a directory. >=20 > Morgan, >=20 > I recall originally having the service activation create the downloads > directory, as your change makes it do, but then removing this as there > was some common case where it made service activation fail. > Unfortunately, I've forgotten what that was. >=20 > Let me see if I can duplicate that and if so, perhaps we can find a > solution that will handle both cases. At any rate: >=20 > > + (,download-dir #o755)) >=20 > The folder permissions should be #o750, not #o755. The reasoning here is > that it ought to be possible to place limits on who can see and access > files being shared by other users. >=20 It's possible it was mkdir vs mkdir-p (ins)scheme@(guile-user)> (mkdir "tmp") (ins)scheme@(guile-user)> (mkdir "tmp") ice-9/boot-9.scm:1685:16: In procedure raise-exception: In procedure mkdir: File exists Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. (ins)scheme@(guile-user) [1]> ,q (ins)scheme@(guile-user)> (use-modules (guix build utils)) (ins)scheme@(guile-user)> (mkdir-p "tmp") $1 =3D #t --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --e4reVeQoChYaVqsn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmD1bFAACgkQQarn3Mo9 g1ESIxAAvwXa1H0F+0oxG1qsXm7kCX462HoHCg1g83WGn0K86wPgtUxZ4XK6f7GN hxSYOdepLf40sIv7Q4CoeJa70B5BeNAnEqb+0IPgcnK1qwbYWXmUHSiRfkFdOEU/ 1XG9Wjx7a5n8syas7kyaq6R/3AEA6buXCqdiGttH10nMsgb/V/Bl1r3tMTBbcxvD X/M3lRm4EdvUTH3y7rh7TE1SJLNQ9g1Fh5LvnFCpBRh5ZZKtKYC+DBV0kMvZ9sBA Ye2oDzSvAQp0AjfgikiLUlKeaFcqBYU4JL/FZLa756YU6qHIDgGdiWMpTzD1ez7o MwYyIV8I52gVyicHKNq6z9Zg0mUpe2cOqPMA/KnUD+Um1/uThiTPuFOK6xElxpee LHcPlrmZCe3bN5FeY6NOJfrKqL5/I/1Qj0yAeXR4VpHkxS4KdpM3t90WZmU65NNk qTaqNpHbTK0Xexg0dWoQL3N4h6iCU29unmGBd6VqwOw5qrgAXa5AK/UYbhw7zEMG XMUhkX13/a+obCeJGGF1g4+ySiNrfP4zXPoYAy3u4sDMOpTBj8eboosc8rM6WLHE oiG0Rek3yI0I3/B3kViXdLos28ureyXmqovZ146sYnc/og4gOnhOYG+GkbQSV7s8 ZnvqviC9hjYPd/a7Y45fPBlfIicXmIdDWYFkrsAyjNYEEZvAAuU= =SBKO -----END PGP SIGNATURE----- --e4reVeQoChYaVqsn-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 21 09:14:54 2021 Received: (at 49601) by debbugs.gnu.org; 21 Jul 2021 13:14:54 +0000 Received: from localhost ([127.0.0.1]:36484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6C3p-0000AW-TC for submit@debbugs.gnu.org; Wed, 21 Jul 2021 09:14:54 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:33862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6C3m-0000AG-Tw for 49601@debbugs.gnu.org; Wed, 21 Jul 2021 09:14:52 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 45B17C0966; Wed, 21 Jul 2021 13:14:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo04-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo04-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OIhYgrjuWBGo; Wed, 21 Jul 2021 13:14:44 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 4B734C0934; Wed, 21 Jul 2021 13:14:40 +0000 (UTC) From: Simon South To: Efraim Flashner Subject: Re: [bug#49601] [PATCH] services: transmission: Create downloads directory. References: <87y2a5gnt6.fsf@simonsouth.net> Date: Wed, 21 Jul 2021 09:14:26 -0400 In-Reply-To: (Efraim Flashner's message of "Mon, 19 Jul 2021 15:13:04 +0300") Message-ID: <87r1frajwt.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49601 Cc: Morgan.J.Smith@outlook.com, 49601@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Efraim Flashner writes: > It's possible it was mkdir vs mkdir-p Yes, or perhaps I hadn't yet added the code that sets the ownership and permissions on the directory. Morgan, I hope you'll submit a revised patch so others can review. -- Simon South simon@simonsouth.net