GNU bug report logs - #49597
[PATCH core-updates 00/15] Ajust packages to label-less input style

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, 49597 <at> debbugs.gnu.org
Subject: [bug#49597] [PATCH core-updates 14/15] gnu: Use 'search-input-file' when looking for .jar files.
Date: Sun, 18 Jul 2021 17:56:11 +0200

[Message part 1 (text/plain, inline)]

> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index fdfd044926..f4a426e559 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -382,8 +382,7 @@ JNI.")
>               (setenv "JAVAC"
>                       (search-input-file inputs "/bin/jikes"))
>               (setenv "CLASSPATH"
> -                     (string-append (assoc-ref inputs "jamvm")
> -                                    "/lib/rt.jar"))
> +                     (search-input-file inputs "/lib/rt.jar"))
>  
>               ;; Ant complains if this file doesn't exist.
>               (setenv "HOME" "/tmp")

This is "ant-bootstrap", right?
"jikes" and "jamvm" are in 'native-inputs',
so 'search-input-file (or native-inputs inputs) [...]' is required
here.

> @@ -486,8 +485,7 @@ build process and its dependencies, whereas Make uses Makefile format.")
>             (lambda* (#:key inputs #:allow-other-keys)
>               (setenv "CLASSPATH"
>                       (string-join
> -                      (cons (string-append (assoc-ref inputs "jamvm")
> -                                           "/lib/rt.jar")
> +                      (cons (search-input-file inputs "/lib/rt.jar")
>                              (find-files (string-append
>                                           (assoc-ref inputs "ant-bootstrap")
>                                           "/lib")

Likewise.

That issue was present in the original code, though,
but something to consider.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.