GNU bug report logs - #49591
[PATCH] import: go: Handle multiple go-import meta tags.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sarah Morgensen via Guix-patches via <guix-patches <at> gnu.org>
Cc: Sarah Morgensen <iskarian <at> mgsn.dev>, 49591-done <at> debbugs.gnu.org
Subject: Re: [bug#49591] [PATCH] import: go: Handle multiple go-import meta
 tags.
Date: Sat, 17 Jul 2021 23:31:31 -0400

Hello again,

Sarah Morgensen via Guix-patches via <guix-patches <at> gnu.org> writes:

> * guix/import/go.scm (fetch-module-meta-data): Parse all go-import meta
> tags and return the first 'module-meta' with a matching import prefix.
> [go-import->module-meta]: Extract parsing into new procedure.
> ---
> Hello Guix,
>
> It seems sometimes a module's go-get page contains multiple
>
>   <meta name="go-import" ...>
>
> tags, for example the 'bazil.org/fuse' module. This causes a backtrace when
> attempting to import such a module:
>
> $ guix import go bazil.org/fuse
> following redirection to `https://bazil.org/fuse/?go-get=1'...
> Backtrace:
>            5 (primitive-load "/home/sarah/.config/guix/current/bin/g…")
> In guix/ui.scm:
>    2182:7  4 (run-guix . _)
>   2145:10  3 (run-guix-command _ . _)
> In guix/scripts/import.scm:
>    120:11  2 (guix-import . _)
> In guix/scripts/import/go.scm:
>    118:27  1 (guix-import-go . _)
> In guix/import/go.scm:
>     467:4  0 (go-module->guix-package _ #:goproxy _ #:version _ # _)
>
> guix/import/go.scm:467:4: In procedure go-module->guix-package:
> Throw to key `match-error' with args `("match" "no matching pattern" ((content "bazil.org/bazil git https://github.com/bazil/bazil") (content "bazil.org/fuse git https://github.com/bazil/fuse") (content "bazil.org/bolt-mount git https://github.com/bazil/bolt-mount") (content "bazil.org/zipfs git https://github.com/bazil/zipfs") (content "bazil.org/plop git https://github.com/bazil/plop")))'.
>
>
> This patch makes the importer parse all such tags and search for one with an
> import prefix that is a prefix of the module-path we are looking for.

Good catch, LGTM!

> (I attempted to add a unit test but could not figure out how to make the
> record type accessible to the test script.)

I started adding a new fixture for fixtures-go-bazil-org-fuse-test, but
but I'm rusty as to where all these bits are pulled from.  Perhaps it
could be nice to add it, but otherwise it seems better in the mean time
to fix apply this fix as-is.

Committed with 5eba9c0960.

Thank you!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.