Subject: Re: bug#49582: [PATCH] gnu: Add tosdr-chromium.

From: Sarah Morgensen <[email-masked]>
Date: Sat, 24 Jul 2021 18:24:45 -0700

Hi,

Apologies, I didn't see this patch when I sent my previous reply.

This patch applies and builds, but the bulk of my previous suggestions
remain.

Justin Veilleux <[email-masked]> writes:

> this patch adds the tos;dr initiative's extension
>
> From c6881b9b065cf2a85b604c8a1e5ddbae77822034 Mon Sep 17 00:00:00 2001
> From: terramorpha <[email-masked]>
> Date: Thu, 15 Jul 2021 14:03:19 -0400
> Subject: [PATCH] gnu: Add tosdr-chromium.
>
> * gnu/packages/browser-extensions.scm (tosdr, tosdr-chromium): New variables.
> ---
>  gnu/packages/browser-extensions.scm | 50 ++++++++++++++++++++++++++++-
>  1 file changed, 49 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/browser-extensions.scm b/gnu/packages/browser-extensions.scm
> index a6120baf96..7a1a5bda69 100644
> --- a/gnu/packages/browser-extensions.scm
> +++ b/gnu/packages/browser-extensions.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2020, 2021 Marius Bakke <[email-masked]>
> +;;; Copyright © 2021 Justin Veilleux <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -21,10 +22,14 @@
>    #:use-module (guix git-download)
>    #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system trivial)
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (gnu build chromium-extension)
>    #:use-module (gnu packages compression)
> -  #:use-module (gnu packages python))
> +  #:use-module (gnu packages python)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages bash)
> +  #:use-module (gnu packages node))
>  
>  (define play-to-kodi
>    (package
> @@ -121,3 +126,46 @@ ungoogled-chromium.")
>  
>  (define-public ublock-origin/chromium
>    (make-chromium-extension ublock-origin "chromium"))
> +
> +(define tosdr
> +  (package
> +    (name "tosdr")
> +    (version "4.1.1")
> +    (source
> +     (origin
> +       (uri
> +        (git-reference
> +         (url "https://github.com/tosdr/browser-extensions.git")
> +         (commit version)))
> +       (sha256
> +        (base32 "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0"))
> +       (method git-fetch)))
> +    (inputs
> +     `(("bash" ,bash)
> +       ("coreutils" ,coreutils)
> +       ("node" ,node)
> +       ("zip" ,zip)
> +       ("unzip" ,unzip)))
> +    (arguments
> +     `(#:builder
> +       (begin
> +         (use-modules (guix build utils))
> +         (set-path-environment-variable "PATH"
> +					'("bin")
> +					(map cdr %build-inputs))

Also, these should be spaces, not tabs.

> +         (copy-recursively (assoc-ref %build-inputs "source") ".")
> +         (invoke "sh" "./build.sh")
> +         (invoke "unzip" "dist/chrome.zip" "-d" %output)
> +         #t)
> +       #:modules ((guix build utils))))
> +    (build-system trivial-build-system)
> +    (synopsis "extension to inform of the important aspects of the terms and
> +conditions of a web service")
> +    (description "This extension informs you instantly of your rights online by
> +showing an unintrusive icon in the toolbar. You can click on this icon to get
> +summaries from the Terms of Service; Didn't Read initiative.")
> +    (license license:agpl3)
> +    (home-page "https://tosdr.org/")))
> +
> +(define-public tosdr-chromium
> +  (make-chromium-extension tosdr))

--
Sarah