GNU bug report logs - #49574
28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49574 in the body.
You can then email your comments to 49574 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Thu, 15 Jul 2021 17:39:52 +0300

[Message part 1 (text/plain, inline)]

Hello everyone,

Following the release of version 1.5.0 of the modus-themes (bug#49572),
I believe this is the right time to remove the long-discontinued
packages 'modus-operandi-theme' and 'modus-vivendi-theme'.

The technicalities were discussed in bug#46964, with the gist being that
we would provide users a few months to migrate to the new 'modus-themes'
package.  We had also introduced code in the old packages that would
pull in the new package, so we can assume that the old packages are no
longer required.

The change I would like to install is attached.

Thank you!
Protesilaos


-- 
Protesilaos Stavrou
https://protesilaos.com

[0001-Remove-deprecated-modus-operandi-vivendi-themes.patch (text/x-patch, attachment)]

Message #8 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Fri, 16 Jul 2021 12:12:07 +0200

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> Following the release of version 1.5.0 of the modus-themes (bug#49572),
> I believe this is the right time to remove the long-discontinued
> packages 'modus-operandi-theme' and 'modus-vivendi-theme'.
>
> The technicalities were discussed in bug#46964, with the gist being that
> we would provide users a few months to migrate to the new 'modus-themes'
> package.  We had also introduced code in the old packages that would
> pull in the new package, so we can assume that the old packages are no
> longer required.
>
> The change I would like to install is attached.

The deprecated themes were also new in Emacs 28, so I think removing
them (since they've been replaced by a new theme) should be fine.

Eli, do you have an opinion here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Fri, 16 Jul 2021 13:15:21 +0300

On 2021-07-16, 12:12 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> Following the release of version 1.5.0 of the modus-themes (bug#49572),
>> I believe this is the right time to remove the long-discontinued
>> packages 'modus-operandi-theme' and 'modus-vivendi-theme'.
>>
>> The technicalities were discussed in bug#46964, with the gist being that
>> we would provide users a few months to migrate to the new 'modus-themes'
>> package.  We had also introduced code in the old packages that would
>> pull in the new package, so we can assume that the old packages are no
>> longer required.
>>
>> The change I would like to install is attached.
>
> The deprecated themes were also new in Emacs 28, so I think removing
> them (since they've been replaced by a new theme) should be fine.
>
> Eli, do you have an opinion here?

Just to add here that the current files in emacs.git are automatically
synced into the 'modus-themes' GNU ELPA package.  Whereas the old
packages were pulled from dedicated branches on my own git repo.

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #14 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49574 <at> debbugs.gnu.org, info <at> protesilaos.com
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Fri, 16 Jul 2021 14:35:33 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
> Date: Fri, 16 Jul 2021 12:12:07 +0200
> 
> > The technicalities were discussed in bug#46964, with the gist being that
> > we would provide users a few months to migrate to the new 'modus-themes'
> > package.  We had also introduced code in the old packages that would
> > pull in the new package, so we can assume that the old packages are no
> > longer required.
> >
> > The change I would like to install is attached.
> 
> The deprecated themes were also new in Emacs 28, so I think removing
> them (since they've been replaced by a new theme) should be fine.
> 
> Eli, do you have an opinion here?

No.  Please do what you feel is right here.

Message #17 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49574 <at> debbugs.gnu.org, info <at> protesilaos.com
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Fri, 16 Jul 2021 13:57:13 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> The deprecated themes were also new in Emacs 28, so I think removing
>> them (since they've been replaced by a new theme) should be fine.
>> 
>> Eli, do you have an opinion here?
>
> No.  Please do what you feel is right here.

OK, Protesilaos, go ahead and push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 49574 <at> debbugs.gnu.org
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Fri, 16 Jul 2021 15:06:17 +0300

On 2021-07-16, 13:57 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> The deprecated themes were also new in Emacs 28, so I think removing
>>> them (since they've been replaced by a new theme) should be fine.
>>> 
>>> Eli, do you have an opinion here?
>>
>> No.  Please do what you feel is right here.
>
> OK, Protesilaos, go ahead and push.

Done.  Thank you for your time!

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #23 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Mon, 19 Jul 2021 17:39:05 +0200

Protesilaos Stavrou <info <at> protesilaos.com> writes:

>> OK, Protesilaos, go ahead and push.
>
> Done.  Thank you for your time!

Did you forget to push this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #26 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Mon, 19 Jul 2021 18:50:33 +0300

On 2021-07-19, 17:39 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>>> OK, Protesilaos, go ahead and push.
>>
>> Done.  Thank you for your time!
>
> Did you forget to push this?

I did.  Here it is:
<https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=b438674100fab7fa7f7424cd6f185e002597c0cb>.

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #31 received at 49574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 49574 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated
 modus-{operandi,vivendi}-themes
Date: Mon, 19 Jul 2021 17:56:37 +0200

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> I did.  Here it is:
> <https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=b438674100fab7fa7f7424cd6f185e002597c0cb>.

Sorry; I looked in the wrong place.  :-/

I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.