From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 11:30:13 2021 Received: (at submit) by debbugs.gnu.org; 11 Jul 2021 15:30:13 +0000 Received: from localhost ([127.0.0.1]:35744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2bPI-0004Vg-Rg for submit@debbugs.gnu.org; Sun, 11 Jul 2021 11:30:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:50742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2bPF-0004VR-58 for submit@debbugs.gnu.org; Sun, 11 Jul 2021 11:30:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2bPE-0004T8-NT for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 11:30:08 -0400 Received: from mail-bn8nam12on2070e.outbound.protection.outlook.com ([2a01:111:f400:fe5b::70e]:27393 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2bPC-0006Ny-FG for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 11:30:08 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GTyP6UY/8znXBYZiPunALCR8i1KtWtE6gIzVsQOIOm54fvjlPgl0ejhjuSKOOYVqveIL7M4beKf1LscrJmxDyYizfr7Gnez/AwgMEW6BuBJrMcZarL4m3EfVOJliZ2y+eH74m5AqTqLV3TMen8x4yqryl42qUuvy7Y5bd4KddKHT7om48uX7LiijxTRX1MhNQtGGOB08Gr8MVDEXRrYYlKcQWdUsqpwf+uC2FWZHZqKrxzcHv2Wwxnosqif8RWWMuuXUD7N0oe4airX0+XD+1KfQRhdiCkJvvMDAwqaJoLtGgePG6U3DM1nXlbuS/OerZ9e4taO4pRt3x442Ew4/uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4qhEESL6fjCUcTBARTvx1ZTMIqQXN+VjNRlesv7VzW8=; b=IONvNHzk4Aj8IcvWdaujlwYeH+5HEwynb3dzUc5aRkNyfPuiVANaCLhHpoiNxD4/wwJCotlBb6TwqG5bkeNeTGt1necKDqBgoscE0J2NWc+bNM+e2yF+8SCI7GprXGIVhylu2XS1xu/d3RjJRTXb1yYitJ+KyJx9SkHeiQAgJ+ZGMKim3TPIpxktRje6EL4CGZL4fjM2ysvTnqV5wQ/Km89PagE52cIqKokFVCtP+b4PhMQfrJ4Hdql1yFT9LHvSKf7eaiU/dSgzN2M5xnpmbGzwAsY5Lo5scLtJH2sif7eLs7tXY0sqOVGONPWouXZpTG2APYgepdDdLdR1QPAK/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4qhEESL6fjCUcTBARTvx1ZTMIqQXN+VjNRlesv7VzW8=; b=je+aB7R2oqrFEvbqKEaXYkWwdH6ZiFY4T6L26vfSwdibwXvyFEJk9OIB6i1PZQD0J94xhUCToBmF6hQEBLGofOo4UjRYp4D4hY9ztYUJ9W7Y0ShZUtAkIKzkh1OCcQBgFkivaxV5T5Cg1I3+bM94jbLIZVx2lt/sMGZqXx5D1tk= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN3PR04MB2322.namprd04.prod.outlook.com (2a01:111:e400:7bb9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Sun, 11 Jul 2021 15:25:01 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42%7]) with mapi id 15.20.4308.021; Sun, 11 Jul 2021 15:25:00 +0000 To: bug-gnu-emacs@gnu.org Subject: 28.0.50; make-serial-process is not portable From: Ken Brown Message-ID: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> Date: Sun, 11 Jul 2021 11:24:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL0PR02CA0084.namprd02.prod.outlook.com (2603:10b6:208:51::25) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.18] (24.194.34.31) by BL0PR02CA0084.namprd02.prod.outlook.com (2603:10b6:208:51::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Sun, 11 Jul 2021 15:25:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd88d769-19c7-4e54-5c5a-08d944800c9a X-MS-TrafficTypeDiagnostic: BN3PR04MB2322: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RQ8aTLWHw0nCAMy70fmKwcm9ooBwrG9eb9mZa38o2GhKeLJD5HZLJ/6WX55VRJY6fiKH2R9KsNmfRa5S/8KqFse2x5s+GTHnam7ta0lpEdyPjStsYTnR6KhpvaOdRMbYI+jA/t4lTKygJM9NXCkM7+xi0vC3EgDbZjmD5buD9Oj+fJ9SOu8D5KOQ+lAYE3FfaJe2yjIFuJRish5c9TZJNeR3ANIt91Xl+y6XsL/GPg6MdL3cGNjNI25iwqaag+LdA0ANgB5EXfjDIleGML+jktvRTHwVYQFfEjA+JeD10sEuuJAkoGCtJTmAmaLyLcQVRVHf6nC8vI8G92DDPwNHn+2hLujIo/63Pj1DMC14fDRThwg4qHTdnaWjoeVYfY1tBmDum2Ttofb4HGReYD1uPKeC6RFuaMO2osG5JAc2IT3c/6xEk+8MixGX9OrbNPXc8guonJHKDX1iePq5UzwrKd+bj9gpnbEymrXs/lVNSX1VrJAGJ2HgeoIKpEwX+JS9TxjgXq5CiRArLJ5LUhTuWpMbztI9tmZ6PPmgiwb2c+Dcs74P7QJl8QNR5Wt4WUE8Ysmkq3tG4K1tZyGsMaR55cvwR8N73c3PTtimtHqmwEwpvrgwdCdSWRWgo/JOYa4FZF4K0lG9isSGMlMCvr+DoovQ7SF36ls7ZotJTRWAGrbjitgYa68vV861ArWeaHXqrY28UGl6c442FwWQ0b5M5BZpCeQJnP2UWpL1StpOR3j7VFB21QvdYr6vJr4jqk7fyXyUUU35Ef/ql+OJSzqoNimuchuH2tWuIHCwpysQbOhz2xcYO2hGg6UaAlmqARTF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(66556008)(2616005)(6916009)(16576012)(956004)(316002)(786003)(26005)(86362001)(8676002)(75432002)(66946007)(36756003)(38100700002)(66476007)(2906002)(478600001)(83380400001)(6486002)(31686004)(966005)(8936002)(31696002)(186003)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?3isUW1t1fTlqBOD1gwwHnbUJNqhEwDcEAHGbDIZIodRvb7ejEZwkOU76?= =?Windows-1252?Q?qntFkMekuUPDN6yb2shNH6mGcoHPie2fNWMIHS0T418DdSd4sjaH7790?= =?Windows-1252?Q?3fNsebHVGlQL2JSpE+j4kBnAeJtWtuk/RUbtWHFpTgh0m79CwYclO/BE?= =?Windows-1252?Q?LB5obmyCr83Dda/TsPVDz4f3kEyCj49nHi4unsK+xCWWMlrSLxvmh281?= =?Windows-1252?Q?3Fp6+6KR2PHyR3uvgpMsHn0at8Z5S9fLZIDQePzzSkWEMtkmq4+iTkP4?= =?Windows-1252?Q?lDrwTwi8DfoF6n59snA5s1/5mwquBiA/0EVyFATlj4hwoK69YEDdtWo/?= =?Windows-1252?Q?SUm2AgJG+WFXuOPLkpwBhtMRo/1HkGY8KulJ73zCl4Ungv1sO1Bg8x/3?= =?Windows-1252?Q?M5ffKv62byDGtk/kllpV3zxBF3P4rm/W22M3Phu67x6DoDrA2y9qRl/K?= =?Windows-1252?Q?eVoom877hp2ty4VSvNPwLRUHniJbl2fuFkD01tjJzt6D9Vl9ZY+6KUYa?= =?Windows-1252?Q?7vu4LLe5Ktsl912LkTQdYuaOiZREQ+KdIriSZb8JRWTqrDn/eIh1lc8B?= =?Windows-1252?Q?36Ks0I6d24U4mbQ+Gwi1Lw/1CTHqf94O4YUcFI8s1DGd8JMC39auWLqR?= =?Windows-1252?Q?TiCw9GwnX7a4ZIHDhvUxqPFodEVcRWG2Rm9pdQgbfmxCA/j27GGrGtPs?= =?Windows-1252?Q?heAXLAg4nWZ4jsY9gCa7WDC2BJNwoULqtyo2VPfofvkDDjwPjBOgtaAI?= =?Windows-1252?Q?UMYzwjuFx0kWSq3lICIxOq96TdvW9HSC1iUKpixq/vnFyCB2+6sxQ+mi?= =?Windows-1252?Q?BQansRpe1ivcxZNrM0Z8S8fsMb83R/gpJHtuL7/wQ2bKdTmTKbBNWSmK?= =?Windows-1252?Q?tIf12UuIktbzy93zjRhuKggSNXFaUYpEqfXPkkVTJ/9IYBSkqv2EscgD?= =?Windows-1252?Q?HRtiP92r1WKx5DVj/oeUK/jHRYiCmK5JEbCulr6dSdhXeQhiD8Bl/TaV?= =?Windows-1252?Q?JYQ1UwkmgXkGw+ACMNMGZ5loYgEK7reiHvncuagYR5ICd+ZlN/y3ryOc?= =?Windows-1252?Q?OjP568e2OYcyx0PKs1V5nzIyfQzDlEbDsOVwyCd+p115hbaqWrg/9EEa?= =?Windows-1252?Q?K7rkaH7gltvziqZZaXuUgFOR/WVuLVaadKDn4ITsOtWgK0mIRe19bin0?= =?Windows-1252?Q?r3k49juYTC3vOpRl/p1ALMnQ5QfBuj3gXzmiM3AAAVu8vNVZu4y8fFLW?= =?Windows-1252?Q?Svy/Ghh7FGz9qh0sRN/wuCpX4sV3HddarnnKTa6kssmfG8SfmGjz+O8f?= =?Windows-1252?Q?HNWy8081NeQ2ag0W0IdbZhbYTt6jM+fStbUEMmVLoqW8fwAVrclrkNqD?= =?Windows-1252?Q?zWx5NRtixF+NsYWPBPSZIyqhq6lb+T3XIr4vgeftDTcjEm9noYDyjucU?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: fd88d769-19c7-4e54-5c5a-08d944800c9a X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2021 15:25:00.8840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z6M6kEjzQg2JC1XK6iSqfMI4+x8pSqlOCjImnl+CM9daBwR5VqobNdupUZcvyh0ZMmWe9DTRh6ZtwSgr5hjSOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR04MB2322 Received-SPF: pass client-ip=2a01:111:f400:fe5b::70e; envelope-from=kbrown@cornell.edu; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Fmake_serial_process calls Fserial_process_configure, which calls serial_configure, which calls cfsetspeed with the speed argument equal to the numerical baud rate (e.g., 9600). But the documentation of cfsetspeed says that the speed argument must be one of the Bnnn constants defined in termios.h (e.g., B9600). See, for example, https://man7.org/linux/man-pages/man3/termios.3.html This incorrect call of cfsetspeed happens to succeed on GNU/Linux because glibc's cfsetspeed allows the argument to be the numerical baud rate, which it converts to the appropriate Bnnn constant. But I don't think emacs should be relying on this undocumented behavior. In particular, this doesn't work on Cygwin. And it wouldn't even work on GNU/Linux if emacs used the cfsetspeed replacement defined in sysdep.c instead of glibc's cfsetspeed. I think the way to fix this is to imitate the glibc code that converts the baud rate to a Bnnn constant, but maybe someone has a better idea. By the way, I came across this issue while investigating the failure of process-tests/fd-setsize-no-crash/make-serial-process on Cygwin. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 12:25:12 2021 Received: (at 49524) by debbugs.gnu.org; 11 Jul 2021 16:25:12 +0000 Received: from localhost ([127.0.0.1]:35788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2cGW-0005o4-7D for submit@debbugs.gnu.org; Sun, 11 Jul 2021 12:25:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2cGR-0005ng-Rj for 49524@debbugs.gnu.org; Sun, 11 Jul 2021 12:25:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52072) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2cGL-0003sQ-MK; Sun, 11 Jul 2021 12:25:01 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4900 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2cGL-0008Io-97; Sun, 11 Jul 2021 12:25:01 -0400 Date: Sun, 11 Jul 2021 19:24:50 +0300 Message-Id: <834kd0byy5.fsf@gnu.org> From: Eli Zaretskii To: Ken Brown In-Reply-To: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> (message from Ken Brown on Sun, 11 Jul 2021 11:24:58 -0400) Subject: Re: bug#49524: 28.0.50; make-serial-process is not portable References: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49524 Cc: 49524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ken Brown > Date: Sun, 11 Jul 2021 11:24:58 -0400 > > Fmake_serial_process calls Fserial_process_configure, which calls > serial_configure, which calls cfsetspeed with the speed argument equal to the > numerical baud rate (e.g., 9600). But the documentation of cfsetspeed says that > the speed argument must be one of the Bnnn constants defined in termios.h (e.g., > B9600). See, for example, > > https://man7.org/linux/man-pages/man3/termios.3.html > > This incorrect call of cfsetspeed happens to succeed on GNU/Linux because > glibc's cfsetspeed allows the argument to be the numerical baud rate, which it > converts to the appropriate Bnnn constant. But I don't think emacs should be > relying on this undocumented behavior. In particular, this doesn't work on > Cygwin. And it wouldn't even work on GNU/Linux if emacs used the cfsetspeed > replacement defined in sysdep.c instead of glibc's cfsetspeed. > > I think the way to fix this is to imitate the glibc code that converts the baud > rate to a Bnnn constant, but maybe someone has a better idea. Converting in sysdep.c:serial_configure sounds TRT to me. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 09:28:03 2021 Received: (at 49524) by debbugs.gnu.org; 12 Jul 2021 13:28:03 +0000 Received: from localhost ([127.0.0.1]:36806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2vyc-0002rw-O2 for submit@debbugs.gnu.org; Mon, 12 Jul 2021 09:28:03 -0400 Received: from mail-dm6nam12on2099.outbound.protection.outlook.com ([40.107.243.99]:49793 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2vya-0002rc-NH for 49524@debbugs.gnu.org; Mon, 12 Jul 2021 09:28:01 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKBlFf2J1y47h1Tl9VdMwM2vSRpXbYgdhnLFUqiYB+zqLmxD9AcYbDJLXHFYeAs9Y7tmgqoYev9N8VC0HdSbtfzYBRYfTWdyZFXNTtvp56DnaRRoXLZsLLgmGJpLpJMTs44PObjBZtKpV7ztjq4YB7yEVcHdKJ0e2cGBGG8OQ3ww4R1B4fq72oZzq02EC2kXKulytwxUnOpHQuAMNIV/NSyjWUfDkCn+ki8VuimqRYZoLGRwajA/LDjV/ZMAUEh4BZOEP58LaBToIuyTZLAfHHZEsEQQ2sMfKXhVL2zVayb/0pqhx+uHWxLMHV3TK8j3k734IQ3ze/4T0prXKIv0Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTP07Y73moa72JhxT51l4GUgT+kUMHiL++4isdnIBA4=; b=gE6wb/vpUPFfmhpEs9mJWZ5zKyXqzh6DEo3GUG1MjeX5r68IZjPLdKiOwEsy8I0D9ztH59l9CnNKfm1VAReUpOs7uOEbkYvrpBy3XwoQqPknTtGb2yJBawsQi91BCrB61QWxiPtykZJKMa8Zwwl4bwgSlqTmcoHeyNP5TD59TJ9WMmV32vUjDkEJT16CJSMUmYZJggytze0enVzZ7FdubFoWVs6xjVgYQPOIDNvbpgGHIIbVK8RRVkrt38vn6bwYrA3JNG+E0FUtmKP7BQSQaDMf8NVqBcV+KMrpksKoXQbFRlVkvBhBVbjTWD2KR7oZQk5CrRMJpJpcu6LO2PjhyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTP07Y73moa72JhxT51l4GUgT+kUMHiL++4isdnIBA4=; b=IWoJ1PM+li0YpSw6ZGlk5S2tSjGZvtloKJGhj8+5rTct+7MWFtoAnCzbGo4YweYV/L+A0fhu908AONgFYnKKHToF4+hVu0YrRVGTi4g91ovK78OHCaxSpg35OBVNHBHPxL482sRgbj0+aIxtPgMk619iVQJVrLN9QldrIM2gfl8= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN3PR04MB2180.namprd04.prod.outlook.com (2a01:111:e400:7bb8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Mon, 12 Jul 2021 13:27:52 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42%7]) with mapi id 15.20.4308.021; Mon, 12 Jul 2021 13:27:48 +0000 Subject: Re: bug#49524: 28.0.50; make-serial-process is not portable To: Eli Zaretskii References: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> <834kd0byy5.fsf@gnu.org> From: Ken Brown Message-ID: <8bf20bb2-ca96-3ee5-01e2-ec8b00cc8c91@cornell.edu> Date: Mon, 12 Jul 2021 09:27:44 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <834kd0byy5.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------C6E53845111F86154969E544" Content-Language: en-US X-ClientProxiedBy: MN2PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:c0::26) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.18] (24.194.34.31) by MN2PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:c0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.12 via Frontend Transport; Mon, 12 Jul 2021 13:27:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be8a66c6-323a-4acc-5e6d-08d94538d69c X-MS-TrafficTypeDiagnostic: BN3PR04MB2180: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kXpsRElX6g8QmUJn2zwIMYOK/jZ5LZGeXbYA8XBZHkZPeaJllh6zVg36BvqT9y8IGgkC5IQpe8WcavJwzL7S3nwi2CTUYXr6b65PGVgiMCDyVslhKZ3M6kGKhnmiwZrqCp6LgCAQSUGUISKfuPj6w+1nZ7O4farkFzgxa8oMxmw4hnLZ3aoxqqE7J3aAnMaSV5O81DGk3Yy8dOIGiHq2+fykGNijp1edfzhfv8JMbjJ90R09Y8/qbIK5QLkr2xg8QrtSh6FtzcAdOxgF1d5NjOBYEx+Hsxzx2LST9RxD70Je6UpglTSUGYsnBbh8VeD8FBpXcV7pHhOviImd1B0HBR8O35lI6a6s9fk65A/NCp9olHkmYFUvtCJQWDNs2KLOY8NhPJoSgzm3BIJnO1x7sJvJA9leOZ21sZCBTjg7Tio8E8zFtGMuPX6O6WYz/j4cu6xKqnD8lysrw/IgKI6iNJ0X21H+A+1deobuD+PHbGwoiCULFWcAarZGOpBcY+vxqXvA2tNw5GYI9WE2LiFx9OSf60rcQLL5iVW3Jf+46NdlXQz9ms0diGcjw/BIHpEA06DTgCq/h2RMnJzkq2KugcO+6Ml4Yw5FxbMzBVgk4DD7o8gqNKkJLbmQ9tftfxycCgn7orrX0ub4BQNkgCJ9cm9Ej0UNnBOIMcFCIWCyQLWG03idOJG5keAHphDjoqCVMjvid1f7IFNMEszGfizKJXLnwQDYh4Q0a1jMa2yDTUOBddoStEKPZlC74UyhetlUGfjzC5ruOvL5UOH/7HoPEhtci5AuEMBm8Fs/BQn+pJbn55naSKiGuf9K+SVO7DUh X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(75432002)(33964004)(966005)(786003)(316002)(235185007)(6486002)(6916009)(66476007)(66616009)(66556008)(4326008)(66946007)(5660300002)(86362001)(16576012)(956004)(38100700002)(2616005)(31696002)(26005)(8676002)(36756003)(8936002)(53546011)(31686004)(2906002)(186003)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?WwcJV9kyU495FxksB7VBTW+CSx18islEa+I/T/x6TUJwLRnSCp0PeHJu?= =?Windows-1252?Q?JLnePjZIT4xKQzVvUqxU50NhmqPONQBcO4IcPh2QU5px7MLnfsq8MN2Z?= =?Windows-1252?Q?OZEd4tXjzpCzD9FrrJNc63yje2ZOM8Gf7uEh2jO+DaPP5KPY6NIzaRFi?= =?Windows-1252?Q?wTDMiB6K6bAoYaAcmmh/MMYLaMvNbGc4fBjWdhI0BCYC/eFFvS7x9fDl?= =?Windows-1252?Q?qiHlhCul8N8Bb41qEWPaMmoN/5JMLUvuJdlwPJWNluAxR/8U6kA10TaE?= =?Windows-1252?Q?Bh2EzpW461oKPxoTtXCjwI3i1OyDkniXRet0UY0371nNjLZYfzF/xzIW?= =?Windows-1252?Q?6rGwZHHmBRY02rxyT8oVRoEApYLAKgJzo1RKVAoUNofPU07NLVbAHE1f?= =?Windows-1252?Q?zyDLLsUS2k3nPiOn0sn5mJOe3485yQK3whiR881/+OrAeQCtWTz4UHY1?= =?Windows-1252?Q?yhPfOiMCFaYD8WC++Iwaotdz5k4ue82WTlvHgCFZ8bBiqgPubGVh8Ub6?= =?Windows-1252?Q?+B56YxlbhPo3nyPH2HC8WQ4KY6l4vxrWoIKTgZFV68udQvwARmbXv+rO?= =?Windows-1252?Q?bjh/VvWEZIQ/Huf9T7kA7HfoFRLc5qwJB/Ayc3cLG0lCGcjZvrgjXCwv?= =?Windows-1252?Q?ErCvL/inbyjk7gCfVt6KkorY79ZdUACi7UjPZE7ufiHz2lsg9G6XZxhp?= =?Windows-1252?Q?oJvKc4eXwnmJgWtJ6IrHgycmMI4yE0MwXJPCBDt14Kignl239RwQmhN1?= =?Windows-1252?Q?Pnu96jHbP56BAahDX22KQyoIzrMEVk1zgkcWFE69gvTPaesZ2tPiepUK?= =?Windows-1252?Q?cpYH4OTOeHH4bBhdVU2sme9CCtNErOMeTF0/6Ksx8xpCyw6qkE9GNiBJ?= =?Windows-1252?Q?68Ap6eeEAdtGrc7FkKNi3AxyaoiJICdIgdr9t3x/vL/08j8Ac6uTkK1J?= =?Windows-1252?Q?3Kh7b7CzY2WMbExI2d/0aA6GgODXBsCTC+Tz/cVVyK7cO4oyc34r6srE?= =?Windows-1252?Q?RdvR/HyUrPelKFdGEuygDyY/E33IU/jc4zmOLeFAvDHiAepCEwURWLK5?= =?Windows-1252?Q?AfWNJj6wrPGOPSxomh5V7p4dMFANc53VUNx75ih2gfcX7WLV9SeyQEwQ?= =?Windows-1252?Q?rMrz92Mpoh+LG/VEtDGkKg05N4+jJ9u0UCXbWz3l45cakkvRY7U42dnU?= =?Windows-1252?Q?xqXmbDEYyLPqWCoFiJ3KH54aVrOm6Xw4olI1x8qSbtGCi+AcXabzSFA7?= =?Windows-1252?Q?/Bx7qkWnJfB4/utLzafglt7IWUrygXAxnCyE7UwcDmc30SbsXfGBkIVi?= =?Windows-1252?Q?xC2Fb8FLgeivKD7H1vmXleIN1fMd3pOwa7DrMThWcXKAxvS1A9NX0wCX?= =?Windows-1252?Q?Wvl7Nr7HfxZUUGK6WDrBfh//TI7SdrAo6AfPYk8ec5c2cx4zg67p2PYA?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: be8a66c6-323a-4acc-5e6d-08d94538d69c X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 13:27:48.4764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: po6GXbo/sF/Lo9eyBsdDgYO3AxyzsbuhaVJagpKEvFBu7N0tH7OlkEPzjGpcjAJeEw3+HPJ2+9Ohei4B6YyOEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR04MB2180 X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 49524 Cc: 49524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --------------C6E53845111F86154969E544 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 7/11/2021 12:24 PM, Eli Zaretskii wrote: >> From: Ken Brown >> Date: Sun, 11 Jul 2021 11:24:58 -0400 >> >> Fmake_serial_process calls Fserial_process_configure, which calls >> serial_configure, which calls cfsetspeed with the speed argument equal to the >> numerical baud rate (e.g., 9600). But the documentation of cfsetspeed says that >> the speed argument must be one of the Bnnn constants defined in termios.h (e.g., >> B9600). See, for example, >> >> https://man7.org/linux/man-pages/man3/termios.3.html >> >> This incorrect call of cfsetspeed happens to succeed on GNU/Linux because >> glibc's cfsetspeed allows the argument to be the numerical baud rate, which it >> converts to the appropriate Bnnn constant. But I don't think emacs should be >> relying on this undocumented behavior. In particular, this doesn't work on >> Cygwin. And it wouldn't even work on GNU/Linux if emacs used the cfsetspeed >> replacement defined in sysdep.c instead of glibc's cfsetspeed. >> >> I think the way to fix this is to imitate the glibc code that converts the baud >> rate to a Bnnn constant, but maybe someone has a better idea. > > Converting in sysdep.c:serial_configure sounds TRT to me. Patch attached. Ken --------------C6E53845111F86154969E544 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-portability-issue-with-make-serial-process.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Fix-portability-issue-with-make-serial-process.patch" >From aeda8d9e4432e5fac627341968e84c98f4df70bd Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Mon, 12 Jul 2021 09:24:12 -0400 Subject: [PATCH] Fix portability issue with make-serial-process * src/sysdep.c (struct speed_struct): New struct. (speeds): New static array of struct speed_struct. (convert_speed): New static function to convert a numerical baud rate (e.g., 9600) to a Bnnn constant defined in termios.h (e.g., B9600). (serial_configure): Use convert_speed to avoid cfsetspeed errors on non-glibc platforms. (Bug#49524) --- src/sysdep.c | 134 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 133 insertions(+), 1 deletion(-) diff --git a/src/sysdep.c b/src/sysdep.c index b8ec22d9dd..8eaee22498 100644 --- a/src/sysdep.c +++ b/src/sysdep.c @@ -2744,6 +2744,138 @@ cfsetspeed (struct termios *termios_p, speed_t vitesse) } #endif +/* The following is based on the glibc implementation of cfsetspeed. */ + +struct speed_struct +{ + speed_t value; + speed_t internal; +}; + +static const struct speed_struct speeds[] = + { +#ifdef B0 + { 0, B0 }, +#endif +#ifdef B50 + { 50, B50 }, +#endif +#ifdef B75 + { 75, B75 }, +#endif +#ifdef B110 + { 110, B110 }, +#endif +#ifdef B134 + { 134, B134 }, +#endif +#ifdef B150 + { 150, B150 }, +#endif +#ifdef B200 + { 200, B200 }, +#endif +#ifdef B300 + { 300, B300 }, +#endif +#ifdef B600 + { 600, B600 }, +#endif +#ifdef B1200 + { 1200, B1200 }, +#endif +#ifdef B1200 + { 1200, B1200 }, +#endif +#ifdef B1800 + { 1800, B1800 }, +#endif +#ifdef B2400 + { 2400, B2400 }, +#endif +#ifdef B4800 + { 4800, B4800 }, +#endif +#ifdef B9600 + { 9600, B9600 }, +#endif +#ifdef B19200 + { 19200, B19200 }, +#endif +#ifdef B38400 + { 38400, B38400 }, +#endif +#ifdef B57600 + { 57600, B57600 }, +#endif +#ifdef B76800 + { 76800, B76800 }, +#endif +#ifdef B115200 + { 115200, B115200 }, +#endif +#ifdef B153600 + { 153600, B153600 }, +#endif +#ifdef B230400 + { 230400, B230400 }, +#endif +#ifdef B307200 + { 307200, B307200 }, +#endif +#ifdef B460800 + { 460800, B460800 }, +#endif +#ifdef B500000 + { 500000, B500000 }, +#endif +#ifdef B576000 + { 576000, B576000 }, +#endif +#ifdef B921600 + { 921600, B921600 }, +#endif +#ifdef B1000000 + { 1000000, B1000000 }, +#endif +#ifdef B1152000 + { 1152000, B1152000 }, +#endif +#ifdef B1500000 + { 1500000, B1500000 }, +#endif +#ifdef B2000000 + { 2000000, B2000000 }, +#endif +#ifdef B2500000 + { 2500000, B2500000 }, +#endif +#ifdef B3000000 + { 3000000, B3000000 }, +#endif +#ifdef B3500000 + { 3500000, B3500000 }, +#endif +#ifdef B4000000 + { 4000000, B4000000 }, +#endif + }; + +/* Convert a numerical speed (e.g., 9600) to a Bnnn constant (e.g., + B9600); see bug#49524. */ +static speed_t +convert_speed (speed_t speed) +{ + for (size_t i = 0; i < sizeof speeds / sizeof speeds[0]; i++) + { + if (speed == speeds[i].internal) + return speed; + else if (speed == speeds[i].value) + return speeds[i].internal; + } + return speed; +} + /* For serial-process-configure */ void serial_configure (struct Lisp_Process *p, @@ -2775,7 +2907,7 @@ serial_configure (struct Lisp_Process *p, else tem = Fplist_get (p->childp, QCspeed); CHECK_FIXNUM (tem); - err = cfsetspeed (&attr, XFIXNUM (tem)); + err = cfsetspeed (&attr, convert_speed (XFIXNUM (tem))); if (err != 0) report_file_error ("Failed cfsetspeed", tem); childp2 = Fplist_put (childp2, QCspeed, tem); -- 2.32.0 --------------C6E53845111F86154969E544-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 12 17:35:52 2021 Received: (at 49524) by debbugs.gnu.org; 12 Jul 2021 21:35:52 +0000 Received: from localhost ([127.0.0.1]:38992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m33ai-0002g1-HL for submit@debbugs.gnu.org; Mon, 12 Jul 2021 17:35:52 -0400 Received: from mail-bn8nam11on2134.outbound.protection.outlook.com ([40.107.236.134]:63168 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m33ag-0002fn-3K for 49524@debbugs.gnu.org; Mon, 12 Jul 2021 17:35:51 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9jiD3pvK6NbfADHDtqm2xkiUrgkyVdbGzbOTpTxYz+ZTUs7j8jowdvOsZhlLLK8dKznZhTtDztg+QtvxEvCtI63xcHQ0m85QyiOmPiJFSvgRBNrw3aLKQsmbqPsFzMT3/SepaiaY1MwZfv1krBDmq2kX7yWcrCq9P07DpV0b2jOFziksWcd049fV7M+ia/I3cl8gcF6FgBxYD2pNFLt5AHFws7yysB2ZB5nuOUwZy96A7ePaHV4mgtJjClSplElHC+mXuOqzwUsfmgQjxzcEftyXCNitx9Qowd7J2tvGnXiw30H+6xV9iH3LAwMcI5Ka7SdX35pWRCGv8nEOK8gmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yi3amFmk/sDyquNvR18ZGza7MniG+TWevpvnRjEDPuc=; b=QR6AugYIYMANFeTN8vEeFv/zBvqsrG1tSiiQ9c0OEdAjgryu2gLQ2pKB8fG8bixxV4lvOkYC8EyHi0Ptk4kSpDw2ZXh4yzFoBIBqQbEyRlll+aABkeqgGnfUI5JS4ycUkNnZbYdxgbSMkBjtucHjMV+n/Zj07I4lPZtFCLLnU6+25ZM4ddqC8u52F1UF5piVYo9nOm7P9YrMIYmDeX9uCqu9PnuB3dKjA8OsXHxpa/go1NILS31/dSAlo7adoB8UEpP0IubklRc2i2+GbXe+EPcW63nImMqoxbLpCVCCnqeqI7T2FPfxBCphKGt6KnvIt06JhXDU8xcwWe5o15NbFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yi3amFmk/sDyquNvR18ZGza7MniG+TWevpvnRjEDPuc=; b=HVzQRscCRkYzFLBiaBk4vL3NutWJ3dBfZcDtdbnrfv3FZovPllTr/TYZ25duun5taSTuVGrjv2qZZetbTKMhI528XTM2/HC1v3VFnGmMpyuyODIM6jFKClYE7qIPF8C3WEHfuqzanvgjFr00vI6UUtaLolWObdewBDJRmqqa+JU= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN6PR04MB0354.namprd04.prod.outlook.com (2603:10b6:404:99::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Mon, 12 Jul 2021 21:35:43 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42%7]) with mapi id 15.20.4308.021; Mon, 12 Jul 2021 21:35:43 +0000 Subject: Re: bug#49524: 28.0.50; make-serial-process is not portable From: Ken Brown To: Eli Zaretskii References: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> <834kd0byy5.fsf@gnu.org> <8bf20bb2-ca96-3ee5-01e2-ec8b00cc8c91@cornell.edu> Message-ID: <57a32998-24f8-9e2c-adf5-d4971d3087cc@cornell.edu> Date: Mon, 12 Jul 2021 17:35:40 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <8bf20bb2-ca96-3ee5-01e2-ec8b00cc8c91@cornell.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL0PR0102CA0069.prod.exchangelabs.com (2603:10b6:208:25::46) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2603:7081:7e41:6a00:edaf:43a:30cb:1538] (2603:7081:7e41:6a00:edaf:43a:30cb:1538) by BL0PR0102CA0069.prod.exchangelabs.com (2603:10b6:208:25::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23 via Frontend Transport; Mon, 12 Jul 2021 21:35:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f82e646-a509-4cc4-cc23-08d9457d0095 X-MS-TrafficTypeDiagnostic: BN6PR04MB0354: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:820; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vmnBIoCldlxHpBMeIenNAehbF+u1SLVVif66nPiOi9JpHlKYIDSEYXYxpqN9IvuKyg+9kq3bQTlmeBOt2v1YqLJFZpsBHTgt3gpTXSmJZd5ifrFwLqLhitOGMeNdzLXLcwUmI3QoLUoPfHbSLr8Rsgss7kBNi0AC9ewU/gnbUEmepE+BMLJuZ3DkVwK9mpgUvr0XsM+Cicam63zvmEYQDISZq4lgMuYvh79jkKkm1wUV6fmiCMc8XOdWhCM6g/ki1YHN5pdKFZjrwT2DAUXKXLoCPWgt5lmvTz1LrIsaEUqCIB1a9KLAyaJvHXZ6oxmhVOVkvdoPJsDnJ6SHi8D/UrGDYw04RbTZiHvcphUj/EQSFQEkYOGhgAL7HF6GmhKHcuHylnpfqjJ1HIjlfw17e/2BD5ImACwVzvlqMghRv7aaSeObKC4isDhHJoRzNkVr2KMqYCFw5WCVtFW3N7/lwSPz43J6zTM9OWp9iTZBG9h/uG0K5qySpKStvt2EUg9HJcH6RhvlhWxKa69DlDs9e0bBbf63R8xwmDn6DIIBq5TweHZOUZrmcv/H4ZFs7YkDWsB7LAI6amGkg3KS5B0YUcru4Gmw0cHsSHt9dDAMP74TIJMT6ttmeZv0f7Pq6lLFrnMIj1RNXsSkmugJPvxO1pwhMj/AbocwGjyUzv17hDiCok3FOD/Gxa2QIt6Hjo6n03oK8TkVSd4Gvbk1s62eI/4cT1/ogFI9+d7QaLFUnM5cfCbYAh3EE9DpGvYEDgdIPJAL+OY/GM5L/Nq6Ja5JMnUaZsKDVqTG0bvaF1bqrG4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(346002)(376002)(39860400002)(8676002)(786003)(4326008)(8936002)(38100700002)(478600001)(36756003)(6486002)(316002)(6916009)(2616005)(186003)(86362001)(2906002)(5660300002)(66476007)(75432002)(66946007)(31686004)(66556008)(31696002)(966005)(53546011)(83380400001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?PHpGNLXhec7lZGRfLOE6g20jOyKipvSlvbWP4MdqGsBKwufQ6jK1r5B8?= =?Windows-1252?Q?8ZwvHztX+flNkVzsM7XOERKNH2cWs40U+s66RYYIg0GD/Gh3QAwav8Yr?= =?Windows-1252?Q?d6HRgUcA2QJDcQkuhDaCzlhbSbgULPDmYKR+FCC0e/cJ111P/xPHtUdZ?= =?Windows-1252?Q?dKho9tYFQq4OVY74CyMqXebyycemASquH00izIJ4l7rWkNQDqfpR9E50?= =?Windows-1252?Q?TSuTWorZYIlo0cq+hmEfCk7I8ONe6F5nzniizBSAfTBiRGlWH1DmnI6c?= =?Windows-1252?Q?KCbkLLz/hYDqhSwwlXYKKM4x5Me2q+Z98/1dPgpw8y5W18BohXmVXZzp?= =?Windows-1252?Q?t6Fu68iTATpNpZOP+uTdqWsSq3gn440uLY81yyhN61UcysKPJdDt/0mb?= =?Windows-1252?Q?sHUulmXOo5ephgENnTiHweLyMn1DPBdZ2Q+2q+rmSwccTYyPDPMf1VAc?= =?Windows-1252?Q?e0pydspBlcAADn1g0VRy+k4omKFToZ0uFbngmExVdTz1gyqohkwIvsh4?= =?Windows-1252?Q?8i4hixKDzcIr4uNWpESTgykSqnfC0YlS2HNkiBNLhZIpWUgGtr+eMnnq?= =?Windows-1252?Q?X+RTquXxBsEHuE8igoq3i8LIIvF9VGZ6Um5r2ClUqpsBSvmag3eXcZJj?= =?Windows-1252?Q?M3nRwvuK/zwYZ5Bc4JzbGqccaz5zeGsnSmnA76GeS2TTdD8RFD0RiOeD?= =?Windows-1252?Q?ZvdCwQuRibQKC/tp5/oIt8jb4kt/LHx8B03JzYHfucWsImcwtiLir9Jx?= =?Windows-1252?Q?vJvljTI9VJ0h3yPxLv+jsM6MZ/fL8QhX6keF3oKeH4inRFKKPG8jIg0x?= =?Windows-1252?Q?KKH4AziX2h1d7DlGu7OrkvGXV/rHefljXl1O3ZBWLgo+ythiW790EtNY?= =?Windows-1252?Q?cLWcN+3Ccnf8PfjiJCKEK8IbRDKYpVbkrgrDDJb/I/ZQP4GlN20WfVE6?= =?Windows-1252?Q?KMF5m48JLF1YrmIbqjqhekV5dU0ciK5AWRIKPzJCzhEWDSQSOECcw/Wn?= =?Windows-1252?Q?HunH527BxnL1u/dnKiBm/UfzD7qtX4JslJLQ7ZzSirk4MXo2r+9pOgcv?= =?Windows-1252?Q?3onUCwHIHbbFvikw6eYER67SVRUC0KXTvJE1hd4tjOtJ04K+56bJomZf?= =?Windows-1252?Q?MmWcjIVW1pn6Mth1pXck368mK20stUu9mHqcdaLF4iTuSwvkVTbirN0d?= =?Windows-1252?Q?2yIENse5wEZUkhXvXVKCF/jFic2Pg7nSu7SuwjGpSfpvr6CPR7PXhmlG?= =?Windows-1252?Q?V1xdgmnwhyjpxJ4hn4MVAZGT/9SAPrkGuTgS20jUk6HvgzGGRsm9/kid?= =?Windows-1252?Q?bwg/2J1AqhxSfznG+2Dg7g6mIsL/cgXVNZ2Aqbg5WF4kvWsHxTaW2W5P?= =?Windows-1252?Q?3qT6zJqNCbLSZ6zk6SUs8nip52UDxbSMjYko1FyMYdTgQo5ZX1TmERIJ?= =?Windows-1252?Q?rqyyyBdXVONAAy9RX0HH2knuAhcKBxMhqQz2rYqtEOOu8NB/p+Fc+o8E?= =?Windows-1252?Q?mqwfM1z6?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 7f82e646-a509-4cc4-cc23-08d9457d0095 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 21:35:43.4300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +4yu5eZ4Xg074kJO0cVOlg2yhuintgUobAgc4srMskO9bMl5ptGzYctAlRL88vgT5+PkEGgI3nfq/xeFP1cvIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0354 X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 49524 Cc: 49524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) On 7/12/2021 9:27 AM, Ken Brown wrote: > On 7/11/2021 12:24 PM, Eli Zaretskii wrote: >>> From: Ken Brown >>> Date: Sun, 11 Jul 2021 11:24:58 -0400 >>> >>> Fmake_serial_process calls Fserial_process_configure, which calls >>> serial_configure, which calls cfsetspeed with the speed argument equal to the >>> numerical baud rate (e.g., 9600).  But the documentation of cfsetspeed says that >>> the speed argument must be one of the Bnnn constants defined in termios.h (e.g., >>> B9600).  See, for example, >>> >>>     https://man7.org/linux/man-pages/man3/termios.3.html >>> >>> This incorrect call of cfsetspeed happens to succeed on GNU/Linux because >>> glibc's cfsetspeed allows the argument to be the numerical baud rate, which it >>> converts to the appropriate Bnnn constant.  But I don't think emacs should be >>> relying on this undocumented behavior.  In particular, this doesn't work on >>> Cygwin.  And it wouldn't even work on GNU/Linux if emacs used the cfsetspeed >>> replacement defined in sysdep.c instead of glibc's cfsetspeed. >>> >>> I think the way to fix this is to imitate the glibc code that converts the baud >>> rate to a Bnnn constant, but maybe someone has a better idea. >> >> Converting in sysdep.c:serial_configure sounds TRT to me. > > Patch attached. BTW, we've decided to change Cygwin's cfsetspeed to be compatible with glibc's, so the problem fixed by my patch won't exist on Cygwin going forward. And I checked FreeBSD out of curiosity and found that there's no issue there either because of the way they define the Bnnn constants: #define B0 0 #define B50 50 #define B75 75 ... So I should probably remove the reference to non-glibc platforms in my commit message. Ken From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 07:19:26 2021 Received: (at 49524) by debbugs.gnu.org; 13 Jul 2021 11:19:26 +0000 Received: from localhost ([127.0.0.1]:39582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3GRh-0001kQ-Rb for submit@debbugs.gnu.org; Tue, 13 Jul 2021 07:19:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3GRg-0001kB-CH for 49524@debbugs.gnu.org; Tue, 13 Jul 2021 07:19:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55798) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3GRa-0001at-Nj; Tue, 13 Jul 2021 07:19:18 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3312 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3GRY-00026V-FL; Tue, 13 Jul 2021 07:19:18 -0400 Date: Tue, 13 Jul 2021 14:19:11 +0300 Message-Id: <831r82a2c0.fsf@gnu.org> From: Eli Zaretskii To: Ken Brown In-Reply-To: <57a32998-24f8-9e2c-adf5-d4971d3087cc@cornell.edu> (message from Ken Brown on Mon, 12 Jul 2021 17:35:40 -0400) Subject: Re: bug#49524: 28.0.50; make-serial-process is not portable References: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> <834kd0byy5.fsf@gnu.org> <8bf20bb2-ca96-3ee5-01e2-ec8b00cc8c91@cornell.edu> <57a32998-24f8-9e2c-adf5-d4971d3087cc@cornell.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49524 Cc: 49524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ken Brown > Cc: 49524@debbugs.gnu.org > Date: Mon, 12 Jul 2021 17:35:40 -0400 > > So I should probably remove the reference to non-glibc platforms in my commit > message. Yes, something to the effect of compliance with advertised APIs would probably be better. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 09:12:23 2021 Received: (at 49524-done) by debbugs.gnu.org; 13 Jul 2021 13:12:23 +0000 Received: from localhost ([127.0.0.1]:39789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3ICy-0006jn-Ky for submit@debbugs.gnu.org; Tue, 13 Jul 2021 09:12:23 -0400 Received: from mail-bn8nam11on2092.outbound.protection.outlook.com ([40.107.236.92]:26747 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3ICi-0006im-05 for 49524-done@debbugs.gnu.org; Tue, 13 Jul 2021 09:12:19 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBIxnlHg94893SfjTvonpzG5OPJZmA7xQ3xywZCfpw0AlcLfF/wJxY3V28zxF5iulonYCoL6ELeVr9CnSjnF+4+h1XEXrLKR7N6noPvMv5yJYR1SDkr/cckdTejmh44xI3gA3rtQrVOWZWlEcAz6tNHhx3G2QLUcuye4oAB5HPyG8xGfKFY+IOWJWvT2NVxRWdPazmhBE1wvJazLhJFOC7E1KTMOp5N6B4I0JkaEyx1X05EuwL5DjW2bIjFhQ2iQyj2y/qdNq8Fo/nAnvghykCIMSgMaJcbceFcaBIpuUrqqBR10xjUX2mPivTZlEXBPaKBpzYik8IYy3dLOYDyu4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFbSD0lwbWWGU3mK5/q3f+fH7R8tAEr7JEcU4bsI2IA=; b=cfv243EQ1P9Jcof8Dd6u85FBOwhOelFCMvoICwF6bLF0NskaU+CAuPReT1xRqzAPvPWg3cADWVkxV+g/7MCQ11ehbPnO5NWshmkG86Z6B9v7s88WvKvbx/7mBHzxw6bYbD9PWcpHdxb6XuG7AC8yHuUxmrmpW/OV+gry0wj5kgIhxNXD3IlNZwa+ASch5zkOXDTYcT83Xs34D6Q7Q6xkbWLtG30QOugc7L2YByK8pDnOCYzEWwBX8jypcRmqGqBjd6ZL28xTX2M4zW9wn9sGIlzpg7/Dgq3aPEv1Y/KpeR4mylrD55+BH8MVZAE6qQLZfUiNuiMcsEtsf39nQr3sPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFbSD0lwbWWGU3mK5/q3f+fH7R8tAEr7JEcU4bsI2IA=; b=Tp95mBw1HsNVfRQCOuQGCfh5k55ZlrwUK5ysDX4EdB6Iw4d9ueu3Uo78h3fB6/3RGbV1jb/rnHq7NmLbXUPu6m4vMtINFdjDynisiXXC+C2B/gmYS2HrN5XMgSi9/gTDaT717sqAWh66dMvTwpsmPUBhYff3bI8QnkzdkNQqtPU= Authentication-Results: debbugs.gnu.org; dkim=none (message not signed) header.d=none;debbugs.gnu.org; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN6PR04MB1026.namprd04.prod.outlook.com (2603:10b6:405:47::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19; Tue, 13 Jul 2021 13:11:57 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::cda2:359c:cb66:5c42%7]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 13:11:57 +0000 Subject: Re: bug#49524: 28.0.50; make-serial-process is not portable To: Eli Zaretskii References: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> <834kd0byy5.fsf@gnu.org> <8bf20bb2-ca96-3ee5-01e2-ec8b00cc8c91@cornell.edu> <57a32998-24f8-9e2c-adf5-d4971d3087cc@cornell.edu> <831r82a2c0.fsf@gnu.org> From: Ken Brown Message-ID: <25a83b24-fa7a-f0f7-a105-2596e48ca9a7@cornell.edu> Date: Tue, 13 Jul 2021 09:11:12 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <831r82a2c0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR15CA0004.namprd15.prod.outlook.com (2603:10b6:208:1b4::17) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.18] (24.194.34.31) by MN2PR15CA0004.namprd15.prod.outlook.com (2603:10b6:208:1b4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Tue, 13 Jul 2021 13:11:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 61fe872d-d831-4661-607f-08d945ffcaaa X-MS-TrafficTypeDiagnostic: BN6PR04MB1026: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 49uTanQ+TbRr0D3NhwPdXwoD6ZaA8xMH82pX+5P0G6DYRMmrflfn7z3fZw8h0gR8FRhOfHq7Wq8in36jnJAfHNdQTyY+Uo+bBgQPA+A6BdLSsO/US4xhy+jVIhzKxetD7dGVfNYE/rBQtprzzQqPkk/+gWtOVdlFWDllt0WJKZvPLQHjKu1205LKM+4J4Q+1+rMEWpdMb9YrDccHK3uA2QVMNI9JnEhvzYKx+JHAL+oVxe449utbCMtcLGps2H7xjFXBlh4wSTOzoaxw3AHliU4KRDDe9UCB+YFUoRV+vz7jvBiaXKkYq26D85++7KR+niEqbILwoPdCGvpVqBWX1itEs531qMuf2JsVrjl1/2CtLzB0g/nDRq44OjTla2VVofwEN8y6Sw88X+6rmGqSU1Zmv3+A7zhCOkHmzIvOlWJ7Q3ShQtVc0xCxff7A171aJ18F4v8soQ34460xT5snH6L1baPpyNvuuxoqL5fhWDFVMIbb6Pe7hn+IKTTbOHJDpROlt5chOvUVYLRqKduZSFCWmnVMXW+p06+QdIG01+q5bEXZpO7KQ06J20mAi2d/9oUl/jC4sFbOx4Ey20kw/Rl8tEGggGFPOAGuJYWPsLlriPda89kBOA44ByDVD2av3HWfdXEx0t4oe6dZUrxMlz+fWlGoBpYbYFjcgyi4ukCyDRyyidZ/fU+TT8XH1dbxbGBQgSyl5RjiOUIpMa494JK4khKscxoIe1cfy39qZxk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(2616005)(186003)(16576012)(26005)(6916009)(66476007)(66556008)(86362001)(786003)(31686004)(4326008)(5660300002)(8676002)(2906002)(956004)(53546011)(316002)(75432002)(6486002)(31696002)(6666004)(36756003)(8936002)(66946007)(38100700002)(478600001)(83380400001)(4744005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?4uzv1RYOOi1OhCsIo+OC20f4vZIvMB1Zk06mlMdyI8xRR7QrrOAv4P6o?= =?Windows-1252?Q?gT4oEQMAuTyNcxwTe5ZjuIT0ZN5ZcOkWvOAjlGVnhDpF/1JvrhrbIzfI?= =?Windows-1252?Q?p6ENfQ8GpLdarSVSLEyOoX/KnaH87KXmgFq8rmwDod16krYHDLjJ+8fI?= =?Windows-1252?Q?me/nmhxw0n4F0BP0Cy88fECES69LYCXu6SgZJCYM5iJ+9FTXA4rkZPIP?= =?Windows-1252?Q?GTDzBF2lZp+x8YWj0Ja7GKyhu54hFZj3PinVzb+qJaG/ZKEkJQbLGofQ?= =?Windows-1252?Q?3DwIFmk7NCp5LNPe5uBS3n/3/DAl9IGN0u8Gp4jETTC+aQEvTSV/Uc96?= =?Windows-1252?Q?BfCMBGbqvGbwUowL4hsbh2Pfet2D/qZ39BfUr/TiszcrHwMU+Fu6DoFe?= =?Windows-1252?Q?rcG7+04IqhnH9OHmvy5sOMA31L6tUElTZJE5k1J8h+D3vWPVrSvtC4BU?= =?Windows-1252?Q?Mr9PEUzIi3Nh7ppc5zk7C9pJ3n37/glQIDMg8+To6CvQSilGifBzkl7f?= =?Windows-1252?Q?xKA9PmjdRGc56OgE9msLilVvlkK1whX5wzHDMhO+Yl803hDybJ+EuM0n?= =?Windows-1252?Q?3Dovbl7ui52pfm7N0E/Lqp6T0Pi87kVfcmA1fCNgcHlWTGA11SOxU2yX?= =?Windows-1252?Q?l1arEtAMPXc0LpWEA2Mh0zs8nHe1uhpgp3LhW6hEMEgUGHwn1aSvcr4u?= =?Windows-1252?Q?GkwTMWbK9l+x+yO+FlBkH9AwTEU62qfD9nrSEiuCCtSeKLSNX8cOc0CJ?= =?Windows-1252?Q?E8rFfGy6yKnjczZa2MvaFm2ht7fobT3dj9mDA8KtNRTLt69PQWqd42D9?= =?Windows-1252?Q?zodNZ3GEZtPula+QyxHep8m8wygd393q4Yg+9Ats9HpUEDbi/RfAZIc8?= =?Windows-1252?Q?UWnKHP+8u0O66LLcBorQViRnBoepCWhFp5+9yOD29oZkQssbnmgRHeXh?= =?Windows-1252?Q?aG1mw4gz4wPFhhLIiJFJUTWVzH4ASCjo/5TKKit2uD3hxWbWKxdxF9xw?= =?Windows-1252?Q?KxaIp3a2SrQ10JNJ6pbgenE+7CFRz2HNkifACV8BVZ/Nkx29doxnpnHV?= =?Windows-1252?Q?pXFs702BKXB8bJqPKUn6MhY9uq7bftoJuoPUsHq+06jUObNF3gMZsgbz?= =?Windows-1252?Q?wW7H6Gc1WSRCHaMoaQ1vIbJm3K4e3icvFvu3aLL56vpjZ2EI+mkZ3x9L?= =?Windows-1252?Q?ERnnos8p5BMhdyWFIOAxXIUyyekT2T6A9N+P/sKdJKc+LlWB1fU+axDD?= =?Windows-1252?Q?fNr7LD2JEAEevHsZBkcGu3zGhLFz6wh2aOWu01J8Hi97iUhZeg4IJ1W6?= =?Windows-1252?Q?9+ecoqZKzCo23IZkkhC9PA8tORa0KCHNO4jDTtotiza5SNTybwjhTQkM?= =?Windows-1252?Q?mjrjex6Ue17cctcKYLokksjdnBknGFOF2mPm4DwrDCP9k4MtMkDx/91/?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 61fe872d-d831-4661-607f-08d945ffcaaa X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 13:11:57.1654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wthQn5/BZAThDGida5bITUZOeXopqty1Lb3/HJXepMH/NQdw2q/kCqi3FmO7nxbHgjUp5bJ0MxiA3gHm+cRKkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB1026 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 49524-done Cc: 49524-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On 7/13/2021 7:19 AM, Eli Zaretskii wrote: >> From: Ken Brown >> Cc: 49524@debbugs.gnu.org >> Date: Mon, 12 Jul 2021 17:35:40 -0400 >> >> So I should probably remove the reference to non-glibc platforms in my commit >> message. > > Yes, something to the effect of compliance with advertised APIs would > probably be better. Done. Closing. From unknown Sun Jun 22 07:40:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 11 Aug 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator