From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 07:56:46 2021 Received: (at submit) by debbugs.gnu.org; 11 Jul 2021 11:56:46 +0000 Received: from localhost ([127.0.0.1]:34114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Y4k-0007Gt-Kn for submit@debbugs.gnu.org; Sun, 11 Jul 2021 07:56:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:44606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Y4i-0007Gk-5R for submit@debbugs.gnu.org; Sun, 11 Jul 2021 07:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2Y4h-0002R1-CY for guix-patches@gnu.org; Sun, 11 Jul 2021 07:56:43 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:41403) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Y4f-0003uW-LJ for guix-patches@gnu.org; Sun, 11 Jul 2021 07:56:43 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 5B15227BC81 for ; Sun, 11 Jul 2021 12:56:39 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e8ee5b3b for ; Sun, 11 Jul 2021 11:56:38 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] weather: Don't look for exported package replacements twice. Date: Sun, 11 Jul 2021 12:56:38 +0100 Message-Id: <20210711115638.30207-1-mail@cbaines.net> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) There could be performance issues with member here, but only if there are lots of replacements. * guix/scripts/weather.scm (all-packages): Return all exported packages, plus non exported replacements, rather than including exported replacements twice. --- guix/scripts/weather.scm | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm index 06312d65a2..0f70dc8460 100644 --- a/guix/scripts/weather.scm +++ b/guix/scripts/weather.scm @@ -53,17 +53,30 @@ #:export (guix-weather)) (define (all-packages) - "Return the list of public packages we are going to query." - (fold-packages (lambda (package result) - (match (package-replacement package) - ((? package? replacement) - (cons* replacement package result)) - (#f - (cons package result)))) - '() - - ;; Dismiss deprecated packages but keep hidden packages. - #:select? (negate package-superseded))) + "Return the list of packages we are going to query." + (let* ((packages + (fold-packages (lambda (package result) + (cons package result)) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded))) + (non-exported-replacement-packages + (fold-packages (lambda (package result) + (let ((replacement (package-replacement package))) + (if (and replacement + ;; Avoid double couting replacements + ;; that are themselves exported + (not (member replacement packages))) + (cons replacement result) + result))) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded)))) + (append + packages + non-exported-replacement-packages))) (define (call-with-progress-reporter reporter proc) "This is a variant of 'call-with-progress-reporter' that works with monadic -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 13:11:06 2021 Received: (at 49522) by debbugs.gnu.org; 19 Jul 2021 17:11:06 +0000 Received: from localhost ([127.0.0.1]:60187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5WnJ-0008ET-Oy for submit@debbugs.gnu.org; Mon, 19 Jul 2021 13:11:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5WnH-0008Dz-QX for 49522@debbugs.gnu.org; Mon, 19 Jul 2021 13:11:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50166) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5WnC-000156-8O; Mon, 19 Jul 2021 13:10:58 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45220 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5WnC-0005J3-16; Mon, 19 Jul 2021 13:10:58 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#49522: [PATCH] weather: Don't look for exported package replacements twice. References: <20210711115638.30207-1-mail@cbaines.net> Date: Mon, 19 Jul 2021 19:10:55 +0200 In-Reply-To: <20210711115638.30207-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 11 Jul 2021 12:56:38 +0100") Message-ID: <875yx6mdpc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49522 Cc: 49522@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Christopher Baines skribis: > There could be performance issues with member here, but only if there are= lots > of replacements. > > * guix/scripts/weather.scm (all-packages): Return all exported packages, = plus > non exported replacements, rather than including exported replacements tw= ice. [...] > + "Return the list of packages we are going to query." > + (let* ((packages > + (fold-packages (lambda (package result) > + (cons package result)) > + '() > + > + ;; Dismiss deprecated packages but keep hidden = packages. > + #:select? (negate package-superseded))) > + (non-exported-replacement-packages > + (fold-packages (lambda (package result) > + (let ((replacement (package-replacement packa= ge))) > + (if (and replacement > + ;; Avoid double couting replacemen= ts > + ;; that are themselves exported > + (not (member replacement packages)= )) > + (cons replacement result) > + result))) > + '() > + > + ;; Dismiss deprecated packages but keep hidden = packages. > + #:select? (negate package-superseded)))) > + (append > + packages > + non-exported-replacement-packages))) Is the goal to delete duplicates? In that case, how about wrapping the existing expression in (delete-duplicates =E2=80=A6 eq?) ? (Note that (member x lst) is O(N) is the number of packages, so the code above is quadratic in the number of packages, which should be avoided. Also, packages cannot be meaningfully compared with =E2=80=98equal?=E2=80= =99 (which is expensive in case of different packages), so =E2=80=98eq?=E2=80=99 should b= e preferred.) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 01 11:01:37 2021 Received: (at 49522) by debbugs.gnu.org; 1 Aug 2021 15:01:37 +0000 Received: from localhost ([127.0.0.1]:36850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mACy9-0002jk-3r for submit@debbugs.gnu.org; Sun, 01 Aug 2021 11:01:37 -0400 Received: from mira.cbaines.net ([212.71.252.8]:40164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mACy4-0002jY-GR for 49522@debbugs.gnu.org; Sun, 01 Aug 2021 11:01:35 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 8D72127BC6B; Sun, 1 Aug 2021 16:01:31 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 92a7ab26; Sun, 1 Aug 2021 15:01:30 +0000 (UTC) References: <20210711115638.30207-1-mail@cbaines.net> <875yx6mdpc.fsf@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#49522: [PATCH] weather: Don't look for exported package replacements twice. In-reply-to: <875yx6mdpc.fsf@gnu.org> Date: Sun, 01 Aug 2021 16:01:27 +0100 Message-ID: <8735rtb454.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49522 Cc: 49522@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Christopher Baines skribis: > >> There could be performance issues with member here, but only if there ar= e lots >> of replacements. >> >> * guix/scripts/weather.scm (all-packages): Return all exported packages,= plus >> non exported replacements, rather than including exported replacements t= wice. > > [...] > >> + "Return the list of packages we are going to query." >> + (let* ((packages >> + (fold-packages (lambda (package result) >> + (cons package result)) >> + '() >> + >> + ;; Dismiss deprecated packages but keep hidden= packages. >> + #:select? (negate package-superseded))) >> + (non-exported-replacement-packages >> + (fold-packages (lambda (package result) >> + (let ((replacement (package-replacement pack= age))) >> + (if (and replacement >> + ;; Avoid double couting replaceme= nts >> + ;; that are themselves exported >> + (not (member replacement packages= ))) >> + (cons replacement result) >> + result))) >> + '() >> + >> + ;; Dismiss deprecated packages but keep hidden= packages. >> + #:select? (negate package-superseded)))) >> + (append >> + packages >> + non-exported-replacement-packages))) > > Is the goal to delete duplicates? Not really, the goal is to have a list with no duplicates. > In that case, how about wrapping the existing expression in > (delete-duplicates =E2=80=A6 eq?) ? > > (Note that (member x lst) is O(N) is the number of packages, so the code > above is quadratic in the number of packages, which should be avoided. > Also, packages cannot be meaningfully compared with =E2=80=98equal?=E2=80= =99 (which is > expensive in case of different packages), so =E2=80=98eq?=E2=80=99 should= be preferred.) Replacing member with memq seems sensible. My understanding of delete duplicates is that it's O(N^2), because it constructs a new list, and keeps searching it in linear time. While that sounds better, doing a linear search of packages for each replacement should be quicker, assuming there's only a few replacements compared to the number of packages. I'm fine with either though, I don't actually know which is faster, and it probably doesn't matter anyway. I'll send a patch with a delete-duplicates approach. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmEGt0dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfqpA/+MsrcuvhMddOGbTZc3YFs95esZrdtLz7K j0rnL0FVYxbkZQnaCLROwMIMSo6QY5S62ZnVmMaCkwMkQmiGa36Py9cBdCbWVn9i S+FwnGEfBEOsxUcn0BLKbi36Uv3S3MAJPeW5XFztFGCpSoh6npEo74P+053Q86KS Q8iQ1lZhZKyux7pX/vANDuVwJl2UWR2ZH1nBTpW7ZcIc+Q5aBN40ntuMs6oMQJyG eq9ozowNc3myo2xc8uQMC48cXr8Zto0jRqd8xC5HWouYhEbn4S95dIl6kadIkzKf eVxIQCpI7yJBVyZTlOQTDWtZJ3rViLQ+38sSYYV0qBhqY8wzefSHENkLpBe9G9KA R53YRwJDk194hNFLcBs3uGkkya4Dm81q4vAUpbWhmczV3AvV87SorWxuPInnszuR Fq7JsINMG4A7cO5/ggQBBG8FTGuQaxCAEVCL3TwPvR+/JC6TumW+lVNDlDkndm79 Q7Mzt9ku3gQK6YA6dzdkoWLK7gLoI4UgzaGlus8B4jnNrjnIdkcnkqNn98qny/08 jfVnUUDi/NrObLT2Qv+3S+WMGR208oFyNBIu3NeeSX06T1TaDMbrGnxBHPL/+Xsk tEA3foBTjknXzWC/Cp5kwoSnK+06jSn+4yzd4SF+3OL0cYEK0Yx3MXhhWlzgSBXe B1CpezBeYLQ= =aBX7 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 01 11:45:38 2021 Received: (at 49522) by debbugs.gnu.org; 1 Aug 2021 15:45:38 +0000 Received: from localhost ([127.0.0.1]:36892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mADej-0003m1-Sx for submit@debbugs.gnu.org; Sun, 01 Aug 2021 11:45:38 -0400 Received: from mira.cbaines.net ([212.71.252.8]:40178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mADei-0003ls-1j for 49522@debbugs.gnu.org; Sun, 01 Aug 2021 11:45:36 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id B38A527BC6B for <49522@debbugs.gnu.org>; Sun, 1 Aug 2021 16:45:34 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fb7b4a1e for <49522@debbugs.gnu.org>; Sun, 1 Aug 2021 15:45:34 +0000 (UTC) From: Christopher Baines To: 49522@debbugs.gnu.org Subject: [PATCH] weather: Don't look for exported package replacements twice. Date: Sun, 1 Aug 2021 16:45:34 +0100 Message-Id: <20210801154534.22051-1-mail@cbaines.net> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49522 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/weather.scm (all-packages): Delete duplicates, so that exported replacements aren't included twice. --- guix/scripts/weather.scm | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/guix/scripts/weather.scm b/guix/scripts/weather.scm index 06312d65a2..60a697d1ac 100644 --- a/guix/scripts/weather.scm +++ b/guix/scripts/weather.scm @@ -54,16 +54,18 @@ (define (all-packages) "Return the list of public packages we are going to query." - (fold-packages (lambda (package result) - (match (package-replacement package) - ((? package? replacement) - (cons* replacement package result)) - (#f - (cons package result)))) - '() - - ;; Dismiss deprecated packages but keep hidden packages. - #:select? (negate package-superseded))) + (delete-duplicates + (fold-packages (lambda (package result) + (match (package-replacement package) + ((? package? replacement) + (cons* replacement package result)) + (#f + (cons package result)))) + '() + + ;; Dismiss deprecated packages but keep hidden packages. + #:select? (negate package-superseded)) + eq?)) (define (call-with-progress-reporter reporter proc) "This is a variant of 'call-with-progress-reporter' that works with monadic -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 01 17:30:27 2021 Received: (at 49522) by debbugs.gnu.org; 1 Sep 2021 21:30:28 +0000 Received: from localhost ([127.0.0.1]:39121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLXoR-0003W4-ON for submit@debbugs.gnu.org; Wed, 01 Sep 2021 17:30:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLXoQ-0003Vr-Gz for 49522@debbugs.gnu.org; Wed, 01 Sep 2021 17:30:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLXoL-0000Rt-26; Wed, 01 Sep 2021 17:30:21 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48830 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLXoC-00007R-OG; Wed, 01 Sep 2021 17:30:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: bug#49522: [PATCH] weather: Don't look for exported package replacements twice. References: <20210711115638.30207-1-mail@cbaines.net> <20210801154534.22051-1-mail@cbaines.net> Date: Wed, 01 Sep 2021 23:30:11 +0200 In-Reply-To: <20210801154534.22051-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 1 Aug 2021 16:45:34 +0100") Message-ID: <87tuj456ho.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49522 Cc: 49522@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Christopher Baines skribis: > * guix/scripts/weather.scm (all-packages): Delete duplicates, so that exp= orted > replacements aren't included twice. LGTM, and apologies for the delay! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 03 05:25:52 2021 Received: (at 49522-done) by debbugs.gnu.org; 3 Sep 2021 09:25:52 +0000 Received: from localhost ([127.0.0.1]:42961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5SK-0005h9-E4 for submit@debbugs.gnu.org; Fri, 03 Sep 2021 05:25:52 -0400 Received: from mira.cbaines.net ([212.71.252.8]:39408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5SI-0005gz-Gq for 49522-done@debbugs.gnu.org; Fri, 03 Sep 2021 05:25:51 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id C5CD727BBE1; Fri, 3 Sep 2021 10:25:49 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 19705a5c; Fri, 3 Sep 2021 09:25:48 +0000 (UTC) References: <20210711115638.30207-1-mail@cbaines.net> <20210801154534.22051-1-mail@cbaines.net> <87tuj456ho.fsf_-_@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#49522: [PATCH] weather: Don't look for exported package replacements twice. In-reply-to: <87tuj456ho.fsf_-_@gnu.org> Date: Fri, 03 Sep 2021 10:25:45 +0100 Message-ID: <87a6kuqacm.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49522-done Cc: 49522-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> * guix/scripts/weather.scm (all-packages): Delete duplicates, so that ex= ported >> replacements aren't included twice. > > LGTM, and apologies for the delay! Great, I've pushed this now as 9540323458de87b0b8aa421e449a4fe27af7c393. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmEx6hlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeVCQ/+KEjg7vpOtpTWUobZEUe3mzByunLMYJeA RDdT3UyEUOJ6z+GRUZXYVt31tGE4HHMl/shzpW0+pMNYiC5y5/9deIlWipbikoCS lZrsvYhDuKJPFDKzkcYs4OGFafOXCjbA9AjjQ6wYQSkj6YaHfIbRV1e+l0TYYYyR KOi79YVbePxnWEpwZLVtO+3W93+GX3B8/D0fciIbV6l2O+vbLP4F6j0KlPEhuArK nWvNuZtqCEpukq8q+/evaqWkyab5ZzQ5Y3UzBd//S0d3K25aKBENraoXYtU1f9tu SEcpyltI+y2Pn513JkskffL4pvUomGWUvaVYiXA1o3XBGHx6F1YnMtn1CKsDH69w s448eE0/exa0cCBErYQfxGh9Q+kRhHLfODoGj7O2Mo+fD2jEC5YYxExu7ETLxkcu Lkn51CUOEHMC05qtTAqkGFJ5tmVW9N2/qMtfzgJuptMMX0so3F6hQ5VDIaYWKAaY MDj+PFFQp13NUQr77Hrv7aExgAHxO3Su0n37ho3ouo/l+5Vfmg7xvr+8bNe42h6H mPkBqPL93cTPHF0pA3Dy+/Z2v5B/VG3AvDlyaIMxjl8Oqq0Sl89bN1aYxK41wEjy qdys5YtH8q5WQHMRwSOcACqCsaB1UfaLgXxBVnMH3icPD6h9kBXoWhOlOMkqHqUP qaJ/pz44MNU= =Yzwt -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 17:17:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 01 Oct 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator