Subject: Re: bug#49520: [PATCH] Minor fixes to interception-tools and update dual-function-keys.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 26 Jul 2021 19:36:03 +0200

Hi,

"Paul A. Patience" <[email-masked]> skribis:

> From 34e0d095c51cb37a10b338586446c48eec9c7bca Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <[email-masked]>
> Date: Sun, 11 Jul 2021 00:08:39 -0400
> Subject: [PATCH 1/3] gnu: interception-tools: Make minor fixes.
>
> * gnu/packages/linux.scm (interception-tools)[inputs]: Move boost to...
> [native-inputs]: ...here. New field.
> [license]: gpl3+ -> gpl3.

[...]

> +    (native-inputs
> +     `(("boost" ,boost)))
>      (inputs
> -     `(("boost" ,boost)
> -       ("libevdev" ,libevdev)
> +     `(("libevdev" ,libevdev)

I believe Boost should remain in ‘inputs’ or it would not be found when
cross-compiling.

> -    ;; Dual-licensed under GPLv3+ or "something else" on request, per
> +    ;; Dual-licensed under GPLv3 or "something else" on request, per
>      ;; 'README.md'.
> -    (license license:gpl3+)))
> +    (license license:gpl3)))

AFAICS, nothing in the source says “version 3 only”, so ‘gpl3+’ is correct.

It seems to me this patch can be dropped.  WDYT?

> From c324fef966098f885454f5afb0687db137d4c7d0 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <[email-masked]>
> Date: Sun, 11 Jul 2021 00:22:46 -0400
> Subject: [PATCH 3/3] gnu: interception-dual-function-keys: Update to 1.4.0.
> 
> * gnu/packages/linux.scm (interception-dual-function-keys)
> [version]: Update to 1.4.0.

Applied.

> From 83c06ca8d7b52c7dc7c38ed2c476ff39047f5cd2 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <[email-masked]>
> Date: Sun, 11 Jul 2021 00:19:56 -0400
> Subject: [PATCH 2/3] gnu: interception-dual-function-keys: Minor fixes.
>
> * gnu/packages/linux.scm (interception-dual-function-keys)
> [arguments]<#:make-flags>: Make use of cc-for-target, cxx-for-target and
> %output.
> <#:phases>{check}: Undelete phase. Disable tests instead with...
> <#:tests?>: ...this. New field.

Applied, thanks!

Ludo’.