From unknown Fri Jun 13 11:12:32 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49499] [PATCH] gnu: add the tos;dr initiative's extension Resent-From: terramorpha@cock.li Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Jul 2021 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49499@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16258591983584 (code B ref -1); Fri, 09 Jul 2021 19:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jul 2021 19:33:18 +0000 Received: from localhost ([127.0.0.1]:59814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1wFR-0000vk-O9 for submit@debbugs.gnu.org; Fri, 09 Jul 2021 15:33:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:42464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1wFP-0000vb-5D for submit@debbugs.gnu.org; Fri, 09 Jul 2021 15:33:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1wFO-0002XX-I4 for guix-patches@gnu.org; Fri, 09 Jul 2021 15:33:14 -0400 Received: from mail.cock.li ([37.120.193.124]:48416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1wFL-0006aH-T1 for guix-patches@gnu.org; Fri, 09 Jul 2021 15:33:14 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1625859188; bh=MRFWCumew8+C7ooDW9a5uD5SH2sY6ufgvzCUidkuoD0=; h=Date:From:To:Subject:From; b=MuY+f/5LBwsR6pCN4Yf4Akf28ITtDoTJ+XTlJuWR6vzD1+RQfwG3jyDVqmRBhCYql KQHBDhKM1vtXQ7S0Gyn9bokYUz+oCMJg/3WPIHLxnHxzhYMaHyQrIcZgvNM87aDyjQ oFPCUqpAR18u5x1CmeGHRvaGJyQqH7AMwTIRWehALub8oPtNMgY06fe6MxIg98tcLr qB6F0/imvqs3OzSNL74CEru/1kxz3RH8wMb2Lfwfhv264XoMfCkmRn73NTucDci+g+ V796u5YBwR0dXAxtFtgwIZ8K5zA0/yBnwZprynVHxD4j2Ue6sM0euLrAKtnbI1Fo6q vUYb6DN6W0s9g== Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 09 Jul 2021 15:33:08 -0400 From: terramorpha@cock.li Message-ID: <9d44234caf247026a5c19af90f5d4471@cock.li> X-Sender: terramorpha@cock.li User-Agent: Roundcube Webmail/1.3.15 Received-SPF: pass client-ip=37.120.193.124; envelope-from=terramorpha@cock.li; helo=mail.cock.li X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL=1.31, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a package definition for the terms of service;didn't read initiative. It is useful to easily know the privacy issues with whatever website the user is using. diff --git a/gnu/packages/browser-extensions.scm b/gnu/packages/browser-extensions.scm index a6120baf96..6cbe77b9c3 100644 --- a/gnu/packages/browser-extensions.scm +++ b/gnu/packages/browser-extensions.scm @@ -121,3 +121,41 @@ ungoogled-chromium.") (define-public ublock-origin/chromium (make-chromium-extension ublock-origin "chromium")) + +(define tosdr + (package + (name "tosdr") + (version "4.1.1") + (source (origin + (uri + (git-reference (url "https://github.com/tosdr/browser-extensions.git") + (commit version))) + (sha256 (base32 "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0")) + (method git-fetch))) + (inputs `(("bash" ,bash) + ("coreutils" ,coreutils) + ("node" ,node) + ("zip" ,zip) + ("unzip" ,unzip))) + (arguments + `(#:builder + (begin + (use-modules (guix build utils)) + (set-path-environment-variable "PATH" + '("bin") + (map cdr %build-inputs)) + (copy-recursively (assoc-ref %build-inputs "source") ".") + (invoke "sh" "./build.sh") + (invoke "unzip" "dist/chrome.zip" "-d" %output) + #t) + #:modules ((guix build utils)))) + (build-system trivial-build-system) + (synopsis "extension for the Terms of Service; Didn't Read initiative") + (description "This extension informs you instantly of your rights online by +showing an unintrusive icon in the toolbar. You can click on this icon to get +summaries from the Terms of Service; Didn't Read initiative.") + (license license:agpl3) + (home-page "https://tosdr.org/"))) + +(define-public tosdr-chromium + (make-chromium-extension tosdr)) From unknown Fri Jun 13 11:12:32 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49499] [PATCH] gnu: add the tos;dr initiative's extension Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jul 2021 21:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: terramorpha@cock.li Cc: 49499@debbugs.gnu.org Received: via spool by 49499-submit@debbugs.gnu.org id=B49499.162699058619309 (code B ref 49499); Thu, 22 Jul 2021 21:50:02 +0000 Received: (at 49499) by debbugs.gnu.org; 22 Jul 2021 21:49:46 +0000 Received: from localhost ([127.0.0.1]:41747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6gZd-00051M-NR for submit@debbugs.gnu.org; Thu, 22 Jul 2021 17:49:46 -0400 Received: from out2.migadu.com ([188.165.223.204]:46449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6gZY-000519-Lu for 49499@debbugs.gnu.org; Thu, 22 Jul 2021 17:49:45 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1626990578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Do+4PcEC1rNpKx5y8jwgJslPgcqfQGfOpyobCfa0Vzk=; b=k3axYX9na6RV2TPyR5rem1TrjHpRb8DK+qi/QpkdXXussUi0jsQy6P9RtF0agK/4O4rB/F /CCFErcbvmFrOHB8n6Wob4ALCEXFDC/Du0kpnqJLX0zvZPDAmqeZTIkMYgv+wdYazDExqg DzYuEEfUFUYsV5mmrwOd+Z9zVqX7cms= From: Sarah Morgensen References: <9d44234caf247026a5c19af90f5d4471@cock.li> Date: Thu, 22 Jul 2021 14:49:36 -0700 In-Reply-To: <9d44234caf247026a5c19af90f5d4471@cock.li> (terramorpha@cock.li's message of "Fri, 09 Jul 2021 15:33:08 -0400") Message-ID: <8635s6rpcf.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thanks for the patch. Unfortunately I am unable to apply your patch; it looks like your mail client wrapped long lines which broke the patch. (That's why most of us send patches with `git send-email`, to avoid this problem.) I also have a few suggestions for your patch, annotated below... terramorpha@cock.li writes: > This is a package definition for the terms of service;didn't read initiative. It > is useful to easily > know the privacy issues with whatever website the user is using. > > diff --git a/gnu/packages/browser-extensions.scm > b/gnu/packages/browser-extensions.scm > index a6120baf96..6cbe77b9c3 100644 > --- a/gnu/packages/browser-extensions.scm > +++ b/gnu/packages/browser-extensions.scm > @@ -121,3 +121,41 @@ ungoogled-chromium.") > > (define-public ublock-origin/chromium > (make-chromium-extension ublock-origin "chromium")) > + > +(define tosdr > + (package > + (name "tosdr") > + (version "4.1.1") > + (source (origin > + (uri > + (git-reference (url > "https://github.com/tosdr/browser-extensions.git") This line is too long and should be wrapped. > + (commit version))) > + (sha256 (base32 > "0wz31f9rz087yw1a7cdhdgqvgnhbk569jywv846n122m4bpk3yw0")) Likewise. > + (method git-fetch))) > + (inputs `(("bash" ,bash) > + ("coreutils" ,coreutils) > + ("node" ,node) > + ("zip" ,zip) > + ("unzip" ,unzip))) These should be native-inputs rather than inputs, since they are just used in building. Perhaps consider just using copy-build-system instead, to avoid manually including these inputs and setting PATH below. You can look at the ublock-origin package as an example (though I would use the copy-build-system instead, adding back in a 'build phase, either removing the "rm -rf build" from `build.sh` beforehand or unzipping the zip immediately afterwards). > + (arguments > + `(#:builder > + (begin > + (use-modules (guix build utils)) > + (set-path-environment-variable "PATH" > + '("bin") > + (map cdr %build-inputs)) > + (copy-recursively (assoc-ref %build-inputs "source") ".") > + (invoke "sh" "./build.sh") > + (invoke "unzip" "dist/chrome.zip" "-d" %output) > + #t) > + #:modules ((guix build utils)))) > + (build-system trivial-build-system) > + (synopsis "extension for the Terms of Service; Didn't Read initiative") The synopsis should begin with a capital letter. > + (description "This extension informs you instantly of your rights online by > +showing an unintrusive icon in the toolbar. You can click on this icon to get > +summaries from the Terms of Service; Didn't Read initiative.") > + (license license:agpl3) > + (home-page "https://tosdr.org/"))) > + > +(define-public tosdr-chromium > + (make-chromium-extension tosdr)) -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 22:32:47 2021 Received: (at control) by debbugs.gnu.org; 25 Jul 2021 02:32:47 +0000 Received: from localhost ([127.0.0.1]:47293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7Twc-0008IA-UB for submit@debbugs.gnu.org; Sat, 24 Jul 2021 22:32:47 -0400 Received: from out0.migadu.com ([94.23.1.103]:15044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7TwY-0008Hz-Cx for control@debbugs.gnu.org; Sat, 24 Jul 2021 22:32:45 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1627180361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=1ukQFzFQMgencPyty4BLFkO3xdp91eUjdndjX26T2JA=; b=GVmf6dwAYPsPvN9D6LhAmbjxCFWcROugW7MnIovxn6i4Jhdw+N+fZWx/gSreFFrBTF5WyJ T2qUEpLcx3/NlWJHfMu6qpRGCXdPvtouBDXI8rEN7I4Hk4O73EgYO6NXpZmimEwwESM2Z8 jVUHH/zvyO1MS41XVjZH+qcraGiQu/E= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #49499 Date: Sat, 24 Jul 2021 19:32:39 -0700 Message-ID: <86fsw3p1h4.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) reassign 49582 guix-patches merge 49499 49582 thanks