From unknown Fri Aug 15 20:55:29 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4947: Comments on misearch.el [repost from emacs-devel] Reply-To: "Tobias C. Rittweiler" , 4947@debbugs.gnu.org Resent-From: "Tobias C. Rittweiler" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 17 Nov 2009 18:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4947 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12584830376021 (code B ref -1); Tue, 17 Nov 2009 18:40:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Nov 2009 18:37:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAHIbEj4006018 for ; Tue, 17 Nov 2009 10:37:16 -0800 Received: from mail.gnu.org ([199.232.76.166]:50873 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1NASvS-0002DL-7R for emacs-pretest-bug@gnu.org; Tue, 17 Nov 2009 13:37:14 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NASvN-0005s6-7B for emacs-pretest-bug@gnu.org; Tue, 17 Nov 2009 13:37:13 -0500 Received: from a022.reverse.yawsp.de ([62.27.20.22]:58559 helo=freebits.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NASvM-0005rk-Tf for emacs-pretest-bug@gnu.org; Tue, 17 Nov 2009 13:37:09 -0500 Received: from host146.natpool.mwn.de ([138.246.7.146] helo=thaleron) by freebits.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.44) id 1NASvB-0008PT-OY for emacs-pretest-bug@gnu.org; Tue, 17 Nov 2009 18:36:57 +0000 From: "Tobias C. Rittweiler" To: emacs-pretest-bug@gnu.org Date: Tue, 17 Nov 2009 19:36:28 +0100 Message-ID: <87my2lj8wj.fsf@freebits.de> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-freebits.de-MailScanner-Information: http://freebits.de X-freebits.de-MailScanner: Sauber X-freebits.de-MailScanner-SpamCheck: not spam, SpamAssassin (notcached, Wertung=0, benoetigt 6, autolearn=not spam) X-MailScanner-From: tcr@freebits.de X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) I just tried misearch.el which provides the ability to search through multiple files / buffers via isearch. Thank you, Juri, for writing it, it's exactly what I need. (BTW., is there something like misearch but for query-replace, too?) I do have some comments on it: * The docstring of `multi-isearch-next-buffer-function' says that the function is called with the current buffer as first argument. However, in case of the initial buffer, it's actually called with `nil' as first argument. Is that intended? If so, the docstring should reflect that. I now have in my next-buffer function (setq current-buffer (or current-buffer (current-buffer))) as a workaround. * It'd be nice, not only to display "Repeat for next buffer", but actually include the next buffer's name. * If I'm in a file that contains matches, and I'm at the last match, it exhibits the following behaviour in the minibuffer: Multi Isearch: ... (pressing C-s) Failing multi Isearch: ... [Repeat ...] (pressing C-s) jumps to first match in next buffer However, if I'm in a buffer that won't have a match, I see the following behaviour: Multi Isearch: ..(incremently typing).. --> turns to Failing multi Isearch: ... [Repeat ...] (pressing C-s) Failing mutli Isearch: ... (pressing C-s) goes to next file I.e., as you can hopefully see, it expects one C-s too much. (The line without the "[Repeat ...]" is superfluous.) -T. -- Diese Nachricht wurde auf Viren und andere gefaerliche Inhalte untersucht und ist - aktuelle Virenscanner vorausgesetzt - sauber. Freebits E-Mail Virus Scanner From unknown Fri Aug 15 20:55:29 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4947: Comments on misearch.el Reply-To: Juri Linkov , 4947@debbugs.gnu.org Resent-From: Juri Linkov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 30 Nov 2009 21:55:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4947 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4947-submit@emacsbugs.donarmstrong.com id=B4947.125961764729611 (code B ref 4947); Mon, 30 Nov 2009 21:55:06 +0000 Received: (at 4947) by emacsbugs.donarmstrong.com; 30 Nov 2009 21:47:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAULlPZG029608 for <4947@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 13:47:26 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id 77F583F40BF; Mon, 30 Nov 2009 23:47:19 +0200 (EET) From: Juri Linkov To: "Tobias C. Rittweiler" Cc: 4947@debbugs.gnu.org Organization: JURTA References: <87my2lj8wj.fsf@freebits.de> Date: Mon, 30 Nov 2009 23:45:43 +0200 In-Reply-To: <87my2lj8wj.fsf@freebits.de> (Tobias C. Rittweiler's message of "Tue, 17 Nov 2009 19:36:28 +0100") Message-ID: <87ljhng0gg.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > I just tried misearch.el which provides the ability to search through > multiple files / buffers via isearch. Thank you, Juri, for writing it, > it's exactly what I need. > > I do have some comments on it: > > * The docstring of `multi-isearch-next-buffer-function' says that the > function is called with the current buffer as first argument. > > However, in case of the initial buffer, it's actually called with > `nil' as first argument. > > Is that intended? If so, the docstring should reflect that. > I now have in my next-buffer function > > (setq current-buffer (or current-buffer (current-buffer))) > > as a workaround. Thanks for the suggestion. I fixed `multi-isearch-next-buffer-function' to always provide a non-nil value of the argument `buffer'. > * It'd be nice, not only to display "Repeat for next buffer", but > actually include the next buffer's name. I see two problems with this: 1. A buffer name might be too long to display in the prompt. 2. To get a buffer name, we should preemptively call `multi-isearch-next-buffer-function' that might break it if this function expects that we call it only when we really are going to switch to the next buffer (not just to get and display its name). > There's another wishlist item, though it's not that important: I'd like > to see a small buffer pop up which contains all the files we're going to > search through, and highlight where we currently are. `list-buffers' (`C-x C-b') already allows selecting buffers to Isearch. So we could mark the currently searched buffer in the *Buffer List*. > * If I'm in a file that contains matches, and I'm at the last match, > it exhibits the following behaviour in the minibuffer: > > Multi Isearch: ... (pressing C-s) > > Failing multi Isearch: ... [Repeat ...] (pressing C-s) > > jumps to first match in next buffer > > However, if I'm in a buffer that won't have a match, I see the > following behaviour: > > Multi Isearch: ..(incremently typing).. --> turns to > Failing multi Isearch: ... [Repeat ...] (pressing C-s) > > Failing multi Isearch: ... (pressing C-s) > > goes to next file > > I.e., as you can hopefully see, it expects one C-s too much. (The > line without the "[Repeat ...]" is superfluous.) Actually this is the intended behaviour. The first Failing multi Isearch: ... [Repeat ...] (pressing C-s) says "There are no more matches in the current buffer, try to search in the next buffer". And the second Failing multi Isearch: ... (pressing C-s) says "I've tried to search all buffers and there are no more matches in all remaining buffers". And goes to next file actually wraps to the first file/buffer. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Fri Aug 15 20:55:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4947: Comments on misearch.el [repost from emacs-devel] Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 4947@debbugs.gnu.org, "Tobias C. Rittweiler" Received: via spool by 4947-submit@debbugs.gnu.org id=B4947.162271261713624 (code B ref 4947); Thu, 03 Jun 2021 09:31:02 +0000 Received: (at 4947) by debbugs.gnu.org; 3 Jun 2021 09:30:17 +0000 Received: from localhost ([127.0.0.1]:42335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lojg9-0003XO-2E for submit@debbugs.gnu.org; Thu, 03 Jun 2021 05:30:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lojg7-0003Qn-S1 for 4947@debbugs.gnu.org; Thu, 03 Jun 2021 05:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jAKhojVVvCZo7V2oWa4LDy4EyLxzk5cazI2SuZGPicc=; b=VWd89EtS4LX1AbtF/twtBAw4gN zoCqyq6wF/zoWWM4gJNB0fNryvqH4G5bmnohFotyvhwmJ+fi8rWwZPgSgO/5mCuzaweBlC8n26KSl WfXu3+oppAukfjZlZKlagVvwrsIkBSIPHBdjVsKeDBF5/GBZUoXdbm/W+VFvdANPeZq0=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lojfz-0000PM-HE; Thu, 03 Jun 2021 11:30:09 +0200 From: Lars Ingebrigtsen References: <87my2lj8wj.fsf@freebits.de> <87ljhng0gg.fsf@mail.jurta.org> X-Now-Playing: Little Simz's _Grey Area_: "Offence" Date: Thu, 03 Jun 2021 11:30:07 +0200 In-Reply-To: <87ljhng0gg.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 30 Nov 2009 23:45:43 +0200") Message-ID: <87tumf5m8w.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> There's another wishlist item, though it's not that important: I'd like >> to see a small buffer pop up which contains all the files we're going to >> search through, and highlight where we current [...] Content analysis details: (-1.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 1.0 URIBL_SBL Contains an URL's NS IP listed in the Spamhaus SBL blocklist [URIs: jurta.org] 0.1 URIBL_SBL_A Contains URL's A record listed in the Spamhaus SBL blocklist [URIs: jurta.org] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> There's another wishlist item, though it's not that important: I'd like >> to see a small buffer pop up which contains all the files we're going to >> search through, and highlight where we currently are. > > `list-buffers' (`C-x C-b') already allows selecting buffers to Isearch. > So we could mark the currently searched buffer in the *Buffer List*. Skimming this bug report, it seems like this wishlist item was the only thing not handled here? Is this something that should still be considered, or should this bug report be closed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Aug 15 20:55:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4947: Comments on misearch.el [repost from emacs-devel] Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 4947@debbugs.gnu.org, "Tobias C. Rittweiler" Received: via spool by 4947-submit@debbugs.gnu.org id=B4947.16227524039878 (code B ref 4947); Thu, 03 Jun 2021 20:34:02 +0000 Received: (at 4947) by debbugs.gnu.org; 3 Jun 2021 20:33:23 +0000 Received: from localhost ([127.0.0.1]:44754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lou1r-0002ZF-5V for submit@debbugs.gnu.org; Thu, 03 Jun 2021 16:33:23 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:44397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lou1p-0002Ym-H9; Thu, 03 Jun 2021 16:33:22 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id C4226100003; Thu, 3 Jun 2021 20:33:13 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET References: <87my2lj8wj.fsf@freebits.de> <87ljhng0gg.fsf@mail.jurta.org> <87tumf5m8w.fsf_-_@gnus.org> Date: Thu, 03 Jun 2021 23:24:47 +0300 In-Reply-To: <87tumf5m8w.fsf_-_@gnus.org> (Lars Ingebrigtsen's message of "Thu, 03 Jun 2021 11:30:07 +0200") Message-ID: <8735ty3igo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) tags 4947 fixed close 4947 28.0.50 thanks >>> There's another wishlist item, though it's not that important: I'd like >>> to see a small buffer pop up which contains all the files we're going to >>> search through, and highlight where we currently are. >> >> `list-buffers' (`C-x C-b') already allows selecting buffers to Isearch. >> So we could mark the currently searched buffer in the *Buffer List*. > > Skimming this bug report, it seems like this wishlist item was the only > thing not handled here? > > Is this something that should still be considered, or should this bug > report be closed? Usually before starting a multi-buffer search you know what files you are going to search, so perhaps this report could be closed.