From unknown Sun Aug 17 09:10:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49457 <49457@debbugs.gnu.org> To: bug#49457 <49457@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add emacs-consult-notmuch. Reply-To: bug#49457 <49457@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:10:58 +0000 retitle 49457 [PATCH] gnu: Add emacs-consult-notmuch. reassign 49457 guix-patches submitter 49457 Andrew Tropin severity 49457 normal tag 49457 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 09:59:57 2021 Received: (at submit) by debbugs.gnu.org; 7 Jul 2021 13:59:57 +0000 Received: from localhost ([127.0.0.1]:53125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m185l-00086Q-6P for submit@debbugs.gnu.org; Wed, 07 Jul 2021 09:59:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:36864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m185h-00086H-OP for submit@debbugs.gnu.org; Wed, 07 Jul 2021 09:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m185g-0002qW-OQ for guix-patches@gnu.org; Wed, 07 Jul 2021 09:59:53 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:46910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m185b-0007Wp-RI for guix-patches@gnu.org; Wed, 07 Jul 2021 09:59:52 -0400 Received: by mail-lf1-x134.google.com with SMTP id p21so4171160lfj.13 for ; Wed, 07 Jul 2021 06:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=ThURMwsuqxPIigxgFPQq7g2A9sKWxdNlwi+gLv3iNSQ=; b=XEhJ092WEM8i9ePBjpBGcgv5Ma0eKbl+JQPSigKgdG3ZH/mK1i5R8ct6eXCwYCnhYu S01kKd2GMR8vv/uiufHm5jwFVcUnoYuWRSVvtCkzv/PPWRkDkPZPc+5aCttEn6g55RJ0 9pHj6aB4f3zIKLv+kCrGXEzAcFxIrKL9S4tKfH2GQXYNGI+v5yuYxhaXmGHgd+pk7d9O 6IGRMWinE57yyFiLuj9hBkmY61C7Arsr082FW2P2WBUxhWGuY8EAsPe8a0PlW/UaK6gB 4Xfoi1Yh0RiQNANpUQB2lYHT3haHbM7akELvomcR45l41Nt2zXrsWU7xDwnrCX9fj1yk Gl1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ThURMwsuqxPIigxgFPQq7g2A9sKWxdNlwi+gLv3iNSQ=; b=AgihzzpMJ4LPMD1FZAmzixA62H5vn2CEX3VHJnEW3sicYLTgk2OwdIn1Xyk+wWQj1d 6iLAqxu8wZmAr2fWi9axYCmFolmoy/igylt8F6VN5EmbyS5G8MBt2QUD5klgVbHdMC0y ErxH71AAbtQR2imY/A8aEmFQiMyt0fsa28SpD6M+xAm/oUBMT7a3y8d8TrvNbfhCgtpe m849gybLWq462RWlzVJB6GeKe37R5NjR3Dx0rvdnnvosQZrC79RCt3zGblpuKyAmOhWL XGU3+rRJZ5xBgxhkVMTCx49oe8dznBgMxUMt+3ICMoVDQEtaMVgiOJcehlzImRvXDaQ8 6OwQ== X-Gm-Message-State: AOAM530pT+NYe4Jo0+NK7M0cgnRJ4Owjb5iKAG3ILXFW0qF1f3HyYp/9 8Bt6MfygDWHFqPvO+pThglGhV39g8O5eJQ== X-Google-Smtp-Source: ABdhPJx+oyaRccWhjpv1g80JhyBtW8Ki6vgJV8KSkUutbFopMdGoKu1AtoLhGzhU99a3nLHWgrGPcQ== X-Received: by 2002:a05:6512:3155:: with SMTP id s21mr16321674lfi.650.1625666385033; Wed, 07 Jul 2021 06:59:45 -0700 (PDT) Received: from localhost (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id h16sm626484lfm.25.2021.07.07.06.59.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 06:59:44 -0700 (PDT) From: Andrew Tropin To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-consult-notmuch. Date: Wed, 07 Jul 2021 16:59:41 +0300 Message-ID: <87tul6w7g2.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2a00:1450:4864:20::134; envelope-from=andrew@trop.in; helo=mail-lf1-x134.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-emacs-consult-notmuch.patch Content-Transfer-Encoding: quoted-printable Content-Description: Add emacs-consult-notmuch From=20eba48a1058bc4ae7486e74ac30cf851a78ce7272 Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Wed, 7 Jul 2021 16:55:41 +0300 Subject: [PATCH] gnu: Add emacs-consult-notmuch. * gnu/packages/emacs-xyz.scm (emacs-consult-notmuch): New variable. =2D-- gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9591a4e6e7..788a25a8e8 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -8084,6 +8084,36 @@ Emacs completion function completing-read, which all= ows quickly selecting from a list of candidates.") (license license:gpl3+))) =20 +(define-public emacs-consult-notmuch + (package + (name "emacs-consult-notmuch") + (version "0.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://codeberg.org/jao/consult-notmuch.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "19flyh3v1xm2zswzjkvjbijvpbq5r8isafza4fd0yicvqbjyklhx")))) + (build-system emacs-build-system) + (inputs + `(("emacs-consult" ,emacs-consult) + ("notmuch" ,notmuch))) + (license license:gpl3+) + (home-page "https://codeberg.org/jao/consult-notmuch") + (synopsis "Search and preview notmuch emails using consult") + (description "\ +This package provides two commands using consult to query notmuch +emails and present results either as single emails @code{consult-notmuch} +or full trees @code{consult-notmuch-tree}. + +The package also defines a narrowing source for @code{consult-buffer}, whi= ch +can be activated with @code{(add-to-list 'consult-buffer-sources +'consult-notmuch-buffer-source)}."))) + (define-public emacs-marginalia (package (name "emacs-marginalia") =2D-=20 2.32.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDls00PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wUYYP/3I28M73++esACnNjmSwLHSvS/4Z15NYbI9b gnzU4ydAT91WSvCuB/qj2/IvZ9KFzD9mcrRRGuqAF4Ya9OqcyxlYK1U+hmBQE5Qk jlkKsWnR3Zzac25J4KtrOeg5a5ywZ5H8aszx3YnDX+RCcVuE9gBbE49OyHSHrnRm i8upg7TT+crA3RKLEjEca/5yTXWCqjcm8oM3VGdJUaMQox56PRN9Qtzcq3LptmSN YW8UmORqGe24aUkHws9nwtByFbsum2H8n1mK8SDSZ6auSM402TzTWOAoWbZ0ZdQ3 JrNqqGfLLhWht54b6F1O5PzxK0gFJfiiAfY5zilDn7airgdAZcE8EaWELHZEA7hi GwUPzxXauIB9QAZbtLqrstExuCiLMEm6e6K+15VMsR/j58X7P12yFAcvlO1EX72u Y7BZRYznV3xhQNHallJcz/o9w/Ar1SPsoTni42mVx22Ns6LYySzeKqQ6vfml/l/g 3dbJpckc3rA3n3DhRGAA/OCNnoPs9HJ22qH2Sv4I6vCZPWbuiSF2qI1dhUhDClZo Oa9O+Q3XIr8Ty7d5TX9CQ4ZMiorYf89KJTIa5cSEmArPsUnpndjX+JOxCSsbcaHj JzqgzrDhiMH9Dp3d1wHTSmkZlvf30maS7N9qFNdEaK+Em32h3s/UMdpnk/79JwkB OZjVHMI2 =igtW -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 10:13:02 2021 Received: (at submit) by debbugs.gnu.org; 7 Jul 2021 14:13:02 +0000 Received: from localhost ([127.0.0.1]:53156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18IQ-0008Tv-4j for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:13:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:53522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18IN-0008TT-FY for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:13:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m18IN-0005kR-5f for guix-patches@gnu.org; Wed, 07 Jul 2021 10:12:59 -0400 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:36358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m18IL-0000wY-AR for guix-patches@gnu.org; Wed, 07 Jul 2021 10:12:58 -0400 Received: by mail-lj1-x231.google.com with SMTP id a6so2895143ljq.3 for ; Wed, 07 Jul 2021 07:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=lkIIhxzo1ZXV7DH/OiyjGXciES2Q+m2TJyPqqUWsj2I=; b=NqXsBYSEtsjtS8Ayjkd8zDGxV9RQ1go0XmxSgQ+GXPOaako8PzPLnnnIkagUohv1nk CjMuQxk8i2HSP7z/9l16tp8PgghwaDCV7PCH/OuoVg1axd96qDb8bGbHC7EtR+5jwSOh yXvNIeD9OlebCVouNdhUTeBGDHD7Rj7JmSk6cZ354KGVChxdO+LDLk+W5cu8BlevJzxw vPA4ClLwWg2CnIGeMDw/AokNf2vp0x3V8kEbmCq1tp86FQTX3WSZRA+msoyVwAEGMy8v yJdZrTvDrA9wTO2j5PrCj5RW+FcXwrWITqH7CNTFn/36n5/Fut760dLf3WdiNAgp/2bk 1blw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=lkIIhxzo1ZXV7DH/OiyjGXciES2Q+m2TJyPqqUWsj2I=; b=e3h0TaEpD7/0+L7Dkwc9pQ4wQJ1/mcd+H1PYnP+VeaiHs5bC3xcmdsYroPBcvkgKEr zZY10xtPXikCjAIYwh3V+g5PwXsV10zuXmTMZGjlhA0Xt9YP2r+xCOlwtB94JUefE5y7 4bbdGL7zGV/fPkTgvyEwphU3MpWJgtHwHEWN0c4XTMcJEEYwFHHkoF8wbphqfjU9VXBg 1rz84j6Uj927uOY90HNpUmnLpLnyBzvB84uf6/TJ5jc/q7bUANKc109ZBGKHmNbyO+eM lD4guN5h7Bb8xODDs1EhsVqrgMJ5kF26TBObU+OqmWSftSoq6PM4oB2uGL5ix8ySMOqp z18Q== X-Gm-Message-State: AOAM533nr5hwQwfF3GLmSCcgaGPWxNKwATLnS/gOTB109joFXx7ArWwm y2ee2BD+9vXqZ8hXQ4oQDhDJuS07Qcg5DQ== X-Google-Smtp-Source: ABdhPJzACWSReASmPwl6WrZnnYP7zKCwxNGKQDNZcvPuOJDowbqp/Pc918aEV7wqgtwESb4C2anRJg== X-Received: by 2002:a05:651c:1689:: with SMTP id bd9mr19001437ljb.373.1625667171747; Wed, 07 Jul 2021 07:12:51 -0700 (PDT) Received: from localhost (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id a26sm203560lfc.218.2021.07.07.07.12.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 07:12:50 -0700 (PDT) From: Andrew Tropin To: guix-patches@gnu.org Subject: [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <87tul6w7g2.fsf@trop.in> References: <87tul6w7g2.fsf@trop.in> Date: Wed, 07 Jul 2021 17:12:47 +0300 Message-ID: <87r1gaw6u8.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2a00:1450:4864:20::231; envelope-from=andrew@trop.in; helo=mail-lj1-x231.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain v2 uses propagated-inputs instead of inputs, because using consult-notmuch without consult and notmuch doesn't make much sense. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=v2-0001-gnu-Add-emacs-consult-notmuch.patch Content-Transfer-Encoding: quoted-printable From=207ba18d68face76d8858ad67a6113f5773fa45cec Mon Sep 17 00:00:00 2001 From: Andrew Tropin Date: Wed, 7 Jul 2021 16:55:41 +0300 Subject: [PATCH v2] gnu: Add emacs-consult-notmuch. * gnu/packages/emacs-xyz.scm (emacs-consult-notmuch): New variable. =2D-- gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9591a4e6e7..492572322c 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -8084,6 +8084,36 @@ Emacs completion function completing-read, which all= ows quickly selecting from a list of candidates.") (license license:gpl3+))) =20 +(define-public emacs-consult-notmuch + (package + (name "emacs-consult-notmuch") + (version "0.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://codeberg.org/jao/consult-notmuch.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "19flyh3v1xm2zswzjkvjbijvpbq5r8isafza4fd0yicvqbjyklhx")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-consult" ,emacs-consult) + ("notmuch" ,notmuch))) + (license license:gpl3+) + (home-page "https://codeberg.org/jao/consult-notmuch") + (synopsis "Search and preview notmuch emails using consult") + (description "\ +This package provides two commands using consult to query notmuch +emails and present results either as single emails @code{consult-notmuch} +or full trees @code{consult-notmuch-tree}. + +The package also defines a narrowing source for @code{consult-buffer}, whi= ch +can be activated with @code{(add-to-list 'consult-buffer-sources +'consult-notmuch-buffer-source)}."))) + (define-public emacs-marginalia (package (name "emacs-marginalia") =2D-=20 2.32.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDltl8PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6weIIP/i54f54VyVru8V3bqGpBPCyPLkFlSO8Ypo8F cxrjgTz9wDQHq3D3lxKluE3hnb4nomTsn9YPE8Re6K3YOKci/dpaceMLnJqW7mBk yK6A8xLJCXPrwRNOuuj6UJ8YhW4gPZOW0WjvcIPVNS/zIinP1Ure/XCjxEtFcHPr BL5rpyQjaV4vFjKAvChjgMs7jZ6gm2MznGeedZGA2tL3knxYsyN83a6Cd48IG1KS 4EGINsZkgJrOEi0llR0QgGxCU6+Ol4BwF9DF2akCn6nDVEOyYCFM34eYueuXkag1 9OIMrnGtqyR6JpHkkhwczod2d0u3wGYuwOHIdkkzLhY+ep5FwB31YnYLoFKg4rTx q/rgtB/FWNyKE1vnRFsZaNDg2ZJUb4tcvl+/0LHmZkPH9auxK9HMfSFDrDKtesj9 J/r2a6E2wgcVrypzdY6UR9m2VwS9UWQSbUKd9e0HqSEyirzWOH/ntPtWIiCAL7l2 D/kgFjtjTGIYKEifOX4DXeP9Iz3VHgvTsgKo3KXyjKo4JbitSA3w7h0MW/rlORjs 5Goktz6iH0zWYWgpGhgvTEfJ/8aj3inAV0R/rXl/mHhblEiptW4+D5rLcdNMUHrF 5g7AboKswG9dtxztA63RD+Ot7ZANUG84fIMrD9PDw5OIVgwC1avR4WPGw2leZzw3 dwrvxgS0 =/H0J -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 10:19:02 2021 Received: (at 49457) by debbugs.gnu.org; 7 Jul 2021 14:19:02 +0000 Received: from localhost ([127.0.0.1]:53166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18OE-0000CJ-2u for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:19:02 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18OA-0000Bl-Ck for 49457@debbugs.gnu.org; Wed, 07 Jul 2021 10:19:00 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 6FEC8E001C; Wed, 7 Jul 2021 14:18:51 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> Date: Wed, 07 Jul 2021 16:18:50 +0200 In-Reply-To: <87r1gaw6u8.fsf@trop.in> (Andrew Tropin's message of "Wed, 07 Jul 2021 17:12:47 +0300") Message-ID: <87czrutdf9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: > v2 uses propagated-inputs instead of inputs, because using > consult-notmuch without consult and notmuch doesn't make much sense. Thank you. However, notmuch should be an input, there's no reason to propagate it into user's profile. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 10:33:46 2021 Received: (at 49457) by debbugs.gnu.org; 7 Jul 2021 14:33:46 +0000 Received: from localhost ([127.0.0.1]:53192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18cU-0000aK-CO for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:33:46 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:37575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18cR-0000a5-DX for 49457@debbugs.gnu.org; Wed, 07 Jul 2021 10:33:44 -0400 Received: by mail-lf1-f42.google.com with SMTP id v14so4450617lfb.4 for <49457@debbugs.gnu.org>; Wed, 07 Jul 2021 07:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=qWM3sz5j8dUb9TxbiMlQpghl7nLt984A/PX1d+e1aO0=; b=aS/EqQwMssBuQjHfw41OVGaBzKls8slERDLxLYjPp/VPba5DwyMzCUMBq9TbWhs9Tl tpefa6xF/Oxnqmv59VU/T1LNtXAb0K79lIvpL5NKfMrRGxOCGYqPjh1b0lurgRoz9nxv kKaKsriXgzAP0Nz+XinNQO1gQRLGvD6xgAE7ENu0orZbX32zqIqc4xTw7yOG73zb76OG jfnTmg5ijQEOSxH00BjQ5YViuILZhQL2vX46HNfSIVC23R5777wLLA5TVQTgOWPmLlOr atgdkHJXBoS7B8TMvV/z/1jtTxeYS+rC+gikSDu3N/gadElfETJpOrsmJ8s7l5CsjiZv WpRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=qWM3sz5j8dUb9TxbiMlQpghl7nLt984A/PX1d+e1aO0=; b=J3JkiLv0a/vMS3Ha9dn7upcOQBbBXMOUZBZNuSdhF4DMp8X8Dbx9PSDTjkqNULTNzr SbeDn8QxXJVX5tPhj3ZRn3eLAyzPVpByq8yjifgH0/8SlpzB7qxesl/NMrQ5aMCmu47W /moi+Msw8Xghsuqnu93idCJ+PL86IJhwJ53CFxJ5/SP7+MyO94wsTmRgSnROSXKghYyj E/KQzQT6sPJZnB7SiXb98fqwAOlINHqF8X4F6+LdELTxWRvKyMKaCN0SqyZDiCXlMyi+ eb9i8wphK4dBwO+9ydXP1ll0aF/rpdckcmbhNsSQviEVv60IsAdUvUs1I8Jw+4X+Eray +Ygw== X-Gm-Message-State: AOAM5332H23Dd/+Eq0iSKijLjQgbc5EG28QKBBs9uAzcOcVWCfKG7JSP 8nZELdudFZxBnPQFX0IiWcRzBQ== X-Google-Smtp-Source: ABdhPJxEWPLeitDRVTgF1x+yj/q8mwIYYfh/8YImEwwpLiexgzaG/mKqpDBXE9V25Vbd4cqzk2tqOg== X-Received: by 2002:a19:5018:: with SMTP id e24mr385832lfb.29.1625668417331; Wed, 07 Jul 2021 07:33:37 -0700 (PDT) Received: from localhost (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id e23sm1680960lfq.221.2021.07.07.07.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 07:33:36 -0700 (PDT) From: Andrew Tropin To: Nicolas Goaziou Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <87czrutdf9.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> Date: Wed, 07 Jul 2021 17:33:33 +0300 Message-ID: <87eecaqjlu.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > Andrew Tropin writes: > >> v2 uses propagated-inputs instead of inputs, because using >> consult-notmuch without consult and notmuch doesn't make much sense. > > Thank you. However, notmuch should be an input, there's no reason to > propagate it into user's profile. There is a (require 'notmuch) in consult-notmuch code, so we need notmuch.el on the load-path, sadly, but we don't have a separate emacs-notmuch package for it and therefore we have to propagate the whole notmuch package here :( --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDluz0PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wPRIP/2m+h10PRoj+GSQn+YITRzlLOK0JGKjhsQ+V NgWtZVOQD+apsnyEszkKUoKKw0tWzfXzFz+aundsbJArBeVSC1eY1bqLKcSD7dS+ S6qIxPHjX6qovhFqH6tgaNbYA/YdZTUgnJ0GRCu9D6U2pK4Dhh9vTbkfy5S3qpnx Gap/YhHPwMNJNG1psoMoySbrNFJkpknDvaol0nk0Rw23I9FwguBuJHITteGTcXa4 1cAJ0HBw2mlHRbpYqmyMbqjAFxcJH+RGnm8KHr6tU5TClDAHR78zCVtHTNVBnkAf mMrvIbFrzS9HCZqKQo1pug8kKkYpD0lMJ6BSWGoQbxnxm88JuvbYLamOuX2ZWcDt AI6AUlMoMWrmi35L9qYU/ZocHY2zDjhOx98/X8GkYVJ1g/Ce4usyVCvfRLw93FGJ Syhse1t1lQ7zvXiAXP5R5X3i/fHCoffAXt0uJuKEsA/5G81t6u4mIKdQqn7jZP82 VnAmTd9dv4bxhPvJ2xJwZTz8gLNyXR+vcvjt0oANdOAzcQTI9uwVtOZ/GcBNkUPY bm/8ClChJtlJubT5Nnhge5iQf0Eelxc8tHjbMN08z82c5vQ2UKoFgj+vQnZ5/A1G Mgr7yJ4RCGYQjZ1azpyM99PBC69tcqcZSkbxXa2/Jl9ZEbfulFy08ZGn8JwHYCE8 a7A/syCp =H6hp -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 03:40:25 2021 Received: (at 49457-done) by debbugs.gnu.org; 8 Jul 2021 07:40:25 +0000 Received: from localhost ([127.0.0.1]:54169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Oe0-0004F6-PV for submit@debbugs.gnu.org; Thu, 08 Jul 2021 03:40:24 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:34889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Ody-0004Er-Ko for 49457-done@debbugs.gnu.org; Thu, 08 Jul 2021 03:40:23 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 6896F200010; Thu, 8 Jul 2021 07:40:15 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> Date: Thu, 08 Jul 2021 09:40:13 +0200 In-Reply-To: <87r1gaw6u8.fsf@trop.in> (Andrew Tropin's message of "Wed, 07 Jul 2021 17:12:47 +0300") Message-ID: <87czrtqmn6.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457-done Cc: 49457-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: > v2 uses propagated-inputs instead of inputs, because using > consult-notmuch without consult and notmuch doesn't make much sense. I applied this patch with the following changes: > + (uri (git-reference > + (url "https://codeberg.org/jao/consult-notmuch.git") I removed the ".git" suffix. > + (license license:gpl3+) > + (home-page "https://codeberg.org/jao/consult-notmuch") > + (synopsis "Search and preview notmuch emails using consult") I properly capitalized synopsis (Notmuch, Consult). > + (description "\ > +This package provides two commands using consult to query notmuch > +emails and present results either as single emails @code{consult-notmuch} > +or full trees @code{consult-notmuch-tree}. > + > +The package also defines a narrowing source for @code{consult-buffer}, which > +can be activated with @code{(add-to-list 'consult-buffer-sources > +'consult-notmuch-buffer-source)}."))) I shortened the description as it looked like an introduction part of the manual instead. I also reordered licence, home-page, synopsis and description parts. Thank you! Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 03:41:18 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 07:41:18 +0000 Received: from localhost ([127.0.0.1]:54176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Oes-0004H6-2g for submit@debbugs.gnu.org; Thu, 08 Jul 2021 03:41:18 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1Oeo-0004Gr-Jk for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 03:41:16 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 9EE3CFF808; Thu, 8 Jul 2021 07:41:07 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> Date: Thu, 08 Jul 2021 09:41:06 +0200 In-Reply-To: <87eecaqjlu.fsf@trop.in> (Andrew Tropin's message of "Wed, 07 Jul 2021 17:33:33 +0300") Message-ID: <878s2hqmlp.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Andrew Tropin writes: > Nicolas Goaziou writes: >> Thank you. However, notmuch should be an input, there's no reason to >> propagate it into user's profile. > > There is a (require 'notmuch) in consult-notmuch code, so we need > notmuch.el on the load-path, sadly, but we don't have a separate > emacs-notmuch package for it and therefore we have to propagate the > whole notmuch package here :( Duh! You're right, of course. Applied, as detailed in another message. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 05:34:56 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 09:34:57 +0000 Received: from localhost ([127.0.0.1]:54352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1QQq-0007DX-NG for submit@debbugs.gnu.org; Thu, 08 Jul 2021 05:34:56 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:42546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1QQp-0007DK-0x for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 05:34:55 -0400 Received: by mail-wr1-f47.google.com with SMTP id r11so1420842wro.9 for <49457@debbugs.gnu.org>; Thu, 08 Jul 2021 02:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=hJor7GZONcc1RCwFjkYDLjt04JXyfO9YQbOY2PzwU4E=; b=YrrbltAhKOOCioWXyNWrd2I94ChHmEsZlD1I6RahPM9mgvokjnd5PBfWHaKS4Mruy1 4Th9KaGLe8ahhiCsOjCk7ZSFe2AnlOuuZAxrCGCP7dcHrUsPXeef0dyQhyn2IWcjyCnb VOD06xKMNr4NZr5M5aamNEKACdZ6cylLoe1rQHgXX/YQFjDu8xTOnWt6OHCRS3+tZ9cm HjVTdUogmByGeGDOx9F+PjsaqjmF2/dh2ZIbmIW0UiQq0ND+BRfjVf1o3JxmUpY7hXzs bcH1rbBJKemE/udyeDDrXOpw8V+ewi3PHi72QtMtU6lBSHAbuXQJnY00SZbjyXSy+woN J34w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=hJor7GZONcc1RCwFjkYDLjt04JXyfO9YQbOY2PzwU4E=; b=B2FNnlh+uKMv7xgDksyu4UmenaAYhLcFpesO4Nh6FazCAmZwm7BBeGBFvUijGppOwx 6dSxAjRRkfNeOA+t5MYfypLOqxsh6xRk6+8lYwb4who1vWVNYRHSQtiOMYH9ZTef7eDA xGYxXwvI2Ip4zGV0C9P5WmQMHNn+sZObuF9IyV7EFr/EjQGTeG+WwX8M/3Z5dB1euCBA auVcyEKAzPli/JdsZKZGj8vlfCnwSXRBEW8HfuXkSRh4vY6HUS3PWziTk9fNPpzm4Wnf StWVDCtLsd+yFSfHFPp3v+gfE8mrbnTdF9/3w3o4OoPr3npIgoleOzIcHz6TIU1r0fmT scjg== X-Gm-Message-State: AOAM532Rrw/HPpvsGqHZpx/pwp0Z/9hVwvqmyS8WjaumNHU222/9aFLs mwAv6LYgRSD2w7Jj+zWkrD52xv2tZeA= X-Google-Smtp-Source: ABdhPJwCx4GS99tp/DQR5H3D5xPgQxvKvaHT43iNb4cbUbnr/21q6arOxE4wvp0Lo4Apk6dbRVqiaA== X-Received: by 2002:a05:6000:1b8c:: with SMTP id r12mr24985775wru.427.1625736889128; Thu, 08 Jul 2021 02:34:49 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t9sm1618849wrq.92.2021.07.08.02.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 02:34:48 -0700 (PDT) From: zimoun To: Nicolas Goaziou , Andrew Tropin Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <878s2hqmlp.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 11:13:37 +0200 Message-ID: <86bl7d2mny.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, (Sorry for this naive question.) On Thu, 08 Jul 2021 at 09:41, Nicolas Goaziou wrot= e: > Andrew Tropin writes: >> Nicolas Goaziou writes: > >>> Thank you. However, notmuch should be an input, there's no reason to >>> propagate it into user's profile. >> >> There is a (require 'notmuch) in consult-notmuch code, so we need >> notmuch.el on the load-path, sadly, but we don't have a separate >> emacs-notmuch package for it and therefore we have to propagate the >> whole notmuch package here :( > > Duh! You're right, of course. For my personal understanding because I am not familiar with Emacs packages and package propagation. The package =E2=80=99emacs-magit=E2=80= =99 has =E2=80=99git=E2=80=99 as inputs and AFAIK it does not work without Git installed in the profile. Why is it different? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 05:41:33 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 09:41:34 +0000 Received: from localhost ([127.0.0.1]:54364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1QXF-0007Ns-MN for submit@debbugs.gnu.org; Thu, 08 Jul 2021 05:41:33 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:33085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1QXC-0007Nc-Sn for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 05:41:32 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 5CC57FF816; Thu, 8 Jul 2021 09:41:22 +0000 (UTC) From: Nicolas Goaziou To: zimoun Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> Date: Thu, 08 Jul 2021 11:41:22 +0200 In-Reply-To: <86bl7d2mny.fsf@gmail.com> (zimoun's message of "Thu, 08 Jul 2021 11:13:37 +0200") Message-ID: <87h7h5p2gt.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org, Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, zimoun writes: > For my personal understanding because I am not familiar with Emacs > packages and package propagation. The package =E2=80=99emacs-magit=E2=80= =99 has =E2=80=99git=E2=80=99 > as inputs and AFAIK it does not work without Git installed in the > profile. Why is it different? It is different because Notmuch is both an external executable and an Emacs library. Git, OTOH, does not ship with an Elisp library. However, I think it is a bug if Emacs Magit does not work with git in profile. We should modify the source so both magit-git-executable and magit-gitk-executable point to those from inputs. I suggest to open a new bug report about it, WDYT? Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 06:14:50 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 10:14:50 +0000 Received: from localhost ([127.0.0.1]:54385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1R3S-0008As-07 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 06:14:50 -0400 Received: from mail-lf1-f54.google.com ([209.85.167.54]:46966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1R3P-0008Ae-2i for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 06:14:49 -0400 Received: by mail-lf1-f54.google.com with SMTP id x25so1026591lfu.13 for <49457@debbugs.gnu.org>; Thu, 08 Jul 2021 03:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=dlK9yIfxEITiGiQcHTowExc/5YIl7D9dwoKSdi228TU=; b=GzfEew8QV98a7Ps/+riP128v1qLBanAgHuRn/hwfGPkO1N1+hlNeoj5qpaM/agBy9z T+ZGFzjG9nQpXU75wUjhP0J5l41UjYxe7DHdlVq31H9ppC1abGq7jcN2chPFMewkHTj4 HuNOQzhGryVPNomgDNqgVan7XWIPbZkOe5bkar9YGjVNx6fVYRFhy9OGLjR5g/n59owA X//8AVL46SNZkTAUQ9JzMxmampalMHmphyIFZOftRLIOuD7FrNcFM47SGWRZAy7WuJIF QEtsG6g/dzWJUsuEfZFOVrg4wmZiPoqRTtin79hLBkJJirRqo2WByXPHR0RNhI664Msg 574A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=dlK9yIfxEITiGiQcHTowExc/5YIl7D9dwoKSdi228TU=; b=bPb6E6IeVsQDqt5JaZoE1j/nNbMqg+NhXsaWyP6XRDcjrYf5ncZOcQ/XMK31+H84EY 4QkxHkg29XlrDKZ5DVJzAGmc+i1DL2QCbP2TEVVv25mx4co43GMjgWYHeD5w5yvxEWfq HWxjdOD9bkQNNNAGOYf/Y306zDOPiMfQSJMsW4zNe/F5L5XeNErnk1FptB9XfFqfNsXc NWS5qI66w5AG5omyEKH8/a8te1hirYAjL6JKkxHqLfDXViVcHTlQSlpows7Q78VoOLjP yp4a9qbEfoW2XU76O8H3Wj2obQDdf4CcRF1c4y6YebSTcTAGS1EUbsPcQjimlvZ2pxYA VejQ== X-Gm-Message-State: AOAM532pnptNfMSj9cIKjZB7c4ULllnmQIK+D47JsyrlqlTCNh6wXHQa s2B3OeG3LmI33KyxJWzQEhtdfg== X-Google-Smtp-Source: ABdhPJxUMMvlrkffT62tnfbKun3rnZynKO9hw4sKe41mSSdX8ITidW/OqtvFNrMV91Lh1LRV6hgnRg== X-Received: by 2002:a05:6512:308c:: with SMTP id z12mr19263103lfd.272.1625739280724; Thu, 08 Jul 2021 03:14:40 -0700 (PDT) Received: from localhost (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id i13sm150808lfc.111.2021.07.08.03.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 03:14:39 -0700 (PDT) From: Andrew Tropin To: zimoun , Nicolas Goaziou Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <86bl7d2mny.fsf@gmail.com> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> Date: Thu, 08 Jul 2021 13:14:34 +0300 Message-ID: <871r893yet.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49457 Cc: 49457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable zimoun writes: > Hi, > > (Sorry for this naive question.) > > On Thu, 08 Jul 2021 at 09:41, Nicolas Goaziou wr= ote: >> Andrew Tropin writes: >>> Nicolas Goaziou writes: >> >>>> Thank you. However, notmuch should be an input, there's no reason to >>>> propagate it into user's profile. >>> >>> There is a (require 'notmuch) in consult-notmuch code, so we need >>> notmuch.el on the load-path, sadly, but we don't have a separate >>> emacs-notmuch package for it and therefore we have to propagate the >>> whole notmuch package here :( >> >> Duh! You're right, of course. > > For my personal understanding because I am not familiar with Emacs > packages and package propagation. The package =E2=80=99emacs-magit=E2=80= =99 has =E2=80=99git=E2=80=99 > as inputs and AFAIK it does not work without Git installed in the > profile. Why is it different? The magit package itself will be loaded correctly, because its emacs package requirements are satisfied and even some functions will work, for example magit-dispatch will show a transient interface. Other functions that rely on git binary will throw an error and there are two solutions for that: make a git a propagated input or set `magit-git-executable` to a path to the git binary inside store, which will make magit work with git as a regular input. notmuch in contrast to git provides not only notmuch binary, but also notmuch.el. consult-notmuch requires only notmuch.el, which have to be propagated and doesn't depend on notmuch binary, but because notmuch.el is a part of notmuch package the binary will be propagated too. The possible solution here is to split notmuch into two packages: notmuch and emacs-notmuch, so we will be able to set `notmuch-command` variable for notmuch.el and have notmuch as an input, but not installed in the profile. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDm0AoPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6w85EP/04IAKbb1Q7ENk1nZqXXIHLlfeMs0MrcanRS VPqE2h3H8KBI7evHd+0bEfoq/dUqmTsYgAHcVTlv0giHFUccP9cD0E+YHHgIj8TS uzFRhV4d3KocXdX0a3wNRFWXZhjG2RdkhXHEE16CFToJECpq+ZzW1U87WrKCSsv+ F6AhH1gZKH8JFjySZV+jodgdoA82N1OEceDZMzAoNAf3QoLmM3N02z8lI/UShjEp vd41bquvJawAQFpxYKTf/hCkQCi5LCEJI4yzbLQA6Sov8Yv4wI4+txnqAUXtTjUS 1WDG+wbFL2JZCQIRHDL1V28WvTkw8zcWXXT6xens2r8tYlmLqHacc7vqmO59Wpxk G1A8sLIMXHyQLRDCKBOOiaf8GancdjFanHx+7VwkIYluNonI9z8BI6gPvzUuIXZC 68AWcj46+wV90yAIXfxHaCLCvpuhL0O5BMvLNc/7TtW0ahdtgljnJiOoidSdabOi hDZv8VNWt9sVLi8vVjLC3+5UvdlAa5QrOaYa64AoS/NK+zJQ/b4UR+Is7Pq7VmmZ njX4ucamj1ru4ODq1Bhxb4dMb4Tuqh0LTWi803Mto1wo4NC167cRV1k0ab5nVcXx Z2WhgvwlVGk/7voMja9tDpmUbbniwxyUtDgLXbkQZLf3a4AMgPH1j2SbAR8S/QLU IkuA5RhY =2F/J -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 06:22:17 2021 Received: (at 49457-done) by debbugs.gnu.org; 8 Jul 2021 10:22:17 +0000 Received: from localhost ([127.0.0.1]:54390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1RAe-0008ML-QP for submit@debbugs.gnu.org; Thu, 08 Jul 2021 06:22:17 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:45697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1RAc-0008M4-M9 for 49457-done@debbugs.gnu.org; Thu, 08 Jul 2021 06:22:15 -0400 Received: by mail-lf1-f45.google.com with SMTP id p1so13765397lfr.12 for <49457-done@debbugs.gnu.org>; Thu, 08 Jul 2021 03:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=cFaQPMWM/1HzQB/kdSBEhDpbM251b3+hjKDu1/1bjOc=; b=CGeFBuWz8D+TG1lhOyRYyv67ducOd/sb7guFtOCm41DC6AVCuuyf5af+IgNCaMcm30 nbjL17IJF/asZ30gyKRyFEjBWEo/rCg32moITnlRw1AWrQJaA04zyzInHplFnOcMmkyZ AyDWMG4eau5DMhzRLVJ0B/iO6WwvNre+ZzERHS1MHDQ0t3V0JPfpUtO7LzZ/a8mv0UfR JoH+OEKLfeVDwNiVNxxhQwbQ364oOszm00Mzmj2uHiJxRKBL9s07uY34/ORFMWb6NFmx dRVeBUMPQVzsGnLb+9jQatqmMWayMSWmuRz2AHtcsiUEn2KB2F0YaavjHyqws4E4wpJk 4Jeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=cFaQPMWM/1HzQB/kdSBEhDpbM251b3+hjKDu1/1bjOc=; b=oV3YJkh6msJjwZek3uPwSnXLTiiB7jXryFYpTlLi/YiLzupA1JvnXKZZcF+HlWREzS VjMeHRTJc8tdQ33iYyFRtaMESeoFEG1YfDHPLPsb/ht896M2gTTIiKSY5bGCc/rht4ac n9+r+nfr9lNUrscIb+UBqcSOGZDW8EYmF+PniC/bzDtHpTfa8XEMTTn8eSFDQCbqS+bX ldeDjae9KfCBa9Wj8g+JM/ROui2C5W1lzEK1xBaQ8jbghNLuJFeXA5OzPpxekL2oWUfg xMxAL7hMXxzxqlxRChHRCY9wbpJzlFEt+b7pUVAFY5ENQAJ0/DElvF84sKYuuG3ZQUbJ 7eEQ== X-Gm-Message-State: AOAM5335ugYmfqavwbWN5gglu5LUuFtpz1fD7q1JAwx1T8e8MY6kYnhs vlI4yiePfOwSvjpT3KQc2jbH0A== X-Google-Smtp-Source: ABdhPJzAOyIcbGIjnUW0wsKBU6tHytoWcKWsNs+hvTBdpDguV3AH/4ECI40FnUhgALH2FhGbsYGYVw== X-Received: by 2002:ac2:4e15:: with SMTP id e21mr16381663lfr.245.1625739728695; Thu, 08 Jul 2021 03:22:08 -0700 (PDT) Received: from localhost (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id h23sm198570ljg.23.2021.07.08.03.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 03:22:07 -0700 (PDT) From: Andrew Tropin To: Nicolas Goaziou Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <87czrtqmn6.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrtqmn6.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 13:22:03 +0300 Message-ID: <87y2ah2jhw.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49457-done Cc: 49457-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > Andrew Tropin writes: > >> v2 uses propagated-inputs instead of inputs, because using >> consult-notmuch without consult and notmuch doesn't make much sense. > > I applied this patch with the following changes: > >> + (uri (git-reference >> + (url "https://codeberg.org/jao/consult-notmuch.git") > > I removed the ".git" suffix. > >> + (license license:gpl3+) >> + (home-page "https://codeberg.org/jao/consult-notmuch") >> + (synopsis "Search and preview notmuch emails using consult") > > I properly capitalized synopsis (Notmuch, Consult). > >> + (description "\ >> +This package provides two commands using consult to query notmuch >> +emails and present results either as single emails @code{consult-notmuch} >> +or full trees @code{consult-notmuch-tree}. >> + >> +The package also defines a narrowing source for @code{consult-buffer}, which >> +can be activated with @code{(add-to-list 'consult-buffer-sources >> +'consult-notmuch-buffer-source)}."))) > > I shortened the description as it looked like an introduction part of > the manual instead. It was complete) but shorter version is also fine. > > I also reordered licence, home-page, synopsis and description parts. > > Thank you! Thank you!) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDm0csPHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wWj4P/jwzmqEWibQLWRMxzRM3Eh+ECQMkhyOVPhAe bZBGUdNGgVuK6TljRxv0a8MjTd667WwvKK8doKwppzJfldbgbKOWh8m8awKkOV15 i8XLHprgmSaeywnJih0FBdIXaZ8OKIdiL3maA9I1Fe5xCtDPO6kmtdaPZke4zBe2 Jt+xHtHQMACxPFQHdQbZ6ZVdgQYDNujq00x9StuQvALov60qdkkbNPG74MQxq70B mO41iT9kH9i2ZnxPihlel96aJZ/UU6lSgVI6WfP+4E9nXEvsMAZRzHvV/a2KXUov dDfxc0eVckREmH4W1D642snpUiRN/PrWTYHsLlnPfYeyxFJWXZfljmj3/np8dFCB YKdonOykjdEUKrwP2PxwP+qoBbdtmH0NceewOYX84akw6vlgZgcjni4sfijtft9t LRkT/PHhZC7r+QBNcQjG9pY4JduXy9hzmvDSA+tTbSoE9cRMADI2I5qX9MTNV7dM 0VjqxghPmCpaDAcfkemZIDPhuzo4jA5rZ49aqaVRSMJgz0Qb4FKS/Jh6d7M9O0Vs M/z+zZARbetvae/Zm5mGsFJ5TGY5nXKXxEutRxQ9WP/TKLLucbF9pJY8b6NQ7ink DQQ3855ogG/1wFxFs58xcDnnZHtcbFrzmElqCQsWnIXoCpk9IsbxP8Zi3G9mgvdm SN4QDovJ =Myfp -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 06:32:21 2021 Received: (at 49457-done) by debbugs.gnu.org; 8 Jul 2021 10:32:21 +0000 Received: from localhost ([127.0.0.1]:54396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1RKO-0000JQ-SZ for submit@debbugs.gnu.org; Thu, 08 Jul 2021 06:32:21 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:40677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1RKL-0000J9-1w for 49457-done@debbugs.gnu.org; Thu, 08 Jul 2021 06:32:19 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 244311C0003; Thu, 8 Jul 2021 10:32:09 +0000 (UTC) From: Nicolas Goaziou To: Andrew Tropin Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrtqmn6.fsf@nicolasgoaziou.fr> <87y2ah2jhw.fsf@trop.in> Date: Thu, 08 Jul 2021 12:32:09 +0200 In-Reply-To: <87y2ah2jhw.fsf@trop.in> (Andrew Tropin's message of "Thu, 08 Jul 2021 13:22:03 +0300") Message-ID: <87v95lnljq.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457-done Cc: 49457-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Andrew Tropin writes: > Nicolas Goaziou writes: >> I shortened the description as it looked like an introduction part of >> the manual instead. > > It was complete) but shorter version is also fine. Yes, it was complete. What I meant is the following: when I look at a description, I try to see what kind of question it answers. If it answers the question: "Do I want to install this package?", that's good. But if it answers: "How can I start using this?", then the description belongs to a manual instead. For example, which can be activated with @code{(add-to-list 'consult-buffer-sources 'consult-notmuch-buffer-source)}. clearly belongs to the second question. So does the name of functions, in general. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 07:28:53 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 11:28:53 +0000 Received: from localhost ([127.0.0.1]:54446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SD7-0001hS-53 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 07:28:53 -0400 Received: from out1.migadu.com ([91.121.223.63]:13115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SD4-0001hI-5D for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 07:28:51 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1625743728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cumhdp1dl0Kq/89Eryft+xh9435IFJ9Vak1/Dcx+SQs=; b=Dyhzg3MQ9aSqZZlFIe4Xtu8zJvzF/QJzkZ8uKd9K+FuaZ3vZgDRu2HGHe6JSf2cgWY8oUW nZBrjyFfaCJtFyHm+hcsKeX70lFd77cjdO0+c0at+ctPt0aP0m9FOoDnzVuxjWAPeVaZ9m JmIYESO7DWpwlOXuFUhO5c6f8oIkSoVoXdeBk58klAI2JPhfWwFI/qEyqKc4uC6r7BbqH7 mKcKLaZGLKL+f759a0C7OlV94zw0WDHPzt7J/O99IiHgpoF3YPdSTfgFtXzGRp4O74OKTG L17gXowkiR2WX4CFgkrQQbOyi1Vayu8uE4MAjZ4Xwn8oU88P2x8a2+GUzW9OFw== From: Kyle Meyer To: Nicolas Goaziou Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <87h7h5p2gt.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> <87h7h5p2gt.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 07:28:36 -0400 Message-ID: <87mtqx82or.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyle@kyleam.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: Andrew Tropin , 49457@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicolas Goaziou writes: > However, I think it is a bug if Emacs Magit does not work with git in > profile. We should modify the source so both magit-git-executable and > magit-gitk-executable point to those from inputs. > > I suggest to open a new bug report about it, WDYT? Rewriting magit-git-executable to an absolute file name will break Magit for those that use it over TRAMP. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 07:38:25 2021 Received: (at 49457) by debbugs.gnu.org; 8 Jul 2021 11:38:25 +0000 Received: from localhost ([127.0.0.1]:54458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SML-00047R-20 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 07:38:25 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1SMI-00047D-RD for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 07:38:23 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 996811C0002; Thu, 8 Jul 2021 11:38:15 +0000 (UTC) From: Nicolas Goaziou To: Kyle Meyer Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> <87h7h5p2gt.fsf@nicolasgoaziou.fr> <87mtqx82or.fsf@kyleam.com> Date: Thu, 08 Jul 2021 13:38:14 +0200 In-Reply-To: <87mtqx82or.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 08 Jul 2021 07:28:36 -0400") Message-ID: <87k0m1nihl.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: zimoun , 49457@debbugs.gnu.org, Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Kyle Meyer writes: > Nicolas Goaziou writes: > >> However, I think it is a bug if Emacs Magit does not work with git in >> profile. We should modify the source so both magit-git-executable and >> magit-gitk-executable point to those from inputs. >> >> I suggest to open a new bug report about it, WDYT? > > Rewriting magit-git-executable to an absolute file name will break Magit > for those that use it over TRAMP. Point taken. However, such users can fix it by modifying the `magit-git-executable' defcustom again, can't they? So, the situation would arguably not be worse that what it is currently, since it simply doesn't work for users relying on a local installation of git, and those are probably more common. Also, a third option: since we're not making use of git input at runtime, why should it be an input at all? If it is needed at build time, a native-input should suffice. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 20:13:10 2021 Received: (at 49457) by debbugs.gnu.org; 9 Jul 2021 00:13:10 +0000 Received: from localhost ([127.0.0.1]:57881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1e8k-0003Vu-0S for submit@debbugs.gnu.org; Thu, 08 Jul 2021 20:13:10 -0400 Received: from out1.migadu.com ([91.121.223.63]:26526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1e8e-0003Vd-OK for 49457@debbugs.gnu.org; Thu, 08 Jul 2021 20:13:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1625789582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=huAIOLAakmcX6eNa3yMqBSKErLwYduP8jFgh5GvQF+w=; b=cowbYImXxY5wnF01Xbi+B+qin/kP1krlN/rx3L9hRXDxXubQtNhgJnOX/82M1qf+/iU1Cm v+P2ApUOicPZhz2rfa5O7q1gcPzDNCBlsjN3fmt844lRK0ryrFmINTNCntX/nHkbAt3CX6 ZVvRl5niYIXipDmQgdkiWI8HiGaCFHSyN+JK1VObzX0bNApUO7KvJNOWV2IZVC3tszdJRb x6Y4z2tjUE0Vlz3Po2wIqZIm+rWzKab44yMWibFu2YvgnvaJ9LehHl8h6cksMQOSXoSV54 jZQDqU9D7n6ODfBmthlX/sQ1sZmmG7pN6RfJ5Ja+cAYLAX0vvEMS7Pwtc/jxNQ== From: Kyle Meyer To: Nicolas Goaziou Subject: Re: [bug#49457] [PATCH v2] gnu: Add emacs-consult-notmuch. In-Reply-To: <87k0m1nihl.fsf@nicolasgoaziou.fr> References: <87tul6w7g2.fsf@trop.in> <87r1gaw6u8.fsf@trop.in> <87czrutdf9.fsf@nicolasgoaziou.fr> <87eecaqjlu.fsf@trop.in> <878s2hqmlp.fsf@nicolasgoaziou.fr> <86bl7d2mny.fsf@gmail.com> <87h7h5p2gt.fsf@nicolasgoaziou.fr> <87mtqx82or.fsf@kyleam.com> <87k0m1nihl.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 20:13:00 -0400 Message-ID: <87im1k8hv7.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyle@kyleam.com X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49457 Cc: zimoun , 49457@debbugs.gnu.org, Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicolas Goaziou writes: > Kyle Meyer writes: > >> Nicolas Goaziou writes: >> >>> However, I think it is a bug if Emacs Magit does not work with git in >>> profile. We should modify the source so both magit-git-executable and >>> magit-gitk-executable point to those from inputs. >>> >>> I suggest to open a new bug report about it, WDYT? >> >> Rewriting magit-git-executable to an absolute file name will break Magit >> for those that use it over TRAMP. > > Point taken. However, such users can fix it by modifying the > `magit-git-executable' defcustom again, can't they? Sure. Given the number of "oops, some change didn't consider tramp compatibility" bugs that crop up in Magit, my guess is that Magit is widely used over TRAMP. So, potentially many users are affected, but I agree it's an easy fix once they spend time to debug what the issue is. (That collectively could amount to a lot of wasted time, so in my eyes it depends on what the practical problem being fixed is.) > So, the situation would arguably not be worse that what it is currently, > since it simply doesn't work for users relying on a local installation > of git, and those are probably more common. Hmm, I'm not clear on what the current problem is; a user will typically have "git" on their path one way or the other. Given Magit's heavily used, I would have expected to see many Guix bug reports about about it if it were a problem in practice. But 1) perhaps I'm missing something or 2) perhaps for philosophical reasons or to promote best practices rewriting magit-git-executable is worth the breakage. My drive-by comment was just to mention the possible breakage [*]. (I don't have a personal stake in what's done because I don't install Magit from Guix.) > Also, a third option: since we're not making use of git input at > runtime, why should it be an input at all? If it is needed at build > time, a native-input should suffice. Yeah, that sounds right (though I haven't tested it). [*] And it might not break things for much longer. On Magit's end, Jonas recently floated the idea of not using magit-git-executable when using TRAMP. https://github.com/magit/magit/issues/4433#issuecomment-875964528 From unknown Sun Aug 17 09:10:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Aug 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator