From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 23:18:17 2021 Received: (at submit) by debbugs.gnu.org; 7 Jul 2021 03:18:17 +0000 Received: from localhost ([127.0.0.1]:50514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0y4n-0003JO-B5 for submit@debbugs.gnu.org; Tue, 06 Jul 2021 23:18:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:47834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0y4m-0003JH-H4 for submit@debbugs.gnu.org; Tue, 06 Jul 2021 23:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0y4m-0001Fl-99 for guix-patches@gnu.org; Tue, 06 Jul 2021 23:18:16 -0400 Received: from mail.ftbfs.org ([52.8.68.13]:37492 helo=aws.ftbfs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0y4k-00078H-Ml for guix-patches@gnu.org; Tue, 06 Jul 2021 23:18:16 -0400 Received: from ip68-228-72-85.oc.oc.cox.net ([68.228.72.85] helo=localhost.localdomain) by aws.ftbfs.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0y4i-0005JH-4c; Wed, 07 Jul 2021 03:18:12 +0000 From: Matthew James Kraai To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-deadgrep: Add missing input. Date: Tue, 6 Jul 2021 20:18:10 -0700 Message-Id: <20210707031810.27321-1-kraai@ftbfs.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No (score -1.0): ALL_TRUSTED=-1 Received-SPF: pass client-ip=52.8.68.13; envelope-from=kraai@ftbfs.org; helo=aws.ftbfs.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Matthew James Kraai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-deadgrep)[propagated-inputs]: Add ripgrep. --- gnu/packages/emacs-xyz.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Add ripgrep as propagated-input, as is done for emacs-ripgrep and emacs-rg. diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9591a4e6e7..029b20ee72 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20805,7 +20805,8 @@ accept and reject GitHub pull requests.") (propagated-inputs `(("emacs-dash" ,emacs-dash) ("emacs-s" ,emacs-s) - ("emacs-spinner" ,emacs-spinner))) + ("emacs-spinner" ,emacs-spinner) + ("ripgrep" ,ripgrep))) (home-page "https://github.com/Wilfred/deadgrep") (synopsis "Frontend for @code{ripgrep}") (description "This package provides an Emacs interface for performing -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 10:20:54 2021 Received: (at 49450) by debbugs.gnu.org; 7 Jul 2021 14:20:54 +0000 Received: from localhost ([127.0.0.1]:53172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18Q2-0000FB-H3 for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:20:54 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:52941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18Py-0000Eu-Tn for 49450@debbugs.gnu.org; Wed, 07 Jul 2021 10:20:53 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 48F80240012; Wed, 7 Jul 2021 14:20:44 +0000 (UTC) From: Nicolas Goaziou To: Matthew James Kraai Subject: Re: [bug#49450] [PATCH] gnu: emacs-deadgrep: Add missing input. References: <20210707031810.27321-1-kraai@ftbfs.org> Date: Wed, 07 Jul 2021 16:20:43 +0200 In-Reply-To: <20210707031810.27321-1-kraai@ftbfs.org> (Matthew James Kraai's message of "Tue, 6 Jul 2021 20:18:10 -0700") Message-ID: <878s2itdc4.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49450 Cc: 49450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Matthew James Kraai writes: > * gnu/packages/emacs-xyz.scm (emacs-deadgrep)[propagated-inputs]: Add > ripgrep. > --- > gnu/packages/emacs-xyz.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Add ripgrep as propagated-input, as is done for emacs-ripgrep and > emacs-rg. I think ripgrep should be an input. Both emacs-ripgrep and emacs-rg needs to be fixed, too. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 11:43:05 2021 Received: (at 49450) by debbugs.gnu.org; 7 Jul 2021 15:43:05 +0000 Received: from localhost ([127.0.0.1]:53270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19hY-0002Mi-VE for submit@debbugs.gnu.org; Wed, 07 Jul 2021 11:43:05 -0400 Received: from mail.ftbfs.org ([52.8.68.13]:18240 helo=aws.ftbfs.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19hX-0002MF-Eq for 49450@debbugs.gnu.org; Wed, 07 Jul 2021 11:43:04 -0400 Received: from 209.sub-174-195-207.myvzw.com ([174.195.207.209] helo=smtpclient.apple) by aws.ftbfs.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m19hQ-0007Q3-Mq; Wed, 07 Jul 2021 15:42:57 +0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Matthew Kraai Mime-Version: 1.0 (1.0) Subject: Re: [bug#49450] [PATCH] gnu: emacs-deadgrep: Add missing input. Date: Wed, 7 Jul 2021 08:42:55 -0700 Message-Id: <859C1BD7-D59C-4990-949F-376ADF47AF26@ftbfs.org> References: <878s2itdc4.fsf@nicolasgoaziou.fr> In-Reply-To: <878s2itdc4.fsf@nicolasgoaziou.fr> To: Nicolas Goaziou X-Mailer: iPhone Mail (18F72) X-Spam-Status: No (score -1.0): ALL_TRUSTED=-1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49450 Cc: 49450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Nicolas, I was trying to ensure that when emacs-deadgrep is installed, ripgrep is als= o installed. The former doesn=E2=80=99t need the latter to build but does r= equire it at runtime. Isn=E2=80=99t propagated-inputs the right field for t= hat? Sent from my iPhone > On Jul 7, 2021, at 7:20 AM, Nicolas Goaziou wrote= : >=20 > =EF=BB=BFHello, >=20 > Matthew James Kraai writes: >=20 >> * gnu/packages/emacs-xyz.scm (emacs-deadgrep)[propagated-inputs]: Add >> ripgrep. >> --- >> gnu/packages/emacs-xyz.scm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>=20 >> Add ripgrep as propagated-input, as is done for emacs-ripgrep and >> emacs-rg. >=20 > I think ripgrep should be an input. Both emacs-ripgrep and emacs-rg > needs to be fixed, too. >=20 > Regards, > --=20 > Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 11:53:17 2021 Received: (at 49450) by debbugs.gnu.org; 7 Jul 2021 15:53:17 +0000 Received: from localhost ([127.0.0.1]:53274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19rQ-0002ce-Ud for submit@debbugs.gnu.org; Wed, 07 Jul 2021 11:53:17 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:36459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m19rN-0002cM-VE for 49450@debbugs.gnu.org; Wed, 07 Jul 2021 11:53:15 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 08917240004; Wed, 7 Jul 2021 15:53:06 +0000 (UTC) From: Nicolas Goaziou To: Matthew Kraai Subject: Re: [bug#49450] [PATCH] gnu: emacs-deadgrep: Add missing input. References: <878s2itdc4.fsf@nicolasgoaziou.fr> <859C1BD7-D59C-4990-949F-376ADF47AF26@ftbfs.org> Date: Wed, 07 Jul 2021 17:53:06 +0200 In-Reply-To: <859C1BD7-D59C-4990-949F-376ADF47AF26@ftbfs.org> (Matthew Kraai's message of "Wed, 7 Jul 2021 08:42:55 -0700") Message-ID: <874kd6t925.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49450 Cc: 49450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Matthew Kraai writes: > I was trying to ensure that when emacs-deadgrep is installed, ripgrep > is also installed. The former doesn=E2=80=99t need the latter to build but > does require it at runtime. Isn=E2=80=99t propagated-inputs the right fie= ld > for that? Inputs are also available at runtime, but do not clobber user's profile. It's preferable to use them, when it's reasonably possible. In this case, it means you just need to modify the Elisp source to make sure code points to the right ripgrep executable in the store. See, e.g., emacs-flycheck-grammalecte. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 19:56:39 2021 Received: (at 49450) by debbugs.gnu.org; 7 Jul 2021 23:56:40 +0000 Received: from localhost ([127.0.0.1]:53746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1HPD-0000JY-NL for submit@debbugs.gnu.org; Wed, 07 Jul 2021 19:56:39 -0400 Received: from mail.ftbfs.org ([52.8.68.13]:18498 helo=aws.ftbfs.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1HP9-0000JE-Go for 49450@debbugs.gnu.org; Wed, 07 Jul 2021 19:56:38 -0400 Received: from ip68-228-72-85.oc.oc.cox.net ([68.228.72.85] helo=localhost.localdomain) by aws.ftbfs.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m1HP3-0008SS-Cq; Wed, 07 Jul 2021 23:56:29 +0000 From: Matthew James Kraai To: 49450@debbugs.gnu.org Subject: [PATCH] gnu: emacs-deadgrep: Add missing input. Date: Wed, 7 Jul 2021 16:56:24 -0700 Message-Id: <20210707235624.25962-1-kraai@ftbfs.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No (score -1.0): ALL_TRUSTED=-1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49450 Cc: Matthew James Kraai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-deadgrep)[inputs]: Add ripgrep. [arguments]: Add configure phase to set deadgrep-executable to absolute path. --- gnu/packages/emacs-xyz.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 9591a4e6e7..fd7f1b54d3 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20802,10 +20802,25 @@ accept and reject GitHub pull requests.") (base32 "1vjhrq02l8gvdn2haygzq7277hnhjchs9xrfpcnh76gqip200gx4")))) (build-system emacs-build-system) + (inputs `(("ripgrep" ,ripgrep))) (propagated-inputs `(("emacs-dash" ,emacs-dash) ("emacs-s" ,emacs-s) ("emacs-spinner" ,emacs-spinner))) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'configure + (lambda* (#:key inputs #:allow-other-keys) + (let ((ripgrep (assoc-ref inputs "ripgrep"))) + ;; .el is read-only in git. + (chmod "deadgrep.el" #o644) + ;; Specify the absolute file names of rg so that everything + ;; works out-of-the-box. + (emacs-substitute-variables + "deadgrep.el" + ("deadgrep-executable" + (string-append ripgrep "/bin/rg"))))))))) (home-page "https://github.com/Wilfred/deadgrep") (synopsis "Frontend for @code{ripgrep}") (description "This package provides an Emacs interface for performing -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 03:33:42 2021 Received: (at 49450-done) by debbugs.gnu.org; 8 Jul 2021 07:33:42 +0000 Received: from localhost ([127.0.0.1]:54161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1OXW-00044o-2v for submit@debbugs.gnu.org; Thu, 08 Jul 2021 03:33:42 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:8255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1OXT-00044a-MZ for 49450-done@debbugs.gnu.org; Thu, 08 Jul 2021 03:33:40 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 5E72F240006; Thu, 8 Jul 2021 07:33:32 +0000 (UTC) From: Nicolas Goaziou To: Matthew James Kraai Subject: Re: [bug#49450] [PATCH] gnu: emacs-deadgrep: Add missing input. References: <20210707031810.27321-1-kraai@ftbfs.org> <20210707235624.25962-1-kraai@ftbfs.org> Date: Thu, 08 Jul 2021 09:33:30 +0200 In-Reply-To: <20210707235624.25962-1-kraai@ftbfs.org> (Matthew James Kraai's message of "Wed, 7 Jul 2021 16:56:24 -0700") Message-ID: <87h7h5qmyd.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49450-done Cc: 49450-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Matthew James Kraai writes: > * gnu/packages/emacs-xyz.scm (emacs-deadgrep)[inputs]: Add ripgrep. > [arguments]: Add configure phase to set deadgrep-executable to > absolute path. Thank you. > + ;; .el is read-only in git. > + (chmod "deadgrep.el" #o644) I used `make-file-writable' function instead of chmod. Applied. Thank you. Regards, -- Nicolas Goaziou From unknown Thu Jun 19 14:30:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Aug 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator