GNU bug report logs - #49443
[PATCH] Add blitz.

Previous Next

Full log

View this message in rfc822 format

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ivan Gankevich <i.gankevich <at> spbu.ru>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 49443 <at> debbugs.gnu.org
Subject: [bug#49443] [PATCH v3 0/1] Add blitz.
Date: Thu, 15 Jul 2021 19:09:30 +0530

Hi Ivan,

Thanks for the quick response! Save a few minor changes, this patch LGTM. I am
sending a v3 patch with the necessary changes in a following email. Let me
know if it works, and I'll push it to master. Below, I note some of the
changes I've made.

1. I added a copyright header for you.

> +          (add-after 'build 'build-doc
> +            (lambda _
> +              (define jobs (format #f "-j~a" (parallel-job-count)))
> +              (invoke "make" jobs "blitz-doc")
> +              #t))

2. We do not need format for this. See how I've done it. It's simpler and does
not use a heavy-weight function like format.

> +          (add-after 'check 'check-examples
> +            (lambda _
> +              (define jobs (format #f "-j~a" (parallel-job-count)))
> +              (invoke "make" jobs "check-examples")
> +              #t)))))

3. Just check-testsuite should be good enough. So, this phase is not required.

> +    (native-inputs
> +      `(("python" ,python)
> +        ("texinfo" ,texinfo)
> +        ("texlive-tex-texinfo" ,texlive-tex-texinfo)
> +        ("texlive" ,(texlive-union (list texlive-epsf))) ;; for texi2dvi
> +        ("texi2html" ,texi2html)

4. Actually, I only wanted you to build the info manual, not the pdf and html
manuals. Sorry, I should have been clearer. So, I removed the texlive,
texlive-tex-texinfo, texi2html, doxygen, graphviz dependencies and other
related things from the package.

> +    (synopsis "C++ template class library for multidimensional arrays")
> +    (description
> +      "High-performance multidimensional array containers for scientific computing.")

5. Description should be a complete sentence.

Regards,
Arun

Ivan Gankevich (1):
  gnu: Add blitz.

 gnu/packages/maths.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

-- 
2.32.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.