From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 03:37:28 2021 Received: (at submit) by debbugs.gnu.org; 6 Jul 2021 07:37:28 +0000 Received: from localhost ([127.0.0.1]:47172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fe4-0005hb-AF for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:37:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:36430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fe3-0005hU-7U for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:37:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fe2-0004PE-Ut for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 03:37:26 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:32781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fdx-0007Gp-4Q for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 03:37:26 -0400 Received: (Authenticated sender: public@protesilaos.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 09910E00F6 for ; Tue, 6 Jul 2021 07:37:14 +0000 (UTC) From: Protesilaos Stavrou To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Faulty list of faces in shr-tag-h1 User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Tue, 06 Jul 2021 10:37:12 +0300 Message-ID: <87im1nzydz.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Received-SPF: none client-ip=217.70.183.196; envelope-from=info@protesilaos.com; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) SW4gJ3Noci5lbCcgd2UgZmluZCB0aGVzZToNCg0KICAgIChkZWZ1biBzaHItdGFnLWgxIChkb20p DQogICAgICAoc2hyLWhlYWRpbmcgZG9tIChpZiBzaHItdXNlLWZvbnRzDQogICAgICAgICAgICAg ICAgICAgJyh2YXJpYWJsZS1waXRjaCAoOmhlaWdodCAxLjMgOndlaWdodCBib2xkKSkNCiAgICAg ICAgICAgICAgICAgJ2JvbGQpKSkNCg0KICAgIChkZWZ1biBzaHItdGFnLWgyIChkb20pDQogICAg ICAoc2hyLWhlYWRpbmcgZG9tICdib2xkKSkNCg0KVGhlIGludGVudCBpcyB0byBtYWtlIGgxIGhl YWRpbmdzIHVzZSAndmFyaWFibGUtcGl0Y2gnLCBob3dldmVyIHRoaXMNCmhhcHBlbnMgcmVnYXJk bGVzcywgYXMgY2FuIGJlIG5vdGljZWQgaW4gb3RoZXIgaGVhZGluZ3MsIHN1Y2ggYXMgaDIgZm9y DQpyZW5kZXJlZCBkb2N1bWVudHMuICBBcyBzdWNoLCAnc2hyLXRhZy1oMScgY3JlYXRlcyBkdXBs aWNhdGlvbiBvZiB0aGUNCid2YXJpYWJsZS1waXRjaCcgZW50cnkuDQoNClN0ZXBzIHRvIHJlcHJv ZHVjZSBvbiBlbWFjcyAtUToNCg0KKyBNLXggZXd3IFJFVCBodHRwczovL3d3dy5nbnUub3JnL3Nv ZnR3YXJlL2VtYWNzLw0KDQorIEdvIHRvIHRoZSBoMSBoZWFkaW5nIHRoYXQgcmVhZHMgIkdOVSBF bWFjcyIuDQoNCisgTS14IGRlc2NyaWJlLWNoYXINCg0KKyBJbiB0aGUgcmVzdWx0aW5nIEhlbHAg YnVmZmVyLCBub3RpY2UgdGhpczoNCg0KICAgICh2YXJpYWJsZS1waXRjaCAodmFyaWFibGUtcGl0 Y2ggKDpoZWlnaHQgMS4zIDp3ZWlnaHQgYm9sZCkpKQ0KDQorIFRoZSBidXR0b24gdGhhdCByZWZl cmVuY2VzIHRoYXQgYW5vbnltb3VzIGZhY2UgZG9lcyBub3QgcHJvdmlkZSBhIEhlbHANCiAgYnVm ZmVyIHdpdGggYWNjdXJhdGUgaW5mb3JtYXRpb24gYXMgdG8gd2hhdCBhdHRyaWJ1dGVzIGFyZSBp biBlZmZlY3QuDQogIEluc3RlYWQsIGl0IG9ubHkgbGlzdHMgdGhlIGF0dHJpYnV0ZXMgb2YgJ3Zh cmlhYmxlLXBpdGNoJy4NCg0KKyBDb21wYXJlIHRoYXQgdG8gdGhlIGluZm9ybWF0aW9uIHdlIGdl dCBmcm9tIHRoZSBuZXh0IGhlYWRpbmcsICJBbg0KICBleHRlbnNpYmxlLCBjdXN0b21pemFibGUs IGZyZWUvbGlicmUgdGV4dCBlZGl0b3Ig4oCUIGFuZCBtb3JlLiIsIHdoaWNoDQogIGFjY3VyYXRl bHkgc2hvd3MgYm90aCBvZiB0aGUgZmFjZXMgdGhhdCBhcmUgaW4gZWZmZWN0Lg0KDQpUbyBmaXgg dGhlIGlzc3VlLCB3ZSBuZWVkIHRvIHBhc3MgYSBmYWNlIGRpcmVjdGx5LCB3aXRob3V0IGNvbWJp bmluZyBpdA0Kd2l0aCAndmFyaWFibGUtcGl0Y2gnLiAgSnVzdCBsaWtlICdzaHItdGFnLWgyJy4g IEluIGEgc2VwYXJhdGUgcmVwb3J0LCBJDQpwcm92aWRlIGEgcGF0Y2ggdGhhdCBkb2VzIHRoYXQg YW5kIGFkZHMgbmV3IGZhY2VzIGZvciBhbGwgaGVhZGluZw0KZWxlbWVudHMgKHVzaW5nICdkZWZm YWNlJyBpbnN0ZWFkIG9mIGhhcmRjb2RpbmcgdmFsdWVzKS4NCg0KVGhhbmsgeW91IQ0KDQotLSAN ClByb3Rlc2lsYW9zIFN0YXZyb3UNCmh0dHBzOi8vcHJvdGVzaWxhb3MuY29tDQo= From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 03:47:31 2021 Received: (at submit) by debbugs.gnu.org; 6 Jul 2021 07:47:31 +0000 Received: from localhost ([127.0.0.1]:47185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fnm-0005yJ-O0 for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:47:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:48414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fnk-0005yC-Rq for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:47:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fnk-0004dl-GD for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 03:47:28 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:39587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fnd-0006Ih-6g for bug-gnu-emacs@gnu.org; Tue, 06 Jul 2021 03:47:28 -0400 Received: (Authenticated sender: public@protesilaos.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 7F2E8200006 for ; Tue, 6 Jul 2021 07:47:16 +0000 (UTC) From: Protesilaos Stavrou To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Add faces for shr heading elements (bug#49433) User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Tue, 06 Jul 2021 10:47:14 +0300 Message-ID: <87fswrzxx9.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=217.70.178.232; envelope-from=info@protesilaos.com; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain In bug#49433 I noted how shr-tag-h1 creates a faulty anonymous face that users cannot inspect properly. The attached patch fixes this issue and also provides named faces for all shr heading levels from 1-6. The attributes of those new faces are the same as before for backward-compatibility in terms of visuals. Thank you! -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-faces-for-shr-heading-elements-bug-49433.patch >From c8b70c1a020e2352379368fd9c2a2647bf88c4d8 Mon Sep 17 00:00:00 2001 Message-Id: From: Protesilaos Stavrou Date: Tue, 6 Jul 2021 10:44:46 +0300 Subject: [PATCH] Add faces for shr heading elements (bug#49433) * etc/NEWS: Document new faces. * lisp/net/shr.el (shr-h1, shr-h2, shr-h3, shr-h4, shr-h5, shr-h6): Define new faces. (shr-tag-h1): Remove inclusion of 'variable-pitch' face. Fix bug#49433 by applying a new face directly. (shr-tag-h2, shr-tag-h3, shr-tag-h4, shr-tag-h5, shr-tag-h6): Apply new faces. --- etc/NEWS | 4 ++++ lisp/net/shr.el | 41 +++++++++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 8 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index c3eaf5fcbb..b1ab6941d0 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1620,6 +1620,10 @@ t, which preserves the original behavior. If set non-nil, showing an unseen message will set the Rmail buffer's modified flag. +--- +*** New faces for heading elements. +Those are 'shr-h1', 'shr-h2', 'shr-h3', 'shr-h4', 'shr-h5', 'shr-h6'. + ** Apropos *** New commands 'apropos-next-symbol' and 'apropos-previous-symbol'. diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 873f0457e3..85d81b6bbc 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -183,6 +183,33 @@ (defface shr-abbreviation "Face for elements." :version "27.1") +(defface shr-h1 + '((t :height 1.3 :weight bold)) + "Face for

elements." + :version "28.1") + +(defface shr-h2 + '((t :weight bold)) + "Face for

elements." + :version "28.1") + +(defface shr-h3 + '((t :slant italic)) + "Face for

elements." + :version "28.1") + +(defface shr-h4 nil + "Face for

elements." + :version "28.1") + +(defface shr-h5 nil + "Face for

elements." + :version "28.1") + +(defface shr-h6 nil + "Face for
elements." + :version "28.1") + (defcustom shr-inhibit-images nil "If non-nil, inhibit loading images." :version "28.1" @@ -1939,24 +1966,22 @@ (defun shr-tag-span (dom) (shr-generic dom)) (defun shr-tag-h1 (dom) - (shr-heading dom (if shr-use-fonts - '(variable-pitch (:height 1.3 :weight bold)) - 'bold))) + (shr-heading dom 'shr-h1)) (defun shr-tag-h2 (dom) - (shr-heading dom 'bold)) + (shr-heading dom 'shr-h2)) (defun shr-tag-h3 (dom) - (shr-heading dom 'italic)) + (shr-heading dom 'shr-h3)) (defun shr-tag-h4 (dom) - (shr-heading dom)) + (shr-heading dom 'shr-h4)) (defun shr-tag-h5 (dom) - (shr-heading dom)) + (shr-heading dom 'shr-h5)) (defun shr-tag-h6 (dom) - (shr-heading dom)) + (shr-heading dom 'shr-h6)) (defun shr-tag-hr (_dom) (shr-ensure-newline) -- 2.32.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 11:06:52 2021 Received: (at 49433) by debbugs.gnu.org; 6 Jul 2021 15:06:52 +0000 Received: from localhost ([127.0.0.1]:49713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mex-0000xj-UO for submit@debbugs.gnu.org; Tue, 06 Jul 2021 11:06:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mew-0000xT-Bq for 49433@debbugs.gnu.org; Tue, 06 Jul 2021 11:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3N0WApKVB1oY50gY9nNvsCvdlmgmeB9hgh1QRFmTq8g=; b=IIM6nrZZhzwkCB/ZQ3JpyQTukC Tug1MfVSoCi1yfNargvWLQu3pM25YAEOCABl0nQUUeI+b0dnTQrZnG2Iy8Q/EqjOiAWWqZgMdFIUO qbu0Sey8x1wAuL/FYNhUSqlt/dRX7qIdKONs9xWNfAAMQ+a45iM3MokFpIRnWs2uQj+Y=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0meo-0002Er-Bl; Tue, 06 Jul 2021 17:06:44 +0200 From: Lars Ingebrigtsen To: Protesilaos Stavrou Subject: Re: bug#49433: 28.0.50; Faulty list of faces in shr-tag-h1 References: <87im1nzydz.fsf@protesilaos.com> <87fswrzxx9.fsf@protesilaos.com> X-Now-Playing: David Allred's _Alone on Friendship Island_: "Quitters" Date: Tue, 06 Jul 2021 17:06:41 +0200 In-Reply-To: <87fswrzxx9.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 06 Jul 2021 10:47:14 +0300") Message-ID: <87lf6jscqm.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Protesilaos Stavrou writes: > In bug#49433 I noted how shr-tag-h1 creates a faulty anonymous face that > users cannot inspect properly. The attached patch fixes this issue and > also provides named faces for all shr heading leve [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49433 Cc: 49433@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Protesilaos Stavrou writes: > In bug#49433 I noted how shr-tag-h1 creates a faulty anonymous face that > users cannot inspect properly. The attached patch fixes this issue and > also provides named faces for all shr heading levels from 1-6. > > The attributes of those new faces are the same as before for > backward-compatibility in terms of visuals. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 11:06:57 2021 Received: (at control) by debbugs.gnu.org; 6 Jul 2021 15:06:57 +0000 Received: from localhost ([127.0.0.1]:49716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mf3-0000y0-5Q for submit@debbugs.gnu.org; Tue, 06 Jul 2021 11:06:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mf1-0000xY-1Z for control@debbugs.gnu.org; Tue, 06 Jul 2021 11:06:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i3dhJvY6WF0wFC57b7Ct/i5DylJ+3kFCbgZcH1KxA3c=; b=l8/w8iBaaOuLOIDbSQd39Qt2Sz +WuSBfpP67cJKUDqyOOE+n3y756J9LVyB9Trhl/ukHGQtWbdhIu4wAqEQCpRoqgAsbWlOg2tJbfhV 2MoRccZAGM5QbSJOtEr6S/U7JJRBACC1X/aqgB1DuKZp+716mX6NkMYM9S3Pl1JJBSc4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0met-0002F1-H3 for control@debbugs.gnu.org; Tue, 06 Jul 2021 17:06:49 +0200 Date: Tue, 06 Jul 2021 17:06:47 +0200 Message-Id: <87k0m3scqg.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49433 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49433 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49433 28.1 quit From unknown Sat Jun 21 02:55:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Aug 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator