From unknown Fri Jun 20 05:26:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49432 <49432@debbugs.gnu.org> To: bug#49432 <49432@debbugs.gnu.org> Subject: Status: [PATCH] gnu: gccgo: Override empty GOROOT/GCCGOTOOLDIR Reply-To: bug#49432 <49432@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:26:59 +0000 retitle 49432 [PATCH] gnu: gccgo: Override empty GOROOT/GCCGOTOOLDIR reassign 49432 guix-patches submitter 49432 Sarah Morgensen severity 49432 normal tag 49432 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 03:30:50 2021 Received: (at submit) by debbugs.gnu.org; 6 Jul 2021 07:30:50 +0000 Received: from localhost ([127.0.0.1]:47166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fXe-0005WR-GX for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:30:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:57614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fXc-0005WH-3r for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:30:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fXb-0007kJ-HG for guix-patches@gnu.org; Tue, 06 Jul 2021 03:30:47 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:35699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fXX-0002he-KY for guix-patches@gnu.org; Tue, 06 Jul 2021 03:30:47 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1625556635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JduiJjlWJSIjCwYQpJm+qgUnEDByvnWrEHncDF4czms=; b=eCNVPS4TFkpvZyjMUIbzvsP6aPFPDO/mUQS1JBPSeaFUeelltFSammUY2KQC8ecwX6qOqE A/CFAXALJyJCn5DKg8KG8cKASJuDAGyk0xhc0cgeJjkm3JRPxfFj6F7NXtrxGmGEs872xl y9I/YVSe6njxflG8EU6elb7M2trd87o= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH] gnu: gccgo: Override empty GOROOT/GCCGOTOOLDIR Date: Tue, 6 Jul 2021 00:30:32 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=iskarian@mgsn.dev; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) gnu/packages/gcc.scm (make-gccgo)[arguments]: Set tool paths (GOROOT and GCCGOTOOLDIR) even if they are already set to "". --- Hello all, It turns out some tools use GOROOT='' go env GOROOT to find Go, which was breaking with Gccgo. This little patch fixes that. As for the commit title, I wasn't sure if "gnu: gccgo" or "gnu: make-gccgo" was more appropriate here... there aren't a lot of examples in the commit log! Thanks, Sarah gnu/packages/gcc.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm index 2fe30b1321..02d6824a99 100644 --- a/gnu/packages/gcc.scm +++ b/gnu/packages/gcc.scm @@ -871,9 +871,9 @@ provides the GNU compiler for the Go programming language.") (tooldir (dirname (car (find-files exedir "^cgo$"))))) (wrap-program (string-append out "/bin/go") `("GCCGOTOOLDIR" = - (,(string-append "${GCCGOTOOLDIR-" tooldir "}"))) + (,(string-append "${GCCGOTOOLDIR:-" tooldir "}"))) `("GOROOT" = - (,(string-append "${GOROOT-" out "}"))))))) + (,(string-append "${GOROOT:-" out "}"))))))) (add-before 'configure 'fix-gotools-runpath (lambda _ (substitute* "gotools/Makefile.in" base-commit: aa6e6fb2e9ea231d12d49a8925fddd8d2686ea94 -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 08:30:15 2021 Received: (at 49432-done) by debbugs.gnu.org; 7 Dec 2021 13:30:15 +0000 Received: from localhost ([127.0.0.1]:36658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muaXu-0005Iw-W4 for submit@debbugs.gnu.org; Tue, 07 Dec 2021 08:30:15 -0500 Received: from flashner.co.il ([178.62.234.194]:56158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muaXr-0005HX-CJ for 49432-done@debbugs.gnu.org; Tue, 07 Dec 2021 08:30:13 -0500 Received: from localhost (unknown [94.230.83.253]) by flashner.co.il (Postfix) with ESMTPSA id 5936A4020F; Tue, 7 Dec 2021 13:30:05 +0000 (UTC) Date: Tue, 7 Dec 2021 15:27:00 +0200 From: Efraim Flashner To: Sarah Morgensen Subject: Re: [bug#49432] [PATCH] gnu: gccgo: Override empty GOROOT/GCCGOTOOLDIR Message-ID: Mail-Followup-To: Efraim Flashner , Sarah Morgensen , 49432-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4XZkUtaNM1DzTsEj" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49432-done Cc: 49432-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --4XZkUtaNM1DzTsEj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Looks like this got dropped somewhere. Patch pushed! --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --4XZkUtaNM1DzTsEj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmGvYSQACgkQQarn3Mo9 g1GzPA/+L4/qyATaHrmLGyliEaNZWCW88Gf/uxSxlj4ETW4R0/oxKDUyfsp+XxSw tyTg5gm3vB94da+5OU38mXJM8EY6oaeq7LUow3vZjID1aLxoh9K4gkiX+1OdHrm4 2zgwARb3mM08My1aB/oWpBmp0pjfNtvJoexAQS0nhm3Sid6DzkUPtsmoNO7wTPJ8 /BVWor/9Xc14UqiLqbYv7aKVDmqSqebI2GY4X7t+y7WN5fmz+VsgIgxGk77pW5AI fC6yMu1qS2yXIHbPXoofFPh2KloqRe5wHaDNn6uEjR6gdGiWl+afuALwo1CIWJ4R S3KUAgxwdfkGN/p92Uy5FuHOOIEfHnqq0S95Zg820ZlwmeoEJ51b0ilo2T+7tq3X Q9/lDIhDimyo26WRmRmzI02wPbg0sju473WLxjOdgjvhpEZQKGtaPYSpVTyZyNfY s5Q7Q+2uu9+t4Bkd0/h4QPzQMEpDEmtbA8nnzNtT7Cfd9hDfiXEKtJjJSfHBneAq OrE1bCLymIlj7aZWgZHRq+g6YGAH2hxP7/8rfyZ5iEU1dkWpO5eAEr6MUus7+c2J 2PSzrtbw658zDuP8+ulyLYuQuvB+eUAuFvb3CYgjx7TNUqZncLj8nnQgW1QZWtY5 GHugl6E1dRND9gnSO9Nv9s+b9HvBGMX5oEwGMCaJ9f6V3tpcjeg= =i0Fi -----END PGP SIGNATURE----- --4XZkUtaNM1DzTsEj-- From unknown Fri Jun 20 05:26:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Jan 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator