GNU bug report logs - #49431
[PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49431: closed ([PATCH maintenance.git] nginx: berlin:
 Redirect old video URLs for each language.)
Date: Sat, 10 Jul 2021 19:30:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 10 Jul 2021 21:28:32 +0200
with message-id <20210710192832.wwvgw3zc24ufhbju <at> pelzflorian.localdomain>
and subject line Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.
has caused the debbugs.gnu.org bug report #49431,
regarding [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49431: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49431
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: guix-patches <at> gnu.org
Cc: Luis Felipe <luis.felipe.la <at> protonmail.com>
Subject: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for
 each language.
Date: Tue, 6 Jul 2021 08:53:04 +0200

[Message part 3 (text/plain, inline)]

Hi guix,

a week ago Luis nicely redesigned how videos are displayed on the Guix
website
<https://lists.gnu.org/archive/html/guix-patches/2021-07/msg00005.html>.
(Because the old CSS stylesheets are cached by the browser, the
website displayed videos wrongly for a day though.)

This patch adds redirects for the guix website from the old video URLs
like

/LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html
/LANG/videos/everyday-use-of-gnu-guix,-part-one/
/LANG/videos/everyday-use-of-gnu-guix,-part-one

to the new

/LANG/videos/2020/everyday-use-of-gnu-guix-part-one/

but maybe the patch is too ugly because that’s code duplication to
have three added redirections for each video.  Note that my old
videos page actually linked to
</LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html> and not
</LANG/videos/everyday-use-of-gnu-guix,-part-one/> as usual.

Shall I push it as-is to guix/maintenance.git,

or do you think it would be better to rewrite the redirect procedure
to return a list to redirect every URL with suffixes

""
"/"
"/index.html"

and change guix.gnu.org-locations accordingly to flatten the location
list?

The patch was tested on a VM of berlin.scm with some services, file
systems and SSL removed and I’m confident it does what it should.

Regards,
Florian

[nginx-berlin-Redirect-old-video-URLs-for-each-language.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49431-done <at> debbugs.gnu.org, Luis Felipe <luis.felipe.la <at> protonmail.com>
Subject: Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old
 video URLs for each language.
Date: Sat, 10 Jul 2021 21:28:32 +0200

On Sat, Jul 10, 2021 at 12:27:05PM +0200, Ludovic Courtès wrote:
> "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> skribis:
> > Do I need to add a copyright header?  I hereby license/declare my
> > patch CC0 <https://creativecommons.org/publicdomain/zero/1.0/>.
> 
> Currently there’s no explicit license on this file,
> hydra/nginx/berlin.scm.
> 
> There’s very little at stake for the sake of transparency, it might be
> best to email guix-sysadmins so people who contribute to this file (and
> to hydra/berlin.scm) agree on the license.  The default license in the
> project would be GPLv3+, but these config files are “special”.

I will send a mail with a patch there.  Thank you.


> > Shall I push and then wait until someone guix system reconfigures
> > berlin?
> 
> Yes, please!

Finally pushed as 2d6dc5e01aa32a01b345ba834e32bbf723e67077.  Old video
URLs will be redirected after guix system reconfigure.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.