GNU bug report logs - #49431
[PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.

Previous Next

Full log

View this message in rfc822 format

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49431 <at> debbugs.gnu.org, Luis Felipe <luis.felipe.la <at> protonmail.com>
Subject: [bug#49431] [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.
Date: Fri, 9 Jul 2021 09:15:04 +0200

[Message part 1 (text/plain, inline)]

Thank you two for your opinion, Luis and Ludo.

On Thu, Jul 08, 2021 at 03:53:16PM +0200, Ludovic Courtès wrote:
> Shouldn’t we also redirect
> 
>   /$lang/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/
> 
> since the left-hand side here was the right-hand side of the previous
> redirects?

Each valid $lang was handled further down, but my patch was confusing,
especially when somebody wants to add more redirections.  Find
attached a revised patch with per-language redirection in only one
place, namely new procedure
`guix.gnu.org-redirects-for-each-language'.

Do I need to add a copyright header?  I hereby license/declare my
patch CC0 <https://creativecommons.org/publicdomain/zero/1.0/>.

In the previous patch I had missed some cases without /LANG like

/videos/everyday-use-of-gnu-guix,-part-one/index.html -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/

Redirecting was unnecessary for

/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/

which already gets taken care of by

/videos/everyday-use-of-gnu-guix,-part-one -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/

thanks to nginx location normalization.

Shall I push and then wait until someone guix system reconfigures
berlin?

Regards,
Florian

[nginx-berlin-Redirect-old-video-URLs-for-each-language-v2.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.