GNU bug report logs - #49431
[PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 49431 <at> debbugs.gnu.org, Luis Felipe <luis.felipe.la <at> protonmail.com>
Subject: [bug#49431] [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language.
Date: Thu, 08 Jul 2021 15:53:16 +0200

Hi,

"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> skribis:

> This patch adds redirects for the guix website from the old video URLs
> like
>
> /LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html
> /LANG/videos/everyday-use-of-gnu-guix,-part-one/
> /LANG/videos/everyday-use-of-gnu-guix,-part-one
>
> to the new
>
> /LANG/videos/2020/everyday-use-of-gnu-guix-part-one/

[...]

>>From d52a189332aa014f9da88fa1ce1e38ffc107fa3b Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian <at> pelzflorian.de>
> Date: Sun, 4 Jul 2021 14:46:39 +0200
> Subject: [PATCH] nginx: berlin: Redirect old video URLs for each language.
>
> * hydra/nginx/berlin.scm (languages-to-accept): New list.  Move here
> the languages list from ...
> (%extra-content) ... here.  Use languages from 'languages-to-accept'.
> (guix.gnu.org-redirect-locations-for-lang): New procedure.  Add
> new video redirections.
> (guix.gnu.org-redirect-locations): New list.  Move here the
> old redirections.  Update old video redirections.
> (guix.gnu.org-other-locations): New list.  Move here the other nginx
> locations from ...
> (guix.gnu.org-locations): ... here.  Reimplement in terms of the above.

[...]

>     (redirect "/screenshots/xfce" "/$lang/screenshots/xfce/")
>     (redirect "/security" "/$lang/security/")
>     (redirect "/videos" "/$lang/videos/")
> -   (redirect "/videos/asking-for-help" "/$lang/videos/asking-for-help/")
> -   (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos/everyday-use-of-gnu-guix,-part-one/")
> -   (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos/everyday-use-of-gnu-guix,-part-two/")
> -   (redirect "/videos/installation-from-script" "/$lang/videos/installation-from-script/")
> -   (redirect "/videos/packaging,-part-one" "/$lang/videos/packaging,-part-one/")
> -   (redirect "/videos/packaging,-part-two" "/$lang/videos/packaging,-part-two/")
> -   (redirect "/videos/packaging,-part-three" "/$lang/videos/packaging,-part-three/")
> -
> +   (redirect "/videos/asking-for-help" "/$lang/videos/2020/asking-for-help/")
> +   (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos/2020/everyday-use-of-gnu-guix-part-one/")
> +   (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos/2020/everyday-use-of-gnu-guix-part-two/")
> +   (redirect "/videos/installation-from-script" "/$lang/videos/2020/installation-from-script/")
> +   (redirect "/videos/packaging,-part-one" "/$lang/videos/2020/packaging-part-one/")
> +   (redirect "/videos/packaging,-part-two" "/$lang/videos/2020/packaging-part-two/")
> +   (redirect "/videos/packaging,-part-three" "/$lang/videos/2020/packaging-part-three/")))

Shouldn’t we also redirect

  /$lang/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/

since the left-hand side here was the right-hand side of the previous
redirects?

Anyway, at first sight it LGTM!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.