From unknown Fri Jun 20 18:13:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49431 <49431@debbugs.gnu.org> To: bug#49431 <49431@debbugs.gnu.org> Subject: Status: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Reply-To: bug#49431 <49431@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:13:00 +0000 retitle 49431 [PATCH maintenance.git] nginx: berlin: Redirect old video URL= s for each language. reassign 49431 guix-patches submitter 49431 "pelzflorian (Florian Pelz)" severity 49431 normal tag 49431 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 02:53:24 2021 Received: (at submit) by debbugs.gnu.org; 6 Jul 2021 06:53:25 +0000 Received: from localhost ([127.0.0.1]:47129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0exQ-0004T7-Cv for submit@debbugs.gnu.org; Tue, 06 Jul 2021 02:53:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:51900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0exO-0004T0-NN for submit@debbugs.gnu.org; Tue, 06 Jul 2021 02:53:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0exO-0008N1-EN for guix-patches@gnu.org; Tue, 06 Jul 2021 02:53:22 -0400 Received: from pelzflorian.de ([5.45.111.108]:37182 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0exK-0007qv-Jq for guix-patches@gnu.org; Tue, 06 Jul 2021 02:53:22 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id B4ED6360672; Tue, 6 Jul 2021 08:53:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1625554394; bh=ZJBz8BpikmDUrAfIpuKm/+8lGlQBBujpX1IFZbM5Grs=; h=Date:From:To:Cc:Subject; b=i3grWfYMJMP4rQK8Akl+P/fUnaMGmTgytLzQMd27kAWufk2K488QRS+yva7f4NgSb O4H/WLcx7hJDtsHRXaqtpBNuPo7OEWaBWbusR1JN8dOoWHF+ccQis/TYT66+3yvb3+ iusfkvSqeAtu0TZa/ydfhEGYUlhiNsf0569Q7uJE= Date: Tue, 6 Jul 2021 08:53:04 +0200 From: "pelzflorian (Florian Pelz)" To: guix-patches@gnu.org Subject: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Message-ID: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="yw3xqgwzlxcaue3q" Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.45.111.108; envelope-from=pelzflorian@pelzflorian.de; helo=mail.pelzflorian.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --yw3xqgwzlxcaue3q Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi guix, a week ago Luis nicely redesigned how videos are displayed on the Guix website . (Because the old CSS stylesheets are cached by the browser, the website displayed videos wrongly for a day though.) This patch adds redirects for the guix website from the old video URLs like /LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html /LANG/videos/everyday-use-of-gnu-guix,-part-one/ /LANG/videos/everyday-use-of-gnu-guix,-part-one to the new /LANG/videos/2020/everyday-use-of-gnu-guix-part-one/ but maybe the patch is too ugly because that’s code duplication to have three added redirections for each video. Note that my old videos page actually linked to and not as usual. Shall I push it as-is to guix/maintenance.git, or do you think it would be better to rewrite the redirect procedure to return a list to redirect every URL with suffixes "" "/" "/index.html" and change guix.gnu.org-locations accordingly to flatten the location list? The patch was tested on a VM of berlin.scm with some services, file systems and SSL removed and I’m confident it does what it should. Regards, Florian --yw3xqgwzlxcaue3q Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="nginx-berlin-Redirect-old-video-URLs-for-each-language.patch" >From d52a189332aa014f9da88fa1ce1e38ffc107fa3b Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Sun, 4 Jul 2021 14:46:39 +0200 Subject: [PATCH] nginx: berlin: Redirect old video URLs for each language. * hydra/nginx/berlin.scm (languages-to-accept): New list. Move here the languages list from ... (%extra-content) ... here. Use languages from 'languages-to-accept'. (guix.gnu.org-redirect-locations-for-lang): New procedure. Add new video redirections. (guix.gnu.org-redirect-locations): New list. Move here the old redirections. Update old video redirections. (guix.gnu.org-other-locations): New list. Move here the other nginx locations from ... (guix.gnu.org-locations): ... here. Reimplement in terms of the above. --- hydra/nginx/berlin.scm | 78 ++++++++++++++++++++++++++++++++---------- 1 file changed, 60 insertions(+), 18 deletions(-) diff --git a/hydra/nginx/berlin.scm b/hydra/nginx/berlin.scm index 443294e..a8f4690 100644 --- a/hydra/nginx/berlin.scm +++ b/hydra/nginx/berlin.scm @@ -188,7 +188,7 @@ PUBLISH-URL." (body (list "root /var/www/guix;")))))) -(define guix.gnu.org-locations +(define guix.gnu.org-redirect-locations (list ;; Short URL for the installation script (redirect "/install.sh" "https://git.savannah.gnu.org/cgit/guix.git/plain/etc/guix-install.sh") @@ -689,14 +689,46 @@ PUBLISH-URL." (redirect "/screenshots/xfce" "/$lang/screenshots/xfce/") (redirect "/security" "/$lang/security/") (redirect "/videos" "/$lang/videos/") - (redirect "/videos/asking-for-help" "/$lang/videos/asking-for-help/") - (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos/everyday-use-of-gnu-guix,-part-one/") - (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos/everyday-use-of-gnu-guix,-part-two/") - (redirect "/videos/installation-from-script" "/$lang/videos/installation-from-script/") - (redirect "/videos/packaging,-part-one" "/$lang/videos/packaging,-part-one/") - (redirect "/videos/packaging,-part-two" "/$lang/videos/packaging,-part-two/") - (redirect "/videos/packaging,-part-three" "/$lang/videos/packaging,-part-three/") - + (redirect "/videos/asking-for-help" "/$lang/videos/2020/asking-for-help/") + (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos/2020/everyday-use-of-gnu-guix-part-one/") + (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos/2020/everyday-use-of-gnu-guix-part-two/") + (redirect "/videos/installation-from-script" "/$lang/videos/2020/installation-from-script/") + (redirect "/videos/packaging,-part-one" "/$lang/videos/2020/packaging-part-one/") + (redirect "/videos/packaging,-part-two" "/$lang/videos/2020/packaging-part-two/") + (redirect "/videos/packaging,-part-three" "/$lang/videos/2020/packaging-part-three/"))) + +(define (guix.gnu.org-redirect-locations-for-lang lang) + (define (redirect-lang old new) + (redirect (string-append "/" lang old) + (string-append "/" lang new))) + (list + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-one" "/videos/2020/everyday-use-of-gnu-guix-part-one/") + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-two" "/videos/2020/everyday-use-of-gnu-guix-part-two/") + (redirect-lang "/videos/system-graphical-installer" "/videos/2020/system-graphical-installer/") + (redirect-lang "/videos/asking-for-help" "/videos/2020/asking-for-help/") + (redirect-lang "/videos/installation-from-script" "/videos/2020/installation-from-script/") + (redirect-lang "/videos/packaging,-part-one" "/videos/2020/packaging-part-one/") + (redirect-lang "/videos/packaging,-part-two" "/videos/2020/packaging-part-two/") + (redirect-lang "/videos/packaging,-part-three" "/videos/2020/packaging-part-three/") + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-one/index.html" "/videos/2020/everyday-use-of-gnu-guix-part-one/") + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-two/index.html" "/videos/2020/everyday-use-of-gnu-guix-part-two/") + (redirect-lang "/videos/system-graphical-installer/index.html" "/videos/2020/system-graphical-installer/") + (redirect-lang "/videos/asking-for-help/index.html" "/videos/2020/asking-for-help/") + (redirect-lang "/videos/installation-from-script/index.html" "/videos/2020/installation-from-script/") + (redirect-lang "/videos/packaging,-part-one/index.html" "/videos/2020/packaging-part-one/") + (redirect-lang "/videos/packaging,-part-two/index.html" "/videos/2020/packaging-part-two/") + (redirect-lang "/videos/packaging,-part-three/index.html" "/videos/2020/packaging-part-three/") + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-one/" "/videos/2020/everyday-use-of-gnu-guix-part-one/") + (redirect-lang "/videos/everyday-use-of-gnu-guix,-part-two/" "/videos/2020/everyday-use-of-gnu-guix-part-two/") + (redirect-lang "/videos/system-graphical-installer/" "/videos/2020/system-graphical-installer/") + (redirect-lang "/videos/asking-for-help/" "/videos/2020/asking-for-help/") + (redirect-lang "/videos/installation-from-script/" "/videos/2020/installation-from-script/") + (redirect-lang "/videos/packaging,-part-one/" "/videos/2020/packaging-part-one/") + (redirect-lang "/videos/packaging,-part-two/" "/videos/2020/packaging-part-two/") + (redirect-lang "/videos/packaging,-part-three/" "/videos/2020/packaging-part-three/"))) + +(define guix.gnu.org-other-locations + (list (nginx-location-configuration (uri "/guix-videos") (body (list "alias /srv/videos;"))) @@ -754,6 +786,24 @@ PUBLISH-URL." (uri "/.well-known") (body (list "root /var/www;"))))) +(define languages-to-accept + ;; List of languages for redirection; see 'accept-languages' above. + '(("en") + ("de") + ("eo") + ("es") + ("fr") + ("ko") + ("ru") + ("sk") + ("zh-CN" "zh" "zh-Hans" "zh-Hans-CN"))) + +(define guix.gnu.org-locations + (append (append-map guix.gnu.org-redirect-locations-for-lang + (map car languages-to-accept)) + guix.gnu.org-redirect-locations + guix.gnu.org-other-locations)) + (define %publish-url "http://localhost:3000") (define %berlin-servers @@ -1033,15 +1083,7 @@ synonymous IETF language tags that should be mapped to the same $lang." "default_type application/octet-stream;" "sendfile on;" - (accept-languages '(("en") - ("de") - ("eo") - ("es") - ("fr") - ("ko") - ("ru") - ("sk") - ("zh-CN" "zh" "zh-Hans" "zh-Hans-CN"))) + (accept-languages languages-to-accept) ;; Maximum chunk size to send. Partly this is a workaround for ;; , but also the nginx docs mention that -- 2.32.0 --yw3xqgwzlxcaue3q-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 13:52:11 2021 Received: (at submit) by debbugs.gnu.org; 7 Jul 2021 17:52:11 +0000 Received: from localhost ([127.0.0.1]:53388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1BiV-0005oI-0C for submit@debbugs.gnu.org; Wed, 07 Jul 2021 13:52:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:34824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1BiQ-0005o8-NY for submit@debbugs.gnu.org; Wed, 07 Jul 2021 13:52:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1BiQ-0004iO-51 for guix-patches@gnu.org; Wed, 07 Jul 2021 13:52:06 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:44177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1BiN-0001J4-Qj for guix-patches@gnu.org; Wed, 07 Jul 2021 13:52:05 -0400 Date: Wed, 07 Jul 2021 17:51:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625680315; bh=1WhjKvkONlZpmGO0LPGaZv4/22OJNm8qgkHP1DId9EE=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=GPzQE93kb/iDkiVJCh7z+IyRruggHtf4rptDivE21O9bMEFlfb0sgVB0UWkeczise KVMm81Z4ZUmbXh47qYr046ZzDR/3VH/bWg0IBfy3BJNM6xcF7BfOzaiao2A5Tt2cCI NAQid5G72ht3ai+KCZVWoxKSAcqDu0bO3JlyvEko= To: "pelzflorian (Florian Pelz)" From: Luis Felipe Subject: Re: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Message-ID: In-Reply-To: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=51.77.79.158; envelope-from=luis.felipe.la@protonmail.com; helo=mail-0201.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Luis Felipe Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Florian, On Tuesday, July 6th, 2021 at 6:53 AM, pelzflorian (Florian Pelz) wrote: > This patch adds redirects for the guix website from the old video URLs > > like > > /LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html > > /LANG/videos/everyday-use-of-gnu-guix,-part-one/ > > /LANG/videos/everyday-use-of-gnu-guix,-part-one > > to the new > > /LANG/videos/2020/everyday-use-of-gnu-guix-part-one/ > > but maybe the patch is too ugly because that=E2=80=99s code duplication t= o > > have three added redirections for each video. Note that my old > > videos page actually linked to > > and not > > as usual. > > Shall I push it as-is to guix/maintenance.git, > > or do you think it would be better to rewrite the redirect procedure > > to return a list to redirect every URL with suffixes > > "" > > "/" > > "/index.html" > > and change guix.gnu.org-locations accordingly to flatten the location > > list? I took a look at the patch, but I'm not familiar with the server-side of th= ings, so there's not much I can say except that I trust your judgement on t= his :) Thanks for taking care of it. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 09:53:26 2021 Received: (at 49431) by debbugs.gnu.org; 8 Jul 2021 13:53:26 +0000 Received: from localhost ([127.0.0.1]:54742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1USz-0005eu-TP for submit@debbugs.gnu.org; Thu, 08 Jul 2021 09:53:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1USy-0005eh-Ds for 49431@debbugs.gnu.org; Thu, 08 Jul 2021 09:53:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38122) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1USr-0004kh-Ve; Thu, 08 Jul 2021 09:53:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42850 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1USr-0001fG-O7; Thu, 08 Jul 2021 09:53:17 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> Date: Thu, 08 Jul 2021 15:53:16 +0200 In-Reply-To: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Tue, 6 Jul 2021 08:53:04 +0200") Message-ID: <87a6mwlxo3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49431 Cc: 49431@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > This patch adds redirects for the guix website from the old video URLs > like > > /LANG/videos/everyday-use-of-gnu-guix,-part-one/index.html > /LANG/videos/everyday-use-of-gnu-guix,-part-one/ > /LANG/videos/everyday-use-of-gnu-guix,-part-one > > to the new > > /LANG/videos/2020/everyday-use-of-gnu-guix-part-one/ [...] >>>From d52a189332aa014f9da88fa1ce1e38ffc107fa3b Mon Sep 17 00:00:00 2001 > From: Florian Pelz > Date: Sun, 4 Jul 2021 14:46:39 +0200 > Subject: [PATCH] nginx: berlin: Redirect old video URLs for each language. > > * hydra/nginx/berlin.scm (languages-to-accept): New list. Move here > the languages list from ... > (%extra-content) ... here. Use languages from 'languages-to-accept'. > (guix.gnu.org-redirect-locations-for-lang): New procedure. Add > new video redirections. > (guix.gnu.org-redirect-locations): New list. Move here the > old redirections. Update old video redirections. > (guix.gnu.org-other-locations): New list. Move here the other nginx > locations from ... > (guix.gnu.org-locations): ... here. Reimplement in terms of the above. [...] > (redirect "/screenshots/xfce" "/$lang/screenshots/xfce/") > (redirect "/security" "/$lang/security/") > (redirect "/videos" "/$lang/videos/") > - (redirect "/videos/asking-for-help" "/$lang/videos/asking-for-help/") > - (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos= /everyday-use-of-gnu-guix,-part-one/") > - (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos= /everyday-use-of-gnu-guix,-part-two/") > - (redirect "/videos/installation-from-script" "/$lang/videos/installat= ion-from-script/") > - (redirect "/videos/packaging,-part-one" "/$lang/videos/packaging,-par= t-one/") > - (redirect "/videos/packaging,-part-two" "/$lang/videos/packaging,-par= t-two/") > - (redirect "/videos/packaging,-part-three" "/$lang/videos/packaging,-p= art-three/") > - > + (redirect "/videos/asking-for-help" "/$lang/videos/2020/asking-for-he= lp/") > + (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos= /2020/everyday-use-of-gnu-guix-part-one/") > + (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos= /2020/everyday-use-of-gnu-guix-part-two/") > + (redirect "/videos/installation-from-script" "/$lang/videos/2020/inst= allation-from-script/") > + (redirect "/videos/packaging,-part-one" "/$lang/videos/2020/packaging= -part-one/") > + (redirect "/videos/packaging,-part-two" "/$lang/videos/2020/packaging= -part-two/") > + (redirect "/videos/packaging,-part-three" "/$lang/videos/2020/packagi= ng-part-three/"))) Shouldn=E2=80=99t we also redirect /$lang/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/e= veryday-use-of-gnu-guix-part-one/ since the left-hand side here was the right-hand side of the previous redirects? Anyway, at first sight it LGTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 09 03:15:17 2021 Received: (at 49431) by debbugs.gnu.org; 9 Jul 2021 07:15:17 +0000 Received: from localhost ([127.0.0.1]:58242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1kjF-0006tQ-82 for submit@debbugs.gnu.org; Fri, 09 Jul 2021 03:15:17 -0400 Received: from pelzflorian.de ([5.45.111.108]:57422 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1kjB-0006tF-O2 for 49431@debbugs.gnu.org; Fri, 09 Jul 2021 03:15:16 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 9005A360672; Fri, 9 Jul 2021 09:15:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1625814912; bh=7HhYRIU+IxGXGoN33KEQoE4Flagtcc85ZEGKlKycZEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IIPQMVpYJM572F1W+vg/xMrRE6o/HzUnHMzBJX7HSqhg/y3R/Bhs+fXuFA62n0jZS FAVWjFNSPyX3KDZPzpMPmjiZfMCHGdR3JRiGzsKRTtCpIgELK5hU7XeYlJVWSRIMpu 5nlZLqlIGKoCn8o+v0PKBirjT1zFRSf5Bb99pgC0= Date: Fri, 9 Jul 2021 09:15:04 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Message-ID: <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> <87a6mwlxo3.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="iookygiwihals7w7" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a6mwlxo3.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49431 Cc: 49431@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --iookygiwihals7w7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Thank you two for your opinion, Luis and Ludo. On Thu, Jul 08, 2021 at 03:53:16PM +0200, Ludovic Courtès wrote: > Shouldn’t we also redirect > > /$lang/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/ > > since the left-hand side here was the right-hand side of the previous > redirects? Each valid $lang was handled further down, but my patch was confusing, especially when somebody wants to add more redirections. Find attached a revised patch with per-language redirection in only one place, namely new procedure `guix.gnu.org-redirects-for-each-language'. Do I need to add a copyright header? I hereby license/declare my patch CC0 . In the previous patch I had missed some cases without /LANG like /videos/everyday-use-of-gnu-guix,-part-one/index.html -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/ Redirecting was unnecessary for /videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/ which already gets taken care of by /videos/everyday-use-of-gnu-guix,-part-one -> /$lang/videos/2020/everyday-use-of-gnu-guix-part-one/ thanks to nginx location normalization. Shall I push and then wait until someone guix system reconfigures berlin? Regards, Florian --iookygiwihals7w7 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="nginx-berlin-Redirect-old-video-URLs-for-each-language-v2.patch" >From f07c22a4a8a26a203f3bf27f619d023d4c668cf3 Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Fri, 9 Jul 2021 07:11:00 +0200 Subject: [PATCH] nginx: berlin: Redirect old video URLs for each language. * hydra/nginx/berlin.scm (languages-to-accept): New list. Move here the languages list from ... (%extra-content) ... here. Use languages from 'languages-to-accept'. (guix.gnu.org-redirects-for-each-language): New procedure. Add new video redirections. (guix.gnu.org-redirect-locations): New list. Move here the old redirections. (guix.gnu.org-other-locations): New list. Move here the other nginx locations from ... (guix.gnu.org-locations): ... here. Reimplement in terms of the above. --- hydra/nginx/berlin.scm | 91 +++++++++++++++++++++++++++++++++--------- 1 file changed, 72 insertions(+), 19 deletions(-) diff --git a/hydra/nginx/berlin.scm b/hydra/nginx/berlin.scm index 443294e..912024d 100644 --- a/hydra/nginx/berlin.scm +++ b/hydra/nginx/berlin.scm @@ -188,7 +188,7 @@ PUBLISH-URL." (body (list "root /var/www/guix;")))))) -(define guix.gnu.org-locations +(define guix.gnu.org-redirect-locations (list ;; Short URL for the installation script (redirect "/install.sh" "https://git.savannah.gnu.org/cgit/guix.git/plain/etc/guix-install.sh") @@ -688,15 +688,71 @@ PUBLISH-URL." (redirect "/screenshots/virtual-machine" "/$lang/screenshots/virtual-machine/") (redirect "/screenshots/xfce" "/$lang/screenshots/xfce/") (redirect "/security" "/$lang/security/") - (redirect "/videos" "/$lang/videos/") - (redirect "/videos/asking-for-help" "/$lang/videos/asking-for-help/") - (redirect "/videos/everyday-use-of-gnu-guix,-part-one" "/$lang/videos/everyday-use-of-gnu-guix,-part-one/") - (redirect "/videos/everyday-use-of-gnu-guix,-part-two" "/$lang/videos/everyday-use-of-gnu-guix,-part-two/") - (redirect "/videos/installation-from-script" "/$lang/videos/installation-from-script/") - (redirect "/videos/packaging,-part-one" "/$lang/videos/packaging,-part-one/") - (redirect "/videos/packaging,-part-two" "/$lang/videos/packaging,-part-two/") - (redirect "/videos/packaging,-part-three" "/$lang/videos/packaging,-part-three/") - + (redirect "/videos" "/$lang/videos/"))) + +(define languages-to-accept + ;; List of languages for redirection; see 'accept-languages' further + ;; below. + '(("en") + ("de") + ("eo") + ("es") + ("fr") + ("ko") + ("ru") + ("sk") + ("zh-CN" "zh" "zh-Hans" "zh-Hans-CN"))) + +(define (guix.gnu.org-redirects-for-each-language) + ;; These old URL request paths existed in many forms; without /LANG + ;; in front and with /LANG in front for each language. Redirect + ;; each of them. + (define redirections + (list + (cons "/videos/everyday-use-of-gnu-guix,-part-one" "/videos/2020/everyday-use-of-gnu-guix-part-one/") + (cons "/videos/everyday-use-of-gnu-guix,-part-two" "/videos/2020/everyday-use-of-gnu-guix-part-two/") + (cons "/videos/system-graphical-installer" "/videos/2020/system-graphical-installer/") + (cons "/videos/asking-for-help" "/videos/2020/asking-for-help/") + (cons "/videos/installation-from-script" "/videos/2020/installation-from-script/") + (cons "/videos/packaging,-part-one" "/videos/2020/packaging-part-one/") + (cons "/videos/packaging,-part-two" "/videos/2020/packaging-part-two/") + (cons "/videos/packaging,-part-three" "/videos/2020/packaging-part-three/"))) + + (define (redirect-directory old new) + ;; Match nginx' behavior that request URLs with suffix "", "/" + ;; "/index.html" lead to the same file. The suffix "/" is not taken + ;; care of here because it already gets normalized by nginx location + ;; handling. The URLs in 'guix.gnu.org-redirect-locations' do not + ;; need this treatment, because they get an /index.html suffix + ;; through rewriting. + (let ((old-with-slashes-trimmed (string-trim-right old #\/))) + (list + (redirect old-with-slashes-trimmed new) + (redirect (string-append old-with-slashes-trimmed "/index.html") new)))) + + (define (guix.gnu.org-redirect-locations-for-lang lang) + (define (redirect-lang old new) + (redirect-directory (string-append "/" lang old) + (string-append "/" lang new))) + (append-map redirect-lang (map car redirections) (map cdr redirections))) + + (append + ;; Now all needed redirections are: + ;; + ;; 1) those without /LANG/ in front get redirected to /$lang/ + (append-map redirect-directory + (map car redirections) ;old URLs without /LANG + ;; new URLs with /$lang prepended: + (map (compose (lambda (new-without-lang) + (string-append "/$lang" new-without-lang)) + cdr) + redirections)) + ;; 2) those with /LANG/ in front get redirected to the same /LANG/ + (append-map guix.gnu.org-redirect-locations-for-lang + (map car languages-to-accept)))) + +(define guix.gnu.org-other-locations + (list (nginx-location-configuration (uri "/guix-videos") (body (list "alias /srv/videos;"))) @@ -754,6 +810,11 @@ PUBLISH-URL." (uri "/.well-known") (body (list "root /var/www;"))))) +(define guix.gnu.org-locations + (append guix.gnu.org-redirect-locations + (guix.gnu.org-redirects-for-each-language) + guix.gnu.org-other-locations)) + (define %publish-url "http://localhost:3000") (define %berlin-servers @@ -1033,15 +1094,7 @@ synonymous IETF language tags that should be mapped to the same $lang." "default_type application/octet-stream;" "sendfile on;" - (accept-languages '(("en") - ("de") - ("eo") - ("es") - ("fr") - ("ko") - ("ru") - ("sk") - ("zh-CN" "zh" "zh-Hans" "zh-Hans-CN"))) + (accept-languages languages-to-accept) ;; Maximum chunk size to send. Partly this is a workaround for ;; , but also the nginx docs mention that -- 2.32.0 --iookygiwihals7w7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 09 15:38:57 2021 Received: (at 49431) by debbugs.gnu.org; 9 Jul 2021 19:38:58 +0000 Received: from localhost ([127.0.0.1]:59819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1wKv-00013d-Jc for submit@debbugs.gnu.org; Fri, 09 Jul 2021 15:38:57 -0400 Received: from pelzflorian.de ([5.45.111.108]:58134 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1wKt-00013T-7D for 49431@debbugs.gnu.org; Fri, 09 Jul 2021 15:38:56 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id DE54A360672; Fri, 9 Jul 2021 21:38:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1625859534; bh=rZyAO0k4HL6cAaGPlrkqMvFty9dNH7PpouuQlKJAySE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=rA/F3mWzJUL/FgyidJTGskZXzB9c9fTpJ32Acb8APwcfnDycCIuW5IovX2NzSuRzB 70sqv4gT/js+RtBkOegCSCuzuunVygDgISi373lF8zKv30NDqqF2dlD3oBQ5V0CeyP WDYanmTaVBQgdfDd3cev9VQzMry6ldrhxJdehDg8= Date: Fri, 9 Jul 2021 21:38:44 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#49431] [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Message-ID: <20210709193844.dk4e7q5nanqe7iz7@pelzflorian.localdomain> References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> <87a6mwlxo3.fsf@gnu.org> <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49431 Cc: 49431@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Jul 09, 2021 at 09:15:04AM +0200, pelzflorian (Florian Pelz) wrote: > From: Florian Pelz > > (guix.gnu.org-redirects-for-each-language): New procedure. Add > > new video redirections. […] > > +(define (guix.gnu.org-redirects-for-each-language) > > + ;; These old URL request paths existed in many forms; without /LANG > > + ;; in front and with /LANG in front for each language. Redirect > > + ;; each of them. > > + (define redirections > > + (list > > + (cons "/videos/everyday-use-of-gnu-guix,-part-one" "/videos/2020/everyday-use-of-gnu-guix-part-one/") > > + (cons "/videos/everyday-use-of-gnu-guix,-part-two" "/videos/2020/everyday-use-of-gnu-guix-part-two/") > > + (cons "/videos/system-graphical-installer" "/videos/2020/system-graphical-installer/") > > + (cons "/videos/asking-for-help" "/videos/2020/asking-for-help/") > > + (cons "/videos/installation-from-script" "/videos/2020/installation-from-script/") > > + (cons "/videos/packaging,-part-one" "/videos/2020/packaging-part-one/") > > + (cons "/videos/packaging,-part-two" "/videos/2020/packaging-part-two/") > > + (cons "/videos/packaging,-part-three" "/videos/2020/packaging-part-three/"))) > > + > > + (define (redirect-directory old new) > > + ;; Match nginx' behavior that request URLs with suffix "", "/" > > + ;; "/index.html" lead to the same file. The suffix "/" is not taken > > + ;; care of here because it already gets normalized by nginx location > > + ;; handling. The URLs in 'guix.gnu.org-redirect-locations' do not > > + ;; need this treatment, because they get an /index.html suffix > > + ;; through rewriting. > > + (let ((old-with-slashes-trimmed (string-trim-right old #\/))) > > + (list > > + (redirect old-with-slashes-trimmed new) > > + (redirect (string-append old-with-slashes-trimmed "/index.html") new)))) > > + > > + (define (guix.gnu.org-redirect-locations-for-lang lang) > > + (define (redirect-lang old new) > > + (redirect-directory (string-append "/" lang old) > > + (string-append "/" lang new))) > > + (append-map redirect-lang (map car redirections) (map cdr redirections))) > > + > > + (append > > + ;; Now all needed redirections are: > > + ;; > > + ;; 1) those without /LANG/ in front get redirected to /$lang/ > > + (append-map redirect-directory > > + (map car redirections) ;old URLs without /LANG > > + ;; new URLs with /$lang prepended: > > + (map (compose (lambda (new-without-lang) > > + (string-append "/$lang" new-without-lang)) > > + cdr) > > + redirections)) > > + ;; 2) those with /LANG/ in front get redirected to the same /LANG/ > > + (append-map guix.gnu.org-redirect-locations-for-lang > > + (map car languages-to-accept)))) > Do I need to add a copyright header? I hereby license/declare my > patch CC0 . > […] > Shall I push and then wait until someone guix system reconfigures > berlin? Sorry for again asking such general questions. A better question might be, should 'guix.gnu.org-redirects-for-each-language' go to a separate Guile module with a copyright header (if yes, what could it be named?), or remain in hydra/nginx/berlin.scm despite more complex code, without licensing information? Regards, Florian From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 10 06:27:15 2021 Received: (at 49431) by debbugs.gnu.org; 10 Jul 2021 10:27:15 +0000 Received: from localhost ([127.0.0.1]:60193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ACY-0004zr-S3 for submit@debbugs.gnu.org; Sat, 10 Jul 2021 06:27:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2ACX-0004zd-MT for 49431@debbugs.gnu.org; Sat, 10 Jul 2021 06:27:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58836) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2ACS-0007li-0x; Sat, 10 Jul 2021 06:27:08 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42874 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2ACR-0000HE-Pi; Sat, 10 Jul 2021 06:27:07 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> <87a6mwlxo3.fsf@gnu.org> <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Messidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 10 Jul 2021 12:27:05 +0200 In-Reply-To: <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Fri, 9 Jul 2021 09:15:04 +0200") Message-ID: <87v95iea6e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49431 Cc: 49431@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > On Thu, Jul 08, 2021 at 03:53:16PM +0200, Ludovic Court=C3=A8s wrote: >> Shouldn=E2=80=99t we also redirect >>=20 >> /$lang/videos/everyday-use-of-gnu-guix,-part-one/ -> /$lang/videos/202= 0/everyday-use-of-gnu-guix-part-one/ >>=20 >> since the left-hand side here was the right-hand side of the previous >> redirects? > > Each valid $lang was handled further down, but my patch was confusing, > especially when somebody wants to add more redirections. Find > attached a revised patch with per-language redirection in only one > place, namely new procedure > `guix.gnu.org-redirects-for-each-language'. OK. > Do I need to add a copyright header? I hereby license/declare my > patch CC0 . Currently there=E2=80=99s no explicit license on this file, hydra/nginx/berlin.scm. There=E2=80=99s very little at stake for the sake of transparency, it might= be best to email guix-sysadmins so people who contribute to this file (and to hydra/berlin.scm) agree on the license. The default license in the project would be GPLv3+, but these config files are =E2=80=9Cspecial=E2=80= =9D. > Shall I push and then wait until someone guix system reconfigures > berlin? Yes, please! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 10 09:41:54 2021 Received: (at 49431) by debbugs.gnu.org; 10 Jul 2021 13:41:54 +0000 Received: from localhost ([127.0.0.1]:60318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2DEw-0003R7-Eb for submit@debbugs.gnu.org; Sat, 10 Jul 2021 09:41:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2DEv-0003Qw-P0 for 49431@debbugs.gnu.org; Sat, 10 Jul 2021 09:41:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33114) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2DEm-0007aT-Jy; Sat, 10 Jul 2021 09:41:44 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42884 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2DEm-0007oP-CE; Sat, 10 Jul 2021 09:41:44 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "pelzflorian (Florian Pelz)" Subject: Re: [bug#49431] [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> <87a6mwlxo3.fsf@gnu.org> <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> <20210709193844.dk4e7q5nanqe7iz7@pelzflorian.localdomain> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Messidor an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 10 Jul 2021 15:41:43 +0200 In-Reply-To: <20210709193844.dk4e7q5nanqe7iz7@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Fri, 9 Jul 2021 21:38:44 +0200") Message-ID: <87a6mue160.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49431 Cc: 49431@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, "pelzflorian (Florian Pelz)" skribis: > Sorry for again asking such general questions. A better question > might be, should 'guix.gnu.org-redirects-for-each-language' go to a > separate Guile module with a copyright header (if yes, what could it > be named?), or remain in hydra/nginx/berlin.scm despite more complex > code, without licensing information? Let=E2=80=99s keep it in hydra/nginx/berlin.scm for now, and split in sever= al files later if we feel it=E2=80=99s becoming too messy. (As for copyright,= it=E2=80=99s not even clear to me that a list of redirects is copyrightable per se since it there=E2=80=99s only one way to do it.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 10 15:29:20 2021 Received: (at 49431-done) by debbugs.gnu.org; 10 Jul 2021 19:29:20 +0000 Received: from localhost ([127.0.0.1]:33498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2IfA-0003jO-7Q for submit@debbugs.gnu.org; Sat, 10 Jul 2021 15:29:20 -0400 Received: from pelzflorian.de ([5.45.111.108]:59346 helo=mail.pelzflorian.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2If4-0003ia-TT for 49431-done@debbugs.gnu.org; Sat, 10 Jul 2021 15:29:18 -0400 Received: from pelzflorian.localdomain (unknown [5.45.111.108]) by mail.pelzflorian.de (Postfix) with ESMTPSA id 574CB360672; Sat, 10 Jul 2021 21:28:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pelzflorian.de; s=mail; t=1625945322; bh=Gg1hHpNOyWFwitI0UavqD+1HlbxhLbEGbOluRRF5mhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=XkITAi87WJw5a/RqZdqpenbW8t2/WaASi4ncaMqdli9xrgysOqcidsz2GsqlOZcZP s6JU6lizO2jVnBU/TIt2AM4F8oHUk2Wb6b7o4X2HOLstOO3duJNBf+z6TmVVEccR5+ w/YZ/vBI1Mt99hnJe7m912YtelnbjjAo5BwK1N2s= Date: Sat, 10 Jul 2021 21:28:32 +0200 From: "pelzflorian (Florian Pelz)" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#49431: [PATCH maintenance.git] nginx: berlin: Redirect old video URLs for each language. Message-ID: <20210710192832.wwvgw3zc24ufhbju@pelzflorian.localdomain> References: <20210706065304.6kqbwqlcf6calkh7@pelzflorian.localdomain> <87a6mwlxo3.fsf@gnu.org> <20210709070715.235m7qs3gicmms4w@pelzflorian.localdomain> <87v95iea6e.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87v95iea6e.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49431-done Cc: 49431-done@debbugs.gnu.org, Luis Felipe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jul 10, 2021 at 12:27:05PM +0200, Ludovic Courtès wrote: > "pelzflorian (Florian Pelz)" skribis: > > Do I need to add a copyright header? I hereby license/declare my > > patch CC0 . > > Currently there’s no explicit license on this file, > hydra/nginx/berlin.scm. > > There’s very little at stake for the sake of transparency, it might be > best to email guix-sysadmins so people who contribute to this file (and > to hydra/berlin.scm) agree on the license. The default license in the > project would be GPLv3+, but these config files are “special”. I will send a mail with a patch there. Thank you. > > Shall I push and then wait until someone guix system reconfigures > > berlin? > > Yes, please! Finally pushed as 2d6dc5e01aa32a01b345ba834e32bbf723e67077. Old video URLs will be redirected after guix system reconfigure. Regards, Florian From unknown Fri Jun 20 18:13:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 08 Aug 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator