From unknown Mon Aug 18 14:16:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4941 <4941@debbugs.gnu.org> To: bug#4941 <4941@debbugs.gnu.org> Subject: Status: hexl mode update Reply-To: bug#4941 <4941@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:16:13 +0000 retitle 4941 hexl mode update reassign 4941 emacs submitter 4941 Vivek Dasmohapatra severity 4941 wishlist tag 4941 fixed patch thanks From rgm@gnu.org Mon Nov 16 13:44:08 2009 Received: (at quiet) by emacsbugs.donarmstrong.com; 16 Nov 2009 21:44:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGLi7wt009976 for ; Mon, 16 Nov 2009 13:44:08 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NA9Mk-0005pI-T5 for quiet@emacsbugs.donarmstrong.com; Mon, 16 Nov 2009 16:44:06 -0500 From: Vivek Dasmohapatra To: quiet@debbugs.gnu.org Subject: Re: hexl mode update In-Reply-To: Date: Tue, 21 Jul 2009 01:44:58 +0100 (BST) Lines: 271 References: X-From-Line: emacs-devel-bounces+rgm=gnu.org@gnu.org Mon Jul 20 20:46:16 2009 Received: from mx10.gnu.org ([199.232.76.166]:55331) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MT3Ul-00085q-HM for rgm@gnu.org; Mon, 20 Jul 2009 20:46:16 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MT3Uj-0008OX-7s for rgm@gnu.org; Mon, 20 Jul 2009 20:46:14 -0400 Received: from lists.gnu.org ([199.232.76.165]:33902) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MT3Uh-0008OF-BQ for rgm@gnu.org; Mon, 20 Jul 2009 20:46:11 -0400 Received: from localhost ([127.0.0.1]:51962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MT3Uh-00045a-6A for rgm@gnu.org; Mon, 20 Jul 2009 20:46:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MT3U6-00045T-B9 for emacs-devel@gnu.org; Mon, 20 Jul 2009 20:45:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MT3U4-00045H-Bf for emacs-devel@gnu.org; Mon, 20 Jul 2009 20:45:33 -0400 Received: from [199.232.76.173] (port=55149 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MT3U4-00045E-5p for emacs-devel@gnu.org; Mon, 20 Jul 2009 20:45:32 -0400 Received: from flounder.pepperfish.net ([87.237.62.181]:51129) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MT3U3-00083v-BI for emacs-devel@gnu.org; Mon, 20 Jul 2009 20:45:31 -0400 Received: from [213.165.225.94] (helo=[192.168.0.5]) by flounder.pepperfish.net with esmtpsa (Exim 4.69 #1 (Debian)) id 1MT3Te-00075e-Om for ; Tue, 21 Jul 2009 01:45:07 +0100 X-X-Sender: vivek@localhost X-Debbugs-No-Ack: yes X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+rgm=gnu.org@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Message-ID: <5qd43icfh5.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Sender: Glenn Morris --=-=-= Content-Type: text/plain; format=flowed Severity: wishlist Tags: patch [ Resent from http://lists.gnu.org/archive/html/emacs-devel/2009-07/msg01028.html ] On Thu, 16 Jul 2009, Stefan Monnier wrote: >>> Now would be a good time to submit it, >> Ok. Is there any particular branch/repo/etc you'd like a patch against? > > CVS trunk. Note that I haven't looked at your code yet. Please send it > to emacs-devel@gnu.org. Here it is. The user can select the "word size" hexl will use with defcustom (it currently screws up if you change this size behind hexl's back, ie after hexlifying a buffer but before unhexlifying it: this could be fixed by saving the word size used in a a local variable in the hexl buffer, let me know if you think this is important enough to add). Other than that, the hexl code doesn't seem to have changed since I last updated the patch from emacs 22 to emacs 23. The word-size could also be chosen at invocation time via a prefix arg, but I have not done this yet either: Again, let me know if you think it's worth adding. I originally prepared this patch for a friend who was debugging something and needed other word sizes: Upon investigation I discovered that the hexl binary had support for the word sizes 8, 16, 32 and 64 bits but the hexl mode code only supported one of those - hence this patch. --=-=-= Content-Type: text/x-diff; name=hexl.variable-word-size.2009-07-21.patch Content-ID: Content-Disposition: attachment; filename=hexl.variable-word-size.2009-07-21.patch Content-Transfer-Encoding: 8bit Content-Description: diff --git a/lisp/hexl.el b/lisp/hexl.el index 2cdd449..0eebe55 100644 --- a/lisp/hexl.el +++ b/lisp/hexl.el @@ -51,6 +51,13 @@ "Edit a file in a hex dump format using the hexl filter." :group 'data) +(defcustom hexl-bits 16 + "The bit grouping that hexl will use" + :type '(choice (const 8 ) + (const 16) + (const 32) + (const 64)) + :group 'hexl) (defcustom hexl-program "hexl" "The program that will hexlify and dehexlify its stdin. @@ -135,6 +142,15 @@ Quoting cannot be used, so the arguments cannot themselves contain spaces." (put 'hexl-mode 'mode-class 'special) +;; 10 chars for the "address: " +;; 32 chars for the hexlified bytes +;; 1 char for the space +;; 16 chars for the character display +;; X chars for the spaces (128 bits divided by the hexl-bits) +;; 1 char for the newline. +(defun hexl-line-displen () + (+ 60 (/ 128 (or hexl-bits 16)))) + ;;;###autoload (defun hexl-mode (&optional arg) "\\A mode for editing binary files in hex dump format. @@ -213,27 +229,33 @@ You can use \\[hexl-find-file] to visit a file in Hexl mode. (unless (eq major-mode 'hexl-mode) (let ((modified (buffer-modified-p)) (inhibit-read-only t) - (original-point (- (point) (point-min)))) + (original-point (- (point) (point-min))) + max-address) (and (eobp) (not (bobp)) (setq original-point (1- original-point))) - ;; If `hexl-mode' is invoked with an argument the buffer is assumed to - ;; be in hexl format. - (when (memq arg '(1 nil)) + (if (not (memq arg '(1 nil))) + ;; if no argument then we guess at hexl-max-address + (setq max-address + (+ (* (/ (1- (buffer-size)) (hexl-line-displen)) 16) 15)) + (setq max-address (1- (buffer-size))) ;; If the buffer's EOL type is -dos, we need to account for ;; extra CR characters added when hexlify-buffer writes the ;; buffer to a file. ;; FIXME: This doesn't take into account multibyte coding systems. (when (eq (coding-system-eol-type buffer-file-coding-system) 1) - (setq original-point (+ (count-lines (point-min) (point)) + (setq max-address (+ (count-lines (point-min) (point-max)) + max-address)) + ;; But if there's no newline at the last line, we are off by + ;; one; adjust. + (or (eq (char-before (point-max)) ?\n) + (setq max-address (1- max-address))) + (setq original-point (+ (count-lines (point-min) (point)) original-point)) (or (bolp) (setq original-point (1- original-point)))) (hexlify-buffer) (restore-buffer-modified-p modified)) - (set (make-local-variable 'hexl-max-address) - (let* ((full-lines (/ (buffer-size) 68)) - (last-line (% (buffer-size) 68)) - (last-line-bytes (% last-line 52))) - (+ last-line-bytes (* full-lines 16) -1))) + (make-local-variable 'hexl-max-address) + (setq hexl-max-address max-address) (condition-case nil (hexl-goto-address original-point) (error nil))) @@ -436,19 +458,23 @@ Ask the user for confirmation." (defun hexl-current-address (&optional validate) "Return current hexl-address." (interactive) - (let ((current-column (- (% (- (point) (point-min) -1) 68) 11)) + (let ((current-column + (- (% (- (point) (point-min) -1) (hexl-line-displen)) 11)) (hexl-address 0)) (if (< current-column 0) (if validate (error "Point is not on a character in the file") (setq current-column 0))) (setq hexl-address - (+ (* (/ (- (point) (point-min) -1) 68) 16) - (if (>= current-column 41) - (- current-column 41) - (/ (- current-column (/ current-column 5)) 2)))) + (+ (* (/ (- (point) (point-min) -1) + (hexl-line-displen)) 16) + (if (>= current-column (- (hexl-ascii-start-column) 10)) + (- current-column (- (hexl-ascii-start-column) 10)) + (/ (- current-column + (/ current-column (1+ (/ hexl-bits 4)))) 2) )) ) (when (interactive-p) - (message "Current address is %d/0x%08x" hexl-address hexl-address)) + (message "Current address is [column: %d] %d/0x%08x" + current-column hexl-address hexl-address)) hexl-address)) (defun hexl-print-current-point-info () @@ -457,10 +483,18 @@ This function is intended to be used as eldoc callback." (let ((addr (hexl-current-address))) (format "Current address is %d/0x%08x" addr addr))) +(defun hexl-ascii-start-column () + "Column at which the ascii display starts." + (+ 43 (/ 128 hexl-bits))) + (defun hexl-address-to-marker (address) "Return buffer position for ADDRESS." (interactive "nAddress: ") - (+ (* (/ address 16) 68) 10 (point-min) (/ (* (% address 16) 5) 2))) + (let ((N (* (% address 16) 2))) + (+ (* (/ address 16) (hexl-line-displen)) ; hexl line no * display length + 10 ; 10 chars for the "address: " prefix + (point-min) ; base offset (point usually starts at 1, not 0) + (+ N (/ N (/ hexl-bits 4))) )) ) ; char offset into hexl display line (defun hexl-goto-address (address) "Go to hexl-mode (decimal) address ADDRESS. @@ -505,7 +539,7 @@ Signal error if HEX-ADDRESS is out of range." (hexl-goto-address (- (hexl-current-address) arg))) (defun hexl-forward-char (arg) - "Move to right ARG bytes (left if ARG negative) in hexl-mode." + "Move right ARG bytes (left if ARG negative) in hexl-mode." (interactive "p") (hexl-goto-address (+ (hexl-current-address) arg))) @@ -544,7 +578,7 @@ Signal error if HEX-ADDRESS is out of range." address))) (defun hexl-forward-short (arg) - "Move to right ARG shorts (left if ARG negative) in hexl-mode." + "Move right ARG shorts (left if ARG negative) in hexl-mode." (interactive "p") (hexl-backward-short (- arg))) @@ -583,7 +617,7 @@ Signal error if HEX-ADDRESS is out of range." address))) (defun hexl-forward-word (arg) - "Move to right ARG words (left if ARG negative) in hexl-mode." + "Move right ARG words (left if ARG negative) in hexl-mode." (interactive "p") (hexl-backward-word (- arg))) @@ -630,7 +664,7 @@ With prefix arg N, puts point N bytes of the way from the true beginning." (defun hexl-beginning-of-line () "Goto beginning of line in hexl mode." (interactive) - (goto-char (+ (* (/ (point) 68) 68) 11))) + (goto-char (+ (* (/ (point) (hexl-line-displen)) (hexl-line-displen)) 11))) (defun hexl-end-of-line () "Goto end of line in hexl mode." @@ -675,12 +709,12 @@ If there's no byte at the target address, move to the first or last line." (recenter 0))) (defun hexl-beginning-of-1k-page () - "Go to beginning of 1KB boundary." + "Go to the beginning of the current 1 KiB block" (interactive) (hexl-goto-address (logand (hexl-current-address) -1024))) (defun hexl-end-of-1k-page () - "Go to end of 1KB boundary." + "Go to the end of the current 1 KiB block." (interactive) (hexl-goto-address (let ((address (logior (hexl-current-address) 1023))) (if (> address hexl-max-address) @@ -710,6 +744,15 @@ You may also type octal digits, to insert a character with that code." ;00000000: 0011 2233 4455 6677 8899 aabb ccdd eeff 0123456789ABCDEF +(defun hexl-options (&optional test) + (let ((opts (or test hexl-options))) + (when (memq hexl-bits '(8 16 32 64)) + (when (string-match "\\(.*\\)-group-by-[0-9]+-bits\\(.*\\)" opts) + (setq opts (concat (match-string 1 opts) + (match-string 2 opts))) ) + (setq opts (format "%s -group-by-%d-bits " opts hexl-bits)) ) + opts)) + ;;;###autoload (defun hexlify-buffer () "Convert a binary buffer to hexl format. @@ -732,7 +775,7 @@ This discards the buffer's undo information." (mapcar (lambda (s) (if (not (multibyte-string-p s)) s (encode-coding-string s locale-coding-system))) - (split-string hexl-options))) + (split-string (hexl-options)))) (if (> (point) (hexl-address-to-marker hexl-max-address)) (hexl-goto-address hexl-max-address)))) @@ -749,7 +792,7 @@ This discards the buffer's undo information." (buffer-undo-list t)) (apply 'call-process-region (point-min) (point-max) (expand-file-name hexl-program exec-directory) - t t nil "-de" (split-string hexl-options)))) + t t nil "-de" (split-string (hexl-options))))) (defun hexl-char-after-point () "Return char for ASCII hex digits at point." @@ -846,12 +889,15 @@ CH must be a unibyte character whose value is between 0 and 255." (let ((address (hexl-current-address t))) (while (> num 0) (let ((hex-position - (+ (* (/ address 16) 68) + (+ (* (/ address 16) (hexl-line-displen)) 10 (point-min) (* 2 (% address 16)) (/ (% address 16) 2))) (ascii-position - (+ (* (/ address 16) 68) 51 (point-min) (% address 16))) + (+ (* (/ address 16) (hexl-line-displen)) + (hexl-ascii-start-column) + (point-min) + (% address 16))) at-ascii-position) (if (= (point) ascii-position) (setq at-ascii-position t)) @@ -867,7 +913,7 @@ CH must be a unibyte character whose value is between 0 and 255." (if at-ascii-position (progn (beginning-of-line) - (forward-char 51) + (forward-char (hexl-ascii-start-column)) (forward-char (% address 16))))) (setq num (1- num))))) @@ -985,7 +1031,7 @@ This function is assumed to be used as callback function for `hl-line-mode'." (defun hexl-follow-ascii-find () "Find and highlight the ASCII element corresponding to current point." - (let ((pos (+ 51 + (let ((pos (+ (hexl-ascii-start-column) (- (point) (current-column)) (mod (hexl-current-address) 16)))) (move-overlay hexl-ascii-overlay pos (1+ pos)) --=-=-=-- From vivek@etla.org Wed Dec 16 05:21:18 2009 Received: (at 4941) by emacsbugs.donarmstrong.com; 16 Dec 2009 13:21:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from flounder.pepperfish.net (flounder.pepperfish.net [87.237.62.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBGDLGw0032618 for <4941@emacsbugs.donarmstrong.com>; Wed, 16 Dec 2009 05:21:18 -0800 Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.69 #1 (Debian)) id 1NKtoD-0001cR-Nj for <4941@emacsbugs.donarmstrong.com>; Wed, 16 Dec 2009 13:20:53 +0000 Date: Wed, 16 Dec 2009 13:20:34 +0000 (GMT) From: Vivek Dasmohapatra X-X-Sender: vivek@octopus.pepperfish.net To: 4941@debbugs.gnu.org Subject: hexl mode update (variable word size in hexl mode) Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII So, is anyone going to look at this? Vaguely encouraging noises were made the first time I submitted it, but that was many months (possibly even a few years) ago now, and no-one seems to have taken any interest in it since: I don't mind if it's not wanted, but I'd rather know one way or another. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 23 22:57:59 2009 Received: (at 4941) by debbugs.gnu.org; 24 Dec 2009 03:57:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNepq-0005Mg-9h for submit@debbugs.gnu.org; Wed, 23 Dec 2009 22:57:58 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNeR3-00059k-CA for 4941@emacsbugs.donarmstrong.com; Wed, 23 Dec 2009 22:32:21 -0500 Received: from alfajor.home (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nBO3WCH2029305; Wed, 23 Dec 2009 22:32:14 -0500 Received: by alfajor.home (Postfix, from userid 20848) id 4DB4C6435B; Wed, 23 Dec 2009 22:32:12 -0500 (EST) From: Stefan Monnier To: Vivek Dasmohapatra Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) Message-ID: References: Date: Wed, 23 Dec 2009 22:32:12 -0500 In-Reply-To: (Vivek Dasmohapatra's message of "Wed, 16 Dec 2009 13:20:34 +0000 (GMT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3434=0 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 4941 X-Mailman-Approved-At: Wed, 23 Dec 2009 22:57:57 -0500 Cc: 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.2 (/) > So, is anyone going to look at this? Vaguely encouraging noises were made > the first time I submitted it, but that was many months (possibly even a few > years) ago now, and no-one seems to have taken any interest in it since: > I don't mind if it's not wanted, but I'd rather know one way or another. Sorry, I think this should be installed, but since we're already in feature freeze again, we can't do it now. As soon as we open up the Emacs-24 branch (which should be real soon now, really), please come back with a vengeance. Say around end of January. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 24 13:38:23 2009 Received: (at 4941) by debbugs.gnu.org; 24 Dec 2009 18:38:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNsZq-00058b-SV for submit@debbugs.gnu.org; Thu, 24 Dec 2009 13:38:23 -0500 Received: from flounder.pepperfish.net ([87.237.62.181]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNsLe-00051D-By for 4941@emacsbugs.donarmstrong.com; Thu, 24 Dec 2009 13:23:42 -0500 Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.69 #1 (Debian)) id 1NNsLD-0000Dd-Dh for <4941@emacsbugs.donarmstrong.com>; Thu, 24 Dec 2009 18:23:15 +0000 Date: Thu, 24 Dec 2009 18:23:13 +0000 (GMT) From: Vivek Dasmohapatra X-X-Sender: vivek@octopus.pepperfish.net To: 4941@debbugs.gnu.org Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 4941 X-Mailman-Approved-At: Thu, 24 Dec 2009 13:38:21 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.3 (-) Ok, I'll keep an eye out for the 24 branch. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 11 09:58:02 2012 Received: (at 4941) by debbugs.gnu.org; 11 Apr 2012 13:58:02 +0000 Received: from localhost ([127.0.0.1]:52072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHy3c-0004Qo-UT for submit@debbugs.gnu.org; Wed, 11 Apr 2012 09:58:02 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:54831) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHy3a-0004Qg-5j for 4941@debbugs.gnu.org; Wed, 11 Apr 2012 09:57:59 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHy2K-0004kI-Gh; Wed, 11 Apr 2012 15:56:40 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) References: X-Now-Playing: Hector Zazou & Swara's _In the House of Mirrors_: "Kanoon Ampa" Date: Wed, 11 Apr 2012 15:56:39 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 23 Dec 2009 22:32:12 -0500") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SHy2K-0004kI-Gh X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334757401.09858@iY1pt4POP+OiaKKIqLjjTA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Vivek Dasmohapatra , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >> So, is anyone going to look at this? Vaguely encouraging noises were made >> the first time I submitted it, but that was many months (possibly even a few >> years) ago now, and no-one seems to have taken any interest in it since: >> I don't mind if it's not wanted, but I'd rather know one way or another. > > Sorry, I think this should be installed, but since we're already in > feature freeze again, we can't do it now. As soon as we open up the > Emacs-24 branch (which should be real soon now, really), please come > back with a vengeance. Say around end of January. Vengeance apparently kinda slow, but perhaps now is the time? The patch still mostly applies cleanly (one block fails), but I'm not a hexl user, so I can't really test the result with great confidence. Vivek, would it be possible for you to re-spin the patch (and test), and then I can apply it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 11 11:04:04 2012 Received: (at 4941) by debbugs.gnu.org; 11 Apr 2012 15:04:04 +0000 Received: from localhost ([127.0.0.1]:52228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHz5X-0008UE-HG for submit@debbugs.gnu.org; Wed, 11 Apr 2012 11:04:04 -0400 Received: from flounder.pepperfish.net ([89.238.129.35]:43865) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHz5T-0008Tk-FI for 4941@debbugs.gnu.org; Wed, 11 Apr 2012 11:04:01 -0400 Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.71 #1 (Debian)) id 1SHz4K-0007RR-P2; Wed, 11 Apr 2012 16:02:48 +0100 Date: Wed, 11 Apr 2012 16:02:44 +0100 (BST) From: Vivek Dasmohapatra X-X-Sender: vivek@octopus.pepperfish.net To: Lars Magne Ingebrigtsen Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-751982310-1334156568=:21340" X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Stefan Monnier , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-751982310-1334156568=:21340 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Wed, 11 Apr 2012, Lars Magne Ingebrigtsen wrote: > Vengeance apparently kinda slow, but perhaps now is the time? > > The patch still mostly applies cleanly (one block fails), but I'm not a > hexl user, so I can't really test the result with great confidence. > > Vivek, would it be possible for you to re-spin the patch (and test), and > then I can apply it. I've done some preliminary testing, seems to work (updated patch is against master, but most of the relevant changes seem to have happened during the emacs 23.x time frame anyway) It's currently controlled by a defcustom, but maybe it should be a prefix arg to hexl-find-file or hexl-mode instead? I don't use hexl a huge amount myself so I'm not sure what its users would prefer. --8323329-751982310-1334156568=:21340 Content-Type: TEXT/x-diff; name=0001-Allow-hexl-mode-to-use-8-16-32-or-64-bit-hexl-word-s.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Allow-hexl-mode-to-use-8-16-32-or-64-bit-hexl-word-s.patch RnJvbSBkZDMxYTkxMmQ1NWI0ZWQ4MGMyNmJkYjgyZDVmNWI3MWJkN2UxNDYx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogVml2ZWsgRGFzbW9o YXBhdHJhIDx2aXZla0Bjb2xsYWJvcmEuY28udWs+DQpEYXRlOiBXZWQsIDEx IEFwciAyMDEyIDE1OjU1OjIwICswMTAwDQpTdWJqZWN0OiBbUEFUQ0hdIEFs bG93IGhleGwgbW9kZSB0byB1c2UgOCwgMTYsIDMyIG9yIDY0IGJpdCBoZXhs IHdvcmQgc2l6ZXMNCg0KLS0tDQogbGlzcC9oZXhsLmVsIHwgIDEwNiArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tDQogMSBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCsp LCAyNSBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvaGV4bC5l bCBiL2xpc3AvaGV4bC5lbA0KaW5kZXggNTM4ZDIxOC4uYmNkMTdiMCAxMDA2 NDQNCi0tLSBhL2xpc3AvaGV4bC5lbA0KKysrIGIvbGlzcC9oZXhsLmVsDQpA QCAtNTEsNiArNTEsMTMgQEANCiAgICJFZGl0IGEgZmlsZSBpbiBhIGhleCBk dW1wIGZvcm1hdCB1c2luZyB0aGUgaGV4bCBmaWx0ZXIuIg0KICAgOmdyb3Vw ICdkYXRhKQ0KIA0KKyhkZWZjdXN0b20gaGV4bC1iaXRzIDE2DQorICAiVGhl IGJpdCBncm91cGluZyB0aGF0IGhleGwgd2lsbCB1c2UuIg0KKyAgOnR5cGUg JyhjaG9pY2UgKGNvbnN0IDggKQ0KKyAgICAgICAgICAgICAgICAgKGNvbnN0 IDE2KQ0KKyAgICAgICAgICAgICAgICAgKGNvbnN0IDMyKQ0KKyAgICAgICAg ICAgICAgICAgKGNvbnN0IDY0KSkNCisgIDpncm91cCAnaGV4bCkNCiANCiAo ZGVmY3VzdG9tIGhleGwtcHJvZ3JhbSAiaGV4bCINCiAgICJUaGUgcHJvZ3Jh bSB0aGF0IHdpbGwgaGV4bGlmeSBhbmQgZGVoZXhsaWZ5IGl0cyBzdGRpbi4N CkBAIC02Nyw3ICs3NCw5IEBAIGFuZCBcIi1kZVwiIHdoZW4gZGVoZXhsaWZ5 aW5nIGEgYnVmZmVyLiINCiANCiAoZGVmY3VzdG9tIGhleGwtb3B0aW9ucyAo Zm9ybWF0ICItaGV4ICVzIiBoZXhsLWlzbykNCiAgICJTcGFjZSBzZXBhcmF0 ZWQgb3B0aW9ucyB0byBgaGV4bC1wcm9ncmFtJyB0aGF0IHN1aXQgeW91ciBu ZWVkcy4NCi1RdW90aW5nIGNhbm5vdCBiZSB1c2VkLCBzbyB0aGUgYXJndW1l bnRzIGNhbm5vdCB0aGVtc2VsdmVzIGNvbnRhaW4gc3BhY2VzLiINCitRdW90 aW5nIGNhbm5vdCBiZSB1c2VkLCBzbyB0aGUgYXJndW1lbnRzIGNhbm5vdCB0 aGVtc2VsdmVzIGNvbnRhaW4gc3BhY2VzLg0KK0lmIHlvdSB3aXNoIHRvIHNl dCB0aGUgYC1ncm91cC1ieS1YLWJpdHMnIG9wdGlvbnMsIHNldCBgaGV4bC1i aXRzJyBpbnN0ZWFkLA0KK2FzIHRoYXQgd2lsbCBvdmVycmlkZSBhbnkgYml0 IGdyb3VwaW5nIG9wdGlvbnMgc2V0IGhlcmUuIg0KICAgOnR5cGUgJ3N0cmlu Zw0KICAgOmdyb3VwICdoZXhsKQ0KIA0KQEAgLTIxMiwxMCArMjIxLDM1IEBA IFF1b3RpbmcgY2Fubm90IGJlIHVzZWQsIHNvIHRoZSBhcmd1bWVudHMgY2Fu bm90IHRoZW1zZWx2ZXMgY29udGFpbiBzcGFjZXMuIg0KICAgICAgKDIgJ2hl eGwtYXNjaWktcmVnaW9uIHQgdCkpKQ0KICAgIkZvbnQgbG9jayBrZXl3b3Jk cyB1c2VkIGluIGBoZXhsLW1vZGUnLiIpDQogDQorKGRlZnVuIGhleGwtcnVs ZXJpc2UgKHN0cmluZyBiaXRzKSANCisgIChsZXQgKChzaXplICgvIGJpdHMg NCkpIChzdHJsZW4gKGxlbmd0aCBzdHJpbmcpKSAocG9zIDApIChydWxlciAi IikpDQorICAgICh3aGlsZSAoPCBwb3Mgc3RybGVuKQ0KKyAgICAgIChzZXRx IHJ1bGVyIChjb25jYXQgcnVsZXIgIiAiIChzdWJzdHJpbmcgc3RyaW5nIHBv cyAoKyBwb3Mgc2l6ZSkpKSkNCisgICAgICAoc2V0cSBwb3MgKCsgcG9zIHNp emUpKSkNCisgICAgKHN1YnN0cmluZyBydWxlciAxKSApKQ0KKw0KKyhkZWZ2 YXIgaGV4bC1ydWxlcnMgDQorICAobWFwY2FyIA0KKyAgIChsYW1iZGEgKGJp dHMpIA0KKyAgICAgKGNvbnMgYml0cw0KKyAgICAgICAgICAgKGNvbmNhdCAi IDg3NjU0MzIxICAiIA0KKyAgICAgICAgICAgICAgICAgICAoaGV4bC1ydWxl cmlzZSAiMDAxMTIyMzM0NDU1NjY3Nzg4OTlhYWJiY2NkZGVlZmYiIGJpdHMp IA0KKyAgICAgICAgICAgICAgICAgICAiICAwMTIzNDU2Nzg5YWJjZGVmIikp KQ0KKyAgICcoOCAxNiAzMiA2NCkpKQ0KIDs7IHJvdXRpbmVzDQogDQogKHB1 dCAnaGV4bC1tb2RlICdtb2RlLWNsYXNzICdzcGVjaWFsKQ0KIA0KKzs7IDEw IGNoYXJzIGZvciB0aGUgImFkZHJlc3M6ICINCis7OyAzMiBjaGFycyBmb3Ig dGhlIGhleGxpZmllZCBieXRlcw0KKzs7IDEgY2hhciBmb3IgdGhlIHNwYWNl IA0KKzs7IDE2IGNoYXJzIGZvciB0aGUgY2hhcmFjdGVyIGRpc3BsYXkNCis7 OyBYIGNoYXJzIGZvciB0aGUgc3BhY2VzICgxMjggYml0cyBkaXZpZGVkIGJ5 IHRoZSBoZXhsLWJpdHMpDQorOzsgMSBjaGFyIGZvciB0aGUgbmV3bGluZS4N CisoZGVmdW4gaGV4bC1saW5lLWRpc3BsZW4gKCkNCisgICJUaGUgbGVuZ3Ro IG9mIGEgaGV4bCBkaXNwbGF5IGxpbmUgKHZhcmllcyB3aXRoIGBoZXhsLWJp dHMnKS4iDQorICAoKyA2MCAoLyAxMjggKG9yIGhleGwtYml0cyAxNikpKSkN Cis7OyAtLQ0KIA0KIChkZWZ1biBoZXhsLW1vZGUtLW1pbm9yLW1vZGUtcCAo dmFyKQ0KICAgKG1lbXEgdmFyICcocnVsZXItbW9kZSBobC1saW5lLW1vZGUp KSkNCkBAIC0yNDgsNyArMjgyLDcgQEAgdXNpbmcgdGhlIGZ1bmN0aW9uIGBo ZXhsaWZ5LWJ1ZmZlcicuDQogRWFjaCBsaW5lIGluIHRoZSBidWZmZXIgaGFz IGFuIFwiYWRkcmVzc1wiIChkaXNwbGF5ZWQgaW4gaGV4YWRlY2ltYWwpDQog cmVwcmVzZW50aW5nIHRoZSBvZmZzZXQgaW50byB0aGUgZmlsZSB0aGF0IHRo ZSBjaGFyYWN0ZXJzIG9uIHRoaXMgbGluZQ0KIGFyZSBhdCBhbmQgMTYgY2hh cmFjdGVycyBmcm9tIHRoZSBmaWxlIChkaXNwbGF5ZWQgYXMgaGV4YWRlY2lt YWwNCi12YWx1ZXMgZ3JvdXBlZCBldmVyeSAxNiBiaXRzKSBhbmQgYXMgdGhl aXIgQVNDSUkgdmFsdWVzLg0KK3ZhbHVlcyBncm91cGVkIGV2ZXJ5IGBoZXhs LWJpdHMnIGJpdHMpIGFuZCBhcyB0aGVpciBBU0NJSSB2YWx1ZXMuDQogDQog SWYgYW55IG9mIHRoZSBjaGFyYWN0ZXJzIChkaXNwbGF5ZWQgYXMgQVNDSUkg Y2hhcmFjdGVycykgYXJlDQogdW5wcmludGFibGUgKGNvbnRyb2wgb3IgbWV0 YSBjaGFyYWN0ZXJzKSB0aGV5IHdpbGwgYmUgcmVwbGFjZWQgYXMNCkBAIC0z MzAsMTAgKzM2NCw3IEBAIFlvdSBjYW4gdXNlIFxcW2hleGwtZmluZC1maWxl XSB0byB2aXNpdCBhIGZpbGUgaW4gSGV4bCBtb2RlLg0KICAgICAgICAgKGhl eGxpZnktYnVmZmVyKQ0KICAgICAgICAgKHJlc3RvcmUtYnVmZmVyLW1vZGlm aWVkLXAgbW9kaWZpZWQpKQ0KICAgICAgIChzZXQgKG1ha2UtbG9jYWwtdmFy aWFibGUgJ2hleGwtbWF4LWFkZHJlc3MpDQotICAgICAgICAgICAobGV0KiAo KGZ1bGwtbGluZXMgKC8gKGJ1ZmZlci1zaXplKSA2OCkpDQotICAgICAgICAg ICAgICAgICAgKGxhc3QtbGluZSAoJSAoYnVmZmVyLXNpemUpIDY4KSkNCi0g ICAgICAgICAgICAgICAgICAobGFzdC1saW5lLWJ5dGVzICglIGxhc3QtbGlu ZSA1MikpKQ0KLSAgICAgICAgICAgICAoKyBsYXN0LWxpbmUtYnl0ZXMgKCog ZnVsbC1saW5lcyAxNikgLTEpKSkNCisgICAgICAgICAgICgrICgqICgvICgx LSAoYnVmZmVyLXNpemUpKSAoaGV4bC1saW5lLWRpc3BsZW4pKSAxNikgMTUp KQ0KICAgICAgIChjb25kaXRpb24tY2FzZSBuaWwNCiAJICAoaGV4bC1nb3Rv LWFkZHJlc3Mgb3JpZ2luYWwtcG9pbnQpDQogCShlcnJvciBuaWwpKSkNCkBA IC01MTAsMTcgKzU0MSwyMCBAQCBBc2sgdGhlIHVzZXIgZm9yIGNvbmZpcm1h dGlvbi4iDQogKGRlZnVuIGhleGwtY3VycmVudC1hZGRyZXNzICgmb3B0aW9u YWwgdmFsaWRhdGUpDQogICAiUmV0dXJuIGN1cnJlbnQgaGV4bC1hZGRyZXNz LiINCiAgIChpbnRlcmFjdGl2ZSkNCi0gIChsZXQgKChjdXJyZW50LWNvbHVt biAoLSAoJSAoLSAocG9pbnQpIChwb2ludC1taW4pIC0xKSA2OCkgMTEpKQ0K KyAgKGxldCAoKGN1cnJlbnQtY29sdW1uIA0KKyAgICAgICAgICgtICglICgt IChwb2ludCkgKHBvaW50LW1pbikgLTEpIChoZXhsLWxpbmUtZGlzcGxlbikp IDExKSkNCiAJKGhleGwtYWRkcmVzcyAwKSkNCiAgICAgKGlmICg8IGN1cnJl bnQtY29sdW1uIDApDQogCShpZiB2YWxpZGF0ZQ0KIAkgICAgKGVycm9yICJQ b2ludCBpcyBub3Qgb24gYSBjaGFyYWN0ZXIgaW4gdGhlIGZpbGUiKQ0KIAkg IChzZXRxIGN1cnJlbnQtY29sdW1uIDApKSkNCiAgICAgKHNldHEgaGV4bC1h ZGRyZXNzDQotCSAgKCsgKCogKC8gKC0gKHBvaW50KSAocG9pbnQtbWluKSAt MSkgNjgpIDE2KQ0KLQkgICAgIChpZiAoPj0gY3VycmVudC1jb2x1bW4gNDEp DQotCQkgKC0gY3VycmVudC1jb2x1bW4gNDEpDQotCSAgICAgICAoLyAoLSBj dXJyZW50LWNvbHVtbiAgKC8gY3VycmVudC1jb2x1bW4gNSkpIDIpKSkpDQor ICAgICAgICAgICgrICgqICgvICgtIChwb2ludCkgKHBvaW50LW1pbikgLTEp IA0KKyAgICAgICAgICAgICAgICAgICAoaGV4bC1saW5lLWRpc3BsZW4pKSAx NikNCisJICAgICAoaWYgKD49IGN1cnJlbnQtY29sdW1uICgtIChoZXhsLWFz Y2lpLXN0YXJ0LWNvbHVtbikgMTApKQ0KKwkJICgtIGN1cnJlbnQtY29sdW1u ICgtIChoZXhsLWFzY2lpLXN0YXJ0LWNvbHVtbikgMTApKQ0KKyAgICAgICAg ICAgICAgICgvICgtIGN1cnJlbnQtY29sdW1uIA0KKyAgICAgICAgICAgICAg ICAgICAgICgvIGN1cnJlbnQtY29sdW1uICgxKyAoLyBoZXhsLWJpdHMgNCkp KSkgMikpKSkNCiAgICAgKHdoZW4gKGNhbGxlZC1pbnRlcmFjdGl2ZWx5LXAg J2ludGVyYWN0aXZlKQ0KICAgICAgIChtZXNzYWdlICJDdXJyZW50IGFkZHJl c3MgaXMgJWQvMHglMDh4IiBoZXhsLWFkZHJlc3MgaGV4bC1hZGRyZXNzKSkN CiAgICAgaGV4bC1hZGRyZXNzKSkNCkBAIC01MzEsMTAgKzU2NSwxOCBAQCBU aGlzIGZ1bmN0aW9uIGlzIGludGVuZGVkIHRvIGJlIHVzZWQgYXMgZWxkb2Mg Y2FsbGJhY2suIg0KICAgKGxldCAoKGFkZHIgKGhleGwtY3VycmVudC1hZGRy ZXNzKSkpDQogICAgIChmb3JtYXQgIkN1cnJlbnQgYWRkcmVzcyBpcyAlZC8w eCUwOHgiIGFkZHIgYWRkcikpKQ0KIA0KKyhkZWZ1biBoZXhsLWFzY2lpLXN0 YXJ0LWNvbHVtbiAoKSANCisgICJDb2x1bW4gYXQgd2hpY2ggdGhlIGFzY2lp IHBvcnRpb24gb2YgdGhlIGhleGwgZGlzcGxheSBzdGFydHMuIg0KKyAgKCsg NDMgKC8gMTI4IGhleGwtYml0cykpKQ0KKw0KIChkZWZ1biBoZXhsLWFkZHJl c3MtdG8tbWFya2VyIChhZGRyZXNzKQ0KICAgIlJldHVybiBidWZmZXIgcG9z aXRpb24gZm9yIEFERFJFU1MuIg0KICAgKGludGVyYWN0aXZlICJuQWRkcmVz czogIikNCi0gICgrICgqICgvIGFkZHJlc3MgMTYpIDY4KSAxMCAocG9pbnQt bWluKSAoLyAoKiAoJSBhZGRyZXNzIDE2KSA1KSAyKSkpDQorICAobGV0ICgo TiAoKiAoJSBhZGRyZXNzIDE2KSAyKSkpDQorICAgICgrICgqICgvIGFkZHJl c3MgMTYpIChoZXhsLWxpbmUtZGlzcGxlbikpIDsgaGV4bCBsaW5lIG5vICog ZGlzcGxheSBsZW5ndGgNCisgICAgICAgMTAgICAgICAgICAgICAgICAgICAg ICAgOyAxMCBjaGFycyBmb3IgdGhlICJhZGRyZXNzOiAiIHByZWZpeA0KKyAg ICAgICAocG9pbnQtbWluKSAgICAgICAgICAgICA7IGJhc2Ugb2Zmc2V0IChw b2ludCB1c3VhbGx5IHN0YXJ0cyBhdCAxLCBub3QgMCkNCisgICAgICAgKCsg TiAoLyBOICgvIGhleGwtYml0cyA0KSkpICkpICkgOyBjaGFyIG9mZnNldCBp bnRvIGhleGwgZGlzcGxheSBsaW5lDQogDQogKGRlZnVuIGhleGwtZ290by1h ZGRyZXNzIChhZGRyZXNzKQ0KICAgIkdvIHRvIGhleGwtbW9kZSAoZGVjaW1h bCkgYWRkcmVzcyBBRERSRVNTLg0KQEAgLTcwMCw3ICs3NDIsNyBAQCBXaXRo IHByZWZpeCBhcmcgTiwgcHV0cyBwb2ludCBOIGJ5dGVzIG9mIHRoZSB3YXkg ZnJvbSB0aGUgdHJ1ZSBiZWdpbm5pbmcuIg0KIChkZWZ1biBoZXhsLWJlZ2lu bmluZy1vZi1saW5lICgpDQogICAiR290byBiZWdpbm5pbmcgb2YgbGluZSBp biBoZXhsIG1vZGUuIg0KICAgKGludGVyYWN0aXZlKQ0KLSAgKGdvdG8tY2hh ciAoKyAoKiAoLyAocG9pbnQpIDY4KSA2OCkgMTEpKSkNCisgIChnb3RvLWNo YXIgKCsgKCogKC8gKHBvaW50KSAoaGV4bC1saW5lLWRpc3BsZW4pKSAoaGV4 bC1saW5lLWRpc3BsZW4pKSAxMSkpKQ0KIA0KIChkZWZ1biBoZXhsLWVuZC1v Zi1saW5lICgpDQogICAiR290byBlbmQgb2YgbGluZSBpbiBoZXhsIG1vZGUu Ig0KQEAgLTc3Niw2ICs4MTgsMTcgQEAgWW91IG1heSBhbHNvIHR5cGUgb2N0 YWwgZGlnaXRzLCB0byBpbnNlcnQgYSBjaGFyYWN0ZXIgd2l0aCB0aGF0IGNv ZGUuIg0KIA0KIDswMDAwMDAwMDogMDAxMSAyMjMzIDQ0NTUgNjY3NyA4ODk5 IGFhYmIgY2NkZCBlZWZmICAwMTIzNDU2Nzg5QUJDREVGDQogDQorKGRlZnVu IGhleGwtb3B0aW9ucyAoJm9wdGlvbmFsIHRlc3QpDQorICAiQ29tYmluZSBg aGV4bC1iaXRzJyB3aXRoIGBoZXhsLW9wdGlvbnMnLCBhbHRlcmluZyBgaGV4 bC1vcHRpb25zJyBhcyBuZWVkZWQNCit0byBwcm9kdWNlIHRoZSBjb21tYW5k IGxpbmUgb3B0aW9ucyB0byBwYXNzIHRvIHRoZSBoZXhsIGNvbW1hbmQuIg0K KyAgKGxldCAoKG9wdHMgKG9yIHRlc3QgaGV4bC1vcHRpb25zKSkpDQorICAg ICh3aGVuIChtZW1xIGhleGwtYml0cyAnKDggMTYgMzIgNjQpKQ0KKyAgICAg ICh3aGVuIChzdHJpbmctbWF0Y2ggIlxcKC4qXFwpLWdyb3VwLWJ5LVswLTld Ky1iaXRzXFwoLipcXCkiIG9wdHMpDQorICAgICAgICAoc2V0cSBvcHRzIChj b25jYXQgKG1hdGNoLXN0cmluZyAxIG9wdHMpIA0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIChtYXRjaC1zdHJpbmcgMiBvcHRzKSkpICkgDQorICAg ICAgKHNldHEgb3B0cyAoZm9ybWF0ICIlcyAtZ3JvdXAtYnktJWQtYml0cyAi IG9wdHMgaGV4bC1iaXRzKSkgKQ0KKyAgICBvcHRzKSkNCisNCiA7OzsjIyNh dXRvbG9hZA0KIChkZWZ1biBoZXhsaWZ5LWJ1ZmZlciAoKQ0KICAgIkNvbnZl cnQgYSBiaW5hcnkgYnVmZmVyIHRvIGhleGwgZm9ybWF0Lg0KQEAgLTc5OCw3 ICs4NTEsNyBAQCBUaGlzIGRpc2NhcmRzIHRoZSBidWZmZXIncyB1bmRvIGlu Zm9ybWF0aW9uLiINCiAgICAgICAgICAgIChtYXBjYXIgKGxhbWJkYSAocykN CiAgICAgICAgICAgICAgICAgICAgICAoaWYgKG5vdCAobXVsdGlieXRlLXN0 cmluZy1wIHMpKSBzDQogICAgICAgICAgICAgICAgICAgICAgICAoZW5jb2Rl LWNvZGluZy1zdHJpbmcgcyBsb2NhbGUtY29kaW5nLXN5c3RlbSkpKQ0KLSAg ICAgICAgICAgICAgICAgICAoc3BsaXQtc3RyaW5nIGhleGwtb3B0aW9ucykp KQ0KKyAgICAgICAgICAgICAgICAgICAoc3BsaXQtc3RyaW5nIChoZXhsLW9w dGlvbnMpKSkpDQogICAgIChpZiAoPiAocG9pbnQpIChoZXhsLWFkZHJlc3Mt dG8tbWFya2VyIGhleGwtbWF4LWFkZHJlc3MpKQ0KIAkoaGV4bC1nb3RvLWFk ZHJlc3MgaGV4bC1tYXgtYWRkcmVzcykpKSkNCiANCkBAIC04MTUsNyArODY4 LDcgQEAgVGhpcyBkaXNjYXJkcyB0aGUgYnVmZmVyJ3MgdW5kbyBpbmZvcm1h dGlvbi4iDQogCShidWZmZXItdW5kby1saXN0IHQpKQ0KICAgICAoYXBwbHkg J2NhbGwtcHJvY2Vzcy1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkN CiAJICAgKGV4cGFuZC1maWxlLW5hbWUgaGV4bC1wcm9ncmFtIGV4ZWMtZGly ZWN0b3J5KQ0KLQkgICB0IHQgbmlsICItZGUiIChzcGxpdC1zdHJpbmcgaGV4 bC1vcHRpb25zKSkpKQ0KKwkgICB0IHQgbmlsICItZGUiIChzcGxpdC1zdHJp bmcgKGhleGwtb3B0aW9ucykpKSkpDQogDQogKGRlZnVuIGhleGwtY2hhci1h ZnRlci1wb2ludCAoKQ0KICAgIlJldHVybiBjaGFyIGZvciBBU0NJSSBoZXgg ZGlnaXRzIGF0IHBvaW50LiINCkBAIC05MTIsMTIgKzk2NSwxNSBAQCBDSCBt dXN0IGJlIGEgdW5pYnl0ZSBjaGFyYWN0ZXIgd2hvc2UgdmFsdWUgaXMgYmV0 d2VlbiAwIGFuZCAyNTUuIg0KICAgKGxldCAoKGFkZHJlc3MgKGhleGwtY3Vy cmVudC1hZGRyZXNzIHQpKSkNCiAgICAgKHdoaWxlICg+IG51bSAwKQ0KICAg ICAgIChsZXQgKChoZXgtcG9zaXRpb24NCi0JICAgICAoKyAoKiAoLyBhZGRy ZXNzIDE2KSA2OCkNCisJICAgICAoKyAoKiAoLyBhZGRyZXNzIDE2KSAoaGV4 bC1saW5lLWRpc3BsZW4pKQ0KIAkJMTAgKHBvaW50LW1pbikNCiAJCSgqIDIg KCUgYWRkcmVzcyAxNikpDQogCQkoLyAoJSBhZGRyZXNzIDE2KSAyKSkpDQog CSAgICAoYXNjaWktcG9zaXRpb24NCi0JICAgICAoKyAoKiAoLyBhZGRyZXNz IDE2KSA2OCkgNTEgKHBvaW50LW1pbikgKCUgYWRkcmVzcyAxNikpKQ0KKwkg ICAgICgrICgqICgvIGFkZHJlc3MgMTYpIChoZXhsLWxpbmUtZGlzcGxlbikp IA0KKyAgICAgICAgICAgICAgICAoaGV4bC1hc2NpaS1zdGFydC1jb2x1bW4p IA0KKyAgICAgICAgICAgICAgICAocG9pbnQtbWluKSANCisgICAgICAgICAg ICAgICAgKCUgYWRkcmVzcyAxNikpKQ0KIAkgICAgYXQtYXNjaWktcG9zaXRp b24pDQogCShpZiAoPSAocG9pbnQpIGFzY2lpLXBvc2l0aW9uKQ0KIAkgICAg KHNldHEgYXQtYXNjaWktcG9zaXRpb24gdCkpDQpAQCAtOTMzLDcgKzk4OSw3 IEBAIENIIG11c3QgYmUgYSB1bmlieXRlIGNoYXJhY3RlciB3aG9zZSB2YWx1 ZSBpcyBiZXR3ZWVuIDAgYW5kIDI1NS4iDQogCShpZiBhdC1hc2NpaS1wb3Np dGlvbg0KIAkgICAgKHByb2duDQogCSAgICAgIChiZWdpbm5pbmctb2YtbGlu ZSkNCi0JICAgICAgKGZvcndhcmQtY2hhciA1MSkNCisJICAgICAgKGZvcndh cmQtY2hhciAoaGV4bC1hc2NpaS1zdGFydC1jb2x1bW4pKQ0KIAkgICAgICAo Zm9yd2FyZC1jaGFyICglIGFkZHJlc3MgMTYpKSkpKQ0KICAgICAgIChzZXRx IG51bSAoMS0gbnVtKSkpKSkNCiANCkBAIC0xMDQxLDcgKzEwOTcsNyBAQCBU aGlzIGZ1bmN0aW9uIGlzIGFzc3VtZWQgdG8gYmUgdXNlZCBhcyBjYWxsYmFj ayBmdW5jdGlvbiBmb3IgYGhsLWxpbmUtbW9kZScuIg0KIA0KIChkZWZ1biBo ZXhsLWZvbGxvdy1hc2NpaS1maW5kICgpDQogICAiRmluZCBhbmQgaGlnaGxp Z2h0IHRoZSBBU0NJSSBlbGVtZW50IGNvcnJlc3BvbmRpbmcgdG8gY3VycmVu dCBwb2ludC4iDQotICAobGV0ICgocG9zICgrIDUxDQorICAobGV0ICgocG9z ICgrIChoZXhsLWFzY2lpLXN0YXJ0LWNvbHVtbikNCiAJCSgtIChwb2ludCkg KGN1cnJlbnQtY29sdW1uKSkNCiAJCShtb2QgKGhleGwtY3VycmVudC1hZGRy ZXNzKSAxNikpKSkNCiAgICAgKG1vdmUtb3ZlcmxheSBoZXhsLWFzY2lpLW92 ZXJsYXkgcG9zICgxKyBwb3MpKQ0KQEAgLTEwNTAsNyArMTEwNiw3IEBAIFRo aXMgZnVuY3Rpb24gaXMgYXNzdW1lZCB0byBiZSB1c2VkIGFzIGNhbGxiYWNr IGZ1bmN0aW9uIGZvciBgaGwtbGluZS1tb2RlJy4iDQogKGRlZnVuIGhleGwt bW9kZS1ydWxlciAoKQ0KICAgIlJldHVybiBhIHN0cmluZyBydWxlciBmb3Ig aGV4bCBtb2RlLiINCiAgIChsZXQqICgoaGlnaGxpZ2h0IChtb2QgKGhleGwt Y3VycmVudC1hZGRyZXNzKSAxNikpDQotCSAocyAiIDg3NjU0MzIxICAwMDEx IDIyMzMgNDQ1NSA2Njc3IDg4OTkgYWFiYiBjY2RkIGVlZmYgIDAxMjM0NTY3 ODlhYmNkZWYiKQ0KKwkgKHMgKGNkciAoYXNzcSBoZXhsLWJpdHMgaGV4bC1y dWxlcnMpKSkNCiAJIChwb3MgMCkpDQogICAgIChzZXQtdGV4dC1wcm9wZXJ0 aWVzIDAgKGxlbmd0aCBzKSBuaWwgcykNCiAgICAgOzsgVHVybiBzcGFjZXMg aW4gdGhlIGhlYWRlciBpbnRvIHN0cmV0Y2ggc3BlY3Mgc28gdGhleSB3b3Jr DQpAQCAtMTA2MiwxMiArMTExOCwxMiBAQCBUaGlzIGZ1bmN0aW9uIGlzIGFz c3VtZWQgdG8gYmUgdXNlZCBhcyBjYWxsYmFjayBmdW5jdGlvbiBmb3IgYGhs LWxpbmUtbW9kZScuIg0KIAkJCSBgKHNwYWNlIDphbGlnbi10byAsKDEtIHBv cykpDQogCQkJIHMpKQ0KICAgICA7OyBIaWdobGlnaHQgdGhlIGN1cnJlbnQg Y29sdW1uLg0KLSAgICAocHV0LXRleHQtcHJvcGVydHkgKCsgMTEgKC8gKCog NSBoaWdobGlnaHQpIDIpKQ0KLQkJICAgICAgICgrIDEzICgvICgqIDUgaGln aGxpZ2h0KSAyKSkNCi0JCSAgICAgICAnZmFjZSAnaGlnaGxpZ2h0IHMpDQor ICAgIChsZXQgKCAob2Zmc2V0ICgrICgqIDIgaGlnaGxpZ2h0KSAoLyAoKiA4 IGhpZ2hsaWdodCkgaGV4bC1iaXRzKSkpICkNCisgICAgICAocHV0LXRleHQt cHJvcGVydHkgKCsgMTEgb2Zmc2V0KSAoKyAxMyBvZmZzZXQpICdmYWNlICdo aWdobGlnaHQgcykpDQogICAgIDs7IEhpZ2hsaWdodCB0aGUgY3VycmVudCBh c2NpaSBjb2x1bW4NCi0gICAgKHB1dC10ZXh0LXByb3BlcnR5ICgrIDEzIDM5 IGhpZ2hsaWdodCkgKCsgMTMgNDAgaGlnaGxpZ2h0KQ0KLQkJICAgICAgICdm YWNlICdoaWdobGlnaHQgcykNCisgICAgKHB1dC10ZXh0LXByb3BlcnR5ICgr IChoZXhsLWFzY2lpLXN0YXJ0LWNvbHVtbikgaGlnaGxpZ2h0IDEpIA0KKyAg ICAgICAgICAgICAgICAgICAgICAgKCsgKGhleGwtYXNjaWktc3RhcnQtY29s dW1uKSBoaWdobGlnaHQgMikNCisgICAgICAgICAgICAgICAgICAgICAgICdm YWNlICdoaWdobGlnaHQgcykNCiAgICAgcykpDQogDQogOzsgc3RhcnR1cCBz dHVmZi4NCi0tIA0KMS43LjcuMw0KDQo= --8323329-751982310-1334156568=:21340-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 12:01:49 2012 Received: (at 4941) by debbugs.gnu.org; 12 Apr 2012 16:01:49 +0000 Received: from localhost ([127.0.0.1]:54489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMSx-000123-Og for submit@debbugs.gnu.org; Thu, 12 Apr 2012 12:01:49 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:47035) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMSu-00011v-Q6 for 4941@debbugs.gnu.org; Thu, 12 Apr 2012 12:01:46 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIMRY-0004Q5-4g; Thu, 12 Apr 2012 18:00:20 +0200 From: Lars Magne Ingebrigtsen To: Vivek Dasmohapatra Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEWGRzs5EBcdCA/7zKr0 vZnprYnJiWxXHR/wi9pIAAACMElEQVQ4jW2ST4+bMBDFZ6uNfY25cK259APA7nklTM6VgunV6pbJ Fa/azNfvG0Noou0okeD9mH/PpvZThBBinAhPXdv2N7VvO4AhRnptzy9t+/4IRoA3fp/ivINuz+iG 9xDP/UOLAk4B4supD7cUBehOA/P8ymm46d2qRyofjMMYz2vzrdIGQuheznuHBxBO57XKJxACvu63 x0cQ/gsGJjmEvrsHQ+Rkq6ZpZL7vMa2ix7+5jrs+Ud3sUX+dw7jpvAN3FPo2xy0APiAeSYisOH+4 A9mQGEPWOVc9gCcMqqqrGu9NUWErwBdREV83O8BIM0C9AQxdwIj1kgFwXkHj3Q102PgKAL1RcMvA gaIt008Aj8Wdrr/QPOtJT3YFlRZCijfT9R54ba7be8O8lirAb60RACOu3JAWWOIbbVsy4A2pi5Ot CVNpDb/5SzZiDbYi9OT/+d7AS108WbhqtyqIj3pBqQFAkgJ3O5FGxBpcdKajFZJN9i47t9g/yOAn QQ+pSnfnRGpZ0u9xmJIrIMPYyrkaLwDPGPayAfUdwCoYnztskbOrCRXgCABZuxCbHkZVqKx3oMRC ljkZOgx20XRk5Fqyy7XV8zR8YKwgK8D3OV+/03giZpPEYKxM2lOTDj+of8XBcRL8dKoStfxiE94g xwsyxNoVIGNmHhKcSkR8ESYdt87YyEBIhCuYCkiENbJufSyjXmC8wGPNwCXByoQ3MrEUWTC1kCse kZ4MaTAvZdC/z+UL8cX/aVIAAAAASUVORK5CYII= X-Now-Playing: Bob Hund's _Sover Aldrig_: "Raketmaskinen" Date: Thu, 12 Apr 2012 18:00:14 +0200 In-Reply-To: (Vivek Dasmohapatra's message of "Wed, 11 Apr 2012 16:02:44 +0100 (BST)") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SIMRY-0004Q5-4g X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334851220.23543@+BEXiD0gf8GqWN3Vsjux2Q X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Stefan Monnier , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Vivek Dasmohapatra writes: > It's currently controlled by a defcustom, but maybe it should be > a prefix arg to hexl-find-file or hexl-mode instead? I don't > use hexl a huge amount myself so I'm not sure what its users > would prefer. `-mode' functions don't usually take additional arguments to control setup, so I think having a defcustom here is fine. I've applied your patch to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 12:01:55 2012 Received: (at control) by debbugs.gnu.org; 12 Apr 2012 16:01:55 +0000 Received: from localhost ([127.0.0.1]:54492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMT3-00012O-Jo for submit@debbugs.gnu.org; Thu, 12 Apr 2012 12:01:55 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:47042) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMT0-00012G-HL for control@debbugs.gnu.org; Thu, 12 Apr 2012 12:01:51 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SIMRg-0004Qm-0k for control@debbugs.gnu.org; Thu, 12 Apr 2012 18:00:28 +0200 Date: Thu, 12 Apr 2012 18:00:27 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4941 X-MailScanner-ID: 1SIMRg-0004Qm-0k X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334851228.0842@uk92DoJD0prJgS+YutiuvA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 4941 fixed close 4941 24.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 12:03:46 2012 Received: (at 4941) by debbugs.gnu.org; 12 Apr 2012 16:03:47 +0000 Received: from localhost ([127.0.0.1]:54499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMUs-00015g-9f for submit@debbugs.gnu.org; Thu, 12 Apr 2012 12:03:46 -0400 Received: from flounder.pepperfish.net ([89.238.129.35]:51157) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIMUq-00015Z-OR for 4941@debbugs.gnu.org; Thu, 12 Apr 2012 12:03:45 -0400 Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.71 #1 (Debian)) id 1SIMTb-00052h-DW; Thu, 12 Apr 2012 17:02:27 +0100 Date: Thu, 12 Apr 2012 17:02:23 +0100 (BST) From: Vivek Dasmohapatra X-X-Sender: vivek@octopus.pepperfish.net To: Lars Magne Ingebrigtsen Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Stefan Monnier , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > `-mode' functions don't usually take additional arguments to control > setup, so I think having a defcustom here is fine. I've applied your > patch to the Emacs trunk. One of the people I asked to test found a bug - as soon as he's verified the fix, I'll post a supplementary patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 12 20:41:16 2012 Received: (at 4941) by debbugs.gnu.org; 13 Apr 2012 00:41:16 +0000 Received: from localhost ([127.0.0.1]:55276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIUZf-0004Xz-KT for submit@debbugs.gnu.org; Thu, 12 Apr 2012 20:41:15 -0400 Received: from flounder.pepperfish.net ([89.238.129.35]:52419) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIUZd-0004Xr-07 for 4941@debbugs.gnu.org; Thu, 12 Apr 2012 20:41:14 -0400 Received: from localhost ([127.0.0.1]) by flounder.pepperfish.net with esmtps (Exim 4.71 #1 (Debian)) id 1SIUYM-0000c9-Gr; Fri, 13 Apr 2012 01:39:54 +0100 Date: Fri, 13 Apr 2012 01:39:51 +0100 (BST) From: Vivek Dasmohapatra X-X-Sender: vivek@octopus.pepperfish.net To: Lars Magne Ingebrigtsen Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-3243566-1334277594=:29517" X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Stefan Monnier , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-3243566-1334277594=:29517 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed > `-mode' functions don't usually take additional arguments to control > setup, so I think having a defcustom here is fine. I've applied your > patch to the Emacs trunk. As I noted earlier, a user found a bug in the display code when editing files in hexl - the hex portion of the display would get scrambled when the word size was <> 16 bits. The attached patch should fix that problem. --8323329-3243566-1334277594=:29517 Content-Type: TEXT/x-diff; name=hexl-editing.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=hexl-editing.patch LS0tIGEvbGlzcC9oZXhsLmVsDQorKysgYi9saXNwL2hleGwuZWwNCkBAIC0y NDksNyArMjQ5LDYgQEAgYXMgdGhhdCB3aWxsIG92ZXJyaWRlIGFueSBiaXQg Z3JvdXBpbmcgb3B0aW9ucyBzZXQgaGVyZS4iDQogKGRlZnVuIGhleGwtbGlu ZS1kaXNwbGVuICgpDQogICAiVGhlIGxlbmd0aCBvZiBhIGhleGwgZGlzcGxh eSBsaW5lICh2YXJpZXMgd2l0aCBgaGV4bC1iaXRzJykuIg0KICAgKCsgNjAg KC8gMTI4IChvciBoZXhsLWJpdHMgMTYpKSkpDQotOzsgLS0NCiANCiAoZGVm dW4gaGV4bC1tb2RlLS1taW5vci1tb2RlLXAgKHZhcikNCiAgIChtZW1xIHZh ciAnKHJ1bGVyLW1vZGUgaGwtbGluZS1tb2RlKSkpDQpAQCAtOTY0LDExICs5 NjMsNyBAQCBDSCBtdXN0IGJlIGEgdW5pYnl0ZSBjaGFyYWN0ZXIgd2hvc2Ug dmFsdWUgaXMgYmV0d2VlbiAwIGFuZCAyNTUuIg0KICAgICAgIChlcnJvciAi SW52YWxpZCBjaGFyYWN0ZXIgMHgleCAtLSBtdXN0IGJlIGluIHRoZSByYW5n ZSBbMC4uMjU1XSIgY2gpKQ0KICAgKGxldCAoKGFkZHJlc3MgKGhleGwtY3Vy cmVudC1hZGRyZXNzIHQpKSkNCiAgICAgKHdoaWxlICg+IG51bSAwKQ0KLSAg ICAgIChsZXQgKChoZXgtcG9zaXRpb24NCi0JICAgICAoKyAoKiAoLyBhZGRy ZXNzIDE2KSAoaGV4bC1saW5lLWRpc3BsZW4pKQ0KLQkJMTAgKHBvaW50LW1p bikNCi0JCSgqIDIgKCUgYWRkcmVzcyAxNikpDQotCQkoLyAoJSBhZGRyZXNz IDE2KSAyKSkpDQorICAgICAgKGxldCAoKGhleC1wb3NpdGlvbiAoaGV4bC1h ZGRyZXNzLXRvLW1hcmtlciBhZGRyZXNzKSkNCiAJICAgIChhc2NpaS1wb3Np dGlvbg0KIAkgICAgICgrICgqICgvIGFkZHJlc3MgMTYpIChoZXhsLWxpbmUt ZGlzcGxlbikpIA0KICAgICAgICAgICAgICAgICAoaGV4bC1hc2NpaS1zdGFy dC1jb2x1bW4pIA0K --8323329-3243566-1334277594=:29517-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 07:09:51 2012 Received: (at 4941) by debbugs.gnu.org; 14 Apr 2012 11:09:51 +0000 Received: from localhost ([127.0.0.1]:58088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ0rW-0001Eu-Ri for submit@debbugs.gnu.org; Sat, 14 Apr 2012 07:09:51 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:45038) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SJ0rU-0001Em-Jr for 4941@debbugs.gnu.org; Sat, 14 Apr 2012 07:09:50 -0400 Received: from static-195.22.91.6.addr.tdcsong.se ([195.22.91.6] helo=rusty) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SJ0q0-0001Wl-6S; Sat, 14 Apr 2012 13:08:16 +0200 From: Lars Ingebrigtsen To: Vivek Dasmohapatra Subject: Re: bug#4941: hexl mode update (variable word size in hexl mode) References: Date: Sat, 14 Apr 2012 13:08:15 +0200 In-Reply-To: (Vivek Dasmohapatra's message of "Fri, 13 Apr 2012 01:39:51 +0100 (BST)") Message-ID: <878vhyo9k0.fsf@gnus.org> User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SJ0q0-0001Wl-6S X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1335006496.29544@1gG9bZVp9minsdxHtCrY+w X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 4941 Cc: Stefan Monnier , 4941@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Vivek Dasmohapatra writes: > As I noted earlier, a user found a bug in the display code when > editing files in hexl - the hex portion of the display would get > scrambled when the word size was <> 16 bits. > > The attached patch should fix that problem. Thanks; applied. -- (domestic pets only, the antidote for overdose, milk.) http://lars.ingebrigtsen.no * Sent from my Rome From unknown Mon Aug 18 14:16:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 12 May 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator