GNU bug report logs - #49407
Request: Specify default values in `map-let` in Map.el

Previous Next

Full log

Message #45 received at control <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Okam <okamsn <at> protonmail.com>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>,
 Lars Ingebrigtsen <larsi <at> gnus.org>, Nicolas Petton <nicolas <at> petton.fr>,
 49407-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#49407: Request: Specify default values in `map-let` in Map.el
Date: Sun, 30 Jul 2023 15:53:20 +0200

[Message part 1 (text/plain, inline)]

close 49407 30.1
quit

Okam [2023-07-29 00:37 +0000] wrote:
> Basil L. Contovounesios wrote:
>> Okam [2023-07-27 01:39 +0000] wrote:
>>> From: Earl Hyatt <okamsn <at> protonmail.com>
>> 
>> I think your past contributions were under "Earl Hyatt
>> <ej32u <at> protonmail.com>", right?  Is okamsn <at> protonmail.com your current
>> address?
>
> Yes, I changed addresses. The mailmap makes it look like I used the old 
> address in `git log`.

Oh, sorry, I actually didn't notice you had existing mailmap entries in
place.

> Would it be OK to make it so that the old address 
> shows as the new one instead?

Is okamsn <at> protonmail.com your canonical address?
If so, what we want is the following, right?

[mailmap.diff (text/x-diff, inline)]

diff --git a/.mailmap b/.mailmap
index 8454eb9154c..0531cc0c290 100644
--- a/.mailmap
+++ b/.mailmap
@@ -51,8 +51,7 @@ David M. Koppelman <koppel <at> ece.lsu.edu>
 Deniz Dogan <deniz <at> dogan.se> <deniz.a.m.dogan <at> gmail.com>
 Dick R. Chiang <dick.r.chiang <at> gmail.com>
 Dick R. Chiang <dick.r.chiang <at> gmail.com> dickmao <none>
-Earl Hyatt <ej32u <at> protonmail.com>
-Earl Hyatt <ej32u <at> protonmail.com> <okamsn <at> protonmail.com>
+Earl Hyatt <okamsn <at> protonmail.com> <ej32u <at> protonmail.com>
 Edward M. Reingold <reingold <at> emr.cs.iit.edu>
 Eli Zaretskii <eliz <at> gnu.org> <eliz <at> is.elta.co.il>
 Emilio C. Lopes <eclig <at> gmx.net>

[Message part 3 (text/plain, inline)]

> I changed it to "An element of ARGS fails to match if PAT does not match 
> the associated value or the default value.  The overall pattern fails
> to match if any element of ARGS fails to match." Does that work?

WFM, thank you!  Installed and closing as done:

Allow default values in 'map-let' and the pcase 'map' form
19777b7c864 2023-07-30 15:20:27 +0200
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=19777b7c864

I'll also bump the map.el Version header in a week or so if no-one beats
me to it.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.