From unknown Sat Sep 06 03:07:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#4940 <4940@debbugs.gnu.org> To: bug#4940 <4940@debbugs.gnu.org> Subject: Status: Avoiding loss of rcirc messages from the on disk log Reply-To: bug#4940 <4940@debbugs.gnu.org> Date: Sat, 06 Sep 2025 10:07:51 +0000 retitle 4940 Avoiding loss of rcirc messages from the on disk log reassign 4940 emacs submitter 4940 Giorgos Keramidas severity 4940 normal tag 4940 patch thanks From rgm@gnu.org Mon Nov 16 13:41:26 2009 Received: (at quiet) by emacsbugs.donarmstrong.com; 16 Nov 2009 21:41:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=IMPRONONCABLE_2, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGLfOf0009926 for ; Mon, 16 Nov 2009 13:41:25 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NA9K8-0005ip-3f for quiet@emacsbugs.donarmstrong.com; Mon, 16 Nov 2009 16:41:24 -0500 From: Giorgos Keramidas To: quiet@debbugs.gnu.org Subject: Avoiding loss of rcirc messages from the on disk log Date: Sat, 31 Oct 2009 05:19:06 +0200 Lines: 61 X-From-Line: emacs-devel-bounces+rgm=gnu.org@gnu.org Fri Oct 30 23:20:46 2009 Received: from mx10.gnu.org ([199.232.76.166]:33222) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1N44WD-0002YS-Sv for rgm@gnu.org; Fri, 30 Oct 2009 23:20:45 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1N44WC-0007WZ-VJ for rgm@gnu.org; Fri, 30 Oct 2009 23:20:45 -0400 Received: from lists.gnu.org ([199.232.76.165]:49200) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N44WC-0007WU-Oh for rgm@gnu.org; Fri, 30 Oct 2009 23:20:44 -0400 Received: from localhost ([127.0.0.1]:45517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N44WC-0007e1-In for rgm@gnu.org; Fri, 30 Oct 2009 23:20:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N44Uo-00078O-A1 for emacs-devel@gnu.org; Fri, 30 Oct 2009 23:19:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N44Uj-00075x-Ih for emacs-devel@gnu.org; Fri, 30 Oct 2009 23:19:17 -0400 Received: from [199.232.76.173] (port=43709 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N44Uj-00075u-BX for emacs-devel@gnu.org; Fri, 30 Oct 2009 23:19:13 -0400 Received: from poseidon.ceid.upatras.gr ([150.140.141.169]:33567) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N44Ui-0007K1-RO for emacs-devel@gnu.org; Fri, 30 Oct 2009 23:19:13 -0400 Received: from mail.ceid.upatras.gr (unknown [10.1.0.143]) by poseidon.ceid.upatras.gr (Postfix) with ESMTP id 53ACBEB46E7 for ; Sat, 31 Oct 2009 05:19:09 +0200 (EET) Received: from localhost (europa.ceid.upatras.gr [127.0.0.1]) by mail.ceid.upatras.gr (Postfix) with ESMTP id 326A1451B2 for ; Sat, 31 Oct 2009 05:19:09 +0200 (EET) X-Virus-Scanned: amavisd-new at ceid.upatras.gr Received: from mail.ceid.upatras.gr ([127.0.0.1]) by localhost (europa.ceid.upatras.gr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3VY8YHdpNUtX for ; Sat, 31 Oct 2009 05:19:09 +0200 (EET) Received: from kobe.laptop (adsl26-237.kln.forthnet.gr [77.49.153.237]) by mail.ceid.upatras.gr (Postfix) with ESMTP id DDB08450C6 for ; Sat, 31 Oct 2009 05:19:08 +0200 (EET) Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.3/8.14.3) with ESMTP id n9V3J7Qv060824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 31 Oct 2009 05:19:07 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by kobe.laptop (8.14.3/8.14.3/Submit) id n9V3J6VL060823; Sat, 31 Oct 2009 05:19:06 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Debbugs-No-Ack: yes X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+rgm=gnu.org@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Glenn Morris [ Resent from http://lists.gnu.org/archive/html/emacs-devel/2009-10/msg00691.html ] The IRC buffers of "rcirc.el" use the auto-save mechanism to push log messages on disk. This is a very good idea, since it avoids hitting the disk for every single line of the IRC log. On busy channels it probably saves a *lot* of time that would be spent waiting for messages to be saved on disk. Unfortunately, it also means that the simple action of killing an rcirc buffer may lose some of the messages. Any messages still on the alist `rcirc-log-alist' are still in memory and I've noticed that some of these may not be written to the log files in `rcirc-log-directory'. I have now bound `C-c L' locally to a function that explicitly calls `rcirc-log-write': (defun keramida/rcirc-log-write () "A command-wrapper for the `rcirc-log-write' function. This wrapper may be bound to a key, so that `rcirc-log-write' can be called from any IRC buffer to immediately save any pending messages on disk." (interactive) (if (null rcirc-log-alist) (message "No IRC messages to save") (when rcirc-log-directory (rcirc-log-write) (message "IRC messages saved in %s" rcirc-log-directory)))) (defun keramida/rcirc-setup-keys () "Set up some custom keys that I find useful in rcirc buffers." (local-set-key (kbd "C-c L") 'keramida/rcirc-log-write)) (add-hook 'rcirc-mode-hook 'keramida/rcirc-setup-keys) This is ok for now, but it seems slightly ugly. Looking at the source code of rcirc, I see that it adds its own `rcirc-kill-buffer-hook' to the `kill-buffer-hook'. This calls `rcirc-clean-up-buffer', but there is no call to `rcirc-log-write' in the rcirc buffer cleanup function. Would it be a good idea to install the following change to `rcirc.el' so that all log messages are flushed to disk when an rcirc buffer is killed? ------------------------------------------------------------------------ diff -r e1381fd70a71 lisp/net/rcirc.el --- a/lisp/net/rcirc.el Fri Apr 03 03:02:01 2009 +0300 +++ b/lisp/net/rcirc.el Sat Oct 31 05:12:55 2009 +0200 @@ -984,6 +984,8 @@ If ALL is non-nil, update prompts in all (defun rcirc-kill-buffer-hook () "Part the channel when killing an rcirc buffer." (when (eq major-mode 'rcirc-mode) + (when (and rcirc-log-directory rcirc-log-alist) + (rcirc-log-write)) (rcirc-clean-up-buffer "Killed buffer"))) (defun rcirc-change-major-mode-hook () ------------------------------------------------------------------------ From rgm@gnu.org Wed Dec 2 13:26:35 2009 Received: (at control) by emacsbugs.donarmstrong.com; 2 Dec 2009 21:26:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,MONOTONE_WORDS_2_15, ONEWORD,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB2LQYsE014460 for ; Wed, 2 Dec 2009 13:26:35 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NFwiW-0003jD-Ln; Wed, 02 Dec 2009 16:26:32 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19222.56200.633746.455197@fencepost.gnu.org> Date: Wed, 2 Dec 2009 16:26:32 -0500 From: Glenn Morris To: control Subject: control reassign 4832 emacs,w32 reassign 4940 emacs,rcirc reassign 5091 emacs,cc-mode reassign 5100 spam reassign 5101 spam reassign 5097 spam severity 5102 minor unarchive 582 reopen 582 unarchive 585 reopen 585 unarchive 604 reopen 604 unarchive 611 reopen 611 unarchive 619 reopen 619 unarchive 628 reopen 628 unarchive 629 reopen 629 unarchive 649 reopen 649 unarchive 650 reopen 650 unarchive 654 reopen 654 unarchive 658 reopen 658 unarchive 661 reopen 661 unarchive 951 reopen 951 unarchive 1866 reopen 1866 unarchive 2466 reopen 2466 unarchive 2482 reopen 2482 unarchive 2719 reopen 2719 unarchive 2958 reopen 2958 stop unarchive and reopen some closed spam in anticipation of deleting it for real on debbugs.gnu.org From deniz.a.m.dogan@gmail.com Sun Dec 6 09:22:11 2009 Received: (at 4940) by emacsbugs.donarmstrong.com; 6 Dec 2009 17:22:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.7 required=4.0 tests=AWL,MISSING_SUBJECT,NOSUBJECT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f211.google.com (mail-ew0-f211.google.com [209.85.219.211]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB6HM8BI019010 for <4940@emacsbugs.donarmstrong.com>; Sun, 6 Dec 2009 09:22:10 -0800 Received: by ewy3 with SMTP id 3so112672ewy.13 for <4940@emacsbugs.donarmstrong.com>; Sun, 06 Dec 2009 09:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=6piTVGD26GDUyespXZouRcpKM7OZo9G4T//yJLIiAJM=; b=UzHXoym7vaZzW4PMrPpgcSF2yh2vBLZWLuWpga4Zg5LiqIX4t2EdJ6CSFv2dHUDjP9 PCzO64Tp970DAdFduNMjoTgDGtjH2ePuMEAz7TZaSXZHnruxbeGO6xKMqV3REhEvPRN0 l2ZvHMRLGMx3z9dwJRGL6woZaofDloYjKx5UM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=ay9leSEuUG3wFBAV8HlXJi/WaTKNuOx6dzu+c4uFlKxkI5a5nRAcsnWUK57yY+3K2H aURyKIK9khQhtPJTSRZ3Vv8wPh3U788UnI6/7aJ0L5sJwRqlKxTUAsP5PN1oTsWtZ9xx 4+lyh1W0zEjxj9EdASgBqz922s+r4fI/uEXTQ= MIME-Version: 1.0 Received: by 10.213.24.12 with SMTP id t12mr5138119ebb.70.1260120123196; Sun, 06 Dec 2009 09:22:03 -0800 (PST) From: Deniz Dogan Date: Sun, 6 Dec 2009 18:21:43 +0100 Message-ID: <7b501d5c0912060921q5878b9fco654d43df6bf659a@mail.gmail.com> Subject: To: 4940@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Shouldn't rcirc-log-flag be part of the equation here? (and rcirc-log-flag rcirc-log-directory rcirc-log-alist) -- Deniz Dogan From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 17 19:01:38 2010 Received: (at 4940) by debbugs.gnu.org; 18 Jan 2010 00:01:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWf3q-0007oJ-Ae for submit@debbugs.gnu.org; Sun, 17 Jan 2010 19:01:38 -0500 Received: from pantheon-po43.its.yale.edu ([130.132.50.104]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWf3p-0007oC-4G for 4940@debbugs.gnu.org; Sun, 17 Jan 2010 19:01:37 -0500 Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0I01X7Q006703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 17 Jan 2010 19:01:33 -0500 Received: by furry (Postfix, from userid 1000) id 4497CC05D; Sun, 17 Jan 2010 17:01:33 -0700 (MST) From: Chong Yidong To: Ryan Yeske Subject: Re: Avoiding loss of rcirc messages from the on disk log Date: Sun, 17 Jan 2010 19:01:33 -0500 Message-ID: <87d418uvqa.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4940 Cc: 4940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Hi Ryan, Could you review the patch from Giorgos Keramidas? Thanks. > The IRC buffers of "rcirc.el" use the auto-save mechanism to push log > messages on disk. This is a very good idea, since it avoids hitting the > disk for every single line of the IRC log. On busy channels it probably > saves a *lot* of time that would be spent waiting for messages to be > saved on disk. > Unfortunately, it also means that the simple action of killing an rcirc > buffer may lose some of the messages. Any messages still on the alist > `rcirc-log-alist' are still in memory and I've noticed that some of > these may not be written to the log files in `rcirc-log-directory'. diff -r e1381fd70a71 lisp/net/rcirc.el --- a/lisp/net/rcirc.el Fri Apr 03 03:02:01 2009 +0300 +++ b/lisp/net/rcirc.el Sat Oct 31 05:12:55 2009 +0200 -984,6 +984,8 If ALL is non-nil, update prompts in all (defun rcirc-kill-buffer-hook () "Part the channel when killing an rcirc buffer." (when (eq major-mode 'rcirc-mode) + (when (and rcirc-log-directory rcirc-log-alist) + (rcirc-log-write)) (rcirc-clean-up-buffer "Killed buffer"))) (defun rcirc-change-major-mode-hook () From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 19 14:23:19 2010 Received: (at control) by debbugs.gnu.org; 19 Jan 2010 19:23:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXJfb-0005Yt-Ck for submit@debbugs.gnu.org; Tue, 19 Jan 2010 14:23:19 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXJfY-0005Ym-Ua for control@debbugs.gnu.org; Tue, 19 Jan 2010 14:23:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXJfU-0007gf-N8; Tue, 19 Jan 2010 14:23:12 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19286.1696.696215.14506@gargle.gargle.HOWL> Date: Tue, 19 Jan 2010 14:23:12 -0500 From: Glenn Morris To: control Subject: control X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) tags 4940 patch reassign 5388 emacs,cc-mode reassign 5303 emacs,w32 retitle 5386 gtk daemon close display hang reassign 5425 notemacs severity 5424 wishlist reassign 5422 emacs,cc-mode reassign 5411 emacs,cc-mode reassign 5404 emacs,ns From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 22 11:18:36 2011 Received: (at 4940-done) by debbugs.gnu.org; 22 Jan 2011 16:18:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PggAe-0003Xz-EW for submit@debbugs.gnu.org; Sat, 22 Jan 2011 11:18:36 -0500 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PggAc-0003Xo-VU for 4940-done@debbugs.gnu.org; Sat, 22 Jan 2011 11:18:35 -0500 Received: by iwn40 with SMTP id 40so2818687iwn.3 for <4940-done@debbugs.gnu.org>; Sat, 22 Jan 2011 08:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:from:date:message-id:subject:to :content-type; bh=G7x3s2JV1lJWB5BfpAY0Q1DX4VRM41RaaBpHLOUsjmU=; b=eYYtRtP3tpcf7DX+42g/6g49v5nXuuA3t92XVIlXEBQUA7jzhfXpHzYs9oX3QZ2q2e zxl9EAqVfxK8XyoCnIONbh7nbPs3ipGEzypdAIwbj2OsiX6NNBi/hULm5dcobylPbTID EHgq53+GlyMLjeR0L9aeKPtW9v6t34OjNDPEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=W51vH4QkTt8TDdfkRddtT+uPCMykTD8JF0T4/dHTXIeV0HEdP7utMhNd7nClpGBR6N /Rp3kuDsdwZ88k7EJgKXHglv3yd7sm8rvm8QfuCrkJUx9+cJn81d8ntAgphMXPOsSdZ5 i37TBI+eOMknb4D4xCc4tB6/wNtczICbVnQfk= Received: by 10.231.12.8 with SMTP id v8mr2342080ibv.147.1295713591544; Sat, 22 Jan 2011 08:26:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.32.197 with HTTP; Sat, 22 Jan 2011 08:26:01 -0800 (PST) From: Deniz Dogan Date: Sat, 22 Jan 2011 17:26:01 +0100 Message-ID: Subject: To: 4940-done@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 4940-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.4 (/) I just pushed this change, only slightly modified, to trunk. Thanks! From unknown Sat Sep 06 03:07:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Feb 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator