From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 16:40:37 2021 Received: (at submit) by debbugs.gnu.org; 3 Jul 2021 20:40:37 +0000 Received: from localhost ([127.0.0.1]:39954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzmRI-0003t9-RJ for submit@debbugs.gnu.org; Sat, 03 Jul 2021 16:40:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:60062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzmRG-0003t1-Nz for submit@debbugs.gnu.org; Sat, 03 Jul 2021 16:40:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzmRG-0007xk-GQ for guix-patches@gnu.org; Sat, 03 Jul 2021 16:40:34 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43745) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzmRF-0002SA-1g for guix-patches@gnu.org; Sat, 03 Jul 2021 16:40:34 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 3BB741C0006 for ; Sat, 3 Jul 2021 20:40:30 +0000 (UTC) From: Brice Waegeneire To: guix-patches@gnu.org Subject: [PATCH] services: gpm: Use "make-forkexec-contstructor". Date: Sat, 3 Jul 2021 22:40:28 +0200 Message-Id: <20210703204028.11582-1-brice@waegenei.re> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.197; envelope-from=brice@waegenei.re; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/services/base.scm (gpm-shepherd-service)[start]: Replace custom logic with "make-forkexec-constructor". --- gnu/services/base.scm | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 6922d7f90b..ab3e441a7b 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -2217,23 +2217,13 @@ instance." (list (shepherd-service (requirement '(udev)) (provision '(gpm)) - (start #~(lambda () - ;; 'gpm' runs in the background and sets a PID file. - ;; Note that it requires running as "root". - (false-if-exception (delete-file "/var/run/gpm.pid")) - (fork+exec-command (list #$(file-append gpm "/sbin/gpm") - #$@options)) - - ;; Wait for the PID file to appear; declare failure if - ;; it doesn't show up. - (let loop ((i 3)) - (or (file-exists? "/var/run/gpm.pid") - (if (zero? i) - #f - (begin - (sleep 1) - (loop (1- i)))))))) - + ;; 'gpm' runs in the background and sets a PID file. + ;; Note that it requires running as "root". + (start #~(make-forkexec-constructor + (list #$(file-append gpm "/sbin/gpm") + #$@options) + #:pid-file "/var/run/gpm.pid" + #:pid-file-timeout 3)) (stop #~(lambda (_) ;; Return #f if successfully stopped. (not (zero? (system* #$(file-append gpm "/sbin/gpm") -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 10:31:08 2021 Received: (at 49365) by debbugs.gnu.org; 7 Jul 2021 14:31:09 +0000 Received: from localhost ([127.0.0.1]:53184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18Zw-0000WO-Og for submit@debbugs.gnu.org; Wed, 07 Jul 2021 10:31:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m18Zu-0000W1-Sl for 49365@debbugs.gnu.org; Wed, 07 Jul 2021 10:31:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60272) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m18Zp-000389-AJ; Wed, 07 Jul 2021 10:31:01 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=43448 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m18Zp-0002Cd-23; Wed, 07 Jul 2021 10:31:01 -0400 From: Mathieu Othacehe To: Brice Waegeneire Subject: Re: bug#49365: [PATCH] services: gpm: Use "make-forkexec-contstructor". References: <20210703204028.11582-1-brice@waegenei.re> Date: Wed, 07 Jul 2021 16:30:59 +0200 In-Reply-To: <20210703204028.11582-1-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 3 Jul 2021 22:40:28 +0200") Message-ID: <87mtqy42n0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49365 Cc: 49365@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Brice, > * gnu/services/base.scm (gpm-shepherd-service)[start]: Replace custom > logic with "make-forkexec-constructor". This seems fine, thanks! Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 13 01:28:32 2021 Received: (at 49365-done) by debbugs.gnu.org; 13 Jul 2021 05:28:32 +0000 Received: from localhost ([127.0.0.1]:39173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3Ay8-0005Ky-Ei for submit@debbugs.gnu.org; Tue, 13 Jul 2021 01:28:32 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3Ay6-0005Kn-A2 for 49365-done@debbugs.gnu.org; Tue, 13 Jul 2021 01:28:30 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 46CCCE0003; Tue, 13 Jul 2021 05:28:24 +0000 (UTC) From: Brice Waegeneire To: Mathieu Othacehe Subject: Re: bug#49365: [PATCH] services: gpm: Use "make-forkexec-contstructor". References: <20210703204028.11582-1-brice@waegenei.re> <87mtqy42n0.fsf@gnu.org> Date: Tue, 13 Jul 2021 07:28:21 +0200 In-Reply-To: <87mtqy42n0.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 07 Jul 2021 16:30:59 +0200") Message-ID: <87mtqqok96.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49365-done Cc: 49365-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Mathieu Othacehe writes: >> * gnu/services/base.scm (gpm-shepherd-service)[start]: Replace custom >> logic with "make-forkexec-constructor". Thank you for the review, pushed as 1beeef62614dc61876558bcd70af11e2bd6854d6. From unknown Tue Jun 17 01:46:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 Aug 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator