From unknown Wed Jun 18 23:15:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49357 <49357@debbugs.gnu.org> To: bug#49357 <49357@debbugs.gnu.org> Subject: Status: [PATCH] gnu darktable update to 3.6.0 Reply-To: bug#49357 <49357@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:15:58 +0000 retitle 49357 [PATCH] gnu darktable update to 3.6.0 reassign 49357 guix-patches submitter 49357 John Kehayias severity 49357 normal tag 49357 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 12:17:24 2021 Received: (at submit) by debbugs.gnu.org; 3 Jul 2021 16:17:24 +0000 Received: from localhost ([127.0.0.1]:39735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lziKa-0005Ei-AL for submit@debbugs.gnu.org; Sat, 03 Jul 2021 12:17:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:41268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lziKY-0005DR-Mi for submit@debbugs.gnu.org; Sat, 03 Jul 2021 12:17:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lziKX-0002IW-GF for guix-patches@gnu.org; Sat, 03 Jul 2021 12:17:22 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:29319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lziKT-0001DJ-6Y for guix-patches@gnu.org; Sat, 03 Jul 2021 12:17:21 -0400 Date: Sat, 03 Jul 2021 16:17:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625329027; bh=FLOeYqbGyYMEi0MHZulP+LsFPGo64Kg8BvJtJC91ZJA=; h=Date:To:From:Reply-To:Subject:From; b=TFVnQHVuwp93PwKYXe27ypYxQkPwO4JQ0PFTi3MP7Fpy7ljxfWqVHjfHKfXRzp6Oc wDc4wxTKmb/t6I0Uu8ow97ZricGjyUD5QiSfZj2YszpErmC8Yz3hVgLILmHhUFaWwF mz0iSnWxlm+n7CZfT7vxqq5Y3LZE3XndDgrXxl8I= To: "guix-patches@gnu.org" From: John Kehayias Subject: [PATCH] gnu darktable update to 3.6.0 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_GRo4BUnRFb7DLppGHkbG3ydpy03ric9I10cXy3VM" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.133; envelope-from=john.kehayias@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_GRo4BUnRFb7DLppGHkbG3ydpy03ric9I10cXy3VM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Update for darktable to latest release, 3.6.0 (tested build locally, no pro= blems). --b1_GRo4BUnRFb7DLppGHkbG3ydpy03ric9I10cXy3VM Content-Type: text/x-patch; name=darktable-3.6.0.diff Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=darktable-3.6.0.diff ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9waG90by5zY20gYi9nbnUvcGFja2FnZXMvcGhvdG8u c2NtCmluZGV4IGUyZDc2ZDk5MDguLjY3Mzk4OWUwNmIgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdl cy9waG90by5zY20KKysrIGIvZ251L3BhY2thZ2VzL3Bob3RvLnNjbQpAQCAtNDcxLDcgKzQ3MSw3 IEBAIHBob3RvZ3JhcGhpYyBlcXVpcG1lbnQuIikKIChkZWZpbmUtcHVibGljIGRhcmt0YWJsZQog ICAocGFja2FnZQogICAgIChuYW1lICJkYXJrdGFibGUiKQotICAgICh2ZXJzaW9uICIzLjQuMSIp CisgICAgKHZlcnNpb24gIjMuNi4wIikKICAgICAoc291cmNlCiAgICAgIChvcmlnaW4KICAgICAg ICAobWV0aG9kIHVybC1mZXRjaCkKQEAgLTQ3OSw3ICs0NzksNyBAQCBwaG90b2dyYXBoaWMgZXF1 aXBtZW50LiIpCiAgICAgICAgICAgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9kYXJrdGFibGUtb3Jn L2Rhcmt0YWJsZS9yZWxlYXNlcy8iCiAgICAgICAgICAgICAgImRvd25sb2FkL3JlbGVhc2UtIiB2 ZXJzaW9uICIvZGFya3RhYmxlLSIgdmVyc2lvbiAiLnRhci54eiIpKQogICAgICAgIChzaGEyNTYK LSAgICAgICAgKGJhc2UzMiAiMDdsbGZoaHo1ZGhoNDNzbWh2NGF4NHhpMWRpeW04aHJ6bDdjYWQ4 N3JrY3Z2OTh6aWh2eiIpKSkpCisgICAgICAgIChiYXNlMzIgIjBmOGFxd2tndzRnczk3YjVpNHln aXFrNXppbHdxN2F4N3p3ZGQzMXI3MnprOThjZDFnNDYiKSkpKQogICAgIChidWlsZC1zeXN0ZW0g Y21ha2UtYnVpbGQtc3lzdGVtKQogICAgIChhcmd1bWVudHMKICAgICAgYCgjOmNvbmZpZ3VyZS1m bGFncyAnKCItREJJTkFSWV9QQUNLQUdFX0JVSUxEPU9uIgo= --b1_GRo4BUnRFb7DLppGHkbG3ydpy03ric9I10cXy3VM-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 12:59:43 2021 Received: (at 49357) by debbugs.gnu.org; 3 Jul 2021 16:59:43 +0000 Received: from localhost ([127.0.0.1]:39767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzizW-0006bo-RS for submit@debbugs.gnu.org; Sat, 03 Jul 2021 12:59:43 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzizS-0006bX-KK for 49357@debbugs.gnu.org; Sat, 03 Jul 2021 12:59:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8CBA32400E5 for <49357@debbugs.gnu.org>; Sat, 3 Jul 2021 18:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1625331571; bh=0liYCQsADcnptxANoktztE4mO3bxbYrC3uW+xlNq8Mk=; h=Subject:From:To:Date:From; b=Gmq5PwHMlCmAHWkDPe1AIKg2eDXBskvs5U6xvsX/otRpez10CWMWB6CktPkcIs7Qg 1Xb3rQkGWZYEDiwI2EOzvIVVq4x3TIymosCwlqpl+ZD8zyDormI5RS2LFYIJ36tmYD Mpbk5NLIo5ui1/LW/SOwXHRUKK8bG23E8IxzDbDTb5u0KF2HxL3teGaPAC9ZMOfUIh w1cCoiPfIRaljwKIiRwlS/BuDzRd6c7Nj9mTzWHstMgMohrgGCg/b7BFrdA9/ntIo1 eZJHLj1lWEiMYpB5zwyejHP4kYj4K/pGilRLd++fiBhtugHSnzbAy4ua2WAhRf1/1W ANsuGonzUhB1w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GHJ8L2CPfz9rxF for <49357@debbugs.gnu.org>; Sat, 3 Jul 2021 18:59:29 +0200 (CEST) Message-ID: Subject: [PATCH] gnu darktable update to 3.6.0 From: Vinicius Monego To: 49357@debbugs.gnu.org Date: Sat, 03 Jul 2021 16:29:41 +0000 Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49357 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, I noticed a warning in the build that darktable now expects LLVM-12, and this: > CMake Warning at src/CMakeLists.txt:332 (find_package): > Could not find a configuration file for package "OpenEXR" that is > compatible with requested version "3.0". > > The following configuration files were considered but not accepted: > > /gnu/store/rhixcbc778wwbi9g7j7qdcbbzpv5rgf7-openexr- > 2.5.5/lib/cmake/OpenEXR/OpenEXRConfig.cmake, version: 2.5.5 > Is the openexr export working in the compiled package? If not, I'd suggest renaming openexr to openexr-2, packaging openexr 3, and then updating darktable to keep the same set of features. WDYT? OpenEXR 3 seems to be incompatible with version 2 [1]. [1] https://github.com/AcademySoftwareFoundation/Imath/blob/master/docs/PortingGuide2-3.md From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 20:38:42 2021 Received: (at 49357) by debbugs.gnu.org; 4 Jul 2021 00:38:42 +0000 Received: from localhost ([127.0.0.1]:40091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzq9h-0003PX-VS for submit@debbugs.gnu.org; Sat, 03 Jul 2021 20:38:42 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:63242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzq9e-0003PE-6q for 49357@debbugs.gnu.org; Sat, 03 Jul 2021 20:38:40 -0400 Date: Sun, 04 Jul 2021 00:38:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625359110; bh=qzMSIzeaTHRQIpsJXtqATnVNU4qgY/xFBgX2t391FTo=; h=Date:To:From:Reply-To:Subject:From; b=LgtG/9CWJCQ/diMXRGZ/lbN8D4f1U0a2xdLHlpJ2pysg+AbHHP+1Twuh1eAV1whhm 6wcFuuVM+LW/RJhPJONZzYnwbKhjnzZ4zU5kdKrRKoHN+kbq2IKYhKYPU0u3Ocwj9f nnVby1b/1XXLeQBqguyUdVKgTF77MgIoerVTf1tE= To: "49357@debbugs.gnu.org" <49357@debbugs.gnu.org> From: John Kehayias Subject: [PATCH] gnu darktable update to 3.6.0 Message-ID: <1yD_s5FBJA76ROAWQgJ0OAyHXsSD8b-Ygf0phy90kb1C8-Z2-UPxBDLCL5audIOcpAfOphVNhw0O6W_-U-iitkDK8r4QnGC_q-pTd54Lp34=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49357 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, did not catch those. For LLVM, I don't think Darktable cares about = version, as this commit just shows they added v12 since it was reported to = work: https://github.com/darktable-org/darktable/commit/4215f9995fdcc308eb9= c6769b839ffac83ded5d9 As for OpenEXR, I have not tested it nor used that feature in the past. I j= ust tried and "darktable --version" does show OpenEXR support. Also, it doe= s export a photo with openexr without complaint and I can open it (I just t= ried in Gimp). It seems like moving to openexr 3 should be done to address security issues= : https://issues.guix.gnu.org/47509 This looks like it may involve patching= many of the dependent packages, based on what I see in Arch (which only ha= s openexr 3 and numerous small patches, though looked easy enough). So I think this update to Darktable is okay, but we should move to openexr = 3 for everything due to #47509. How does that sound to you? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 20:03:53 2021 Received: (at 49357) by debbugs.gnu.org; 6 Jul 2021 00:03:53 +0000 Received: from localhost ([127.0.0.1]:46872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0YZ7-0004pn-7e for submit@debbugs.gnu.org; Mon, 05 Jul 2021 20:03:53 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0YZ5-0004pZ-K7 for 49357@debbugs.gnu.org; Mon, 05 Jul 2021 20:03:52 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 47A06240026 for <49357@debbugs.gnu.org>; Tue, 6 Jul 2021 02:03:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1625529825; bh=n2UtTguXWzjnthuM9dCQT1QJ5GuAd9Oi3QYPIjiOCRk=; h=Subject:From:To:Date:From; b=as/vdZnmEw/ltIw/ekDX+qAgud3SDCucoMBlw1cMF3P6VnyXxV2gA49qupWtA/SAR GxwCVmXyiISFN19vuw0m5L4jXnKx9ZCXKsfPljQ8rHWCMTz4/8GrDDCp81FU+wk20f 0mg/QJm7CrP9EhRifkEwSaDsfeXLXi0SKLXFtWCsASQ/WSipfqUx8oksMCrWJvmANb xQIupLz+u0IkHQnmL4xwvrlsSnoQ2XCLOFZpsYjzfpXlH5erqONieBG9LWonHnGjxg o4pwG1kdHofTySbeJ85j50CoJKpkF5ih83REwbb6fnxOsxRDUiyUz+2SJHK2qYohQZ J2NITDJ7ABYew== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GJjSt6zjSz6tm9 for <49357@debbugs.gnu.org>; Tue, 6 Jul 2021 02:03:42 +0200 (CEST) Message-ID: Subject: [PATCH] gnu darktable update to 3.6.0 From: Vinicius Monego To: 49357@debbugs.gnu.org Date: Tue, 06 Jul 2021 00:03:33 +0000 Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49357 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > It seems like moving to openexr 3 should be done to address security > issues: https://issues.guix.gnu.org/47509This looks like it may > involve patching many of the dependent packages, based on what I see > in Arch (which only has openexr 3 and numerous small patches, though > looked easy enough). I left a comment on that issue. OpenEXR addressed those vulnerabilities in version 2.5.4, while we're at 2.5.5. > So I think this update to Darktable is okay, but we should move to > openexr 3 for everything due to #47509. Looking at the releases page for openexr, it seems that both versions 2 and 3 are being actively maintained. We can have both, and IMO we should. But there's no need to work on it immediately. I built the package and executed darktable --version and also see that openexr support is enabled. This patch LGTM then. I will now wait for a committer to review. Thanks, Vinicius From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 17:51:22 2021 Received: (at 49357) by debbugs.gnu.org; 6 Jul 2021 21:51:23 +0000 Received: from localhost ([127.0.0.1]:50367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0syQ-0001pZ-Ne for submit@debbugs.gnu.org; Tue, 06 Jul 2021 17:51:22 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:34024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0syO-0001pI-5M for 49357@debbugs.gnu.org; Tue, 06 Jul 2021 17:51:21 -0400 Date: Tue, 06 Jul 2021 21:51:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625608273; bh=8aRou0G4+LX8QkndhrB6AzJW2elYalmuK3y2BZsYjj8=; h=Date:To:From:Reply-To:Subject:From; b=ahPeWsiEmD8T4AKsEgWGB/wuEr4vUXCYM7qgCeW1zdFgdHdbgj2a66Nk5XTJg/qk0 bfEAHdFuIQLe/QbqXgZ6Kj01Yz3S5LUGMKHQvTUJjriqCqzBe3ACaPSeDn1fa8DOOa GlGZ1hIiKzo9kIobrPIqPmEVqGMHT6w2M3AdguUY= To: "49357@debbugs.gnu.org" <49357@debbugs.gnu.org> From: John Kehayias Subject: [PATCH] gnu darktable update to 3.6.0 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49357 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the follow-up, that sounds good to me! From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 03:48:01 2021 Received: (at 49357-done) by debbugs.gnu.org; 8 Jul 2021 07:48:01 +0000 Received: from localhost ([127.0.0.1]:54186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1OlM-0004R6-Tv for submit@debbugs.gnu.org; Thu, 08 Jul 2021 03:48:01 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:52805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1OlM-0004Qs-1F for 49357-done@debbugs.gnu.org; Thu, 08 Jul 2021 03:48:00 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 1CFB2240005; Thu, 8 Jul 2021 07:47:52 +0000 (UTC) From: Nicolas Goaziou To: John Kehayias via Guix-patches via Subject: Re: [bug#49357] [PATCH] gnu darktable update to 3.6.0 References: Date: Thu, 08 Jul 2021 09:47:51 +0200 In-Reply-To: (John Kehayias via Guix-patches via's message of "Tue, 06 Jul 2021 21:51:11 +0000") Message-ID: <871r89qmag.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49357-done Cc: John Kehayias , "49357@debbugs.gnu.org" <49357-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, John Kehayias via Guix-patches via writes: > Thanks for the follow-up, that sounds good to me! I applied your patch, thank you! And thanks to Vinicius Monego for the review. I also added a proper commit message. Next time, please use "git format-patch" to generate one. You may want to look at the "Submitting Patches" section of the Guix manual for more information. Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 08 10:39:34 2021 Received: (at submit) by debbugs.gnu.org; 8 Jul 2021 14:39:35 +0000 Received: from localhost ([127.0.0.1]:57200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1VBe-0005fL-N8 for submit@debbugs.gnu.org; Thu, 08 Jul 2021 10:39:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1VBZ-0005ey-MY for submit@debbugs.gnu.org; Thu, 08 Jul 2021 10:39:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VBZ-00033B-5m for guix-patches@gnu.org; Thu, 08 Jul 2021 10:39:29 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:64204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VBW-0003GH-Ng for guix-patches@gnu.org; Thu, 08 Jul 2021 10:39:28 -0400 Date: Thu, 08 Jul 2021 14:39:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625755164; bh=2RThhUXdtWiRFfdPi41NffsSzw8LDDKyo3F8UlHFfb4=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=WIZ3FT2lqwlforkR3m39i32BBgymJRVrmEzDXNsuSqtFP0Imai/dIKy+1qALTPNh7 ITYEyLCpmHn4eW1P5QKDjwFUGaF4iJUr2V1pzS9u3QF3rVo0BVQ7CiuhvTEUEeTVd1 qoFsz8tz5VEQqqUWRPD99s97ikbdYRK2DmtiR/B4= To: Nicolas Goaziou From: John Kehayias Subject: Re: [bug#49357] [PATCH] gnu darktable update to 3.6.0 Message-ID: In-Reply-To: <871r89qmag.fsf@nicolasgoaziou.fr> References: <871r89qmag.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.40.131; envelope-from=john.kehayias@protonmail.com; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: "49357@debbugs.gnu.org" <49357-done@debbugs.gnu.org>, John Kehayias via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Thursday, July 8th, 2021 at 3:47 AM, Nicolas Goaziou wrote: > Hello, > > John Kehayias via Guix-patches via guix-patches@gnu.org writes: > > > Thanks for the follow-up, that sounds good to me! > > I applied your patch, thank you! And thanks to Vinicius Monego for the > > review. > > I also added a proper commit message. Next time, please use "git > > format-patch" to generate one. You may want to look at the "Submitting > > Patches" section of the Guix manual for more information. > Thanks, and will do for the next ones! From unknown Wed Jun 18 23:15:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Aug 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator