From cabo@tzi.org Sun Nov 15 21:38:49 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 16 Nov 2009 05:38:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAG5cmqn002794 for ; Sun, 15 Nov 2009 21:38:49 -0800 Received: from mail.gnu.org ([199.232.76.166]:49565 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1N9uIZ-0000oe-H6 for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 00:38:47 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1N9uIW-0000AA-Lu for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 00:38:47 -0500 Received: from mailhost.informatik.uni-bremen.de ([134.102.201.18]:60181 helo=informatik.uni-bremen.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N9uIW-00008s-27 for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 00:38:44 -0500 X-Virus-Scanned: amavisd-new at informatik.uni-bremen.de Received: from smtp-fb3.informatik.uni-bremen.de (smtp-fb3.informatik.uni-bremen.de [134.102.224.120]) by informatik.uni-bremen.de (8.14.3/8.14.3) with ESMTP id nAG5cRR7023671 for ; Mon, 16 Nov 2009 06:38:27 +0100 (CET) Received: from [192.168.217.101] (p5489FD70.dip.t-dialin.net [84.137.253.112]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by smtp-fb3.informatik.uni-bremen.de (Postfix) with ESMTP id 6331DBF81; Mon, 16 Nov 2009 06:38:27 +0100 (CET) From: Carsten Bormann Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Mon, 16 Nov 2009 06:38:26 +0100 Subject: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer To: emacs-pretest-bug@gnu.org Message-Id: Mime-Version: 1.0 (Apple Message framework v1077) X-Mailer: Apple Mail (2.1077) X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) Start Emacs with -Q -q. C-x C-f a file with an RCS version control file behind it. perform some edit somewhere. C-x C-s. Bug: Point does not stay where it was, but jumps to the beginning of the = file. (Note that this does not seem to occur with, e.g., svn-controlled = files.) In GNU Emacs 23.1.50.3 (x86_64-apple-darwin10.2.0, NS = apple-appkit-1038.25) of 2009-11-16 on tuffi.local Windowing system distributor `Apple', version 10.3.1038 configured using `configure '--without-dbus' '--without-x' '--with-ns' = 'CFLAGS=3D-O9 -mtune=3Dnocona -pipe -fomit-frame-pointer'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-f / t p m p / b =20 > b l a b a l C-x C-s =20 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set Saving file /tmp/b... Wrote /tmp/b Load-path shadows: None found. Features: (shadow mail-extr message ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils emacsbug sendmail regexp-opt vc-rcs tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) From monnier@IRO.UMontreal.CA Mon Nov 16 11:34:45 2009 Received: (at 4933-done) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:34:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGHT0r2028073 for <4933-done@emacsbugs.donarmstrong.com>; Mon, 16 Nov 2009 09:29:02 -0800 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nAGHSxK8020821 for <4933-done@emacsbugs.donarmstrong.com>; Mon, 16 Nov 2009 12:28:59 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 50FB43A461; Mon, 16 Nov 2009 12:29:06 -0500 (EST) Resent-Message-ID: Resent-To: 4933-done@debbugs.gnu.org Resent-From: Stefan Monnier Resent-Date: Mon, 16 Nov 2009 12:29:06 -0500 X-Original-To: monnier@iro.umontreal.ca Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id EC8F42CFC99 for ; Mon, 16 Nov 2009 10:30:13 -0500 (EST) Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.183]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 99E1B3B8F31 for ; Mon, 16 Nov 2009 10:29:55 -0500 (EST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEABP+AEtMCqHJ/2dsb2JhbACBTdUXhDwEiT4 X-IronPort-AV: E=Sophos;i="4.44,751,1249272000"; d="scan'208";a="49473442" Received: from 76-10-161-201.dsl.teksavvy.com (HELO pastel.home) ([76.10.161.201]) by ironport2-out.pppoe.ca with ESMTP; 16 Nov 2009 10:29:55 -0500 Received: by pastel.home (Postfix, from userid 20848) id EC53FF1A31; Mon, 16 Nov 2009 10:29:54 -0500 (EST) From: Stefan Monnier To: Carsten Bormann Subject: Re: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer Message-ID: References: Date: Mon, 16 Nov 2009 10:29:54 -0500 In-Reply-To: (Carsten Bormann's message of "Mon, 16 Nov 2009 15:54:36 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.599, requis 5, autolearn=not spam, BAYES_00 -2.60) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3407=0 >> I've just installed the patch >> below which should fix it, > Works correctly for me, now. Thank you for confirming it, Stefan From cabo@tzi.org Mon Nov 16 11:35:09 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:35:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGEso74031187 for ; Mon, 16 Nov 2009 06:54:51 -0800 Received: from mx10.gnu.org ([199.232.76.166]:33403) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1NA2yf-0007Gl-HM for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:54:49 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NA2yd-0001Gz-Ol for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:54:49 -0500 Received: from mailhost.informatik.uni-bremen.de ([134.102.201.18]:54951 helo=informatik.uni-bremen.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NA2yd-0001Gf-85 for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:54:47 -0500 X-Virus-Scanned: amavisd-new at informatik.uni-bremen.de Received: from smtp-fb3.informatik.uni-bremen.de (smtp-fb3.informatik.uni-bremen.de [134.102.224.120]) by informatik.uni-bremen.de (8.14.3/8.14.3) with ESMTP id nAGEsbuZ005403; Mon, 16 Nov 2009 15:54:37 +0100 (CET) Received: from [192.168.217.101] (p5489FD70.dip.t-dialin.net [84.137.253.112]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by smtp-fb3.informatik.uni-bremen.de (Postfix) with ESMTP id 199CEB2EE; Mon, 16 Nov 2009 15:54:37 +0100 (CET) Subject: Re: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Carsten Bormann In-Reply-To: Date: Mon, 16 Nov 2009 15:54:36 +0100 Cc: 4933@debbugs.gnu.org, emacs-pretest-bug@gnu.org Content-Transfer-Encoding: 7bit Message-Id: References: To: Stefan Monnier X-Mailer: Apple Mail (2.1077) X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) > I've just installed the patch > below which should fix it, Works correctly for me, now. Thanks! Gruesse, Carsten From monnier@iro.umontreal.ca Mon Nov 16 11:35:22 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:35:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGEfKmY028781 for ; Mon, 16 Nov 2009 06:41:22 -0800 Received: from mail.gnu.org ([199.232.76.166]:60595 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1NA2lc-00070L-5Y for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:41:20 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NA2lb-0007TQ-7x for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:41:19 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183]:26772 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NA2la-0007T4-Nu for emacs-pretest-bug@gnu.org; Mon, 16 Nov 2009 09:41:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAIfzAEtMCqHJ/2dsb2JhbACBTNRphDwEiT4 X-IronPort-AV: E=Sophos;i="4.44,751,1249272000"; d="scan'208";a="49469632" Received: from 76-10-161-201.dsl.teksavvy.com (HELO pastel.home) ([76.10.161.201]) by ironport2-out.pppoe.ca with ESMTP; 16 Nov 2009 09:41:17 -0500 Received: by pastel.home (Postfix, from userid 20848) id 34A91F1A31; Mon, 16 Nov 2009 09:41:17 -0500 (EST) From: Stefan Monnier To: Carsten Bormann Cc: 4933@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer Message-ID: References: Date: Mon, 16 Nov 2009 09:41:17 -0500 In-Reply-To: (Carsten Bormann's message of "Mon, 16 Nov 2009 06:38:26 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. > Start Emacs with -Q -q. > C-x C-f a file with an RCS version control file behind it. > perform some edit somewhere. > C-x C-s. > Bug: Point does not stay where it was, but jumps to the beginning of the file. > (Note that this does not seem to occur with, e.g., svn-controlled files.) Thank you for that precise bug report. I've just installed the patch below which should fix it, Stefan --- vc-rcs.el.~1.97.~ 2009-11-15 23:34:56.000000000 -0500 +++ vc-rcs.el 2009-11-16 09:38:57.000000000 -0500 @@ -1056,6 +1056,7 @@ ((not (get-file-buffer file)) nil) ((let (status version locking-user) (with-current-buffer (get-file-buffer file) + (save-excursion (goto-char (point-min)) (cond ;; search for $Id or $Header @@ -1112,7 +1113,7 @@ (setq status 'rev))) ;; else: nothing found ;; ------------------- - (t nil))) + (t nil)))) (if status (vc-file-setprop file 'vc-working-revision version)) (and (eq status 'rev-and-lock) (vc-file-setprop file 'vc-state From cabo@tzi.org Mon Nov 16 11:36:01 2009 Received: (at 4933) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:36:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,SPF_HELO_PASS autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from informatik.uni-bremen.de (mailhost.informatik.uni-bremen.de [134.102.201.18]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGDIIGN015854 for <4933@emacsbugs.donarmstrong.com>; Mon, 16 Nov 2009 05:18:19 -0800 X-Virus-Scanned: amavisd-new at informatik.uni-bremen.de Received: from smtp-fb3.informatik.uni-bremen.de (smtp-fb3.informatik.uni-bremen.de [134.102.224.120]) by informatik.uni-bremen.de (8.14.3/8.14.3) with ESMTP id nAGDIAMX015534; Mon, 16 Nov 2009 14:18:10 +0100 (CET) Received: from [192.168.217.101] (p5489FD70.dip.t-dialin.net [84.137.253.112]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by smtp-fb3.informatik.uni-bremen.de (Postfix) with ESMTP id D14C9B230; Mon, 16 Nov 2009 14:18:09 +0100 (CET) From: Carsten Bormann Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Date: Mon, 16 Nov 2009 14:18:08 +0100 Subject: More information on bug 4933 (vc-rcs.el) To: 4933@debbugs.gnu.org Message-Id: <8B5D98D2-20D9-43E4-9B41-A262831D6BD7@tzi.org> Mime-Version: 1.0 (Apple Message framework v1077) X-Mailer: Apple Mail (2.1077) Specifically, the jump seems to occur in (vc-after-save) and there in (vc-checkout-model backend (list file)) drilling down further: (vc-rcs-checkout-model (list (buffer-file-name))) (vc-rcs-consult-headers (buffer-file-name)) And right there in vc-rcs.el is the culprit: 1.96 (monnier 13-Nov-09): (goto-char (point-min)) Are we missing a save-excursion? From rgm@gnu.org Mon Nov 16 12:19:34 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Nov 2009 20:19:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGKJXwb002350 for ; Mon, 16 Nov 2009 12:19:34 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NA82q-0001eG-Cv; Mon, 16 Nov 2009 15:19:28 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19201.46032.329389.979397@fencepost.gnu.org> Date: Mon, 16 Nov 2009 15:19:28 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: 9VS.!s?&\wahsq)]!hBRJdbTY%0A\3I)%|fhtz9xz/i/b.2U'\"~sPJ"FQ_W#NzJVoLOjO X-Debbugs-No-Ack: yes tags 4924 = reassign 2932 emacs reassign 4932 spam forcemerge 4933 4936 From monnier@IRO.UMontreal.CA Mon Nov 16 13:34:58 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Nov 2009 21:34:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGLYu9U009155 for ; Mon, 16 Nov 2009 13:34:57 -0800 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id nAGLYt8f010765; Mon, 16 Nov 2009 16:34:55 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 12F743A0FA; Mon, 16 Nov 2009 16:34:55 -0500 (EST) From: Stefan Monnier To: control@debbugs.gnu.org (Emacs bug Tracking System) Subject: Re: Processed (with 1 errors): Re: bug#4936: 23.1.50; Position jumps when saving RCS-versioned files Message-ID: References: Date: Mon, 16 Nov 2009 16:34:55 -0500 In-Reply-To: (Emacs bug Tracking System's message of "Mon, 16 Nov 2009 11:50:33 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3407=0 forcemerge 4933 4936 close 4936 thanks From unknown Fri Sep 05 09:10:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Dec 2009 15:24:15 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator