From unknown Sat Sep 20 16:32:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49329 <49329@debbugs.gnu.org> To: bug#49329 <49329@debbugs.gnu.org> Subject: Status: [PATCH 00/??] Improve Ren'py package Reply-To: bug#49329 <49329@debbugs.gnu.org> Date: Sat, 20 Sep 2025 23:32:42 +0000 retitle 49329 [PATCH 00/??] Improve Ren'py package reassign 49329 guix-patches submitter 49329 Leo Prikler severity 49329 normal tag 49329 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 08:40:34 2021 Received: (at submit) by debbugs.gnu.org; 2 Jul 2021 12:40:34 +0000 Received: from localhost ([127.0.0.1]:35212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzITC-0006ry-J6 for submit@debbugs.gnu.org; Fri, 02 Jul 2021 08:40:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:41212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzIT9-0006rp-Uo for submit@debbugs.gnu.org; Fri, 02 Jul 2021 08:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzIT9-00040l-N7 for guix-patches@gnu.org; Fri, 02 Jul 2021 08:40:31 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:28963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzIT6-00017f-DB for guix-patches@gnu.org; Fri, 02 Jul 2021 08:40:30 -0400 Received: from [10.0.0.4] (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GGZRk3GBhz1LXt4 for ; Fri, 2 Jul 2021 14:40:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GGZRk3GBhz1LXt4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625229618; bh=6MeyvRGR4fstgazkaVgLRboaneePEHj0TtGr4peLXEg=; h=Subject:From:To:Date:From; b=G1nSpVJr54HzEx2A2k+vcCYUyi3QsyYSeg+uFB7xrNgwMXf/z7ZOFmByNH9UGAUAc 8OoNWMKPGJuUvQ6qUWtY5M0vmNnIBRTWi27LPGhi1//nBulvV+RgnyxzJZymO/X5vQ OG8bpDdND3w+dWd2xVNQL4cz6xT+4lVePvOUbpq8= Message-ID: Subject: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: guix-patches@gnu.org Date: Fri, 02 Jul 2021 14:39:52 +0200 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Guix, Being one of the first package I've ever contributed to Guix, the renpy package contains a few mistakes, some of which were fixed over time, but many of which still remain. This series aims to address a few of them. At the time of writing, I haven't yet finished it, I just want to claim the bug ID, so that I can 'git send-email' later today. Thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 09:58:38 2021 Received: (at 49329) by debbugs.gnu.org; 2 Jul 2021 13:58:38 +0000 Received: from localhost ([127.0.0.1]:36831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgk-0000q7-37 for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:38 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:52785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgh-0000pq-KO for 49329@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:37 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GGcB14qCtz1LZW9 for <49329@debbugs.gnu.org>; Fri, 2 Jul 2021 15:58:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GGcB14qCtz1LZW9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625234313; bh=nANYCQgDug04g5rFTR1sA9gKOTwQB1UH8kSbbn8r/pw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Be3Xx8wvnPSsgRJUCkFbsbUCQyyiE9srSdpcgdn3ZAjTo4VybCbrBtT2VOrtIJSS6 38+6PgItB6DB7MvczP/WEzZy8qEHrFVbMh7/ZrPoY4Fx2cR40Ndm7Vh7aEWeQqc/tF /X4ldnQ0c+XSwCok7TUrkulc3CaMv+u1ZLA9g8fE= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH 2/4] gnu: python2-renpy: Update description. Date: Fri, 2 Jul 2021 15:58:16 +0200 Message-Id: <20210702135818.16084-2-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210702135818.16084-1-leo.prikler@student.tugraz.at> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (python2-renpy)[description]: Mention, that it's only used for bootstrapping renpy. --- gnu/packages/game-development.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 22c44a585c..9b231ad333 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") ("xdg-utils" ,xdg-utils))) (home-page "https://www.renpy.org/") (synopsis "Ren'py python module") - (description "This package contains the shared libraries and Python -modules of Ren'py.") + (description "This package contains the shared libraries and Python modules +of Ren'py. While functional, they are not meaningful on their own without +the launcher and common Ren'py code provided by the @code{renpy} package and +are only used to bootstrap it.") (license license:expat))) (define-public renpy -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 09:58:39 2021 Received: (at 49329) by debbugs.gnu.org; 2 Jul 2021 13:58:39 +0000 Received: from localhost ([127.0.0.1]:36834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgl-0000qQ-Aa for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:39 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:8074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgj-0000pt-36 for 49329@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:37 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GGcB30lHDz1LZWB for <49329@debbugs.gnu.org>; Fri, 2 Jul 2021 15:58:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GGcB30lHDz1LZWB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625234315; bh=Ycr2IQssYLQZ0/LJO/vvIHi3XUiaKR79eZCG4OsUlB4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=hOKrkM2nBIBUHxbGwISe4gmH1R7MQjYBG0VTla+K+KS+Axp61f0ZIjsWyOkBMak89 1U2G41SbN8Y8YLlgj3QgNwkYljKvo/0zOgluUTgy+R+9OZm7KtWP2K4YkQyM/MEj7M GcjwfttpeEXqeYQV83dh8nPFpgPGPXF5Cf57NwQo= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH 3/4] gnu: python2-renpy: Correct inputs. Date: Fri, 2 Jul 2021 15:58:17 +0200 Message-Id: <20210702135818.16084-3-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210702135818.16084-1-leo.prikler@student.tugraz.at> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (python2-renpy)[#:phases]: Search for ‘xdg-open’ in inputs. : Search for ‘cython’ in native-inputs. [native-inputs]: Move ‘xdg-utils’ from here… [inputs]: … to here. --- gnu/packages/game-development.scm | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 9b231ad333..7c5d45c412 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1186,10 +1186,11 @@ developed mainly for Ren'py.") #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-commands - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (substitute* "renpy/editor.py" (("xdg-open") - (which "xdg-open"))) + (string-append (assoc-ref inputs "xdg-utils") + "/bin/xdg-open"))) #t)) (add-after 'unpack 'fix-include-paths (lambda* (#:key inputs #:allow-other-keys) @@ -1199,9 +1200,10 @@ developed mainly for Ren'py.") "/include/fribidi"))) #t)) (add-after 'set-paths 'set-build-vars - (lambda* (#:key inputs #:allow-other-keys) + (lambda* (#:key inputs native-inputs #:allow-other-keys) (setenv "RENPY_CYTHON" - (string-append (assoc-ref inputs "python2-cython") + (string-append (assoc-ref (or native-inputs inputs) + "python2-cython") "/bin/cython")) (setenv "RENPY_DEPS_INSTALL" (string-join (map cdr inputs) ":")) #t)) @@ -1240,14 +1242,14 @@ developed mainly for Ren'py.") ("glew" ,glew) ("libpng" ,libpng) ("sdl-union" - ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf))))) + ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf))) + ("xdg-utils" ,xdg-utils))) (propagated-inputs `(("python2-future" ,python2-future) ("python2-pygame" ,python2-pygame-sdl2))) (native-inputs `(("gcc" ,gcc-8) ; for const variables as initializer elements - ("python2-cython" ,python2-cython) - ("xdg-utils" ,xdg-utils))) + ("python2-cython" ,python2-cython))) (home-page "https://www.renpy.org/") (synopsis "Ren'py python module") (description "This package contains the shared libraries and Python modules -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 09:58:40 2021 Received: (at 49329) by debbugs.gnu.org; 2 Jul 2021 13:58:40 +0000 Received: from localhost ([127.0.0.1]:36836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgl-0000qS-Jy for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:39 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:40323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgh-0000po-Ho for 49329@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:38 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GGcB03P4Wz1LXt4 for <49329@debbugs.gnu.org>; Fri, 2 Jul 2021 15:58:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GGcB03P4Wz1LXt4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625234312; bh=r5yNDmAn9XiqLGr/D0Ac28GU5AV0qm5+5HakMyrZvI8=; h=From:To:Subject:Date:From; b=W/Bl0n8a/fbNpRLBW4gtsA8wRA5Qr+cEUsN3+zWAQRWYBKywjNVaXmB7j78fV0L7z 2HaG8vmL7FLsfdbWG86nhluBIlhfJXPLy9NJPxP62FUapbtrC8Aj13DWuGhuf67O7j oGaMjQomSU0D2HrOUOmSLA5FOgQlNHoX7CU+axFQ= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources. Date: Fri, 2 Jul 2021 15:58:15 +0200 Message-Id: <20210702135818.16084-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) These sources are written in Ren'py (the language) and thus not particularly useful before renpy itself is built. In particular, they serve no purpose when installed without prior compilation. * gnu/packages/game-development.scm (python2-renpy)[#:phases]: Drop installed "common" folder. (renpy)[#:phases]: Adjust comment accordingly. --- gnu/packages/game-development.scm | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 9069b88d0c..22c44a585c 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1230,7 +1230,8 @@ developed mainly for Ren'py.") (with-directory-excursion "module" (apply (assoc-ref %standard-phases 'install) args)) (copy-recursively "renpy" - (string-append out site "/renpy"))) + (string-append out site "/renpy")) + (delete-file-recursively (string-append out site "/renpy/common"))) #t))))) (inputs `(("ffmpeg" ,ffmpeg) @@ -1304,11 +1305,14 @@ modules of Ren'py.") ;; After finishing this step, "out" will have the following: ;; |-- bin/renpy ;; `-- share/renpy ; i.e. path_to_renpy_base() - ;; `-- common + ;; |-- common + ;; `-- gui ;; - ;; Note that common is also a de facto unused directory in - ;; python2-renpy. On other systems, renpy_base would point to - ;; site-packages or even somewhere in /opt. + ;; Note that common shares the source files that would be installed + ;; by python2-renpy (which are instead deleted from that package), + ;; but also contains their byte-compiled versions. + ;; On other systems, renpy_base would point to site-packages or + ;; even somewhere in /opt. ;; The former approach is not as straightforward as it seems ;; -- it causes renpy to load files twice for some weird reason -- ;; and the latter is impossible on Guix. Hence the detour through @@ -1319,9 +1323,11 @@ modules of Ren'py.") ;; well. This differs from the traditional layout, which is ;; roughly the following: ;; `-- Super Awesome Game - ;; |-- game ; <- the folder we actually want - ;; |-- lib ; compiled renpy module and dependencies - ;; |-- renpy ; Ren'py python code (source + compiled) + ;; |-- game ; <- the folder we actually want + ;; |-- lib ; compiled renpy module and dependencies + ;; |-- renpy ; yet another copy of Ren'py's code + ;; | |-- common ; the common folder from above + ;; | `-- ... ; Python code (source + compiled) ;; |-- Super Awesome Game.py ;; `-- Super Awesome Game.sh (let* ((out (assoc-ref outputs "out")) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 09:58:42 2021 Received: (at 49329) by debbugs.gnu.org; 2 Jul 2021 13:58:42 +0000 Received: from localhost ([127.0.0.1]:36838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgo-0000qg-1f for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:42 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:40846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJgk-0000q9-K9 for 49329@debbugs.gnu.org; Fri, 02 Jul 2021 09:58:39 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GGcB443Pxz1LZWn for <49329@debbugs.gnu.org>; Fri, 2 Jul 2021 15:58:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GGcB443Pxz1LZWn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625234316; bh=vrUaaG1fXhNhDOq9hmM/m+xmUmqF0kxH5AbZL969yfY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=TNAU48daRB0QeOxOREqFTp51/SzGz0ib8MmobHfWBGjHbgl+Y2tYwtJslYHfOluWX Dk1Zae5pFkpsjD0IcBF9wDbN0weDl4jJ2QcwyoHG/VFagtjBnCwemaJl9+zAiBYLyk JEa0PQ9A7ejmnxOSE0ExC9rdrzhdJXc5T1ogtp2s= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH 4/4] gnu: renpy: Correct inputs. Date: Fri, 2 Jul 2021 15:58:18 +0200 Message-Id: <20210702135818.16084-4-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210702135818.16084-1-leo.prikler@student.tugraz.at> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (renpy)[#:modules]: Add SRFI-1. [#:imported-modules]: Likewise. [#:phases]: Search for ‘python2’ and ‘xdg-open’ in inputs. : Search for ‘xorg-server’ in native-inputs. : Search for ‘python2’ in inputs. : Search for python dependencies in inputs. [inputs]: Add python2, drop python2-pygame (already propagated by python2-renpy). Move xorg-server from here… [native-inputs]: … to here. [propagated-inputs]: Empty. --- gnu/packages/game-development.scm | 54 +++++++++++++++++++++++-------- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 7c5d45c412..5d5fa5cf8b 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1266,15 +1266,22 @@ are only used to bootstrap it.") (arguments `(#:tests? #f ; see python2-renpy #:python ,python-2 + #:modules ((srfi srfi-1) + (guix build python-build-system) + (guix build utils)) + #:imported-modules ((srfi srfi-1) ,@%python-build-system-modules) #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-commands - (lambda* (#:key outputs #:allow-other-keys) + (lambda* (#:key inputs outputs #:allow-other-keys) (substitute* "launcher/game/choose_directory.rpy" - (("/usr/bin/python") (which "python2"))) + (("/usr/bin/python") + (string-append (assoc-ref inputs "python2") + "/bin/python2"))) (substitute* "launcher/game/front_page.rpy" (("xdg-open") - (which "xdg-open"))) + (string-append (assoc-ref inputs "xdg-utils") + "/bin/xdg-open"))) (substitute* "launcher/game/project.rpy" (("cmd = \\[ executable, \"-EO\", sys.argv\\[0\\] \\]") (string-append "cmd = [ \"" (assoc-ref outputs "out") @@ -1291,8 +1298,9 @@ are only used to bootstrap it.") ((", \"game\",") ",")) #t)) (add-before 'build 'start-xserver - (lambda* (#:key inputs #:allow-other-keys) - (let ((xorg-server (assoc-ref inputs "xorg-server"))) + (lambda* (#:key inputs native-inputs #:allow-other-keys) + (let ((xorg-server (assoc-ref (or native-inputs inputs) + "xorg-server"))) (setenv "HOME" (getcwd)) (system (format #f "~a/bin/Xvfb :1 &" xorg-server)) (setenv "DISPLAY" ":1") @@ -1344,7 +1352,8 @@ are only used to bootstrap it.") (call-with-output-file bin/renpy (lambda (port) - (format port "#!~a~%" (which "python2")) + (format port "#!~a/bin/python2~%" + (assoc-ref inputs "python2")) (format port " from __future__ import print_function @@ -1433,15 +1442,32 @@ if __name__ == \"__main__\": #t)) (replace 'wrap (lambda* (#:key inputs outputs #:allow-other-keys) - (wrap-program (string-append (assoc-ref outputs "out") - "/bin/renpy") - `("PYTHONPATH" = (,(getenv "PYTHONPATH")))) - #t))))) + (let ((out (assoc-ref outputs "out")) + (site (string-append "/lib/python" + (python-version + (assoc-ref inputs "python")) + "/site-packages"))) + (wrap-program (string-append out "/bin/renpy") + `("PYTHONPATH" = + (,@(delete-duplicates + (map + (lambda (store-path) + (string-append store-path site)) + (cons (assoc-ref outputs "out") + (map cdr + (filter + (lambda (input) + (string-prefix? "python2" (car input))) + inputs)))))))) + #t)))))) (inputs - `(("python2-tkinter" ,python-2 "tk") - ("python2-pygame" ,python2-pygame-sdl2) - ("python2-renpy" ,python2-renpy) - ("xorg-server" ,xorg-server))) + `(("python2-renpy" ,python2-renpy) + ("python2-tkinter" ,python-2 "tk") + ("python2" ,python-2) ; for ‘fix-commands’ and ‘wrap’ + ("xdg-utils" ,xdg-utils))) + (propagated-inputs '()) + (native-inputs + `(("xorg-server" ,xorg-server-for-tests))) (outputs (list "out" "tutorial" "the-question")) (home-page "https://www.renpy.org/") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 03:54:36 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 07:54:37 +0000 Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzaU0-0002mE-Nx for submit@debbugs.gnu.org; Sat, 03 Jul 2021 03:54:36 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:46849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzaTw-0002lm-UQ for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 03:54:35 -0400 Received: by mail-wm1-f44.google.com with SMTP id k16-20020a05600c1c90b02901f4ed0fcfe7so6671256wms.5 for <49329@debbugs.gnu.org>; Sat, 03 Jul 2021 00:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=VOD+af27EtwPrgtRGDnqF5LLwnSqI9ukYT2724LiVLE=; b=WveATn+JI71LRtZtzlSUudu4GEixA+C/1PKQB1JrNr7EswvJ0NYArIK3Tjh45b8Iw2 s3tvQuV3Vi2keN7ks9iQ3V89UWHq8swlU9IX6KYOlDHqaQGhhoyfS9RUVk7XW0PsyLO2 0Grh8AVWeXxIymz10wMvLSRw2zi7eDvry9GUxGD7SAm4YjVqRDuGauhYXFh7mn3r4uX3 ldND2SXjMiNQDF3JWTa4MLcdYkbz6+SP3Lt39/vbgEI8YDT8aezDUJinnbv6BzRG/m8/ xCvPLY/Em0myEJFrcE6QpDhbc3lbhUwwi4uJHavvL6+Xr3VBuvayQ/mhTNwe95nNXGPY rAUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=VOD+af27EtwPrgtRGDnqF5LLwnSqI9ukYT2724LiVLE=; b=fEXkFmv2XXpkLreDhyij62+e61xJDKoPgN1QxomKzEEyHFVHjPzHgqUOxiaBt7Gymz MU2am333pLtsrU79mawt5XLBTi9Ywk0XOcztuNgGLdv3x198zR2f6la5bNMfo6Xw30HT yLdlECkIo3iCo+n/vyjFh7I/d+4YXyZxry2SAuprAhpEOiAjpvcHbwz+HSf36jnylKIV p3kky/3306yBpHBdfJmW7yWN4Sx/+asVziKMeE8xz3zYXjTLlMtqLUV/gKl0mUwCQetn ROp3hxQSuaZzNg8nwDwXv+Fly1K2DZ0aozK0I5t8h4infPzos2Dc4Rbdc5GuVXJbLZsc DORw== X-Gm-Message-State: AOAM530nY41aaPEJ5JkIfEDTuXGWq43i0RDd6bz25wDZ74f/mCNIkIWU /omsKWPBSn2VYpMfINGQNBDI98A8sBw= X-Google-Smtp-Source: ABdhPJw9Ur46tlvRbgJkNEHYYcHw3rH9K5fQkjc5fZJItw3InsFVSCq+H9TcxTNGhcxynmkilRNDWA== X-Received: by 2002:a1c:f717:: with SMTP id v23mr3919376wmh.32.1625298867071; Sat, 03 Jul 2021 00:54:27 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t17sm5469054wrs.61.2021.07.03.00.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 00:54:26 -0700 (PDT) From: zimoun To: Leo Prikler , 49329@debbugs.gnu.org Subject: Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources. In-Reply-To: <20210702135818.16084-1-leo.prikler@student.tugraz.at> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> Date: Sat, 03 Jul 2021 09:50:50 +0200 Message-ID: <8635sval9h.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Just a general comment about Python 2. :-) On Fri, 02 Jul 2021 at 15:58, Leo Prikler w= rote: > * gnu/packages/game-development.scm (python2-renpy)[#:phases]: Is Ren=E2=80=99py working only with Python 2? Or does it also work with Py= thon 3? Because Python 2 is EOL, officially since January 2020, if Ren=E2=80=99= py is Python 2 only, maybe it could go to the channel guix-past [1], soon or later. :-) WDYT? 1: Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 04:35:13 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 08:35:13 +0000 Received: from localhost ([127.0.0.1]:37910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzb7J-0003jx-HF for submit@debbugs.gnu.org; Sat, 03 Jul 2021 04:35:13 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:26529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzb7F-0003jj-IC for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 04:35:12 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH4yK6HHXz1LB21; Sat, 3 Jul 2021 10:35:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH4yK6HHXz1LB21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625301306; bh=Cd7+ETozysB+Vqmj1cHj1JL/zLgKsYXGaQH95g1bO0s=; h=Subject:From:To:Date:In-Reply-To:References:From; b=ENhZw+N7M6IUtxLzdcY9yTAQugnXGb4IU5djbz7LiOH6K6LPDAkOw7t2LBjqDgXb3 +7nYXGJcMmMm/wHN3RTW8KQySz8360p7lastp6Vg/8Xc3FXLaCbVGlH0o/MS0I8VJK WBwhPbtF5e4cyTE8hdo8b+RBYXv+iONTDGTfWYLk= Message-ID: <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> Subject: Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources. From: Leo Prikler To: zimoun , 49329@debbugs.gnu.org Date: Sat, 03 Jul 2021 10:35:05 +0200 In-Reply-To: <8635sval9h.fsf@gmail.com> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> <8635sval9h.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi simon, Am Samstag, den 03.07.2021, 09:50 +0200 schrieb zimoun: > Hi Leo, > > Just a general comment about Python 2. :-) > > On Fri, 02 Jul 2021 at 15:58, Leo Prikler < > leo.prikler@student.tugraz.at> wrote: > > > * gnu/packages/game-development.scm (python2- > > renpy)[#:phases]: > > Is Ren’py working only with Python 2? Or does it also work with > Python > 3? Because Python 2 is EOL, officially since January 2020, if Ren’py > is > Python 2 only, maybe it could go to the channel guix-past [1], soon > or > later. :-) WDYT? > > 1: Ren'py does have a Python 3 compatibility layer, but I haven't gone around to doing a pure Python 3 build yet. I imagine it could also be used with Tauthon[1], which was suggested to be used as python2 replacement in places where projects can't trivially be ported to the newer python 3 stuffs. Furthermore, Ren'py 8 will use Python 3 as a base. I don't know if it'll be backwards compatible with Ren'py 7 then – probably not. If not, moving Ren'py 7 to Guix-Past sounds like a good idea. I must admit, I haven't been following the Python 2 removal plan too closely. Is it already time to move working leaf packages? Cheers, Leo [1] https://github.com/naftaliharris/tauthon From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 05:30:22 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 09:30:22 +0000 Received: from localhost ([127.0.0.1]:37935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyg-00055c-3z for submit@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:22 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:19714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyb-00055C-Jf for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:21 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH69y24vBz1DH93 for <49329@debbugs.gnu.org>; Sat, 3 Jul 2021 11:30:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH69y24vBz1DH93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625304614; bh=lA5L/EsAsgLJWfrQOoiB16ZKio35y+k8aIbb7YRTpDE=; h=From:To:Subject:Date:From; b=uqxnLcmdY12IydZxxbNLDLhoICwLUGIS6A344T8pfGkH7QxFrS7v3LmJ78DyoG1EG Fm1vRK9Q/jG4k52VmKOitU4Qf0f+AmJs6Fz0twjk8Yn3XLj7eURQ3AzRoAYa/X+CSB xiUIausNBsqIpXLjdnZAJZSn5yg5iHAAVLG1wYEs= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH v2 1/5] gnu: python2-renpy: Drop unused Ren'py sources. Date: Sat, 3 Jul 2021 11:28:39 +0200 Message-Id: <20210703092842.32189-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) These sources are written in Ren'py (the language) and thus not particularly useful before renpy itself is built. In particular, they serve no purpose when installed without prior compilation. * gnu/packages/game-development.scm (python2-renpy)[#:phases]: Drop installed "common" folder. (renpy)[#:phases]: Adjust comment accordingly. --- 0001 up to 0004 are identical to v1. gnu/packages/game-development.scm | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 9069b88d0c..22c44a585c 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1230,7 +1230,8 @@ developed mainly for Ren'py.") (with-directory-excursion "module" (apply (assoc-ref %standard-phases 'install) args)) (copy-recursively "renpy" - (string-append out site "/renpy"))) + (string-append out site "/renpy")) + (delete-file-recursively (string-append out site "/renpy/common"))) #t))))) (inputs `(("ffmpeg" ,ffmpeg) @@ -1304,11 +1305,14 @@ modules of Ren'py.") ;; After finishing this step, "out" will have the following: ;; |-- bin/renpy ;; `-- share/renpy ; i.e. path_to_renpy_base() - ;; `-- common + ;; |-- common + ;; `-- gui ;; - ;; Note that common is also a de facto unused directory in - ;; python2-renpy. On other systems, renpy_base would point to - ;; site-packages or even somewhere in /opt. + ;; Note that common shares the source files that would be installed + ;; by python2-renpy (which are instead deleted from that package), + ;; but also contains their byte-compiled versions. + ;; On other systems, renpy_base would point to site-packages or + ;; even somewhere in /opt. ;; The former approach is not as straightforward as it seems ;; -- it causes renpy to load files twice for some weird reason -- ;; and the latter is impossible on Guix. Hence the detour through @@ -1319,9 +1323,11 @@ modules of Ren'py.") ;; well. This differs from the traditional layout, which is ;; roughly the following: ;; `-- Super Awesome Game - ;; |-- game ; <- the folder we actually want - ;; |-- lib ; compiled renpy module and dependencies - ;; |-- renpy ; Ren'py python code (source + compiled) + ;; |-- game ; <- the folder we actually want + ;; |-- lib ; compiled renpy module and dependencies + ;; |-- renpy ; yet another copy of Ren'py's code + ;; | |-- common ; the common folder from above + ;; | `-- ... ; Python code (source + compiled) ;; |-- Super Awesome Game.py ;; `-- Super Awesome Game.sh (let* ((out (assoc-ref outputs "out")) -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 05:30:34 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 09:30:34 +0000 Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyg-00055j-El for submit@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:34 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:30703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyc-00055F-1S for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:21 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH69z610Tz1DH95 for <49329@debbugs.gnu.org>; Sat, 3 Jul 2021 11:30:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH69z610Tz1DH95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625304615; bh=nANYCQgDug04g5rFTR1sA9gKOTwQB1UH8kSbbn8r/pw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kZFgPx87yhyrdINIri9sIW2spa+V4p7fA2wXAPCZGQaoNEHuIOrxDdEDdBosyeX/F 1Gm3IHaBxvCWERaKT6ZXm+HOtkTIA6RL8F5zq/ffdcI6l932FVOvfCnTq/Via+lqWt k6sx6EyEaYWpIhweSUxaTt8MflTpwHWLhlbPby8E= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH v2 2/5] gnu: python2-renpy: Update description. Date: Sat, 3 Jul 2021 11:28:40 +0200 Message-Id: <20210703092842.32189-2-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210703092842.32189-1-leo.prikler@student.tugraz.at> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/game-development.scm (python2-renpy)[description]: Mention, that it's only used for bootstrapping renpy. --- gnu/packages/game-development.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 22c44a585c..9b231ad333 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") ("xdg-utils" ,xdg-utils))) (home-page "https://www.renpy.org/") (synopsis "Ren'py python module") - (description "This package contains the shared libraries and Python -modules of Ren'py.") + (description "This package contains the shared libraries and Python modules +of Ren'py. While functional, they are not meaningful on their own without +the launcher and common Ren'py code provided by the @code{renpy} package and +are only used to bootstrap it.") (license license:expat))) (define-public renpy -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 05:30:35 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 09:30:35 +0000 Received: from localhost ([127.0.0.1]:37940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbys-000568-9W for submit@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:35 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:43821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyd-00055H-Qn for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:21 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH6B147lNz1LXt0 for <49329@debbugs.gnu.org>; Sat, 3 Jul 2021 11:30:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH6B147lNz1LXt0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625304617; bh=Ycr2IQssYLQZ0/LJO/vvIHi3XUiaKR79eZCG4OsUlB4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=gO+/5ESXmHd3s/bL2HdEKW483fORQVNOzzCWX7VZOwSonqQm29pJ5i4jNnEeut3KM lX0EGuOuDiv6Btd/4Olq+2yBcPdjryZGdFlPZkzL0Fmrxn5ojTyZpkU5viNzBfzxtP xs5bhtB3d5CrYD/zdSKGmgqGQ1l1a/7XKJmp4+UU= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH v2 3/5] gnu: python2-renpy: Correct inputs. Date: Sat, 3 Jul 2021 11:28:41 +0200 Message-Id: <20210703092842.32189-3-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210703092842.32189-1-leo.prikler@student.tugraz.at> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (python2-renpy)[#:phases]: Search for ‘xdg-open’ in inputs. : Search for ‘cython’ in native-inputs. [native-inputs]: Move ‘xdg-utils’ from here… [inputs]: … to here. --- gnu/packages/game-development.scm | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 9b231ad333..7c5d45c412 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1186,10 +1186,11 @@ developed mainly for Ren'py.") #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-commands - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) (substitute* "renpy/editor.py" (("xdg-open") - (which "xdg-open"))) + (string-append (assoc-ref inputs "xdg-utils") + "/bin/xdg-open"))) #t)) (add-after 'unpack 'fix-include-paths (lambda* (#:key inputs #:allow-other-keys) @@ -1199,9 +1200,10 @@ developed mainly for Ren'py.") "/include/fribidi"))) #t)) (add-after 'set-paths 'set-build-vars - (lambda* (#:key inputs #:allow-other-keys) + (lambda* (#:key inputs native-inputs #:allow-other-keys) (setenv "RENPY_CYTHON" - (string-append (assoc-ref inputs "python2-cython") + (string-append (assoc-ref (or native-inputs inputs) + "python2-cython") "/bin/cython")) (setenv "RENPY_DEPS_INSTALL" (string-join (map cdr inputs) ":")) #t)) @@ -1240,14 +1242,14 @@ developed mainly for Ren'py.") ("glew" ,glew) ("libpng" ,libpng) ("sdl-union" - ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf))))) + ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf))) + ("xdg-utils" ,xdg-utils))) (propagated-inputs `(("python2-future" ,python2-future) ("python2-pygame" ,python2-pygame-sdl2))) (native-inputs `(("gcc" ,gcc-8) ; for const variables as initializer elements - ("python2-cython" ,python2-cython) - ("xdg-utils" ,xdg-utils))) + ("python2-cython" ,python2-cython))) (home-page "https://www.renpy.org/") (synopsis "Ren'py python module") (description "This package contains the shared libraries and Python modules -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 05:30:35 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 09:30:35 +0000 Received: from localhost ([127.0.0.1]:37942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyt-00056G-5u for submit@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:35 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:43983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyf-00055R-Lq for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:22 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH6B32cVMz1LXt4 for <49329@debbugs.gnu.org>; Sat, 3 Jul 2021 11:30:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH6B32cVMz1LXt4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625304619; bh=vrUaaG1fXhNhDOq9hmM/m+xmUmqF0kxH5AbZL969yfY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Ik8LiEAgkHk/12gXymifLoOpBePbN/YLHTcv1TsGt5h+ClcBN741/X3mx8didLqFl DjZH91yCbJ4WG00Q8olw4qQTe5NfL/ofvIwFjTlb0F9EIl45Mr9VbdinH/GeoBqJNY qrFxku6eTFJg6no9m1LxVpMhYHum274FM+pGqgdk= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH v2 4/5] gnu: renpy: Correct inputs. Date: Sat, 3 Jul 2021 11:28:42 +0200 Message-Id: <20210703092842.32189-4-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210703092842.32189-1-leo.prikler@student.tugraz.at> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (renpy)[#:modules]: Add SRFI-1. [#:imported-modules]: Likewise. [#:phases]: Search for ‘python2’ and ‘xdg-open’ in inputs. : Search for ‘xorg-server’ in native-inputs. : Search for ‘python2’ in inputs. : Search for python dependencies in inputs. [inputs]: Add python2, drop python2-pygame (already propagated by python2-renpy). Move xorg-server from here… [native-inputs]: … to here. [propagated-inputs]: Empty. --- gnu/packages/game-development.scm | 54 +++++++++++++++++++++++-------- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 7c5d45c412..5d5fa5cf8b 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1266,15 +1266,22 @@ are only used to bootstrap it.") (arguments `(#:tests? #f ; see python2-renpy #:python ,python-2 + #:modules ((srfi srfi-1) + (guix build python-build-system) + (guix build utils)) + #:imported-modules ((srfi srfi-1) ,@%python-build-system-modules) #:phases (modify-phases %standard-phases (add-after 'unpack 'fix-commands - (lambda* (#:key outputs #:allow-other-keys) + (lambda* (#:key inputs outputs #:allow-other-keys) (substitute* "launcher/game/choose_directory.rpy" - (("/usr/bin/python") (which "python2"))) + (("/usr/bin/python") + (string-append (assoc-ref inputs "python2") + "/bin/python2"))) (substitute* "launcher/game/front_page.rpy" (("xdg-open") - (which "xdg-open"))) + (string-append (assoc-ref inputs "xdg-utils") + "/bin/xdg-open"))) (substitute* "launcher/game/project.rpy" (("cmd = \\[ executable, \"-EO\", sys.argv\\[0\\] \\]") (string-append "cmd = [ \"" (assoc-ref outputs "out") @@ -1291,8 +1298,9 @@ are only used to bootstrap it.") ((", \"game\",") ",")) #t)) (add-before 'build 'start-xserver - (lambda* (#:key inputs #:allow-other-keys) - (let ((xorg-server (assoc-ref inputs "xorg-server"))) + (lambda* (#:key inputs native-inputs #:allow-other-keys) + (let ((xorg-server (assoc-ref (or native-inputs inputs) + "xorg-server"))) (setenv "HOME" (getcwd)) (system (format #f "~a/bin/Xvfb :1 &" xorg-server)) (setenv "DISPLAY" ":1") @@ -1344,7 +1352,8 @@ are only used to bootstrap it.") (call-with-output-file bin/renpy (lambda (port) - (format port "#!~a~%" (which "python2")) + (format port "#!~a/bin/python2~%" + (assoc-ref inputs "python2")) (format port " from __future__ import print_function @@ -1433,15 +1442,32 @@ if __name__ == \"__main__\": #t)) (replace 'wrap (lambda* (#:key inputs outputs #:allow-other-keys) - (wrap-program (string-append (assoc-ref outputs "out") - "/bin/renpy") - `("PYTHONPATH" = (,(getenv "PYTHONPATH")))) - #t))))) + (let ((out (assoc-ref outputs "out")) + (site (string-append "/lib/python" + (python-version + (assoc-ref inputs "python")) + "/site-packages"))) + (wrap-program (string-append out "/bin/renpy") + `("PYTHONPATH" = + (,@(delete-duplicates + (map + (lambda (store-path) + (string-append store-path site)) + (cons (assoc-ref outputs "out") + (map cdr + (filter + (lambda (input) + (string-prefix? "python2" (car input))) + inputs)))))))) + #t)))))) (inputs - `(("python2-tkinter" ,python-2 "tk") - ("python2-pygame" ,python2-pygame-sdl2) - ("python2-renpy" ,python2-renpy) - ("xorg-server" ,xorg-server))) + `(("python2-renpy" ,python2-renpy) + ("python2-tkinter" ,python-2 "tk") + ("python2" ,python-2) ; for ‘fix-commands’ and ‘wrap’ + ("xdg-utils" ,xdg-utils))) + (propagated-inputs '()) + (native-inputs + `(("xorg-server" ,xorg-server-for-tests))) (outputs (list "out" "tutorial" "the-question")) (home-page "https://www.renpy.org/") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 03 05:30:35 2021 Received: (at 49329) by debbugs.gnu.org; 3 Jul 2021 09:30:35 +0000 Received: from localhost ([127.0.0.1]:37944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyt-00056O-IN for submit@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:35 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:31195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzbyh-00055q-GF for 49329@debbugs.gnu.org; Sat, 03 Jul 2021 05:30:23 -0400 Received: from localhost.localdomain (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GH6B51XBJz1LZVs for <49329@debbugs.gnu.org>; Sat, 3 Jul 2021 11:30:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GH6B51XBJz1LZVs DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625304621; bh=TACTcAQTzZRNdB1nu7ByqgpxhYNYoQTIM8TSxqVrI14=; h=From:To:Subject:Date:In-Reply-To:References:From; b=kdtSwQRmHAIHHqDztZV8KLffrvxPV1FjznetjJUAfewSw+k6JP+Zqzh+dGGli4zOp C30fHNIEw+l/DVs1Z06yNbPzIHbn0ogtv2HQAbW2GsEBBg6Q1SYBrrqdqUvPA5Io6q R2zqaRXQmIwRoczBBPVivVbACP3mTUWsg4KQHP1Y= From: Leo Prikler To: 49329@debbugs.gnu.org Subject: [PATCH v2 5/5] gnu: Add python-pygame-sdl2. Date: Sat, 3 Jul 2021 11:28:43 +0200 Message-Id: <20210703092842.32189-5-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210703092842.32189-1-leo.prikler@student.tugraz.at> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (python-pygame-sdl2): New variable. Inherit package definition from previous python2-pygame-sdl2, with the following additions: [source]: Also drop “gen3” in snippet. [arguments]: Drop #:python. [native-inputs]: Use ‘python-cython’ instead of ‘python2-cython’. (python2-pygame-sdl2): Define in terms of python-pygame-sdl2. --- gnu/packages/game-development.scm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 5d5fa5cf8b..e1593c0f82 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1106,12 +1106,12 @@ to create fully featured games and multimedia programs in the python language.") (define-public python2-pygame (package-with-python2 python-pygame)) -(define-public python2-pygame-sdl2 +(define-public python-pygame-sdl2 (let ((real-version "2.1.0") (renpy-version "7.4.6")) (package - (inherit python2-pygame) - (name "python2-pygame-sdl2") + (inherit python-pygame) + (name "python-pygame-sdl2") (version (string-append real-version "-for-renpy-" renpy-version)) (source (origin @@ -1124,12 +1124,12 @@ to create fully featured games and multimedia programs in the python language.") '(begin ;; drop generated sources (delete-file-recursively "gen") + (delete-file-recursively "gen3") (delete-file-recursively "gen-static") #t)))) (build-system python-build-system) (arguments `(#:tests? #f ; tests require pygame to be installed first - #:python ,python-2 #:phases (modify-phases %standard-phases (add-after 'set-paths 'set-sdl-vars @@ -1149,7 +1149,7 @@ to create fully featured games and multimedia programs in the python language.") `(("sdl-union" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer sdl2-ttf))))) (native-inputs - `(("python2-cython" ,python2-cython))) + `(("python-cython" ,python-cython))) (home-page "https://www.renpy.org/") (synopsis "Reimplementation of the Pygame API using SDL2") (description "Pygame_SDL2 reimplements the Pygame API using SDL2, @@ -1158,6 +1158,9 @@ While it aims to be used as a drop-in replacement, it appears to be developed mainly for Ren'py.") (license (list license:lgpl2.1 license:zlib))))) +(define-public python2-pygame-sdl2 + (package-with-python2 python-pygame-sdl2)) + (define-public python2-renpy (package (name "python2-renpy") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 10 23:50:57 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 03:50:57 +0000 Received: from localhost ([127.0.0.1]:33693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2QUb-0000tv-4n for submit@debbugs.gnu.org; Sat, 10 Jul 2021 23:50:57 -0400 Received: from mail-pf1-f171.google.com ([209.85.210.171]:40625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2QUY-0000th-HC for 49329@debbugs.gnu.org; Sat, 10 Jul 2021 23:50:55 -0400 Received: by mail-pf1-f171.google.com with SMTP id j199so12843938pfd.7 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 20:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:cc:subject:references:sto:date:in-reply-to:message-id :user-agent:mime-version; bh=6OKv8+L5qkj3u7gEUmAlby1Ew0mBN2Iv0tW2IPkNHZA=; b=RKh7i/zODLwh5m1IQDKo0uCGTfqgYkq/p3MoApXBzkuPQg3pRpYK3SGCatt+6q9DbE +qs6pwQklkLy/4slL2wGu6RhuOt/n4BSiO1IHiwlNmurbcwmNFoTnKjDtp22hbYf5U03 wkFXCnuml2mwoANm91hCnTAt/Pb5p3LGiVPSHDR0/jGK76QkGEYFSvA64k2wGSl21jOa 2+KH45cltHGzQYZXcRm4YkZNJ9eXKRULxjMQj9TpJzfSJCPViVqDWhB390VwvYy4TI6u rwiV1LEv+EzO6WnprnIcDKPgU4LCl0N9uPVOiPNLfBHFTThRSIAKSKzt0uMGhTUfn19Y TLUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:cc:subject:references:sto:date:in-reply-to :message-id:user-agent:mime-version; bh=6OKv8+L5qkj3u7gEUmAlby1Ew0mBN2Iv0tW2IPkNHZA=; b=biRflovwTtagbpwJFzGGyWyy/A9dBahu7e7Vwqbhg+GitZqVqbpbdT3VjDYwD1cKAP ITRkd43GQsvH8kFlueN6KnfRruIoVLCrAwYbVnUkq//Omd1RuZwsQEcIFEhgNhYeD/6J NaNep0ZGSQz+X24kCXI8ST5CiWPpBzVHVAR2oFevd4c3zWO9X4gPZ17qs/db3oTTX9IZ DkdqidgoiOoPbXaUiQWgVwK9ClbG6IJujs8BTl//DJu0UUh7ZOJVVc09DxXZNzG+Zn0Z o6ZLR4FAElOuBkG+BUmG4dPRiIAk6Q8eZnHSuhZpGiwiZVBihIPr6xx+SZYK7ZvUVd10 vjPw== X-Gm-Message-State: AOAM532g4MbOpG3nzXkXF5GoOBQPQWuiXn+gS9uO3WM7hJP2fVA+xjXn yOF6KKzj+YXcOPSbPMOfUmJA4RMfEt6M8Q== X-Google-Smtp-Source: ABdhPJx3khcEz4sexg0XCZ2ml8OQOwlg7hO65Ypd1vezWG+3LDIM/x5l0icIFawmyn5QigZIs8X2QQ== X-Received: by 2002:a05:6a00:1305:b029:315:7312:2b0b with SMTP id j5-20020a056a001305b029031573122b0bmr46441726pfu.15.1625975448188; Sat, 10 Jul 2021 20:50:48 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id t23sm307835pfe.8.2021.07.10.20.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 20:50:47 -0700 (PDT) From: Chris Marusich Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> <8635sval9h.fsf@gmail.com> <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> STo: Leo Prikler Date: Sat, 10 Jul 2021 20:50:43 -0700 In-Reply-To: <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> (Leo Prikler's message of "Sat, 03 Jul 2021 10:35:05 +0200") Message-ID: <87fswl5x0s.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Leo Prikler writes: > Hi simon, > > Am Samstag, den 03.07.2021, 09:50 +0200 schrieb zimoun: >> Hi Leo, >> >> Just a general comment about Python 2. :-) >> >> On Fri, 02 Jul 2021 at 15:58, Leo Prikler < >> wrote: >> >> [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 MISSING_HEADERS Missing To: header 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (cmmarusich[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.210.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.210.171 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Hi simon, > > Am Samstag, den 03.07.2021, 09:50 +0200 schrieb zimoun: >> Hi Leo, >>=20 >> Just a general comment about Python 2. :-) >>=20 >> On Fri, 02 Jul 2021 at 15:58, Leo Prikler < >> leo.prikler@student.tugraz.at> wrote: >>=20 >> > * gnu/packages/game-development.scm (python2- >> > renpy)[#:phases]: >>=20 >> Is Ren=E2=80=99py working only with Python 2? Or does it also work with >> Python >> 3? Because Python 2 is EOL, officially since January 2020, if Ren=E2=80= =99py >> is >> Python 2 only, maybe it could go to the channel guix-past [1], soon >> or >> later. :-) WDYT? >>=20 >> 1: > Ren'py does have a Python 3 compatibility layer, but I haven't gone > around to doing a pure Python 3 build yet. I imagine it could also be > used with Tauthon[1], which was suggested to be used as python2 > replacement in places where projects can't trivially be ported to the > newer python 3 stuffs. > > Furthermore, Ren'py 8 will use Python 3 as a base. I don't know if > it'll be backwards compatible with Ren'py 7 then =E2=80=93 probably not. = If > not, moving Ren'py 7 to Guix-Past sounds like a good idea. > > I must admit, I haven't been following the Python 2 removal plan too > closely. Is it already time to move working leaf packages? It sounds like the plan is in flux, but essentially yes: https://lists.gnu.org/archive/html/guix-devel/2021-06/msg00179.html It seems to me that Python 2 will likely remain in Guix for some time, but the various Python 2 packages will over time become hidden or removed in favor of their Python 3 variants. The Ren'Py plan is outlined here (I think?): https://github.com/renpy/renpy/issues/2003 It sounds like it's going to be a slow (years) process for them. Other issues can be found here: https://github.com/renpy/renpy/issues?q=3Dis%3Aissue+is%3Aopen+%22python+3%= 22 Personally, I don't think it would be bad to add Ren'Py 7 to Guix proper, even if it still depends on Python 2 and Python 2 libraries. Until upstream supports Python 3, there is no other option, and for now it sounds like we are not planning on removing all of the Python 2 libraries just yet. If the maintenance burden becomes too great or we decide to eliminate more Python 2 dependencies from Guix proper, we can always drop Ren'Py 7 or move it to Guix-Past along with its dependencies. Hopefully Ren'Py 8 will bring Python 3 support sooner sooner than that, though, and we can just drop Ren'Py 7 in favor of Ren'Py 8 at that time. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqapMVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkaduDwP/i4TdXO0fx6nAmKNdtvig4SdJopL WLAzPknQyWvsV/f7E8kyLr3hnS2JhqksvwUghjqEU2MQ60Wa6YfiQWwGLeWb5NS+ LlPqPUSwHA+CVZb9cB9mOAniwZvDWV7wGwU/IzOTnsc1O5kwPZiXbjtDRi74xRJ1 A7xt7zBp600umbCRLMHYr6TjEcg7p+TFRcXjTjMciTEDvYgPU+G8HE4e91zuM8ya 6xdSQqgNs4Qnu5Vjzic/kVqXprgilIV03H7QgRBsfFgtfvUgbYu3N2X9fmWXxrFd KFhXvulgh+LzMyOuKmBJcZmGmPiMq34Rtw5h8hmXf/ILRnXCNMnIlB/7ttoEMhBj rntNtZAyUnDdM7UDoQWqxt+z/zduIm68D2sgebw1ZDEIAZqhg11B3XCQbBhaSbf9 KKC5ZgdoVsYu0iGN7yX/sBZl296JLvWUUTUma61+xRZ496RPrR9y9/vua1htvA4o f24lORLpfy1TjIprXr0BpwqGnZNriom4Fc1RF9jRB3pMaxhnZdCirYN7L4orxNAv nsY8x27QPM0oBEc6Fqs62Pyc+eS3tDaaFcFqJMue5as8IEfX4WGMh8G2O+APEzvZ tnTHU4zBPidtRFc54E7zxDT3je4zhz2Oqueoarmb0tVTbCZrKkIfhFmQVlZsfVLY NKF3odvp9yrbO9PQ =67xY -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 00:38:04 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:38:04 +0000 Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2REC-00020L-D9 for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:38:04 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:35760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2REA-0001zr-HL for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:38:03 -0400 Received: by mail-pg1-f172.google.com with SMTP id v7so14498072pgl.2 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p8N/tRmxRRGXLDSGqjyJN+JBpAYRtT2aTyMw/EEQJaY=; b=cdpKxcOGtAPqxFoDM5syVbJeRIZj13A6NKnJOi2MUIyUYEfBvVKDrYcjUJurk8+huT 0j6sJPiLgsZS0TpQY3I+QSIDA3FcguXNo/KFojVb0UgEAYDFPR9uqzFSV6mSytecHDnJ Z+w3piLV72QRVfyXn8sxUZ7AKhVsfT2pg2tyESj1x7dar0S2q+3GdDAxH4n+RgPYLRne xUpMwSkwk9GhF68fxq6/TrhBArVysmSMEzDVHXOqQtG7E+2yctCqYDDJpVIFcMzuJPNG zg+JDk8cEp4thOgOIbSpyuC7hoY6JTov3vhyCMhRFCLU0dBE/un62SRwdPnW0OdwM2Jc dM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p8N/tRmxRRGXLDSGqjyJN+JBpAYRtT2aTyMw/EEQJaY=; b=Su+2XQdEMyWVC4rB1MV1KzNz0ZeCHAOg2MH5bpzGGYjcQzROsqdrIXP6SJE3acaEja SYRDI7SZekw3A4NSHPmOlSpHwfuctAEslvRI/+PrivYpjkAtvdKDV/ZYcWpNa5cvOn3x 39Dk8AZwGrS+Mrzd/aZlYiLkP99iMzt36gFgV2sZ3mrMYUMvMjcw7F69NLa+e5NqDBpv QPkLoayT8BSwBSQqHHI6wIv3VbOyeV86W7cP/oZaVG1wgvhYkWqEtg3qDP49LDWcsM+p 72KNJaI2XH/C/so+N88rWhQ66yeNfAkGVoWU4spI2k3P6DXstW0f1meKwMZb4VCipYwQ BctA== X-Gm-Message-State: AOAM531+Sb/MNOKRFzi95CZXY3sVZUi3Vx5SbCZFS/L8W/ExShFgVMhs 0QvVTItEh6Trm4EoCaRzYBQnAVNIWRHCuw== X-Google-Smtp-Source: ABdhPJz8/fj4nOEJAaHmoPo/kA8Pqs2RAzDSaW3bTQlQ9susAj24zt5bqcIiUSXERiVhSNAGJhbkxw== X-Received: by 2002:aa7:8112:0:b029:328:70bc:3307 with SMTP id b18-20020aa781120000b029032870bc3307mr14277540pfi.67.1625978276226; Sat, 10 Jul 2021 21:37:56 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id 1sm10784493pfm.123.2021.07.10.21.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:37:55 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-4-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:37:51 -0700 In-Reply-To: <20210703092842.32189-4-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:42 +0200") Message-ID: <8735sl5uu8.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm > [...] > #t)) > (replace 'wrap > (lambda* (#:key inputs outputs #:allow-other-keys) > - (wrap-program (string-append (assoc-ref outputs "out") > - "/bin/renpy") > - `("PYTHONPATH" =3D (,(getenv "PYTHONPATH")))) > - #t))))) > + (let ((out (assoc-ref outputs "out")) > + (site (string-append "/lib/python" > + (python-version > + (assoc-ref inputs "python")) > + "/site-packages"))) > + (wrap-program (string-append out "/bin/renpy") > + `("PYTHONPATH" =3D > + (,@(delete-duplicates > + (map > + (lambda (store-path) > + (string-append store-path site)) > + (cons (assoc-ref outputs "out") > + (map cdr > + (filter > + (lambda (input) > + (string-prefix? "python2" (car inp= ut))) > + inputs)))))))) > + #t)))))) What's the motivation for doing this? It seems like the new version deletes duplicates, but has the downside of being a little more complicated and relying on the package names to determine what goes into the PYTHONPATH. Duplicate entries in the PYTHONPATH should not be a problem for correctness or performance, right? I feel like this section was perhaps better the way it was originally. Am I missing something? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqdZ8VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadt48QANHE5O25M4VFKZBCFRiNqyJe0AJh ccusZ23P4wPvg97hLKZT6c9GKCjiPLWZGHRIh5a9Fmh4MH6XN6KXRg5zA4V5GzjF WriXfbpzT8kRGHvaLLiM8F1U+xQWfYnry0Cz1tp13NZU9U7LNpnVF1mMTnc/IDX2 Bo5G1r+uq3g+Q5DPQjbKiJyko/Up8bL53360h2W+dYX+ZN6tZ+pExKVl+E97a2Wz 5D38S5W3j5Epn1UxzlbVp5eY8H3SvCU5DNN+LFiWVKLWH4M6vBVi7Flagi3GTLRW kDWtJk1usrZHR8rS9M3tG56JQ9FeGSxsQ0EXSnaD3tKQLhwHaqYwMDA+HhM8B4r7 YY7xglQ6dCPj5WZdulVaiS6SQWHS+WvuArrgm07Ef+Oxg8h4aiQm/h1NMdYflJ67 rzuDFlrZtUanL33K+yZnIwbOBg03+6STCkSzRPNMzcv9txB6KGva5B6zdvtUgLX8 vIMJq4DgymEMlD8BarfPy+euXt9QhnvWnWA0zIoUvJmt41+CsVIUzVBUjF5yfjb9 5GT1WZjZhQtNtdhGEh4LS+q8K/4jVdGi+YFNEt/tX39kphb1qcqM7t4ORm5dSaOS GB7rBHDwFXT847+hAluItvV9z9x09aOziiK5O/TeVhRXxBDqIl7RPuE7+PtczPd+ NSqPJAGVgWsjgJp8 =hvkH -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 00:44:39 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:44:39 +0000 Received: from localhost ([127.0.0.1]:33736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RKZ-00029H-5j for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:44:39 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:38708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RKX-000294-NA for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:44:38 -0400 Received: by mail-pj1-f47.google.com with SMTP id me13-20020a17090b17cdb0290173bac8b9c9so111706pjb.3 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HnNsUh1nZ9aih7+qoc2vqvg1mD4VtM4a9K4alLUmsy4=; b=TB5O5tuHqq+W3YN/rDL8fbnl8mgLTfIZkcoTARtgjHteruwRow8leb+Awco3VGW4GF wNviB8+Q1eQVcIDJ5vp6O0SYtS+iVjUxTIXTIYpJXkdrYx7zxnTTFw9K2v/VjzkLp/Nf 1WAP8eDaFBHams8loGltUpwFaK3nV9i6s8/jW6GRdYG8kag2eq6k+KViXzC1GODEWMwi ah8c306oDK3csbdbsGXQnpq6ya9JT8eB+edRB0iDRPVm5me7CXZYqDzKawpYt/4yhzfN 7ir8JK7nKJ5mFdFI3swUr15XADdoiPXNNeSGZHy0HIzhVmOlnj0HsN3yfILI4QJhCTYJ dkSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=HnNsUh1nZ9aih7+qoc2vqvg1mD4VtM4a9K4alLUmsy4=; b=WLPOEz9MzXFo+KhTDKoVq/w1KYW4nP2oI9yHubNjhUspRcS3G9XwIfDaXGaPkS/FSV YcVfCb64BCUWniievId+N9hgxEsLBQulxT/h5QgVICznE4kc/lnyW3Bjlr2v5nPqNzR8 YKC3xX6qjxqd16dZ1SFaxOcG6RcEy7PDUWx6Kb6W2WONYiKgzeO3bwjguFwFlQLG56Du WrmMLkaWg2n5DQbCU/bUxo808z3ZJqrT8MZkbMo/MMKNQWMfcuBRv6Wi5GK8C4Wwz/BW kueu259vRgjqFlvy0AT6n6SApzz+T0X71Y/o+762RpwL7JZDRxTkbtYqIzseWIrRdPgt nq1g== X-Gm-Message-State: AOAM531oOEzFZusJVWmWeAKjHlSGaTwlRqhQRgPrz2/vVnrGz+uni4ZF KqFCzqnCiWmAKmL6vA7v2loZrbDF18g9zA== X-Google-Smtp-Source: ABdhPJy6H8JTo3rFcxrbmOEjz5Ramjiit83LBfpFovHNa92NFjv7fwnHuJpERse0XVh9oqOOl8mBQA== X-Received: by 2002:a17:90a:a607:: with SMTP id c7mr47009465pjq.199.1625978671479; Sat, 10 Jul 2021 21:44:31 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id j3sm6766815pfc.10.2021.07.10.21.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:44:30 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-5-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:44:29 -0700 In-Reply-To: <20210703092842.32189-5-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:43 +0200") Message-ID: <87y2ad4fyq.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > * gnu/packages/game-development.scm (python-pygame-sdl2): New variable. > Inherit package definition from previous python2-pygame-sdl2, with the > following additions: Actually, it inherits from python-pygame, right? > [source]: Also drop =E2=80=9Cgen3=E2=80=9D in snippet. > [arguments]: Drop #:python. > [native-inputs]: Use =E2=80=98python-cython=E2=80=99 instead of =E2=80=98= python2-cython=E2=80=99. > (python2-pygame-sdl2): Define in terms of python-pygame-sdl2. LGTM. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqdy0VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadrEgP/1J8Mm1TM9ArQyEiaWP6NgfAI+oK Ex9zkA/LUaDpi6+6JP+anrJZ7euk04sK5MNx5lXlyPub9FHpbViDshTpcyO/hDHj WavLpckc1H2OE21oaUazMT+P2YAIp4x1v0U2hHFjXwP+Gdr1ul9VAKPQ80/LGxlR 7LDRUagPztSQrdzDfNE0299xtcRiDJGZDAvIdLi5klf1Kz6yqZNONVv0QdRyp7hM pDk2wlEVHnqneRv9J4luT/277cf7fmzTn6YprpCCNb5SuEmEZ1lwOhlVB33XzsYl vjHw1PM0HPAEW059d2g01Zbv79yhWRjWKpbutRRfwl1fbKu7cGKRTV7K8tV7AI6I kARld40N+yCJC96vBJiA7cXPbYmozHshEgAkUOKWNCUinWwgpp1yy5VrPEpvPRm0 l0/uuUzNRIhM0oV7TAHUcGCkocBTNI5+5/ujNGO30nKHdsdu+U7vguEqIKbChX9+ ZHDYdP8M4S51/gXGGUo3mANK+3Dn98SnSyZzPGDhLbPZMesm7Lok2HbpCSO16j++ 0JlicIoXqD1vGfWg0rR6PxoXCKeETrmWGcLM0eiETcURhrYUxHmdN6YFZRMUva7e d0FDaos/eC10TUL45sZ0Qo3RAReUopeYIyJIc8Kk2GAed/wQTO4UR1i+cDALJNrC 05WcPGwPB2O4T/z6 =HQFc -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 00:52:43 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:52:43 +0000 Received: from localhost ([127.0.0.1]:33740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RSM-0002KS-Vl for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:52:43 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:45931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RSL-0002KF-KB for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:52:42 -0400 Received: by mail-pj1-f50.google.com with SMTP id b8-20020a17090a4888b02901725eedd346so8477178pjh.4 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+FIG3V/0DQrdk06nXv2XzrRbGOKavxMbZu7cgxfa1MI=; b=sDj1snJaUg4D8oTEceRAcjti/L+unCMvIX1QQDjpIfgi9i1zQxCYjxUZ9D7lMdwGNd 5mr9THNOb+Fx7ZH29H3CjAhF9Zuwpg5yGaW7ki+CqVnsRckUn4Ny3zJUMBF0vk85UBCD iKsdqEbn+kuuSX09kO0FSVO8S3Lj/e43Xo1aV5a9qN4oaqbcWDg5hAne30IVmmdXhzDA +itWl51h02BvlOSMSLrJ4tL+fcCstrz3oHLcnOqfsFTPU3nZwPOiMBdtUI6FeyqznmE3 JiziCLOK6WD+7uIiAJruyZXX5i2vaWymBUvYMPypzPiqnOkNjmkdTPrBfCdr9LyN2aIs r0Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+FIG3V/0DQrdk06nXv2XzrRbGOKavxMbZu7cgxfa1MI=; b=C3z9SWNrXsbIW3oUG8d1ge7yHRPTGKrBTZpTVSpn26zTtfXlONOVi/QhSOezeaprNo I5KgvEx4Ybh17Xm+o3WmPG0W/BQqT9HI/9sUSMWtONDGYQEQRzIZx8m5yaERaq9wj3s0 RdXJ8LojNetbfiJnb/BsOXEa1eO11jaOXnuR7WDvYbzZ2l+Y8g/N8ggLxoHLmCZVg9Sj Bdd7Oi4hzCvOIwVk+8gzt2sEx/kw0D4ZODaCO44naAFV0iJP+vRhYW2PJz2HGT3CF/uf gFSvzRv6GvNzhhR4QWEyxlzZvQmXNaLzdm4QqOORE7RzLUH+z3XLoJG3HU+Vy7IqdmiI Rz6g== X-Gm-Message-State: AOAM530UEnxZmhBYVR9WndcQpxFrDaQGWxNl7E1GhgSYvdJBUEhwi9uh cLPGsb32Xylk4B9NGUR4bcDxlFw3pQUOlQ== X-Google-Smtp-Source: ABdhPJy3JQh36ZOVcxSRJigbGi6FVoF+8Gokd1wk/FpgFcCMjhSiLguqURYZ/GLbRQpQNbZ4dN2g3g== X-Received: by 2002:a17:902:9890:b029:120:1299:678e with SMTP id s16-20020a1709029890b02901201299678emr37889496plp.32.1625979155541; Sat, 10 Jul 2021 21:52:35 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id j2sm11825980pfb.53.2021.07.10.21.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:52:35 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:52:33 -0700 In-Reply-To: <20210703092842.32189-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:39 +0200") Message-ID: <87r1g54fla.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > These sources are written in Ren'py (the language) and thus not particula= rly > useful before renpy itself is built. In particular, they serve no purpose > when installed without prior compilation. Could we pre-compile those sources on installation, instead of deleting the common directory? I haven't used Ren'Py much (or at all in Guix), so I don't really understand the purpose of the common directory. I could just be missing some context/info. Other than that, this patch seems OK as far as I can tell. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeREVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadR1sP/0lLnM6/0IBtgJ8d2BJK7yLZt0/y vPnk8/4WDwgwLoytvEl70z8SesWz5IUqN30h+2iQi4VOklGbftuMSOK8fxU0IIgA Qt/xbfWhWg/fCaJ3K0tCcjPkzE0AYigF2kWBBBhAKxhnZeYVPgrXOm6i5JBzXcpV gAkzfrXlApk/+wrqOVQGSC9z3/Skwqc2UZKcPotsiF9RDAyr1rHrymIh4iDxF8r4 1kGthvVW0hWpwuRrUy+NNrpS3TD5T1B9lU0tEAeKllgg9PHUmtYsjHR+/P3vLXbK 5a3KUar2Ekq2LycU3QTaLn3oAJTdzIHfF3J4iiQr0POCA5Kn2uEGK43BsrpdRIOU xw/oBAGalEy0dPdAzhMnw86Rr7bnli1hi2ZEPC39V2LlgEc3JhOKj7H6NYbtHTLW tDJxPDZd6SOMGMSd3rf6CFHbh8ifYsntnV5Vhc7k60fGt7UOzZ/EkXJbHKv1MzQE DGrXpKlqDX1wAkk/z72Qh25sMCW7rVi+N9afsEGoaYOPKSaxawE8MfsKgAiZRZIj 4T8CkW60v3FfgOtvLc6kdU3BXwBS0LbDeYkRofuRS7cQhJlBrN0s5BpIr4+/BStp fsGXv33xnqNFNBbpFZXddrSZlx/IPvljQc1q6nXhSTC8arFh5lxRBHbq8oYYi18K eGL2NgKjJAyP/YD5 =rl1E -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 00:53:51 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:53:51 +0000 Received: from localhost ([127.0.0.1]:33744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RTS-0002M9-8L for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:53:51 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:39694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RTQ-0002Lu-0o for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:53:48 -0400 Received: by mail-pl1-f177.google.com with SMTP id h1so7254793plf.6 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UtqnD9Zd1ihbCGgRB35wWCjtnlDfBQbe4DYhia/9RzU=; b=H4qRWu/6uADQ+7KukgP8+7TQC82fKKdrenV8Z2YvlSPDbYPsM09NQQCmw/MdhnA/eH 9iWq89hSSssAw+ZM+1jki3CF/Lb9Xx+JMXQ159aPClhp7OD/jch3dqOZQBTiRhCDJ7lz gZr7aKCx4EAzQOI51PYpOgOTJkz7Hmu5uHKPvar8zz4tvI97CYjnn1Ait0x6C/Nwxg28 wXA0KbCv3fm2tz11eD+6m4OEfG+SRvSSvCpkbyL30tesRG2SXae17ulNthb7/WVQjGaf 1ez7hGRjzh+SC7HWLRFkor7wR4x+6mFVb+eLg5OAxrEQli9si55+vi9P8feLOovwCr9X MSmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UtqnD9Zd1ihbCGgRB35wWCjtnlDfBQbe4DYhia/9RzU=; b=pbz87eCVBku9k7coLFmqYYXeTx6dxR5WRQc2D90AaVQa1Or9W3Xl9jOd+pp4Hyc3LQ zIDL7MRGYj/bW7XzSID9Q20sEIhrqBuLXG9oIlO40Y8euZfyyettAE8WL9QI6ufYCY/W fO5XSbzR7tP6xhBcs+K6bSkP29ymlN6PQewARQg2yzGWdBmPy3LejQuLG5a4mCN1XbPQ xVaxlK5XQ4J1SISgoWfjWjlbV68T60PMVlu4R+FHjRWR3Tw14a77/iEO5ssWjpO6pB7P +OuoBdT3BuesdXtoGq0dW3Fwg5rUK4pmAdwLZlvTmnGsLtPVGJlNcxpjJ1/Hj4w8lQRd vlRQ== X-Gm-Message-State: AOAM530X22vnqv7X272uQhrK1P5c8KMgKi0b2PBuyYw3+1d9ro8rhcEg b0U/yngmUtABLjmJ9w5i0wfOpcunYQ22Pw== X-Google-Smtp-Source: ABdhPJzJl5ataP7/9autfTEhAfL0eNFz6q1ykf6uUTg+9XUdhzVXvOI9G8yv/HCwzGPa4emKp+W63A== X-Received: by 2002:a17:902:bf4c:b029:129:c4f1:2ecc with SMTP id u12-20020a170902bf4cb0290129c4f12eccmr19037437pls.73.1625979222134; Sat, 10 Jul 2021 21:53:42 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id e2sm11230380pfj.212.2021.07.10.21.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:53:41 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-2-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:53:40 -0700 In-Reply-To: <20210703092842.32189-2-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:40 +0200") Message-ID: <87mtqt4fjf.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > * gnu/packages/game-development.scm (python2-renpy)[description]: Mention, > that it's only used for bootstrapping renpy. > --- > gnu/packages/game-development.scm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-develo= pment.scm > index 22c44a585c..9b231ad333 100644 > --- a/gnu/packages/game-development.scm > +++ b/gnu/packages/game-development.scm > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") > ("xdg-utils" ,xdg-utils))) > (home-page "https://www.renpy.org/") > (synopsis "Ren'py python module") > - (description "This package contains the shared libraries and Python > -modules of Ren'py.") > + (description "This package contains the shared libraries and Python = modules > +of Ren'py. While functional, they are not meaningful on their own witho= ut > +the launcher and common Ren'py code provided by the @code{renpy} package= and > +are only used to bootstrap it.") > (license license:expat))) >=20=20 > (define-public renpy LGTM. If this isn't meant to be installed by users, should it be non-public or perhaps hidden? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeVQVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadnLAQAKfClHdXxGOJwdgD6nPmFwe14qNa cepgbzrr2grd4nLF642emjk/4KeF8EDWaaJGn9ClLalOkfTqmunUHGVHwjLLTepY 9DaZ6OdpbKFFWF2coFgzDr6EGtppivpbY9Vgq12sYIwaNbrsq+yEu2bIUkhWBHV0 MxVmmAmR8n9IHpIEWfiqOFaBsq20hHRhYlp9W1ogLVIDRQeDEy6V/b6RDhhQXzZW VbgW8cgnz7/yLOr/nLfTy0VP98isgKeG0g2qY0/lyi3xjLbe+37mGhXdXfIRIbT6 yvz78ZbQlHyDupPE93ZF9NgYCWPDWbDfa1PxoeUpD2Gxf06+DFm6MkROoHpxL1VQ 7CdcdGgHBtYYZP8ZHh3AyGfcPf7kxBA2FQLn/4XOR0JGq1aBg8ywJ80S1tmIubmZ /AAIU8r9J9cZTIm7fJiWi02g5bBfuRWy3ZcnXQeUWgh1luUWnPSlmz/7X/3PTDCO qAmkxXn43MDmTISMGmlogr37URctW9nR/PV8q/jYszX3crQvkIg8nNZ8cmZOlVRf TsYjMoKTkI8G54x+l6kN6Izuo1m5GaK9UuavhuBMXdhu5O8y/CBZTkHpmNFfJohn oaDDas5VCuu6ewhxI/s/1YKu4GJc3nqf6M1YbALny+izDzjD6oNsKXEhn0kApXxR kXbMiRu23CVX1YRV =WsUU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 00:55:12 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 04:55:12 +0000 Received: from localhost ([127.0.0.1]:33748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RUm-0002OT-9w for submit@debbugs.gnu.org; Sun, 11 Jul 2021 00:55:12 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:40608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2RUk-0002OA-Ie for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 00:55:10 -0400 Received: by mail-pf1-f182.google.com with SMTP id j199so12921576pfd.7 for <49329@debbugs.gnu.org>; Sat, 10 Jul 2021 21:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/ch37YhG26gc2pJvim8WZcQidN24qTVXscAOM3ZFV2E=; b=hqc63yqRYKyyGnSuovPmHRCtpC2WLDjNFqBUCHTzrFrCfESeF+818eaiNc1wwftpS+ 9WAcwuEkdH2XxldQh2NKkSiOeC6NVe2tEDDvZ5O8+6E8F1q9bU9f7v3NoEjOfUREwC8d 6MP1+EOAc/bEDK1Um2q7c1KQrCwFnkSMKmAQb7J4/d/rhUqF8WtGQIoscV17KkeL0k7e Eefy4qCnH4xN+VAe8TJLl6uXMid4STKaMfv8tlr9KOE5NjAw3eEZ42LvuTIPkqKHkXgp 3HW4KoLfsThQg3i/czlIV3f2Ttjfs5xUHc8yH1mgsmxSiuAA08XuZkm/fNx8LHzXz4bm WYIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/ch37YhG26gc2pJvim8WZcQidN24qTVXscAOM3ZFV2E=; b=mWIN2jHX2THgfYAb1ut8DzPHojIG3q+tcj9SnqhHOQHpStB0KFVSytuF0dr+46FDs6 PMUkxZ2zoqUSVzieGBmwMIOS2A266tXdM+lTTB2AzbAl6e3N6JCynXXnnDQcr7+vdDYS 3eaTooe67kUes1KAUhwPraFey0gslemGn2sLeqjhULc0hq8bPzBbVrey70vABGqQu1S1 CKXiqU9+zAIP0lS3gy1W/V4uvb2jdS2fcW2oBDefzSe85scSn+m2ZWyh5tdZ+3Tf4AvD ua/uufP7Ec5t9USdzMROvNpyyMGDA9NSA46cssD7fBC4mYao0S/uTfQ41NR+63tpt3w2 oRCg== X-Gm-Message-State: AOAM530j6IW1xoBtdQKYTBkSnVKaXcm/c9T2rDqCAs5M0WIY/mabNdyC QJhXC8KLIJ7zCh8f/u6UCTDg647WekbSnQ== X-Google-Smtp-Source: ABdhPJzV7bx9LS+59sh7i8kGQv5+ZicbO2cXDZoYGGPHzFFYb938iflLErHKJ8D2hSriP4lfJFuOWQ== X-Received: by 2002:aa7:9e5c:0:b029:32b:4e2a:e549 with SMTP id z28-20020aa79e5c0000b029032b4e2ae549mr712090pfq.68.1625979304556; Sat, 10 Jul 2021 21:55:04 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::a1ab]) by smtp.gmail.com with ESMTPSA id z9sm10840774pfa.2.2021.07.10.21.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 21:55:04 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-3-leo.prikler@student.tugraz.at> Date: Sat, 10 Jul 2021 21:55:02 -0700 In-Reply-To: <20210703092842.32189-3-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Sat, 3 Jul 2021 11:28:41 +0200") Message-ID: <87im1h4fh5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > * gnu/packages/game-development.scm (python2-renpy)[#:phases]: > Search for =E2=80=98xdg-open=E2=80=99 in inputs. > : Search for =E2=80=98cython=E2=80=99 in native-inputs. > [native-inputs]: Move =E2=80=98xdg-utils=E2=80=99 from here=E2=80=A6 > [inputs]: =E2=80=A6 to here. LGTM. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDqeaYVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadBNgP/jl/X+8c2MM+RIbkbSrlW3E7Tx8H CeVxQOyoEkuuVQsuCq5t6k2teLkD/0yjwnJXn2XxmVnBef1Sr4JOjylh+rZy2C4m EoHAsqKssbv4Wq1p5nvmkYZOB2DlegPm3oEjL+1a3/YMKrpw1uuDwfA23w3mED7X pZrXwQ4qWval4pbbfTc0hKKH8mfk2VV85pR7GOfbKBTjyvOYupaIlbloIkCQyV3W 3e4SElFHSKNwwwnQAX57kjD8qEDdWtcRsFD/SSUaC9Hg04nfLuOMob3XaDAKB4Xc W6bVCCmwIR+R/YT7/CDwXmcMDkOWQfaSOjCkKWZtlsCJOikE1EIzyJU/ALqrXjkr EGAMT0bhZUgs7/1G+VEXkjFFdy527IMyEQ64ISQj4MIHYANz1kqs++9RLKV9DdEw d6apaSWvjvh8ugk5F9v4LHtrJIuPWZA+qXDQ0fByXcyoMRSBFr9v+7el4FXLOVeO 6yc4f5n94qq+XPawknW6+ZvT2FfRpfleHKLsSZkWJJGFTCa40bMb31I0UEna5q3y shyLnjwq50xgS256dNZpR9m0S/OxcZB+fN40cTBfE63fSeY+bjnrkc+ZlEoE9zxH jMQo4QmIToAsw1LZDHSeCW6z8CrZaIusTnh8KyV2AFPmSxmRS8znhF9lAFU9QOWh xG9wPNq5zai3Zkpr =HQuh -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 02:58:58 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 06:58:59 +0000 Received: from localhost ([127.0.0.1]:33783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TQY-0005pW-Kq for submit@debbugs.gnu.org; Sun, 11 Jul 2021 02:58:58 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:29807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TQW-0005pN-Gc for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 02:58:57 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GMyRd0Lq3z3wWT; Sun, 11 Jul 2021 08:58:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625986733; bh=CDwGDakN+flB5gbA4V3Kiu32+tRbIqJQ/VOM/xys8VY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZXvEn1f+6Q4ZpsRadzFlBOF1rYh0UXCVm632Q/REo1fxDxq4zfjnZhs/8tVX0by05 6mzwtO6OTIfMe7PE3wqbqTn0sdsZ2lWS/XY7E9TqngL712DATy+DJ7NlpX/EDVoP3n VIKthJTBZ1UVz/zLWlC7t9L0Kd8aksLpzyyRLbNk= Message-ID: <235456dfa9f27b6a3b612fb0a8d6e86aa4b5d362.camel@student.tugraz.at> Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: Chris Marusich Date: Sun, 11 Jul 2021 08:58:51 +0200 In-Reply-To: <8735sl5uu8.fsf_-_@gmail.com> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-4-leo.prikler@student.tugraz.at> <8735sl5uu8.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Samstag, den 10.07.2021, 21:37 -0700 schrieb Chris Marusich: > Leo Prikler writes: > > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- > > development.scm > > [...] > > #t)) > > (replace 'wrap > > (lambda* (#:key inputs outputs #:allow-other-keys) > > - (wrap-program (string-append (assoc-ref outputs > > "out") > > - "/bin/renpy") > > - `("PYTHONPATH" = (,(getenv "PYTHONPATH")))) > > - #t))))) > > + (let ((out (assoc-ref outputs "out")) > > + (site (string-append "/lib/python" > > + (python-version > > + (assoc-ref inputs > > "python")) > > + "/site-packages"))) > > + (wrap-program (string-append out "/bin/renpy") > > + `("PYTHONPATH" = > > + (,@(delete-duplicates > > + (map > > + (lambda (store-path) > > + (string-append store-path site)) > > + (cons (assoc-ref outputs "out") > > + (map cdr > > + (filter > > + (lambda (input) > > + (string-prefix? "python2" > > (car input))) > > + inputs)))))))) > > + #t)))))) > > What's the motivation for doing this? It seems like the new version > deletes duplicates, but has the downside of being a little more > complicated and relying on the package names to determine what goes > into > the PYTHONPATH. > > Duplicate entries in the PYTHONPATH should not be a problem for > correctness or performance, right? I feel like this section was > perhaps > better the way it was originally. Am I missing something? The reason is that I want to avoid having native-inputs in PYTHONPATH (which the naïve getenv-based solution will always return). For native builds these currently can't be avoided even with the above snippet, but for cross-builds and maybe future native-builds which separate inputs and native-inputs, this ought to do "the correct thing". delete-duplicates is more of a style thing than anything else, in my personal opinion the wrapper script is more readable with it. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 03:00:51 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 07:00:51 +0000 Received: from localhost ([127.0.0.1]:33787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TSN-0005u6-1j for submit@debbugs.gnu.org; Sun, 11 Jul 2021 03:00:51 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:40995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TSL-0005tw-6X for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 03:00:49 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GMyTq4Sbdz3wNk; Sun, 11 Jul 2021 09:00:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625986847; bh=TF7YSIwDGBiG3riv3zZWUNCYtWFBYlSlM65ycTdEX9E=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=g7CMApm6U7IE0QniH3yzus9JKHx60oqLIrXy12sWJqrTUptSqGEmpv5lruEVvmLEf HVmyzQtpEdiHGQvqg4o2ZPh4WmP52M+o+vLdGuF/xxVCH3KfDcf9G82bUUpI9wVfdG H/7+InIKNCMKnDHsHpOAyCwccwnoVdSoeLdjHIvw= Message-ID: Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: Chris Marusich Date: Sun, 11 Jul 2021 09:00:46 +0200 In-Reply-To: <87y2ad4fyq.fsf_-_@gmail.com> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-5-leo.prikler@student.tugraz.at> <87y2ad4fyq.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich: > Leo Prikler writes: > > > * gnu/packages/game-development.scm (python-pygame-sdl2): New > > variable. > > Inherit package definition from previous python2-pygame-sdl2, with > > the > > following additions: > > Actually, it inherits from python-pygame, right? "Inherit" as in "use the code that was originally written for python2- pygame-sdl2". Did the inherit field change with this patch? If so, I should reflect it in the commit message. > > [source]: Also drop “gen3” in snippet. > > [arguments]: Drop #:python. > > [native-inputs]: Use ‘python-cython’ instead of ‘python2-cython’. > > (python2-pygame-sdl2): Define in terms of python-pygame-sdl2. > > LGTM. > From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 03:03:15 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 07:03:15 +0000 Received: from localhost ([127.0.0.1]:33791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TUh-0005yO-EP for submit@debbugs.gnu.org; Sun, 11 Jul 2021 03:03:15 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:24721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2TUf-0005yG-Up for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 03:03:14 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GMyXc0mzwz1DH93; Sun, 11 Jul 2021 09:03:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GMyXc0mzwz1DH93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625986992; bh=x6c5GL3yjtgP8B7EFuQu8J1+Vc9/IZvFqzF5NzA/AAE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=M2l485j0S8Nnp1WWpuDFh9gvz3SWtj8IKerEyLSsMMSOlgWehtdLbIZKCWsZ0TO6y 0tqdiRj3fH8aGzz03hjySso0q1yx1rXO5l0wcg7902jgvEAHxYiPaf7WnBfMsclZfv nUdykFJquJm6nZuRn33mOCxuEjx4Y1j5lvikVQ2o= Message-ID: Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: Chris Marusich Date: Sun, 11 Jul 2021 09:03:11 +0200 In-Reply-To: <87r1g54fla.fsf_-_@gmail.com> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <87r1g54fla.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Samstag, den 10.07.2021, 21:52 -0700 schrieb Chris Marusich: > Leo Prikler writes: > > > These sources are written in Ren'py (the language) and thus not > > particularly > > useful before renpy itself is built. In particular, they serve no > > purpose > > when installed without prior compilation. > > Could we pre-compile those sources on installation, instead of > deleting > the common directory? I haven't used Ren'Py much (or at all in > Guix), > so I don't really understand the purpose of the common directory. I > could just be missing some context/info. > > Other than that, this patch seems OK as far as I can tell. You need Ren'py (as in the package you're currently compiling) to compile these sources. These sources will get compiled just fine in the renpy package given that we already have python2-renpy available by then, so they are shipped as part of that instead of this package. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 03:09:54 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 07:09:54 +0000 Received: from localhost ([127.0.0.1]:33795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Tb8-00068P-4w for submit@debbugs.gnu.org; Sun, 11 Jul 2021 03:09:54 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:60607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2Tb6-00068H-FP for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 03:09:53 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GMyhG5Bhcz1LBRt; Sun, 11 Jul 2021 09:09:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GMyhG5Bhcz1LBRt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625987390; bh=SMZnIHnb6mVbJoWSSfkEIOWqNa3GZbVc+gxkm6Dq/7c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Lt34l4QnQ0p+cmhQiqG8idEqjswzJIEEsvuua0KzikajVKank1i9GzwZ/0qN0MQ1z C8Pfw2VgpP+FY5Aggfy07mfmnWmqzh0i2QsT3gEm0n4s3BBT576MQpGNOtP4U41Zu8 91FIxoIGO+XvRiwqeSGePge67o3OZxmw/eKPV4J4= Message-ID: Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: Chris Marusich Date: Sun, 11 Jul 2021 09:09:50 +0200 In-Reply-To: <87mtqt4fjf.fsf_-_@gmail.com> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-2-leo.prikler@student.tugraz.at> <87mtqt4fjf.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich: > Leo Prikler writes: > > > * gnu/packages/game-development.scm (python2-renpy)[description]: > > Mention, > > that it's only used for bootstrapping renpy. > > --- > > gnu/packages/game-development.scm | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- > > development.scm > > index 22c44a585c..9b231ad333 100644 > > --- a/gnu/packages/game-development.scm > > +++ b/gnu/packages/game-development.scm > > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") > > ("xdg-utils" ,xdg-utils))) > > (home-page "https://www.renpy.org/") > > (synopsis "Ren'py python module") > > - (description "This package contains the shared libraries and > > Python > > -modules of Ren'py.") > > + (description "This package contains the shared libraries and > > Python modules > > +of Ren'py. While functional, they are not meaningful on their own > > without > > +the launcher and common Ren'py code provided by the @code{renpy} > > package and > > +are only used to bootstrap it.") > > (license license:expat))) > > > > (define-public renpy > > LGTM. If this isn't meant to be installed by users, should it be > non-public or perhaps hidden? Good point, but I don't think users will accidentally install it like they do with gcc. This description was written to address a point made by Ludovic in IRC concerning the package's lack of one. Having the package publicly exported also makes my own life easier when updating the recipe. Last, but not least, these are functional modules and could be used to develop code, that depends on Ren'py's internals, but none of the "common" renpy stuff (or the common renpy stuff could otherwise be extracted from the renpy package and changed to the developer's desires). Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 04:41:07 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 08:41:07 +0000 Received: from localhost ([127.0.0.1]:33849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2V1P-0008NA-5J for submit@debbugs.gnu.org; Sun, 11 Jul 2021 04:41:07 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:44708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2V1N-0008MZ-79 for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 04:41:05 -0400 Received: by mail-wm1-f45.google.com with SMTP id i2-20020a05600c3542b02902058529ea07so9178492wmq.3 for <49329@debbugs.gnu.org>; Sun, 11 Jul 2021 01:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=wq+ReQvXtUbnQgZsq5YlXPtr7ZHLeJ69c51zhSGiZ+w=; b=qcEMRiasHu1vYH4xQQ+uOGhnLp9P2oKWPkZaedl6NcZ8u1914YPrX40MxxhovIhDVe sPkkw0gtkAKZyNKEnWa82MmFmia+XC9W3QZA2wyEtxQsWlxg23XEtCYlfQ+IVZj3Notn HjzGwLem5snO9t6u24RZvTqrq88pGQ5jnATKtXjERVuKtXo0teiMblRKXVH/Hr4fC35o MuP3u67p1AHDgfOlNdMQwsOFYgmDvtK1L8A9ENKYNGFVjttlGkxz22SpB/Mp9JYvSl7W v+7Vbn0mDQ5vJWvtSweS3utRgG846oujgToKgGATc9vRKAjFK9WkpLnK9ebP2amCN7tk fAwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=wq+ReQvXtUbnQgZsq5YlXPtr7ZHLeJ69c51zhSGiZ+w=; b=B6Ej6vHegsIGSGBJO+hlU58doV0BrBKiX1IzW7RvFCKt/P2kEOoSgDJhD+NBGajpvT 7xOmJH0wGbZXIwnUpx5qB5LXefeh75JefRPciJUfWJVgDQhrpqSHnvHNlammZ0tGTEBm y7ycWj2Bf/wcqs//ks4jsM0h3blbSbDA+S6FtX992IkMvK1DmC+3KH2smLFIfTRNQn9G K+9XdKBdgF8aGSeCCSKop6v8KL5hOs2dlFZhF1K7wsDfxSjP38E9HnaY+vMMtgMcklm5 XmQBL7+0KpLViCwPije3zy2mqT+YI64wh8kvcve+b+p0wLra+m8Ryq9IGE9SbEO3Hetu pr6Q== X-Gm-Message-State: AOAM532AybB0F8zT5EPZJsZabv83k1iwqpJhWZONXe2bRIbfXD0MHPoA XF7ebu9fAUzEjI3d0crSvj1dgZb2B+o= X-Google-Smtp-Source: ABdhPJwgLEinwKdTHrGeRfkuTxQG3+V/LTkKJbT/FBZGjGT9lmfDUiw81aEG++UTk0Btxz21kFR9/w== X-Received: by 2002:a7b:c4d3:: with SMTP id g19mr7159721wmk.78.1625992859065; Sun, 11 Jul 2021 01:40:59 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id g3sm10889205wrv.64.2021.07.11.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 01:40:58 -0700 (PDT) From: zimoun To: Leo Prikler , 49329@debbugs.gnu.org Subject: Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources. In-Reply-To: <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> <8635sval9h.fsf@gmail.com> <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> Date: Sun, 11 Jul 2021 10:28:05 +0200 Message-ID: <86r1g5i7ai.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, On Sat, 03 Jul 2021 at 10:35, Leo Prikler w= rote: > I must admit, I haven't been following the Python 2 removal plan too > closely. Is it already time to move working leaf packages? The Python EOL is January, 1rst 2020 [1]. So now, we are 1.5 years ahead, so yes it seems already time to cook a plan. :-) However, there is no consensus about such plan. ;-) Some related discussions: 2018-12: 2019-10: 2019-11: Failed attempt to cook s= omething 2021-01: >From my understanding, the =E2=80=9Cimplemented=E2=80=9D plan is described = by Maxim here: I just want to point that it is less work to transfer a functional and supported by upstream package than to transfer a package starting to have issues. Other said, I think it is easier to find motivation to do the transfer for this previous case than to do some =E2=80=9Cjanitor=E2=80= =9D work later. For what my opinion is worth. :-) About Ren=E2=80=99Py 7, I do not have an opinion. Yeah, waiting Ren=E2=80= =99Py 8 seems The Right Thing=E2=84=A2 to do. :-) Hope that helps, simon 1: From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 11 05:53:09 2021 Received: (at 49329) by debbugs.gnu.org; 11 Jul 2021 09:53:09 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2W97-0001vo-GM for submit@debbugs.gnu.org; Sun, 11 Jul 2021 05:53:09 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:19241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2W94-0001vd-Er for 49329@debbugs.gnu.org; Sun, 11 Jul 2021 05:53:07 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GN2JZ661vz3wNG; Sun, 11 Jul 2021 11:53:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1625997183; bh=yO0Fg/n6wjOfLWsbNWfVwAvVqK+IwcHfbovZQDz+QdY=; h=Subject:From:To:Date:In-Reply-To:References; b=fO991/7izYzS8sULgGWUUfcEeY2fV0rFQ8jBUYXkxGMdpZl0QxSjZHHCP3VFHsP3c heZpZ1HxkNZKmnEn7Qe98Q2Gr5uu/EBN1vyp5DzIuSQ3l++/YYdFPce2P8xZ0IzrGg wXtyXbjsYXL2rAP/5mC6blLk4VsLe8VoQd9pjAOM= Message-ID: <794829194e7b95660ac164920bc62f68e14a0508.camel@student.tugraz.at> Subject: Re: [bug#49329] [PATCH 1/4] gnu: python2-renpy: Drop unused Ren'py sources. From: Leo Prikler To: zimoun , 49329@debbugs.gnu.org Date: Sun, 11 Jul 2021 11:53:02 +0200 In-Reply-To: <86r1g5i7ai.fsf@gmail.com> References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> <8635sval9h.fsf@gmail.com> <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> <86r1g5i7ai.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi simon, Am Sonntag, den 11.07.2021, 10:28 +0200 schrieb zimoun: > Hi Leo, > > On Sat, 03 Jul 2021 at 10:35, Leo Prikler < > leo.prikler@student.tugraz.at> wrote: > > > I must admit, I haven't been following the Python 2 removal plan > > too > > closely. Is it already time to move working leaf packages? > > The Python EOL is January, 1rst 2020 [1]. So now, we are 1.5 years > ahead, so yes it seems already time to cook a plan. :-) > > However, there is no consensus about such plan. ;-) Some related > discussions: I know, but to be fair, we aren't the only ones behind on the Python removal. Python 2 is very much a zombie at this point, still kept alive by other (mostly dead, but some live) projects that people rely on for various reasons. > 2018-12: > 2019-10: < > https://yhetil.org/guix/CAJ3okZ33HsXxgVgK3XyVHvYUfDUrbcwBnOn7FC6=3AG_YvAUbQ@mail.gmail.com/ > > > 2019-11: Failed attempt to > cook something > 2021-01: > > From my understanding, the “implemented” plan is described by Maxim > here: > > Using this plan as a starting point, I think renpy counts as a non- variant package relying on some python2-variant. > I just want to point that it is less work to transfer a functional > and > supported by upstream package than to transfer a package starting to > have issues. Other said, I think it is easier to find motivation to > do > the transfer for this previous case than to do some “janitor” work > later. For what my opinion is worth. :-) Fair enough, I could open up a merge request to have renpy in Guix Past "ahead of time", but OTOH I feel like `guix time-machine` offers similar benefits. If we're going to *mirror* python packages, because they will soon be broken, I think it would also be a good idea to start from python2 instead of leaf packages. Regards, Leo From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 02:47:48 2021 Received: (at 49329) by debbugs.gnu.org; 15 Jul 2021 06:47:48 +0000 Received: from localhost ([127.0.0.1]:46566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3v9v-0003Pl-Np for submit@debbugs.gnu.org; Thu, 15 Jul 2021 02:47:47 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:41678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3v9t-0003Ku-Kz for 49329@debbugs.gnu.org; Thu, 15 Jul 2021 02:47:46 -0400 Received: by mail-pg1-f181.google.com with SMTP id s18so5014647pgg.8 for <49329@debbugs.gnu.org>; Wed, 14 Jul 2021 23:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6onRWH8f9yyKbJDAyHgB6QYS3lnAg1LMURu/Jd5M18I=; b=d6n2RdfiPNIkOzQdjh1Y1zQsG9/1uK1f3Xv27qMfnN7SuyYJvScyixrk5snqlhx3pG NvaF914ILbP/JRBLzrW34yrt3+GlwihU/U+NKXKMFu6XnMBFLLwU+AsESFO/VoUYQoN1 TnaF9YldFldN0s6jCgKirHFLHajK5pPw74Dcpo9SDaRO+z3/eN64KAD4ewO+LYDRfR6e oDsQ0RIKeY7FQ7T81NDou+izVlc6t4oKffuqA1mYEZdaUoUE8clcrwIZg2f4wH4vqRSR CnkqZhHyttOEUAQygzL8dsSkfKD4S0IFoLB4s0KygamLo5+XguTUCg/iYDlIDc8n53nn J6kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6onRWH8f9yyKbJDAyHgB6QYS3lnAg1LMURu/Jd5M18I=; b=pC+2nnf8JDdjYwGOLCnGu9Bgacr+9BbR0XJTz5DM/PLxcofRJahmthA9NP7GcqnU+C 3PnJ1ZADvrT86g9Lz2oRTFEq4bIQUBgt0dVkCWnbNAqFEfXz9BF/eCbfeOsAf2/fid+c DBZRReWJ3lGRnad6z4c0o+QILqDHmjulzhUglMNxuaWcaxmnmvlQdmr//qo19CSaDGJK xViswg+puwlx6wpfM+Gm0fwXabp+4hTm2E/+jK9g8+SOnzNm96eHlN/h2eKMyOeHrHK0 Pu+JBJ5D/sPwcC6YXkgYDKBdnN8u39jE/ZJ0ZQj2Iz3HeIKVOisMSNsHtqYf/5TNIeND +0cQ== X-Gm-Message-State: AOAM532J0GGZJlOxzY3MK0UFFVqTmy5iaeSVIeX6zQYDTQHhSIZqXZ7B v9kMfMTa3xtAL/n0mLa/dJq6xemPNbBY7A== X-Google-Smtp-Source: ABdhPJxBQ0wDwFR+D54tR04ett8FXfWb71eYdHZ5yo1WB29JXr+gW8rB18Hhig4LQY+Dp3PXmO6jcg== X-Received: by 2002:a05:6a00:1515:b029:329:932b:9484 with SMTP id q21-20020a056a001515b0290329932b9484mr2929951pfu.13.1626331659052; Wed, 14 Jul 2021 23:47:39 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b00d]) by smtp.gmail.com with ESMTPSA id s20sm8547678pjn.23.2021.07.14.23.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 23:47:36 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210702135818.16084-1-leo.prikler@student.tugraz.at> <8635sval9h.fsf@gmail.com> <68f5b3c4ac813caef41da4062179eb2d07ae2575.camel@student.tugraz.at> <86r1g5i7ai.fsf@gmail.com> <794829194e7b95660ac164920bc62f68e14a0508.camel@student.tugraz.at> Date: Wed, 14 Jul 2021 23:47:32 -0700 In-Reply-To: <794829194e7b95660ac164920bc62f68e14a0508.camel@student.tugraz.at> (Leo Prikler's message of "Sun, 11 Jul 2021 11:53:02 +0200") Message-ID: <87h7gwysxn.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Leo Prikler writes: >> From my understanding, the =E2=80=9Cimplemented=E2=80=9D plan is describ= ed by Maxim >> here: >>=20 >> > Using this plan as a starting point, I think renpy counts as a non- > variant package relying on some python2-variant. > >> I just want to point that it is less work to transfer a functional >> and >> supported by upstream package than to transfer a package starting to >> have issues. Other said, I think it is easier to find motivation to >> do >> the transfer for this previous case than to do some =E2=80=9Cjanitor=E2= =80=9D work >> later. For what my opinion is worth. :-) > Fair enough, I could open up a merge request to have renpy in Guix Past > "ahead of time", but OTOH I feel like `guix time-machine` offers > similar benefits. If we're going to *mirror* python packages, because > they will soon be broken, I think it would also be a good idea to start > from python2 instead of leaf packages. I feel like keeping it all in Guix proper but vaguely "moving things toward Python 3 wherever possible" is the best approach for now. An approach like the one Maxim suggested in the above link sounds good. Moving Ren'Py to Guix-Past would be fine, I guess, but I have to admit it feels a little strange. After all, Ren'Py is neither stale nor unmaintained. However, some of its dependencies are (like Python 2), and their plan for upgrading to Python 3 sounds like it will take years. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv2gQVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadtMwQAI0zEp0oIlaHHD/t2Jl4lFTnjfG1 5eDhP77DI+Jx6S1Eza4H5E2A2dmYnkdEIvCV8Ar+YDb26qUn/OOCZrKZRnxQjIQN YD4XgkCVpXx6S4ABPhVYYxSDjAExCfCIgn45Gs0gI+4bwzOV0meAatejc1dOPZ/P PR8c9Y1rHTwfO//sfU2TuZ/Vo5VcLMWAvX2qx3kgtLLGVCQ8OLM2VUMQmzBPO2vW 5VKXeA8+gp9sNYETFVjbML8mOU6XMhiHos7FvJwtmopSRVpsoiyPI7NtbZNp80SL gZEkdubNcb4sRPX+4qeRyniXyC9CUTglGBqapqDsKIFcLmwCTFqCi2KMzllDrV15 1T5JMrMmciopLpKcoUFAYyqz72SzLUBX6SNNjB6GdIClbEbX2nuXHN37OhQF32jk tA1/L8uCC5ukRHbkDXsb35I2ChNpc2Xv2+5eqV0+kTSngSpt6pvr0IYKilC5zvho ceLfOUXRTG7+qw3oPdXcXKXliVUocMLC2wROHdR6+0XcgEvaYNBHfAfexfyTY32g 6BoWv5jzAc/rlw5mf/fHxQaADhyJ828bu1MYVuL0O/VD9GHBRT0ilb4C5KwWsTBH yHD6jBMBwRsOUt0LX7C4E/h3DJ0pLmb9eYLzfWL9qoXhQWedZfOxFjn6nQIUqM1V H7M3t4myPFxl55qW =f0bT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 02:48:35 2021 Received: (at 49329) by debbugs.gnu.org; 15 Jul 2021 06:48:35 +0000 Received: from localhost ([127.0.0.1]:46570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vAh-0003Xb-2L for submit@debbugs.gnu.org; Thu, 15 Jul 2021 02:48:35 -0400 Received: from mail-pj1-f45.google.com ([209.85.216.45]:41558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vAf-0003XN-73 for 49329@debbugs.gnu.org; Thu, 15 Jul 2021 02:48:33 -0400 Received: by mail-pj1-f45.google.com with SMTP id jx7-20020a17090b46c7b02901757deaf2c8so3081150pjb.0 for <49329@debbugs.gnu.org>; Wed, 14 Jul 2021 23:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hDpTTM2Z4+jQvxhu156sjEqilDemPyu0mF3jcEfFIho=; b=Ii++uisLyMgWtP39RMZ6Zz39Wb3Urm1V27DnrTnmm5DTvtDcMKV6Vz1MU9Mx+2qI42 5C+cjZwCJnR3cxuYkGjkkll4XPfR8ZOZQltI/H5T97LRAZ80dYE2mVMi8qAt3q6aeAZR nDzGd/DdVxEcl2ZZcuPks9j4LeQlnZ73SloZCDwCnOrF7dS9/umG6QnI6ZiC51R+b2SN 6kxzVlGngwYkIi2H1BdSeh1A7PzhdFp4a/fOXUg2j8uxmXsBefritoUwt6Ime3GT4w1j +jTViU9Z9rWdYvaUY4/aVeHSORNe4fLEA+x7C9ZzD9vUmVJRLI+SbMolJ1ak8lQpk5gl qKXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hDpTTM2Z4+jQvxhu156sjEqilDemPyu0mF3jcEfFIho=; b=mM4HfGoe+AdkjlUCB2tNuaHnX9tAy2yGG5j0rK2QkSfGyly9sK6VodPPM/at+n6dod I17XaNu0p8sggof/0U91KyQCYw1CnhkIt51Ai7xXDMQZfZ0QoSrIavMKTeRUOKj4wzE6 uQccZoW+oT3HRq+7PSA4FujQ9BCAi3vaPtSdDUUYJGulkJ9qoLDqoeAkYxPxjihIwtNO rWNW6OW7vE6/KEFqWlyzdkv7S6LNQpijmv9V1VOtMMEMe4a4s6qXOQBOH2b74byibmYt DX5h3gQnQWLkBuwm4E8yN33nWkb2flemfLU34BHkM0RoZNc4rqmjjXItEVaA6pkELMo+ 7U8Q== X-Gm-Message-State: AOAM5330AUc0a5rfmBqxQmxr/6KyLNQfKK+o76PqNcAgguJjP5HtA4d1 XI/xZRPR/8nfFEXCbfPJFTHjrUTpnWVKrg== X-Google-Smtp-Source: ABdhPJx4zDlOaKFq6g9K+wFgAmW7Cc+UZ4SJf0CweerDw7d4u8M9dyDdfO70MqJ+n2pogjgYM1OUwQ== X-Received: by 2002:a17:90b:4754:: with SMTP id ka20mr2681802pjb.29.1626331706893; Wed, 14 Jul 2021 23:48:26 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b00d]) by smtp.gmail.com with ESMTPSA id d1sm4151494pju.16.2021.07.14.23.48.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 23:48:26 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-2-leo.prikler@student.tugraz.at> <87mtqt4fjf.fsf_-_@gmail.com> Date: Wed, 14 Jul 2021 23:48:25 -0700 In-Reply-To: (Leo Prikler's message of "Sun, 11 Jul 2021 09:09:50 +0200") Message-ID: <87czrkysw6.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich: >> Leo Prikler writes: >>=20 >> > * gnu/packages/game-development.scm (python2-renpy)[description]: >> > Mention, >> > that it's only used for bootstrapping renpy. >> > --- >> > gnu/packages/game-development.scm | 6 ++++-- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> >=20 >> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- >> > development.scm >> > index 22c44a585c..9b231ad333 100644 >> > --- a/gnu/packages/game-development.scm >> > +++ b/gnu/packages/game-development.scm >> > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") >> > ("xdg-utils" ,xdg-utils))) >> > (home-page "https://www.renpy.org/") >> > (synopsis "Ren'py python module") >> > - (description "This package contains the shared libraries and >> > Python >> > -modules of Ren'py.") >> > + (description "This package contains the shared libraries and >> > Python modules >> > +of Ren'py. While functional, they are not meaningful on their own >> > without >> > +the launcher and common Ren'py code provided by the @code{renpy} >> > package and >> > +are only used to bootstrap it.") >> > (license license:expat))) >> >=20=20 >> > (define-public renpy >>=20 >> LGTM. If this isn't meant to be installed by users, should it be >> non-public or perhaps hidden? > Good point, but I don't think users will accidentally install it like > they do with gcc. This description was written to address a point made > by Ludovic in IRC concerning the package's lack of one. Having the > package publicly exported also makes my own life easier when updating > the recipe. Last, but not least, these are functional modules and > could be used to develop code, that depends on Ren'py's internals, but > none of the "common" renpy stuff (or the common renpy stuff could > otherwise be extracted from the renpy package and changed to the > developer's desires). OK. I'm fine with that, then. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv2jkVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadVywP/iQEzsCmMrvu/B4xlzCFnjOHi9lw n3bsl/jFaVkE5uTRBuTdhXPuxPuwV3wPVbkPF8Qm9d/0MMXSSm/chR0WXsRBEA3G Tbno8VH6fSs8mYhD0+1TG4B0xAiXHCnmANbrN4wZelO0HpKZArNm0mwbJMXR95/e m/KTlFtJQRXkKJiXy5tGfdaRhrLIRyZneuOi/vJRMTORIxLfZeQuBGkQCucJw9lc 1zT/TXiBqkK7XS+P7kD4fBUWkL82cwGq0GNKp3xxfEuz3CdCo4KuRQlbSwtRViKr yU/mY8BeP7tLLBzfwsqc/tj8dHZ7d7TIY/lkK/5+fPhE0hOwUZ4IpYsKbY/ujaqC jB1Lf3LFsfjh0WE6Rh5zEdQhIFQvg7vRcxdvJoS5RyFBtCNu7oWH4AKiOg3/EPok 6BVarsKTxH5FmAzRayZHNbd5bVKnYPBfI4GvqqrRRdHT2etn5Y89je9VAW/DD3Qt DlDTBj7cpkrRyPDfxMGNwPmOaIT8CVkGdEFLgM6kx91gZ+IJoBqSRgxfUxRaaCc1 RUMshO2KDw/HTz0keJBRZUjPFDkdW2FCjatPLhN5Z6iY5hoEiKGZeXiba/am9Rk7 MV/+s/NP/S4WzCKRctGwaizvWU5FQX8qLdueWaWQB3bT3jJPlUuCmoBvpzcV3oCu 2WA3zEV+MKnoLuFX =MStQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 03:21:35 2021 Received: (at 49329) by debbugs.gnu.org; 15 Jul 2021 07:21:35 +0000 Received: from localhost ([127.0.0.1]:46618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vgd-0006aL-Bb for submit@debbugs.gnu.org; Thu, 15 Jul 2021 03:21:35 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:35358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vgb-0006a8-OG for 49329@debbugs.gnu.org; Thu, 15 Jul 2021 03:21:34 -0400 Received: by mail-pf1-f182.google.com with SMTP id d12so4316614pfj.2 for <49329@debbugs.gnu.org>; Thu, 15 Jul 2021 00:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=H/Zyka4NdTauPH3eq5yK8iyRzppcXLeznW5MlrLNyI4=; b=TpjroWS07N/L5caVjEzdwTrMQZoPCm98CosIbGIOtinHYFtsUR/PmpBbEIX2cQAiNT ddBHQpeXCuX+yQ6XRZN8bMCNqcCnbMxg1yA9qhoRMKROXzW2U3AKVzjD/pMdRKvkJp4t ftpP/l9SXtiZRPpbU34SZqIM+Dd87KE7tj0bvJCNB1mZZun/KZLLSDANdFYql36EN2u2 dllAxBGbN3eT1l60OR1W8PKV9saYyGxIOrXkSMntQ2z9xKYb8q2c9eHC5+e7o61KRA7D cgbQtPBjU3Wl5+6SgiJrJP+3lSiQmGIPMSYfhBa9EuMGskqitETiaIF7KT76d7nvZzE5 cuKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=H/Zyka4NdTauPH3eq5yK8iyRzppcXLeznW5MlrLNyI4=; b=cQqXd3Y9wT+rooAV50LLLmSK6zDaNjHBpGSD43S2rW/ZoIX1zz4F8xspEIgFySeyWQ vq4R+a3sg1twLA9QXXr56H5JfiB+VyVp182LRg9Pja6luw9WC/IYwHxlV9apAWnRGIPi wboUXJuEB9pCXLU30wUPExXNsyNbWdG3/y36r164O3VHmQgrX8OQbfoTetSeC3ARAL88 nZdMb2rB/79S3gWUiYNhzmbaULgFHaVsW1h5AuQaVJPxe9GuaV/iF206HzXnQpHebXHI ADFfDCR8Qv6H8GbQF/HYr9xFcpmpQTAmFZO7fIdZkt3BDPOqbddiiQQVWm2spAdsYocR /P+A== X-Gm-Message-State: AOAM531+GUYpOpzKKnwdUuWgY5oz58v3BGhNePNS/wHx06K37JNjeHSl eLxDRT/X87V6SK1Z6avMeRUd+UJyNSVP2g== X-Google-Smtp-Source: ABdhPJwNmfU+QHyGcKnYlDgMdugzlZwu2iBi8hwXFDY2Ne11wNohlL27GwMliota3kVxi6T4Oa1zgw== X-Received: by 2002:a63:ef4c:: with SMTP id c12mr3093025pgk.441.1626333687306; Thu, 15 Jul 2021 00:21:27 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b00d]) by smtp.gmail.com with ESMTPSA id q24sm5880799pgk.32.2021.07.15.00.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 00:21:26 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-5-leo.prikler@student.tugraz.at> <87y2ad4fyq.fsf_-_@gmail.com> Date: Thu, 15 Jul 2021 00:21:19 -0700 In-Reply-To: (Leo Prikler's message of "Sun, 11 Jul 2021 09:00:46 +0200") Message-ID: <875yxcxcsw.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich: >> Leo Prikler writes: >>=20 >> > * gnu/packages/game-development.scm (python-pygame-sdl2): New >> > variable. >> > Inherit package definition from previous python2-pygame-sdl2, with >> > the >> > following additions: >>=20 >> Actually, it inherits from python-pygame, right? > "Inherit" as in "use the code that was originally written for python2- > pygame-sdl2". Did the inherit field change with this patch? If so, I > should reflect it in the commit message. I see now what you mean. It's fine. Personally, I think the word "re-use" would have been clearer, since it is not possible to confuse it with the "inherit" feature of package records. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv4e8VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadpQ0P/2xDhdxsXZ6/VnWj2ahJR0f57alp EjiVqCD2NjrqXTFrnsjwAgE0ghsJbMndAvbUxIkuCLTeNxkGXTebf91gSJQXOVB1 BZZSurVFiCt35aFRSGaKzLl60Rv/p51KTrQyrSEEicRklXHlAETFNGfyO70pNe9R DgEqpqElTZ6CybqalwR1Dct3HFQ7gMtFS769z8hZO56YS68Ah2hGT0LraIP0Lof3 KXpld72akVHGbVe4OkVhm0pYq5ZNmuFCv5xAgT2J97GgpyTwuJ67tTYf/8X6ggti PGGqmjxkKLK3nd/iil12lRl1+0XOJacKlF/+Q9XI+5hzk4zQExRtrNKFUJ8xZqWZ FS+NG+uroyk+1KFVe8NT8xTm/d87PU8JWtktwpaFYGCmtceU9xeuO/IT7CyAIoO6 gkh1fLX1H34gvIvkRQxbkb1HjLUPLcAN44fFAykw9kAg95x+RcGSfFb0uDfZmOjp e6t49fAdRihWoYpVpKH/uZIoxPkEp4HZ5ukf6ETs/F2xRV5emImqV/TTT6zoUmiZ HpsIisCawaT+Wqr2+u9yGlHzcrZP8wl/P+qm9jLfwVmtXvgeVHBURf/obcCtNR6a szK4fSguAq6OawQ57ZkGqgde/St55PFXqzW5DOH6wzPdzybFWXPuY8ZgglvTdqyB pYPYMzkl4c4FLNGk =Osuz -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 03:22:53 2021 Received: (at 49329) by debbugs.gnu.org; 15 Jul 2021 07:22:53 +0000 Received: from localhost ([127.0.0.1]:46625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vhs-0006cX-Rx for submit@debbugs.gnu.org; Thu, 15 Jul 2021 03:22:53 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:42621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3vhq-0006cI-NC for 49329@debbugs.gnu.org; Thu, 15 Jul 2021 03:22:51 -0400 Received: by mail-pj1-f50.google.com with SMTP id i16-20020a17090acf90b02901736d9d2218so3413819pju.1 for <49329@debbugs.gnu.org>; Thu, 15 Jul 2021 00:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=E8s/IZ/66KhdyywmoLeusg88kWY2vswyIo8riGX3S0g=; b=bAce4c5F4dhIdIQFEwepPH5nlAqy3GL2rrZuNrpsmoLR4DY4QapmLJlloHh1ozpQBh hl4aNKyeMo9FR0tYgvSPccelVFItg0UmbFPthOphP9NzpdhJu/PLOIsGch4+3fGa/gba Vpwmjfsyw1LlDtBxWzJ0C4Ui0dYkWFDN1Lf/7dHw9Ca6J8/dKCfMxZPQr6BV0hTmo4SH ej5PYL1yae8oXlcShkipYFKp5wU+iy6eSdWbr7hnaFqsCnsTI5D/e4Agq2j9xYakyb98 pVzwLFfiOrLd4S7Fe7mcDqgmhJAcSohZFUYmD118DAKg6Z2wxeS4A30G8Lku2E3A8bDA 0ONg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=E8s/IZ/66KhdyywmoLeusg88kWY2vswyIo8riGX3S0g=; b=tdC9d73vyeNUN8cki0Naim3KMUDTMBl0AtdWSkBmBU7KdmWY8gR/G7G5hn7uJKnvVb yi74ne3KS+M1kuLCSi8oeUHQPfsODV2lmNfrbR8Gt2uQc1zxzGTyZNb7JPyKEgKE8aFo M3YpBkqFZF+GPkFPb8c662quBwoymWzXzZifUkP1geAM4/xCSgWIkIvEgf/hrlIh/t2g aK507A2JTQSf9nIpORMD4pWMdpgdyxRuRCZMz9DoVwsyc3DHNyGxRKSwp6IvQdoN3aDj akQ4sL1FElnrDhkeuCswgYqc+sRya9yv4AAiD0H5czVMDbyYRRI5oNYkw71U67/61CLB a34Q== X-Gm-Message-State: AOAM532ww7hUM8peSHSBXoMcgNQX/SWU4fN70sWKhTGByCUyfo+TKOEh IqzAquGfZKKY9OWGvpsO7zhWu9prShHyTQ== X-Google-Smtp-Source: ABdhPJxIfKUL7RB+hxkariYwxHsuefSwJKVYOTZHiyOuSvfTHlWWsg4qZyBbAgDqGxTKwjeqk1cinA== X-Received: by 2002:a17:902:b90a:b029:12b:3338:1870 with SMTP id bf10-20020a170902b90ab029012b33381870mr2263728plb.73.1626333764560; Thu, 15 Jul 2021 00:22:44 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b00d]) by smtp.gmail.com with ESMTPSA id hk18sm7785106pjb.41.2021.07.15.00.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 00:22:43 -0700 (PDT) From: Chris Marusich To: Leo Prikler Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <87r1g54fla.fsf_-_@gmail.com> Date: Thu, 15 Jul 2021 00:22:42 -0700 In-Reply-To: (Leo Prikler's message of "Sun, 11 Jul 2021 09:03:11 +0200") Message-ID: <8735sgxcql.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49329 Cc: 49329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Prikler writes: > Am Samstag, den 10.07.2021, 21:52 -0700 schrieb Chris Marusich: >> Leo Prikler writes: >>=20 >> > These sources are written in Ren'py (the language) and thus not >> > particularly >> > useful before renpy itself is built. In particular, they serve no >> > purpose >> > when installed without prior compilation. >>=20 >> Could we pre-compile those sources on installation, instead of >> deleting >> the common directory? I haven't used Ren'Py much (or at all in >> Guix), >> so I don't really understand the purpose of the common directory. I >> could just be missing some context/info. >>=20 >> Other than that, this patch seems OK as far as I can tell. > You need Ren'py (as in the package you're currently compiling) to > compile these sources. These sources will get compiled just fine in > the renpy package given that we already have python2-renpy available by > then, so they are shipped as part of that instead of this package. OK, I think I understand. This seems fine. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmDv4kIVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadpHAP/2uLdOg43jOwyzcb1vCglW+JaK+g gilegCueN0kiikfyD/jN8Sne7+s+BGyM0sQxltiXnaPPRKMQoWbliTdu2xl6HXWo q+VCtlSQu1ZOuMIZkO2n2hq21utDgn05xuT/937ntmr5I6PfRHBvqNmysLWnaPAO Zh8rOSRfHXGjVX3pmd7/GhF9wXkUbFj0zPA/4RMXoeGsY9ncak6YM1sqaXp/nSFy 1jEKJmsKiUpBmpyWJJ9jG+iQZlQ+mbaIziiCXRiCy37rJ+ERVr06al+xgYfnt502 PCvtM83skwZaFWoy76Zi7Kw5hfxjHRlBfvUC16+8EOhUAc+slAMLhKCt0NT3xwok xm2LuzOubedYE1p2BKGk+3MU+guDGPlk/VsD1Hf9Bmd5At8QIL/Xtxo5aR7aEcr2 C80XAlH5NLGpYgz/YeM3PKmZ0h/TPRkM+URlFUta2D60EyYSnC2ACSHvIkbMg7YN nvkZ5PAlSkCVf+Ilk5LBgjG5IXmLVwDJP/FfteG5Z6SAAOQGt/QEwoE//r/ycNYE JdSE4cBSae2vwqyhtraCKI1iV5r77XVOLTWxr6SNq+dXTEd2WO71EMj31aQmQJac O/+wS8h9OkPjAdFs0+AeLdglx3TkYkaJMfSEubBUkQ8aAR/Iul6cU62CFigD0JoX RWZbBSZ+YnRkdVMC =cw3l -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 15 07:46:38 2021 Received: (at 49329-done) by debbugs.gnu.org; 15 Jul 2021 11:46:38 +0000 Received: from localhost ([127.0.0.1]:46947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3zp7-0005Jk-Rv for submit@debbugs.gnu.org; Thu, 15 Jul 2021 07:46:38 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:15256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3zp5-0005Jb-UH for 49329-done@debbugs.gnu.org; Thu, 15 Jul 2021 07:46:36 -0400 Received: from [10.0.0.4] (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GQXdk0y26z3x8h; Thu, 15 Jul 2021 13:46:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626349594; bh=pWH0zCNMxSbVXZYLEdaZ/7LL1U3nUhCkMaGL3Vv87f0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=eCA1b9OwjdvHjELjYcBuT8W8OU2W/w0EztXE+ABersZ25IBDOHv4VquUlwzo7dbfS WJ8SzOKBMziYjfV43635X2BwF4V3Q0YttBgEK1igP34LSRnjImi1v0v6Cw8ReeyEAi M99k6jKUUGBO4Kgvm4mf9V7dyC4oYJx01kX2PYxY= Message-ID: <26e29ba3e5a2514d340eab8d49dcb838c4f8224c.camel@student.tugraz.at> Subject: Re: bug#49329: [PATCH 00/??] Improve Ren'py package From: Leo Prikler To: Chris Marusich Date: Thu, 15 Jul 2021 13:46:13 +0200 In-Reply-To: <875yxcxcsw.fsf_-_@gmail.com> References: <20210703092842.32189-1-leo.prikler@student.tugraz.at> <20210703092842.32189-5-leo.prikler@student.tugraz.at> <87y2ad4fyq.fsf_-_@gmail.com> <875yxcxcsw.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49329-done Cc: 49329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Donnerstag, den 15.07.2021, 00:21 -0700 schrieb Chris Marusich: > Leo Prikler writes: > > > Am Samstag, den 10.07.2021, 21:44 -0700 schrieb Chris Marusich: > > > Leo Prikler writes: > > > > > > > * gnu/packages/game-development.scm (python-pygame-sdl2): New > > > > variable. > > > > Inherit package definition from previous python2-pygame-sdl2, > > > > with > > > > the > > > > following additions: > > > > > > Actually, it inherits from python-pygame, right? > > "Inherit" as in "use the code that was originally written for > > python2- > > pygame-sdl2". Did the inherit field change with this patch? If > > so, I > > should reflect it in the commit message. > > I see now what you mean. It's fine. > > Personally, I think the word "re-use" would have been clearer, since > it > is not possible to confuse it with the "inherit" feature of package > records. I've changed the commit message to say "reuse" and pushed this now. Thanks! From unknown Sat Sep 20 16:32:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 13 Aug 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator