Subject: Re: bug#49327: [PATCH core-updates 000/128] Add 'bash' input for 'wrap-program'.

From: Ludovic Courtès <[email-masked]>
Date: Thu, 08 Jul 2021 15:35:36 +0200

Hi!

Maxime Devos <[email-masked]> skribis:

> * gnu/packages/package-management.scm
>   (guix-build-coordinator)[arguments]<#:phases>{wrap-executable}:
>   Set #:sh argument of 'wrap-program'. Don't substitute the interpreter
>   with another interpreter. Drop the 'target' argument.
>   (guix-build-coordinator)[inputs]{bash}: Make this input unconditional.

[...]

> +                      (bash (assoc-ref inputs "bash"))
>                        (version (target-guile-effective-version))
>                        (scm (string-append out "/share/guile/site/" version))
>                        (go  (string-append out "/lib/guile/" version "/site-ccache")))
> @@ -1079,7 +1081,7 @@ environments.")
>                                           ,@(if (hurd-target?)
>                                                 '()
>                                                 '("guile-fibers")))))
> -                      (wrap-program file
> +                      (wrap-program file #:sh (string-append bash "/bin/bash")

I think we should write:

  (search-input-file inputs "/bin/bash")

in such cases from now on, rather than (assoc-ref inputs …) & co.

Ludo’.