GNU bug report logs - #49315
[PATCH]: Lint usages of 'wrap-program' without a "bash" input.

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Thu, 1 Jul 2021 11:41:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #22 received at 49315-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49315-done <at> debbugs.gnu.org
Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a
 "bash" input.
Date: Wed, 07 Jul 2021 11:12:33 +0200

Hey,

> That usage should ideally be detected by 'wrap-program'.  But as no
> current package definition seems to do such a thing, and using
> 'find-procedure-body' seems marginally ‘cleaner’ to me (YMMV?),
> I would use 'find-procedure-body' anyways.

OK, seems fair. I just edited the first patch to use "last" that has the
benefit of hiding a "car" call and wrapped a long line.

Pushed on master.

Thanks,

Mathieu
This bug report was last modified 3 years and 321 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.