GNU bug report logs - #49315
[PATCH]: Lint usages of 'wrap-program' without a "bash" input.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49315: closed ([PATCH]: Lint usages of 'wrap-program' without
 a "bash" input.)
Date: Wed, 07 Jul 2021 09:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 07 Jul 2021 11:12:33 +0200
with message-id <87sg0q4hdq.fsf <at> gnu.org>
and subject line Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input.
has caused the debbugs.gnu.org bug report #49315,
regarding [PATCH]: Lint usages of 'wrap-program' without a "bash" input.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49315: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49315
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH]: Lint usages of 'wrap-program' without a "bash" input.
Date: Thu, 01 Jul 2021 13:39:53 +0200

[Message part 3 (text/plain, inline)]

Hi Guix,

These two patches add a 'wrapper-inputs' linter.
It detects if "wrap-program" is used without adding
"bash" or "bash-minimal" to 'inputs'. Adding "bash"
or "bash-minimal" is necessary when cross-compiling,
otherwise the resulting wrapper will use an interpreter
for the wrong architecture.

This linter detects 365 problematic packages.

Greetings,
Maxime.

[0001-lint-Define-some-procedures-for-analysing-code-in-ph.patch (text/x-patch, attachment)]

[0002-lint-Lint-usages-of-wrap-program-without-a-bash-inpu.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49315-done <at> debbugs.gnu.org
Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a
 "bash" input.
Date: Wed, 07 Jul 2021 11:12:33 +0200

Hey,

> That usage should ideally be detected by 'wrap-program'.  But as no
> current package definition seems to do such a thing, and using
> 'find-procedure-body' seems marginally ‘cleaner’ to me (YMMV?),
> I would use 'find-procedure-body' anyways.

OK, seems fair. I just edited the first patch to use "last" that has the
benefit of hiding a "car" call and wrapped a long line.

Pushed on master.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.