From unknown Fri Jun 20 19:58:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49315 <49315@debbugs.gnu.org> To: bug#49315 <49315@debbugs.gnu.org> Subject: Status: [PATCH]: Lint usages of 'wrap-program' without a "bash" input. Reply-To: bug#49315 <49315@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:58:26 +0000 retitle 49315 [PATCH]: Lint usages of 'wrap-program' without a "bash" input. reassign 49315 guix-patches submitter 49315 Maxime Devos severity 49315 normal tag 49315 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 01 07:40:25 2021 Received: (at submit) by debbugs.gnu.org; 1 Jul 2021 11:40:25 +0000 Received: from localhost ([127.0.0.1]:59693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyv3L-0000Vd-Ol for submit@debbugs.gnu.org; Thu, 01 Jul 2021 07:40:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:45760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyv3J-0000VV-JC for submit@debbugs.gnu.org; Thu, 01 Jul 2021 07:40:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyv3I-0003wB-Rn for guix-patches@gnu.org; Thu, 01 Jul 2021 07:40:17 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:57406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyv3A-0006zR-Ik for guix-patches@gnu.org; Thu, 01 Jul 2021 07:40:16 -0400 Received: from butterfly.local ([188.189.253.4]) by laurent.telenet-ops.be with bizsmtp id Png22500b06Tga401ng3Fp; Thu, 01 Jul 2021 13:40:03 +0200 Message-ID: Subject: [PATCH]: Lint usages of 'wrap-program' without a "bash" input. From: Maxime Devos To: guix-patches@gnu.org Date: Thu, 01 Jul 2021 13:39:53 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-0KuMRWfMRiElRL39JaGn" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625139603; bh=ZNoqbkj7X09l/JuuJpsU3CLGHwcP7gCrEBArQDs89ik=; h=Subject:From:To:Date; b=O2WSoP3PKMOudZMnpV1EqF5ZstKlqX3tqXoQNqzOQgU6Un5qzrllujnXaKd2x7Y6L mWftYKG8reEj6f62aN7P9OW7KD4sm3diSSWesg6aX8ax4+D9/CxIoS0xXM0FL3cXNq sd5aFZV2NbhZoFKbOIo6iOeB3JRU/K490EiJ0fl7nG+JVtDaiU0Rt5ibNSE8flENs1 dmIPjPxo5xquxW4RcV2zSYlo8lRDy12DyCvBYKZNd6BqlWqEE2jGp/8ZHrDBhGAJDv 4vQWcUCkoRzVtFXV/RPydyc8d6XctDiL/NmUi5E1QLC/4d/Tkp0pPRaco8jyM4So6G atJq4Dt6UAxaw== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Guix, These two patches add a 'wrapper-inputs' linter. It detects if "wrap-program" is used without adding "bash" or "bash-minimal" to 'inputs'. Adding "bash" or "bash-minimal" is necessary when cross-compi [...] Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 1.7 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Guix, These two patches add a 'wrapper-inputs' linter. It detects if "wrap-program" is used without adding "bash" or "bash-minimal" to 'inputs'. Adding "bash" or "bash-minimal" is necessary when cross-compi [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maximedevos[at]telenet.be) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-0KuMRWfMRiElRL39JaGn Content-Type: multipart/mixed; boundary="=-IVmCbr6hBVBHLJTFtHUQ" --=-IVmCbr6hBVBHLJTFtHUQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Guix, These two patches add a 'wrapper-inputs' linter. It detects if "wrap-program" is used without adding "bash" or "bash-minimal" to 'inputs'. Adding "bash" or "bash-minimal" is necessary when cross-compiling, otherwise the resulting wrapper will use an interpreter for the wrong architecture. This linter detects 365 problematic packages. Greetings, Maxime. --=-IVmCbr6hBVBHLJTFtHUQ Content-Disposition: attachment; filename*0=0001-lint-Define-some-procedures-for-analysing-code-in-ph.pat; filename*1=ch Content-Type: text/x-patch; name="0001-lint-Define-some-procedures-for-analysing-code-in-ph.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAxOGE3Y2ZjYmU1NGUyMGM4MGFmZDU1ZTIxYzUwNGE4NzJjMDUzNTkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IFRodSwgMSBKdWwgMjAyMSAxMjo1MToxNCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8y XSBsaW50OiBEZWZpbmUgc29tZSBwcm9jZWR1cmVzIGZvciBhbmFseXNpbmcgY29kZSBpbgogcGhh c2VzLgoKKiBndWl4L2xpbnQuc2NtCiAgKGNoZWNrLW9wdGlvbmFsLXRlc3RzKTogRXh0cmFjdCBs b2dpYyBmb3IgZXh0cmFjdGluZyB0aGUgcGhhc2VzIGZyb20gYQogIHBhY2thZ2UgdG8gLi4uCiAg KGZpbmQtcGhhc2UtZGVsdGFzKTogLi4uIGhlcmUsIGFuZCAuLi4KICAocmVwb3J0LWJvZ3VzLXBo YXNlLWRlbHRhcyk6IC4uLiBoZXJlLgogIChjaGVjay1vcHRpb25hbC10ZXN0cylbY2hlY2stY2hl Y2stcHJvY2VkdXJlXTogRXh0cmFjdCBjb2RlIGZvciBleHRyYWN0aW5nCiAgdGhlIHByb2NlZHVy ZSBib2R5IHRvIC4uLgogIChmaW5kLXByb2NlZHVyZS1ib2R5KSAuLi4gaGVyZS4KICAoZmluZC1w aGFzZS1wcm9jZWR1cmUpOiBOZXcgcHJvY2VkdXJlLgogIChyZXBvcnQtYm9ndXMtcGhhc2UtcHJv Y2VkdXJlKTogTmV3IHByb2NlZHVyZS4KLS0tCiBndWl4L2xpbnQuc2NtIHwgMTE2ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgODMgaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ3VpeC9s aW50LnNjbSBiL2d1aXgvbGludC5zY20KaW5kZXggYzYzNzkyOWMzOC4uZjU0ZjY5NDllYyAxMDA2 NDQKLS0tIGEvZ3VpeC9saW50LnNjbQorKysgYi9ndWl4L2xpbnQuc2NtCkBAIC0xNjAsNiArMTYw LDc3IEBACiAgICAgKChfIHBhY2thZ2UgKEdfIG1lc3NhZ2UpIHJlc3QgLi4uKQogICAgICAoJW1h a2Utd2FybmluZyBwYWNrYWdlIG1lc3NhZ2UgcmVzdCAuLi4pKSkpCiAKKwwKKzs7OworOzs7IFBy b2NlZHVyZXMgZm9yIGFuYWx5c2luZyBTY2hlbWUgY29kZSBpbiBwYWNrYWdlIGRlZmluaXRpb25z Cis7OzsKKworKGRlZmluZSogKGZpbmQtcHJvY2VkdXJlLWJvZHkgZXhwcmVzc2lvbiBmb3VuZAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIzprZXkgKG5vdC1mb3VuZCAoY29uc3QgJygp KSkpCisgICJUcnkgdG8gZmluZCB0aGUgYm9keSBvZiB0aGUgcHJvY2VkdXJlIGRlZmluZWQgaW5s aW5lIGJ5IEVYUFJFU1NJT04uCitJZiBpdCB3YXMgZm91bmQsIGNhbGwgRVhQUkVTU0lPTiB3aXRo IGl0cyBib2R5LiBJZiBpdCB3YXNuJ3QsIGNhbGwKK3RoZSB0aHVuayBOT1QtRk9VTkQuIgorICAo bWF0Y2ggZXhwcmVzc2lvbgorICAgIChgKCwob3IgJ2xldCAnbGV0KikgLiAsXykKKyAgICAgKGZp bmQtcHJvY2VkdXJlLWJvZHkgKGNhciAobGFzdC1wYWlyIGV4cHJlc3Npb24pKSBmb3VuZAorICAg ICAgICAgICAgICAgICAgICAgICAgICAjOm5vdC1mb3VuZCBub3QtZm91bmQpKQorICAgIChgKCwo b3IgJ2xhbWJkYSAnbGFtYmRhKikgLF8gLiAsY29kZSkKKyAgICAgKGZvdW5kIGNvZGUpKQorICAg IChfIChub3QtZm91bmQpKSkpCisKKyhkZWZpbmUqIChyZXBvcnQtYm9ndXMtcGhhc2UtZGVsdGFz IHBhY2thZ2UgYm9ndXMtZGVsdGFzKQorICAiUmVwb3J0IGEgYm9ndXMgaW52b2NhdGlvbiBvZiDi gJhtb2RpZnktcGhhc2Vz4oCZLiIKKyAgKGxpc3QgKG1ha2Utd2FybmluZyBwYWNrYWdlCisgICAg ICAgICAgICAgICAgICAgICAgOzsgVFJBTlNMQVRPUlM6ICdtb2RpZnktcGhhc2VzJyBpcyBhIFNj aGVtZSBzeW50YXgKKyAgICAgICAgICAgICAgICAgICAgICA7OyBhbmQgc2hvdWxkIG5vdCBiZSB0 cmFuc2xhdGVkLgorICAgICAgICAgICAgICAgICAgICAgIChHXyAiaW5jb3JyZWN0IGNhbGwgdG8g 4oCYbW9kaWZ5LXBoYXNlc+KAmSIpCisgICAgICAgICAgICAgICAgICAgICAgIzpmaWVsZCAnYXJn dW1lbnRzKSkpCisKKyhkZWZpbmUqIChmaW5kLXBoYXNlLWRlbHRhcyBwYWNrYWdlIGZvdW5kCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIzprZXkgKG5vdC1mb3VuZCAoY29uc3QgJygpKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYm9ndXMgKGN1dCByZXBvcnQtYm9ndXMtcGhh c2UtZGVsdGFzIHBhY2thZ2UgPD4pKSkKKyAgIlRyeSB0byBmaW5kIHRoZSBjbGF1c2VzIG9mIHRo ZSDigJhtb2RpZnktcGhhc2Vz4oCZIGZvcm0gaW4gdGhlIHBoYXNlcworc3BlY2lmaWNhdGlvbiBv ZiBQQUNLQUdFLiAgSWYgdGhleSB3ZXJlIGZvdW5kLCBhbGwgRk9VTkQgd2l0aCBhIGxpc3QKK29m IHRoZSBjbGF1c2VzLiAgSWYgdGhleSB3ZXJlbid0IChlLmcuIGJlY2F1c2Ug4oCYbW9kaWZ5LXBo YXNlc+KAmSB3YXNuJ3QKK3VzZWQgYXQgYWxsKSwgY2FsbCB0aGUgdGh1bmsgTk9ULUZPVU5EIGlu c3RlYWQuICBJZiDigJhtb2RpZnktcGhhc2Vz4oCZCit3YXMgdXNlZCwgYnV0IHRoZSBjbGF1c2Vz IGRvbid0IGZvcm0gYSBsaXN0LCBjYWxsIEJPR1VTIHdpdGggdGhlCitub3QtYS1saXN0LiIKKyAg KGFwcGx5IChsYW1iZGEqICgjOmtleSBwaGFzZXMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAg ICAgICAoZGVmaW5lIHBoYXNlcy9zZXhwCisgICAgICAgICAgICAgKGlmIChnZXhwPyBwaGFzZXMp CisgICAgICAgICAgICAgICAgIChnZXhwLT5hcHByb3hpbWF0ZS1zZXhwIHBoYXNlcykKKyAgICAg ICAgICAgICAgICAgcGhhc2VzKSkKKyAgICAgICAgICAgKG1hdGNoIHBoYXNlcy9zZXhwCisgICAg ICAgICAgICAgKGAobW9kaWZ5LXBoYXNlcyAsXyAuICxjaGFuZ2VzKQorICAgICAgICAgICAgICAo KGlmIChsaXN0PyBjaGFuZ2VzKSBmb3VuZCBib2d1cykgY2hhbmdlcykpCisgICAgICAgICAgICAg KF8gKG5vdC1mb3VuZCkpKSkKKyAgICAgICAgIChwYWNrYWdlLWFyZ3VtZW50cyBwYWNrYWdlKSkp CisKKyhkZWZpbmUgKHJlcG9ydC1ib2d1cy1waGFzZS1wcm9jZWR1cmUgcGFja2FnZSkKKyAgIlJl cG9ydCBhIHN5bnRhY3RpY2FsbHktaW52YWxpZCBwaGFzZSBjbGF1c2UuIgorICAobGlzdCAobWFr ZS13YXJuaW5nIHBhY2thZ2UKKyAgICAgICAgICAgICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzog U2VlIOKAmG1vZGlmeS1waGFzZXPigJkgaW4gdGhlIG1hbnVhbC4KKyAgICAgICAgICAgICAgICAg ICAgICAoR18gImludmFsaWQgcGhhc2UgY2xhdXNlIikKKyAgICAgICAgICAgICAgICAgICAgICAj OmZpZWxkICdhcmd1bWVudHMpKSkKKworKGRlZmluZSogKGZpbmQtcGhhc2UtcHJvY2VkdXJlIHBh Y2thZ2UgZXhwcmVzc2lvbiBmb3VuZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICM6 a2V5IChub3QtZm91bmQgKGNvbnN0ICcoKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgKGJvZ3VzIChjdXQgcmVwb3J0LWJvZ3VzLXBoYXNlLXByb2NlZHVyZQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhY2thZ2UpKSkKKyAgIlRyeSB0byBmaW5k IHRoZSBwcm9jZWR1cmUgaW4gdGhlIHBoYXNlIGNsYXVzZSBFWFBSRVNTSU9OLiBJZiBpdCB3YXMK K2ZvdW5kLCBjYWxsIEZPVU5EIHdpdGggdGhlIHByb2NlZHVyZSBleHByZXNzaW9uLiBJZiBFWFBS RVNTSU9OIGlzbid0CithY3R1YWxseSBhIHBoYXNlIGNsYXVzZSwgY2FsbCB0aGUgdGh1bmsgQk9H VVMuIElmIHRoZSBwaGFzZSBmb3JtIGRvZXNuJ3QKK2hhdmUgYSBwcm9jZWR1cmUsIGNhbGwgdGhl IHRodW5rIE5PVC1GT1VORC4iCisgIChtYXRjaCBleHByZXNzaW9uCisgICAgKCgnYWRkLWFmdGVy IGJlZm9yZSBhZnRlciBwcm9jLWV4cHIpCisgICAgIChmb3VuZCBwcm9jLWV4cHIpKQorICAgICgo J2FkZC1iZWZvcmUgYWZ0ZXIgYmVmb3JlIHByb2MtZXhwcikKKyAgICAgKGZvdW5kIHByb2MtZXhw cikpCisgICAgKCgncmVwbGFjZSBfIHByb2MtZXhwcikKKyAgICAgKGZvdW5kIHByb2MtZXhwcikp CisgICAgKCgnZGVsZXRlIF8pIChub3QtZm91bmQpKQorICAgIChfIChib2d1cykpKSkKKwogDAog Ozs7CiA7OzsgQ2hlY2tlcnMKQEAgLTEwNjMsNDYgKzExMzQsMjUgQEAgZGVzY3JpcHRpb25zIG1h aW50YWluZWQgdXBzdHJlYW0uIgogICAoZGVmaW5lIChzZXhwLXVzZXMtdGVzdHM/PyBzZXhwKQog ICAgICJUZXN0IGlmIFNFWFAgY29udGFpbnMgdGhlIHN5bWJvbCAndGVzdHM/Jy4iCiAgICAgKHNl eHAtY29udGFpbnMtYXRvbT8gc2V4cCAndGVzdHM/KSkKKyAgKGRlZmluZSAoY2hlY2stcHJvY2Vk dXJlLWJvZHkgY29kZSkKKyAgICAoaWYgKHNleHAtdXNlcy10ZXN0cz8/IGNvZGUpCisgICAgICAg ICcoKQorICAgICAgICAobGlzdCAobWFrZS13YXJuaW5nIHBhY2thZ2UKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBUUkFOU0xBVE9SUzogY2hlY2sgYW5kICM6dGVzdHM/IGFyZSBhCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgU2NoZW1lIHN5bWJvbCBhbmQga2V5d29yZCBy ZXNwZWN0aXZlbHkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBhbmQgc2hvdWxkIG5v dCBiZSB0cmFuc2xhdGVkLgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHXyAidGhlICdj aGVjaycgcGhhc2Ugc2hvdWxkIHJlc3BlY3QgIzp0ZXN0cz8iKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICM6ZmllbGQgJ2FyZ3VtZW50cykpKSkKICAgKGRlZmluZSAoY2hlY2stY2hlY2st cHJvY2VkdXJlIGV4cHJlc3Npb24pCi0gICAgKG1hdGNoIGV4cHJlc3Npb24KLSAgICAgIChgKCwo b3IgJ2xldCAnbGV0KikgLiAsXykKLSAgICAgICAoY2hlY2stY2hlY2stcHJvY2VkdXJlIChjYXIg KGxhc3QtcGFpciBleHByZXNzaW9uKSkpKQotICAgICAgKGAoLChvciAnbGFtYmRhICdsYW1iZGEq KSAsXyAuICxjb2RlKQotICAgICAgIChpZiAoc2V4cC11c2VzLXRlc3RzPz8gY29kZSkKLSAgICAg ICAgICAgJygpCi0gICAgICAgICAgIChsaXN0IChtYWtlLXdhcm5pbmcgcGFja2FnZQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDs7IFRSQU5TTEFUT1JTOiBjaGVjayBhbmQgIzp0ZXN0 cz8gYXJlIGEKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBTY2hlbWUgc3ltYm9s IGFuZCBrZXl3b3JkIHJlc3BlY3RpdmVseQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IDs7IGFuZCBzaG91bGQgbm90IGJlIHRyYW5zbGF0ZWQuCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKEdfICJ0aGUgJ2NoZWNrJyBwaGFzZSBzaG91bGQgcmVzcGVjdCAjOnRlc3RzPyIp Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIzpmaWVsZCAnYXJndW1lbnRzKSkpKQot ICAgICAgKF8gJygpKSkpCisgICAgKGZpbmQtcHJvY2VkdXJlLWJvZHkgZXhwcmVzc2lvbiBjaGVj ay1wcm9jZWR1cmUtYm9keSkpCiAgIChkZWZpbmUgKGNoZWNrLXBoYXNlcy1kZWx0YSBkZWx0YSkK ICAgICAobWF0Y2ggZGVsdGEKICAgICAgIChgKHJlcGxhY2UgJ2NoZWNrICxleHByZXNzaW9uKQog ICAgICAgIChjaGVjay1jaGVjay1wcm9jZWR1cmUgZXhwcmVzc2lvbikpCiAgICAgICAoXyAnKCkp KSkKICAgKGRlZmluZSAoY2hlY2stcGhhc2VzLWRlbHRhcyBkZWx0YXMpCi0gICAgKG1hdGNoIGRl bHRhcwotICAgICAgKCgpICcoKSkKLSAgICAgICgoaGVhZCAuIHRhaWwpCi0gICAgICAgKGFwcGVu ZCAoY2hlY2stcGhhc2VzLWRlbHRhIGhlYWQpCi0gICAgICAgICAgICAgICAoY2hlY2stcGhhc2Vz LWRlbHRhcyB0YWlsKSkpCi0gICAgICAoXyAobGlzdCAobWFrZS13YXJuaW5nIHBhY2thZ2UKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgVFJBTlNMQVRPUlM6IG1vZGlmeS1waGFzZXMg aXMgYSBTY2hlbWUKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgc3ludGF4IGFuZCBt dXN0IG5vdCBiZSB0cmFuc2xhdGVkLgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoR18g ImluY29ycmVjdCBjYWxsIHRvIOKAmG1vZGlmeS1waGFzZXPigJkiKQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAjOmZpZWxkICdhcmd1bWVudHMpKSkpKQotICAoYXBwbHkgKGxhbWJkYSog KCM6a2V5IHBoYXNlcyAjOmFsbG93LW90aGVyLWtleXMpCi0gICAgICAgICAgIChkZWZpbmUgcGhh c2VzL3NleHAKLSAgICAgICAgICAgICAoaWYgKGdleHA/IHBoYXNlcykKLSAgICAgICAgICAgICAg ICAgKGdleHAtPmFwcHJveGltYXRlLXNleHAgcGhhc2VzKQotICAgICAgICAgICAgICAgICBwaGFz ZXMpKQotICAgICAgICAgICAobWF0Y2ggcGhhc2VzL3NleHAKLSAgICAgICAgICAgICAoYChtb2Rp ZnktcGhhc2VzICxfIC4gLGNoYW5nZXMpCi0gICAgICAgICAgICAgIChjaGVjay1waGFzZXMtZGVs dGFzIGNoYW5nZXMpKQotICAgICAgICAgICAgIChfICcoKSkpKQotICAgICAgICAgKHBhY2thZ2Ut YXJndW1lbnRzIHBhY2thZ2UpKSkKKyAgICAoYXBwZW5kLW1hcCBjaGVjay1waGFzZXMtZGVsdGEg ZGVsdGFzKSkKKyAgKGZpbmQtcGhhc2UtZGVsdGFzIHBhY2thZ2UgY2hlY2stcGhhc2VzLWRlbHRh cykpCiAKIChkZWZpbmUqIChjaGVjay1kZXJpdmF0aW9uIHBhY2thZ2UgIzprZXkgc3RvcmUpCiAg ICJFbWl0IGEgd2FybmluZyBpZiB3ZSBmYWlsIHRvIGNvbXBpbGUgUEFDS0FHRSB0byBhIGRlcml2 YXRpb24uIgotLSAKMi4zMi4wCgo= --=-IVmCbr6hBVBHLJTFtHUQ Content-Disposition: attachment; filename*0=0002-lint-Lint-usages-of-wrap-program-without-a-bash-inpu.pat; filename*1=ch Content-Type: text/x-patch; name="0002-lint-Lint-usages-of-wrap-program-without-a-bash-inpu.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA3NzZkYjMyYzk4YWQzYTJiYWQwZjgxYzMzMTQ4NzhmYTllZWE4NGFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CkRhdGU6IFRodSwgMSBKdWwgMjAyMSAxMjo1OTo1MiArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMi8y XSBsaW50OiBMaW50IHVzYWdlcyBvZiAnd3JhcC1wcm9ncmFtJyB3aXRob3V0IGEgImJhc2giCiBp bnB1dC4KCldoZW4gdXNpbmcgJ3dyYXAtcHJvZ3JhbScsICJiYXNoIiAob3IgImJhc2gtbWluaW1h bCIpIHNob3VsZCBiZQppbiBpbnB1dHMuICBPdGhlcndpc2UsIHdoZW4gY3Jvc3MtY29tcGlsaW5n LCAnd3JhcC1wcm9ncmFtJyB3aWxsIHVzZQphIG5hdGl2ZSBiYXNoIGluc3RlYWQgb2YgdGhlIGNy b3NzIGJhc2ggYW5kIHRoZSAncGF0Y2gtc2hlYmFuZ3MnIHdvbid0CmJlIGFibGUgdG8gY29ycmVj dCB0aGlzLgoKVG9iaWFzIEdlZXJpbmNreC1SaWNlIGlzIGFkZGVkIHRvIHRoZSBjb3B5cmlnaHQg bGluZXMgYmVjYXVzZQphIHBhcnQgb2YgdGhlICJzdHJhdy12aWV3ZXIiIHBhY2thZ2UgZGVmaW5p dGlvbiBpcyBpbmNsdWRlZC4KClRoaXMgbGludGVyIGRldGVjdHMgMzY1IHByb2JsZW1hdGljIHBh Y2thZ2UgZGVmaW5pdGlvbnMgYXQgdGltZQpvZiB3cml0aW5nLgoKKiBndWl4L2xpbnQuc2NtCiAg KHJlcG9ydC13cmFwLXByb2dyYW0tZXJyb3IpOiBOZXcgcHJvY2VkdXJlLgogIChjaGVjay13cmFw cGVyLWlucHV0cyk6IE5ldyBsaW50ZXIuCiAgKCVsb2NhbC1jaGVja2Vycylbd3JhcHBlci1pbnB1 dHNdOiBBZGQgdGhlIG5ldyBsaW50ZXIuCiAgKCJleHBsaWNpdCAjOnNoIGFyZ3VtZW50IHRvICd3 cmFwLXByb2dyYW0nIGlzIGFjY2VwdGFibGUiKQogICgiJ2NoZWNrLXdyYXBwZXItaW5wdXRzJyBk ZXRlY3RzICd3cmFwLXByb2dyYW0nIHdpdGhvdXQgXCJiYXNoXCIgaW4gaW5wdXRzIikKICAoIidj aGVjay13cmFwcGVyLWlucHV0cycgZGV0ZWN0cyAnd3JhcC1xdC1wcm9ncmFtJyB3aXRob3V0IFwi YmFzaFwiIGluIGlucHV0cyIpCiAgKCJcImJhc2hcIiBpbiAnaW5wdXRzJyBzYXRpc2ZpZXMgJ2No ZWNrLXdyYXBwZXItaW5wdXRzJyIpCiAgKCJcImJhc2gtbWluaW1hbFwiIGluICdpbnB1dHMnIHNh dGlzZmllcyAnY2hlY2std3JhcHBlci1pbnB1dHMnIikKICAoIidjdXQnIGRvZXNuJ3QgaGlkZSBi YWQgdXNhZ2VzIG9mICd3cmFwLXByb2dyYW0nIikKICAoImJvZ3VzIHBoYXNlIHNwZWNpZmljYXRp b25zIGRvbid0IGNyYXNoIHRoZSBsaW50ZXIiKTogTmV3IHRlc3RzLgotLS0KIGd1aXgvbGludC5z Y20gIHwgNDggKysrKysrKysrKysrKysrKysrKysrKysrKysrCiB0ZXN0cy9saW50LnNjbSB8IDg4 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZp bGVzIGNoYW5nZWQsIDEzNiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ3VpeC9saW50LnNj bSBiL2d1aXgvbGludC5zY20KaW5kZXggZjU0ZjY5NDllYy4uZTEyYjM1YmNhOCAxMDA2NDQKLS0t IGEvZ3VpeC9saW50LnNjbQorKysgYi9ndWl4L2xpbnQuc2NtCkBAIC04MCw2ICs4MCw3IEBACiAg ICM6ZXhwb3J0IChjaGVjay1kZXNjcmlwdGlvbi1zdHlsZQogICAgICAgICAgICAgY2hlY2staW5w dXRzLXNob3VsZC1iZS1uYXRpdmUKICAgICAgICAgICAgIGNoZWNrLWlucHV0cy1zaG91bGQtbm90 LWJlLWFuLWlucHV0LWF0LWFsbAorICAgICAgICAgICAgY2hlY2std3JhcHBlci1pbnB1dHMKICAg ICAgICAgICAgIGNoZWNrLXBhdGNoLWZpbGUtbmFtZXMKICAgICAgICAgICAgIGNoZWNrLXBhdGNo LWhlYWRlcnMKICAgICAgICAgICAgIGNoZWNrLXN5bm9wc2lzLXN0eWxlCkBAIC00ODksNiArNDkw LDQ5IEBAIG9mIGEgcGFja2FnZSwgYW5kIElOUFVULU5BTUVTLCBhIGxpc3Qgb2YgcGFja2FnZSBz cGVjaWZpY2F0aW9ucyBzdWNoIGFzCiAgICAgICAgICAocGFja2FnZS1pbnB1dC1pbnRlcnNlY3Rp b24gKHBhY2thZ2UtZGlyZWN0LWlucHV0cyBwYWNrYWdlKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGlucHV0LW5hbWVzKSkpKQogCisoZGVmaW5lIChyZXBvcnQtd3JhcC1w cm9ncmFtLWVycm9yIHBhY2thZ2Ugd3JhcHBlci1uYW1lKQorICAiV2FybiB0aGF0IFwiYmFzaC1t aW5pbWFsXCIgaXMgbWlzc2luZyBmcm9tICdpbnB1dHMnLCB3aGlsZSBXUkFQUEVSLU5BTUUKK3Jl cXVpcmVzIGl0LiIKKyAgKG1ha2Utd2FybmluZyBwYWNrYWdlCisgICAgICAgICAgICAgICAgKEdf ICJcImJhc2gtbWluaW1hbFwiIHNob3VsZCBiZSBpbiAnaW5wdXRzJyB3aGVuICd+YScgaXMgdXNl ZCIpCisgICAgICAgICAgICAgICAgKGxpc3Qgd3JhcHBlci1uYW1lKSkpCisKKyhkZWZpbmUgKGNo ZWNrLXdyYXBwZXItaW5wdXRzIHBhY2thZ2UpCisgICJFbWl0IGEgd2FybmluZyBpZiBQQUNLQUdF IHVzZXMgJ3dyYXAtcHJvZ3JhbScgb3Igc2ltaWxhciwgYnV0IFwiYmFzaFwiCitvciBcImJhc2gt bWluaW1hbFwiIGlzIG5vdCBpbiBpdHMgaW5wdXRzLiAnd3JhcC1zY3JpcHQnIGlzIG5vdCBzdXBw b3J0ZWQuIgorICAoZGVmaW5lIGlucHV0LW5hbWVzICcoImJhc2giICJiYXNoLW1pbmltYWwiKSkK KyAgKGRlZmluZSBoYXMtYmFzaC1pbnB1dD8KKyAgICAocGFpcj8gKHBhY2thZ2UtaW5wdXQtaW50 ZXJzZWN0aW9uIChwYWNrYWdlLWlucHV0cyBwYWNrYWdlKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW5wdXQtbmFtZXMpKSkKKyAgKGRlZmluZSAoY2hlY2stcHJvY2Vk dXJlLWJvZHkgYm9keSkKKyAgICAobWF0Y2ggYm9keQorICAgICAgOzsgRXhwbGljaXRlbHkgc2V0 dGluZyBhbiBpbnRlcnByZXRlciBpcyBhY2NlcHRhYmxlLAorICAgICAgOzsgIzpzaCBzdXBwb3J0 IGlzIGFkZGVkIG9uICdjb3JlLXVwZGF0ZXMnLgorICAgICAgOzsgVE9ETyhjb3JlLXVwZGF0ZXMp OiByZW1vdmUgbWVudGlvbiBvZiBjb3JlLXVwZGF0ZXMuCisgICAgICAoKCd3cmFwLXByb2dyYW0g XyAnIzpzaCAuIF8pICcoKSkKKyAgICAgICgoJ3dyYXAtcHJvZ3JhbSBfIC4gXykKKyAgICAgICAo bGlzdCAocmVwb3J0LXdyYXAtcHJvZ3JhbS1lcnJvciBwYWNrYWdlICd3cmFwLXByb2dyYW0pKSkK KyAgICAgIDs7IFdyYXBwZXIgb2YgJ3dyYXAtcHJvZ3JhbScgZm9yIFF0IHByb2dyYW1zLgorICAg ICAgOzsgVE9ETyAjOnNoIGlzIG5vdCB5ZXQgc3VwcG9ydGVkIGJ1dCBwcm9iYWJseSB3aWxsIGJl LgorICAgICAgKCgnd3JhcC1xdC1wcm9ncmFtIF8gJyM6c2ggLiBfKSAnKCkpCisgICAgICAoKCd3 cmFwLXF0LXByb2dyYW0gXyAuIF8pCisgICAgICAgKGxpc3QgKHJlcG9ydC13cmFwLXByb2dyYW0t ZXJyb3IgcGFja2FnZSAnd3JhcC1xdC1wcm9ncmFtKSkpCisgICAgICAoKHggLiB5KQorICAgICAg IChhcHBlbmQgKGNoZWNrLXByb2NlZHVyZS1ib2R5IHgpIChjaGVjay1wcm9jZWR1cmUtYm9keSB5 KSkpCisgICAgICAoXyAnKCkpKSkKKyAgKGRlZmluZSAoY2hlY2stcGhhc2UtcHJvY2VkdXJlIGV4 cHJlc3Npb24pCisgICAgKGZpbmQtcHJvY2VkdXJlLWJvZHkgZXhwcmVzc2lvbiBjaGVjay1wcm9j ZWR1cmUtYm9keSkpCisgIChkZWZpbmUgKGNoZWNrLWRlbHRhIGV4cHJlc3Npb24pCisgICAgKGZp bmQtcGhhc2UtcHJvY2VkdXJlIHBhY2thZ2UgZXhwcmVzc2lvbiBjaGVjay1waGFzZS1wcm9jZWR1 cmUpKQorICAoZGVmaW5lIChjaGVjay1kZWx0YXMgZGVsdGFzKQorICAgIChhcHBlbmQtbWFwIGNo ZWNrLWRlbHRhIGRlbHRhcykpCisgIChpZiBoYXMtYmFzaC1pbnB1dD8KKyAgICAgIDs7ICJiYXNo IiAob3IgImJhc2gtbWluaW1hbCIpIGlzIGluICdpbnB1dHMnLCBzbyBldmVyeXRoaW5nIHNlZW1z IG9rLgorICAgICAgJygpCisgICAgICA7OyAiYmFzaCIgaXMgbm90IGluICdpbnB1dHMnLiAgVmVy aWZ5ICd3cmFwLXByb2dyYW0nIGFuZCBmcmllbmRzCisgICAgICA7OyBhcmUgdW51c2VkCisgICAg ICAoZmluZC1waGFzZS1kZWx0YXMgcGFja2FnZSBjaGVjay1kZWx0YXMpKSkKKwogKGRlZmluZSAo cGFja2FnZS1uYW1lLXJlZ2V4cCBwYWNrYWdlKQogICAiUmV0dXJuIGEgcmVnZXhwIHRoYXQgbWF0 Y2hlcyBQQUNLQUdFJ3MgbmFtZSBhcyBhIHdvcmQgYXQgdGhlIGJlZ2lubmluZyBvZiBhCiBsaW5l LiIKQEAgLTE2ODcsNiArMTczMSwxMCBAQCB0aGVtIGZvciBQQUNLQUdFLiIKICAgICAgKG5hbWUg ICAgICAgICdpbnB1dHMtc2hvdWxkLW5vdC1iZS1pbnB1dCkKICAgICAgKGRlc2NyaXB0aW9uICJJ ZGVudGlmeSBpbnB1dHMgdGhhdCBzaG91bGRuJ3QgYmUgaW5wdXRzIGF0IGFsbCIpCiAgICAgIChj aGVjayAgICAgICBjaGVjay1pbnB1dHMtc2hvdWxkLW5vdC1iZS1hbi1pbnB1dC1hdC1hbGwpKQor ICAgKGxpbnQtY2hlY2tlcgorICAgICAobmFtZSAgICAgICAgJ3dyYXBwZXItaW5wdXRzKQorICAg ICAoZGVzY3JpcHRpb24gIk1ha2Ugc3VyZSAnd3JhcC1wcm9ncmFtJyBjYW4gZmluZHMgaXRzIGlu dGVycHJldGVyLiIpCisgICAgIChjaGVjayAgICAgICBjaGVjay13cmFwcGVyLWlucHV0cykpCiAg ICAobGludC1jaGVja2VyCiAgICAgIChuYW1lICAgICAgICAnbGljZW5zZSkKICAgICAgOzsgVFJB TlNMQVRPUlM6IDxsaWNlbnNlPiBpcyB0aGUgbmFtZSBvZiBhIGRhdGEgdHlwZSBhbmQgbXVzdCBu b3QgYmUKZGlmZiAtLWdpdCBhL3Rlc3RzL2xpbnQuc2NtIGIvdGVzdHMvbGludC5zY20KaW5kZXgg NGVmNDAwYTlhMC4uODI5NzFkYjhmMCAxMDA2NDQKLS0tIGEvdGVzdHMvbGludC5zY20KKysrIGIv dGVzdHMvbGludC5zY20KQEAgLTgsNiArOCw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTcgRWZy YWltIEZsYXNobmVyIDxlZnJhaW1AZmxhc2huZXIuY28uaWw+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MTgsIDIwMTkgQXJ1biBJc2FhYyA8YXJ1bmlzYWFjQHN5c3RlbXJlYm9vdC5uZXQ+CiA7OzsgQ29w eXJpZ2h0IMKpIDIwMjAgVGltb3RoeSBTYW1wbGUgPHNhbXBsZXRAbmd5cm8uY29tPgorOzs7IENv cHlyaWdodCDCqSAyMDIwIFRvYmlhcyBHZWVyaW5ja3gtUmljZSA8bWVAdG9iaWFzLmdyPgogOzs7 IENvcHlyaWdodCDCqSAyMDIxIFhpbmdsdSBDaGVuIDxwdWJsaWNAeW9jdG9jZWxsLnh5ej4KIDs7 OyBDb3B5cmlnaHQgwqkgMjAyMSBNYXhpbWUgRGV2b3MgPG1heGltZWRldm9zQHRlbGVuZXQuYmU+ CiA7OzsKQEAgLTQ3LDYgKzQ4LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ2xp YikKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcGtnLWNvbmZpZykKICAgIzp1c2UtbW9k dWxlIChnbnUgcGFja2FnZXMgcHl0aG9uLXh5eikKKyAgIzp1c2UtbW9kdWxlICgoZ251IHBhY2th Z2VzIGJhc2gpICM6c2VsZWN0IChiYXNoIGJhc2gtbWluaW1hbCkpCiAgICM6dXNlLW1vZHVsZSAo d2ViIHVyaSkKICAgIzp1c2UtbW9kdWxlICh3ZWIgc2VydmVyKQogICAjOnVzZS1tb2R1bGUgKHdl YiBzZXJ2ZXIgaHR0cCkKQEAgLTM1Nyw2ICszNTksOTIgQEAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGAoKCJweXRob24tc2V0dXB0b29scyIgLHB5dGhvbi1zZXR1cHRvb2xzKSkpKSkp CiAgICAgIChjaGVjay1pbnB1dHMtc2hvdWxkLW5vdC1iZS1hbi1pbnB1dC1hdC1hbGwgcGtnKSkp KQogCisodGVzdC1lcXVhbCAiZXhwbGljaXQgIzpzaCBhcmd1bWVudCB0byAnd3JhcC1wcm9ncmFt JyBpcyBhY2NlcHRhYmxlIgorICAnKCkKKyAgKGxldCogKChwaGFzZXMKKyAgICAgICAgICA7OyBM b29zZWx5IGJhc2VkIG9uIHRoZSAiY2F0ZmlzaCIgcGFja2FnZQorICAgICAgICAgIGAobW9kaWZ5 LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFs bCAnd3JhcAorICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6a2V5IGlucHV0cyBvdXRwdXRzICM6 YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgICAgKGRlZmluZSBjYXRmaXNoIChzdHJp bmctYXBwZW5kIChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvYmluL2NhdGZpc2giKSkKKyAgICAgICAgICAg ICAgICAgKGRlZmluZSBoc2FiIChzdHJpbmctYXBwZW5kIChhc3NvYy1yZWYgaW5wdXRzICJoc2Fi IikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvYmluL2hz YWIiKSkKKyAgICAgICAgICAgICAgICAgKHdyYXAtcHJvZ3JhbSBjYXRmaXNoICM6c2ggaHNhYgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGAoIlBZVEhPTlBBVEgiID0gKCwiYmxhYmxh IikpKSkpKSkKKyAgICAgICAgIChwa2cgKGR1bW15LXBhY2thZ2UgIngiIChhcmd1bWVudHMgYCgj OnBoYXNlcyAscGhhc2VzKSkpKSkKKyAgICAoY2hlY2std3JhcHBlci1pbnB1dHMgcGtnKSkpCisK Kyh0ZXN0LWVxdWFsCisgICAgIidjaGVjay13cmFwcGVyLWlucHV0cycgZGV0ZWN0cyAnd3JhcC1w cm9ncmFtJyB3aXRob3V0IFwiYmFzaFwiIGluIGlucHV0cyIKKyAgIlwiYmFzaC1taW5pbWFsXCIg c2hvdWxkIGJlIGluICdpbnB1dHMnIHdoZW4gJ3dyYXAtcHJvZ3JhbScgaXMgdXNlZCIKKyAgKGxl dCogKChwaGFzZXMKKyAgICAgICAgICBgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwor ICAgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAKKyAgICAgICAgICAgICAgIChs YW1iZGEgXworICAgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIHRoZS1iaW5hcnkgYmxhLWJs YSkpKSkpCisgICAgICAgICAocGtnIChkdW1teS1wYWNrYWdlICJ4IiAoYXJndW1lbnRzIGAoIzpw aGFzZXMgLHBoYXNlcykpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZSAoY2hl Y2std3JhcHBlci1pbnB1dHMgcGtnKSkpKQorCisodGVzdC1lcXVhbAorICAgICInY2hlY2std3Jh cHBlci1pbnB1dHMnIGRldGVjdHMgJ3dyYXAtcXQtcHJvZ3JhbScgd2l0aG91dCBcImJhc2hcIiBp biBpbnB1dHMiCisgICJcImJhc2gtbWluaW1hbFwiIHNob3VsZCBiZSBpbiAnaW5wdXRzJyB3aGVu ICd3cmFwLXF0LXByb2dyYW0nIGlzIHVzZWQiCisgIChsZXQqICgocGhhc2VzCisgICAgICAgICAg YChtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgICAgICAoYWRkLWFmdGVy ICdpbnN0YWxsICdxdHdyYXAKKyAgICAgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAg ICAgICAod3JhcC1xdC1wcm9ncmFtIHRoZS1iaW5hcnkgYmxhLWJsYSkpKSkpCisgICAgICAgICAo cGtnIChkdW1teS1wYWNrYWdlICJ4IiAoYXJndW1lbnRzIGAoIzpwaGFzZXMgLHBoYXNlcykpKSkp CisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZSAoY2hlY2std3JhcHBlci1pbnB1dHMg cGtnKSkpKQorCisodGVzdC1lcXVhbCAiXCJiYXNoXCIgaW4gJ2lucHV0cycgc2F0aXNmaWVzICdj aGVjay13cmFwcGVyLWlucHV0cyciCisgICcoKQorICAobGV0KiAoKHBoYXNlcworICAgICAgICAg IGAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgKGFkZC1hZnRl ciAnaW5zdGFsbCAnd3JhcAorICAgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAg ICAgICh3cmFwLXByb2dyYW0gdGhlLWJpbmFyeSBibGEtYmxhKSkpKSkKKyAgICAgICAgIChwa2cg KGR1bW15LXBhY2thZ2UgIngiIChhcmd1bWVudHMgYCgjOnBoYXNlcyAscGhhc2VzKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGlucHV0cyBgKCgiYmFzaCIgLGJhc2gpKSkpKSkKKyAg ICAoY2hlY2std3JhcHBlci1pbnB1dHMgcGtnKSkpCisKKyh0ZXN0LWVxdWFsICJcImJhc2gtbWlu aW1hbFwiIGluICdpbnB1dHMnIHNhdGlzZmllcyAnY2hlY2std3JhcHBlci1pbnB1dHMnIgorICAn KCkKKyAgKGxldCogKChwaGFzZXMKKyAgICAgICAgICBgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJk LXBoYXNlcworICAgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAKKyAgICAgICAg ICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIFRIRS1CSU5B UlkgYmxhLWJsYSkpKSkpCisgICAgICAgICAocGtnIChkdW1teS1wYWNrYWdlICJ4IiAoYXJndW1l bnRzIGAoIzpwaGFzZXMgLHBoYXNlcykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChp bnB1dHMgYCgoImJhc2gtbWluaW1hbCIgLGJhc2gtbWluaW1hbCkpKSkpKQorICAgIChjaGVjay13 cmFwcGVyLWlucHV0cyBwa2cpKSkKKworKHRlc3QtZXF1YWwgIidjdXQnIGRvZXNuJ3QgaGlkZSBi YWQgdXNhZ2VzIG9mICd3cmFwLXByb2dyYW0nIgorICAiXCJiYXNoLW1pbmltYWxcIiBzaG91bGQg YmUgaW4gJ2lucHV0cycgd2hlbiAnd3JhcC1wcm9ncmFtJyBpcyB1c2VkIgorICAobGV0KiAoKHBo YXNlcworICAgICAgICAgIDs7IFRha2VuIGZyb20gdGhlICJzdHJhdy12aWV3ZXIiIHBhY2thZ2UK KyAgICAgICAgICBgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAg IChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAtcHJvZ3JhbQorICAgICAgICAgICAgICAgKGxhbWJk YSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAo bGV0KiAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAgICAgICAgICAgICAgICAg ICAgICAgKGJpbi1kaXIgKHN0cmluZy1hcHBlbmQgb3V0ICIvYmluLyIpKQorICAgICAgICAgICAg ICAgICAgICAgICAgKHNpdGUtZGlyIChzdHJpbmctYXBwZW5kIG91dCAiL2xpYi9wZXJsNS9zaXRl X3BlcmwvIikpCisgICAgICAgICAgICAgICAgICAgICAgICAobGliLXBhdGggKGdldGVudiAiUEVS TDVMSUIiKSkpCisgICAgICAgICAgICAgICAgICAgKGZvci1lYWNoIChjdXQgd3JhcC1wcm9ncmFt IDw+CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYCgiUEVSTDVMSUIiICI6IiBw cmVmaXgKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgsbGliLXBhdGggLHNp dGUtZGlyKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmaW5kLWZpbGVzIGJpbi1k aXIpKSkpKSkpCisgICAgICAgICAocGtnIChkdW1teS1wYWNrYWdlICJ4IiAoYXJndW1lbnRzIGAo IzpwaGFzZXMgLHBoYXNlcykpKSkpCisgICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZSAo Y2hlY2std3JhcHBlci1pbnB1dHMgcGtnKSkpKQorCisodGVzdC1lcXVhbCAiYm9ndXMgcGhhc2Ug c3BlY2lmaWNhdGlvbnMgZG9uJ3QgY3Jhc2ggdGhlIGxpbnRlciIKKyAgImludmFsaWQgcGhhc2Ug Y2xhdXNlIgorICAobGV0KiAoKHBoYXNlcworICAgICAgICAgIGAobW9kaWZ5LXBoYXNlcyAlc3Rh bmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgKGFkZC1pbnZhbGlkKSkpCisgICAgICAgICAocGtn IChkdW1teS1wYWNrYWdlICJ4IiAoYXJndW1lbnRzIGAoIzpwaGFzZXMgLHBoYXNlcykpKSkpCisg ICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZSAoY2hlY2std3JhcHBlci1pbnB1dHMgcGtn KSkpKQorCiAodGVzdC1lcXVhbCAiZmlsZSBwYXRjaGVzOiBkaWZmZXJlbnQgZmlsZSBuYW1lIC0+ IHdhcm5pbmciCiAgICJmaWxlIG5hbWVzIG9mIHBhdGNoZXMgc2hvdWxkIHN0YXJ0IHdpdGggdGhl IHBhY2thZ2UgbmFtZSIKICAgKHNpbmdsZS1saW50LXdhcm5pbmctbWVzc2FnZQotLSAKMi4zMi4w Cgo= --=-IVmCbr6hBVBHLJTFtHUQ-- --=-0KuMRWfMRiElRL39JaGn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYN2piRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kZ4AQC9xW337TSGGeNhhqJjaVAq8Nza gdTCaSgds8ndOHy1awD+PoMUYWqZ+fKmLXh5N629OvlyAJuwE7lbaw619vQ9VQE= =ZsMU -----END PGP SIGNATURE----- --=-0KuMRWfMRiElRL39JaGn-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 13:29:19 2021 Received: (at 49315) by debbugs.gnu.org; 6 Jul 2021 17:29:19 +0000 Received: from localhost ([127.0.0.1]:49996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0oso-0007KV-Qc for submit@debbugs.gnu.org; Tue, 06 Jul 2021 13:29:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0osm-0007KH-MQ for 49315@debbugs.gnu.org; Tue, 06 Jul 2021 13:29:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52558) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0osg-0002qb-AW; Tue, 06 Jul 2021 13:29:10 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=43418 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0osg-0002q9-2P; Tue, 06 Jul 2021 13:29:10 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input. References: Date: Tue, 06 Jul 2021 19:29:07 +0200 In-Reply-To: (Maxime Devos's message of "Thu, 01 Jul 2021 13:39:53 +0200") Message-ID: <87pmvv4aho.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49315 Cc: 49315@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Maxim, > + "Try to find the body of the procedure defined inline by EXPRESSION. > +If it was found, call EXPRESSION with its body. If it wasn't, call ^ FOUND > + (`(,(or 'let 'let*) . ,_) > + (find-procedure-body (car (last-pair expression)) found > + #:not-found not-found)) You can use "last" from (srfi srfi-1) here. What's the point of stripping the let clause by the way? > + (list (make-warning package > + ;; TRANSLATORS: 'modify-phases' is a Scheme syntax > + ;; and should not be translated. > + (G_ "incorrect call to =E2=80=98modify-phases=E2= =80=99") > + #:field 'arguments))) Maybe you could return a plain object here. > + (list (make-warning package > + ;; TRANSLATORS: See =E2=80=98modify-phases=E2=80= =99 in the manual. > + (G_ "invalid phase clause") > + #:field 'arguments))) and here. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 13:43:29 2021 Received: (at 49315) by debbugs.gnu.org; 6 Jul 2021 17:43:29 +0000 Received: from localhost ([127.0.0.1]:50057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0p6X-0001Uu-0g for submit@debbugs.gnu.org; Tue, 06 Jul 2021 13:43:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0p6V-0001Uf-CK for 49315@debbugs.gnu.org; Tue, 06 Jul 2021 13:43:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52970) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0p6P-0004Hg-DB; Tue, 06 Jul 2021 13:43:21 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=43420 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0p6P-00040s-4J; Tue, 06 Jul 2021 13:43:21 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input. References: Date: Tue, 06 Jul 2021 19:43:19 +0200 In-Reply-To: (Maxime Devos's message of "Thu, 01 Jul 2021 13:39:53 +0200") Message-ID: <87im1n49u0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49315 Cc: 49315@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > When using 'wrap-program', "bash" (or "bash-minimal") should be > in inputs. Otherwise, when cross-compiling, 'wrap-program' will use > a native bash instead of the cross bash and the 'patch-shebangs' won't > be able to correct this. Nice one! Seems to work fine, and as most packages that use wrap-program are broken in that aspect, that's a welcomed addition. Sorry for misspelling your first name in my last email. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 16:38:21 2021 Received: (at 49315) by debbugs.gnu.org; 6 Jul 2021 20:38:21 +0000 Received: from localhost ([127.0.0.1]:50315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rpl-000072-0W for submit@debbugs.gnu.org; Tue, 06 Jul 2021 16:38:21 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:57166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rpi-00006s-2P for 49315@debbugs.gnu.org; Tue, 06 Jul 2021 16:38:19 -0400 Received: from butterfly.local ([213.132.130.78]) by andre.telenet-ops.be with bizsmtp id RweF250051he2ND01weGlD; Tue, 06 Jul 2021 22:38:16 +0200 Message-ID: Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input. From: Maxime Devos To: Mathieu Othacehe Date: Tue, 06 Jul 2021 22:38:03 +0200 In-Reply-To: <87pmvv4aho.fsf@gnu.org> References: <87pmvv4aho.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-EBPVfTSczUon0RVTqKUF" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625603896; bh=LigMBUJa/vsPoQLOU1ROAdpC21ceRN03HEq+ydalbkE=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=plKfSSKtOV/tNx/ltJnxRuFHD9QMav79Kct+3Hd6lWFtzwvGZXnZQ/hpc7c9WnjK7 zBpiANpxzelcHU5dA2jKTVtO95tKe5275zKX2AGaKb6FB+jjw6kQWV4Dxz4ruHo7d1 zRGasE+QWj5b/WL8UZaZWZDeyGC4YeopdF52LJnZ+NiwmTcOEmavTKQA1qoidkbtNx 0l5ipVvW4TIuSGRwo+crl8RDlKvKMpPqx9Mfo7IBEdvLaqiFL9I265S32L/iQ0q0Bl aFp8rZGp3WM39aNfi7H8o9eSorHQPScckLHIvQwmqnZ2mVe1ZCRI5vPd5w309ex9rN K9RDJfHSNpw5w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49315 Cc: 49315@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-EBPVfTSczUon0RVTqKUF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op di 06-07-2021 om 19:29 [+0200]: > Hey Maxime, >=20 > > + "Try to find the body of the procedure defined inline by EXPRESSION. > > +If it was found, call EXPRESSION with its body. If it wasn't, call > ^ > FOUND >=20 > > + (`(,(or 'let 'let*) . ,_) > > + (find-procedure-body (car (last-pair expression)) found > > + #:not-found not-found)) >=20 > You can use "last" from (srfi srfi-1) here. No, I can't -- unless a backtrace in case of invalid code is acceptable. The problem is that the procedure 'last' expects its argument to be a list. E.g., try from a REPL: scheme@(guile-user)> ((@ (srfi srfi-1) last) '("a" . 0)) $1 =3D 0 ... wait, why didn't this raise an exception? Looking at the definition of 'last' in (srfi srfi-1) in guile, I see (define (last pair) "Return the last element of the non-empty, finite list PAIR." (car (last-pair pair))) So, you're correct that "last" from (srfi srfi-1) can be used here, but this still seems rather fragile to me and an implementation detail of (srfi srfi-1). > What's the point of stripping the let clause by the way? Because 'find-procedure-body' is supposed to find the body of the procedure= , but sometimes the lambda is wrapped in a 'let'. (I don't have an example currently in mind, but I've definitely seen things like (modify-phases %standard-phases (replace 'something (let ((three (+ 1 2)) (lambda _ (format #t "~a~%" tree))))) in package definitions). You could ask, why do we need to extract the procedure body, can't we just pass the whole expression as-is to 'check-procedure-body'? That's a possiblity, but would lead to some false negatives: consider the following phases definition: (modify-phases %standard-phases (replace 'check (let ((three (+ 1 2))) (lambda* (#:key tests? #:allow-other-keys) (invoke "stuff" (number->string bla-bla)))))) In this case, the parameter tests? is ignored, even though the symbol 'test= s?' appears in the expression. So we shouldn't look at the parameter. --- wait, this is a patch review for the 'wrapper-inputs' linter, not the 'optional-tests' linter! Indeed, for the 'wrapper-inputs' linter, strippin= g the 'let' (or 'let*') is pointless. It might even lead to false negatives! Consider the case (add-after 'install 'wrap (let ((wrap (lambda (x) (wrap-program x [...])))) (lambda _ (wrap "stuff") (wrap "other-stuff")))) That usage should ideally be detected by 'wrap-program'. But as no current package definition seems to do such a thing, and using 'find-procedure-body' seems marginally =E2=80=98cleaner=E2=80=99 to me (YMM= V?), I would use 'find-procedure-body' anyways. > > + (list (make-warning package > > + ;; TRANSLATORS: 'modify-phases' is a Scheme synt= ax > > + ;; and should not be translated. > > + (G_ "incorrect call to =E2=80=98modify-phases=E2= =80=99") > > + #:field 'arguments))) >=20 > Maybe you could return a plain object here. Yes, but then (define* (find-phase-deltas package found #:key (not-found (const '())) (bogus (cut report-bogus-phase-deltas package <= >))) would need to become (define* (find-phase-deltas package found #:key (not-found (const '())) (bogus (lambda (bogus-deltas) (list (report-bogus-deltas package bog= us-deltas))))) which is rather verbose. (The 'bogus-deltas' argument could be dropped I su= ppose? But 'find-phase-deltas' is supposed to be generic, such that its callers ca= n have easy access to the bogus (dotted) list of phases ...) > > + (list (make-warning package > > + ;; TRANSLATORS: See =E2=80=98modify-phases=E2=80= =99 in the manual. > > + (G_ "invalid phase clause") > > + #:field 'arguments))) >=20 > and here. Likewise. Greetings, Maxime. --=-EBPVfTSczUon0RVTqKUF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYOS/KxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7l93AQDVtPHFYqAg5Ov9DtOCSr/hbrN0 9pg1sqOh2DLXBw5czwD+Kllml/SMCBvma1r8SuGqU9Rtgdr/AAHqVc7okMUpOQE= =gSgD -----END PGP SIGNATURE----- --=-EBPVfTSczUon0RVTqKUF-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 16:51:39 2021 Received: (at 49315) by debbugs.gnu.org; 6 Jul 2021 20:51:39 +0000 Received: from localhost ([127.0.0.1]:50336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0s2d-0000QQ-9m for submit@debbugs.gnu.org; Tue, 06 Jul 2021 16:51:39 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:44470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0s2b-0000QG-60 for 49315@debbugs.gnu.org; Tue, 06 Jul 2021 16:51:38 -0400 Received: from butterfly.local ([213.132.130.78]) by andre.telenet-ops.be with bizsmtp id Rwra250051he2ND01wrbxB; Tue, 06 Jul 2021 22:51:35 +0200 Message-ID: <3a1ae19bb6bb2ceca57e71312caf31391374a934.camel@telenet.be> Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input. From: Maxime Devos To: Mathieu Othacehe Date: Tue, 06 Jul 2021 22:51:29 +0200 In-Reply-To: <87im1n49u0.fsf@gnu.org> References: <87im1n49u0.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-pfUBF8ICWjDv0fIXxXjA" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625604695; bh=Q2Z/GVsrdM0uvxc7Fy5p3nvuiywoVrMdjxVZNvS3CyQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=iLokAqeOPIG2IK3pWalR0gmkN5NYdOCZUgTQ81ESaHmqAcJAkfXUvlfagjyqFej/8 noDIHyb+x6zbvGWmD4e6nWgMbUBPoOcWZ4Cs8aDR82aHc6EKhWHI+8+xQpIkGZNCj8 vFrKhFlbgZrb9UsphSrKEQeabjHZ/AS36BIpbS37BO1WH67Tarrzu2aHqgvM1jCIm7 dzMvtE/TSpbq0L+zC6pRekIBfTceM2+8LQYy+EGpaUWupD5olaI/R1R5jDcU7dYB+0 n+WQJXwk0xKpKjLfVtMut69T1BkGI19v3ToaX+7JKhul+IeTuxq/lrUJcUWY9DIySU DrIqWuFZbfmCw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49315 Cc: 49315@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-pfUBF8ICWjDv0fIXxXjA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op di 06-07-2021 om 19:43 [+0200]: > > When using 'wrap-program', "bash" (or "bash-minimal") should be > > in inputs. Otherwise, when cross-compiling, 'wrap-program' will use > > a native bash instead of the cross bash and the 'patch-shebangs' won't > > be able to correct this. >=20 > Nice one! Seems to work fine, and as most packages that use wrap-program > are broken in that aspect, that's a welcomed addition. Thanks! I sent a patch series lately adding "bash-minimal" to 'inputs' when 'wrap-program' is used, using this linter to identify relevant cases. Ludo would merge it (on core-updates, after some other things have been fix= ed there). I noticed 'qt-build-system' uses 'wrap-program' in its 'qt-wrap' phase, so I've sent a patch to add 'bash-minimal' to the bag of 'qt-build-s= ystem' when cross-compiling. That should largely take care of the 'wrap-program' cross-compilation issues, I hope! Greetings, Maxime. --=-pfUBF8ICWjDv0fIXxXjA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYOTCURccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vmdAQCmXRy2aQSv4ZTCaTF6aj9tm3Ri /NtctNjionmWgYhsrAD+J62W40ZHfFcfTjiX1M3YDX+7XIHfiLOHEtug0DIrzgA= =VvDM -----END PGP SIGNATURE----- --=-pfUBF8ICWjDv0fIXxXjA-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 07 05:12:44 2021 Received: (at 49315-done) by debbugs.gnu.org; 7 Jul 2021 09:12:44 +0000 Received: from localhost ([127.0.0.1]:50868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m13bo-00045Q-AZ for submit@debbugs.gnu.org; Wed, 07 Jul 2021 05:12:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m13bm-00045E-R6 for 49315-done@debbugs.gnu.org; Wed, 07 Jul 2021 05:12:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51782) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m13bg-0000o2-GC; Wed, 07 Jul 2021 05:12:36 -0400 Received: from [2a01:cb18:832e:5f00:3563:417e:2a38:86d8] (port=43432 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m13bf-0006qR-JW; Wed, 07 Jul 2021 05:12:35 -0400 From: Mathieu Othacehe To: Maxime Devos Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input. References: <87pmvv4aho.fsf@gnu.org> Date: Wed, 07 Jul 2021 11:12:33 +0200 In-Reply-To: (Maxime Devos's message of "Tue, 06 Jul 2021 22:38:03 +0200") Message-ID: <87sg0q4hdq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49315-done Cc: 49315-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > That usage should ideally be detected by 'wrap-program'. But as no > current package definition seems to do such a thing, and using > 'find-procedure-body' seems marginally =E2=80=98cleaner=E2=80=99 to me (Y= MMV?), > I would use 'find-procedure-body' anyways. OK, seems fair. I just edited the first patch to use "last" that has the benefit of hiding a "car" call and wrapped a long line. Pushed on master. Thanks, Mathieu From unknown Fri Jun 20 19:58:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Aug 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator