Subject: Re: [bug#49315] [PATCH]: Lint usages of 'wrap-program' without a "bash" input.

From: Mathieu Othacehe <[email-masked]>
Date: Tue, 06 Jul 2021 19:29:07 +0200

Hey Maxim,

> +  "Try to find the body of the procedure defined inline by EXPRESSION.
> +If it was found, call EXPRESSION with its body. If it wasn't, call
                               ^
                               FOUND

> +    (`(,(or 'let 'let*) . ,_)
> +     (find-procedure-body (car (last-pair expression)) found
> +                          #:not-found not-found))

You can use "last" from (srfi srfi-1) here. What's the point of
stripping the let clause by the way?

> +  (list (make-warning package
> +                      ;; TRANSLATORS: 'modify-phases' is a Scheme syntax
> +                      ;; and should not be translated.
> +                      (G_ "incorrect call to ‘modify-phases’")
> +                      #:field 'arguments)))

Maybe you could return a plain object here.

> +  (list (make-warning package
> +                      ;; TRANSLATORS: See ‘modify-phases’ in the manual.
> +                      (G_ "invalid phase clause")
> +                      #:field 'arguments)))

and here.

Thanks,

Mathieu